diff --git a/.gitignore b/.gitignore index b07af7464..b1e97de56 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,21 @@ fix_qt6_gui_deps.py fix_rti_conditionals.py fix_target_checks.py build +__pycache__/ +add_logger_bootstrap_include.py +aqtinstall.log +ces_fix.py +ces_pass2.py +fix_additem_enum.py +fix_broken_includes.py +fix_enum_as_int.py +fix_enums.py +fix_logger_init.py +fix_logger_remnant.py +fix_members.py +fix_mlogger.py +fix_pdm_combo.py +fix_sco.py +restore_underlying.py +../../restore_ppm_dtc.py +*.py diff --git a/qt6-after/qt6-migrated-legatus/CMakeLists.txt b/qt6-after/qt6-migrated-legatus/CMakeLists.txt index 002ecd75e..a9042d043 100755 --- a/qt6-after/qt6-migrated-legatus/CMakeLists.txt +++ b/qt6-after/qt6-migrated-legatus/CMakeLists.txt @@ -82,6 +82,9 @@ SET(CMAKE_INCLUDE_CURRENT_DIR ON) # (The qt5 legacy has no include/ tree; Lts/ is the real include root.) include_directories(BEFORE ${CMAKE_SOURCE_DIR}/Lts) include_directories(${CMAKE_SOURCE_DIR}/include) +# Legacy also used source-root-relative includes (/logger.h>, ...); +# the source root must be an include root so those resolve. +include_directories(${CMAKE_SOURCE_DIR}) # Include directory for generated export headers include_directories(${CMAKE_BINARY_DIR}) include_directories(${CMAKE_SOURCE_DIR}/Z/src) @@ -89,10 +92,28 @@ include_directories(${CMAKE_SOURCE_DIR}/Z/src) include_directories(${CMAKE_SOURCE_DIR}/Z/src) include_directories(${CMAKE_SOURCE_DIR}/Z/src/ngltools) include_directories(${CMAKE_SOURCE_DIR}/Lts/Viewer/SituationMap/Symbology) +# headers (symbol_dictionary.h, sidc_codec.h, ...) are consumed tree-wide +# (e.g. AdvancedSymbology/asb_data_plugin_interface.h is pulled into PpmCommon), so the +# parent dir must be a global root too, not only on the AdvancedSymbology target. +include_directories(${CMAKE_SOURCE_DIR}/Lts/Viewer/SituationMap) +# Generated SymbologyGui/advancedsymbologygui_export.h lives in the build dir; the source +# SituationMap root above only covers the source Symbology headers. +include_directories(${CMAKE_BINARY_DIR}/Lts/Viewer/SituationMap) include_directories(${CMAKE_SOURCE_DIR}/Lts/Viewer/LtsDataView) include_directories(${CMAKE_SOURCE_DIR}/Lts/Proxies/TrainingAreaBase) include_directories(${CMAKE_BINARY_DIR}/Lts/Services/ProjectDataManagement) include_directories(${CMAKE_SOURCE_DIR}/Lts/Services) +# Consumers include generated DDS service headers by service-prefixed name +# (, , ...). Those headers +# live in the per-service BUILD dirs, so the binary Lts/Services ROOT must be +# visible tree-wide (the per-service build dirs below only satisfy the bare +# form). Placed right after the source Lts/Services so a header +# present in both still resolves to the source (binary only supplies the +# generated headers). This mirrors the legacy form. +include_directories(${CMAKE_BINARY_DIR}/Lts/Services) +# Generated DDS headers for Proxies (GuezNasat/gna_dtc.h, ...) live under the binary +# Lts/Proxies dir; consumers include them by proxy-prefixed name (). +include_directories(${CMAKE_BINARY_DIR}/Lts/Proxies) include_directories(${CMAKE_SOURCE_DIR}/include/ProjectDataManagement) include_directories(${CMAKE_BINARY_DIR}/Lts/Services/InfrastructureManagement) include_directories(${CMAKE_SOURCE_DIR}/include/InfrastructureManagement) @@ -120,6 +141,9 @@ include_directories(${CMAKE_SOURCE_DIR}/include/SituationReplay) # is added (same shape as FileManagement above, which has no stub tree either). include_directories(${CMAKE_BINARY_DIR}/Lts/Services/Evaluations) include_directories(${CMAKE_SOURCE_DIR}/Lts/Proxies/GuezNasat) +# GuezNasat's generated export header (svcgnacommon_export.h) lives in the build dir; +# logger.h includes it by bare name, so the build dir must be visible tree-wide. +include_directories(${CMAKE_BINARY_DIR}/Lts/Proxies/GuezNasat) include_directories(${CMAKE_SOURCE_DIR}/Lts/DDS) include_directories(${CMAKE_SOURCE_DIR}/Lts/DDS/QosProfile) # Generated DDS headers (BUILD_RTI=ON) @@ -137,6 +161,9 @@ include_directories(${CMAKE_BINARY_DIR}/Lts/Common/LtsUtils/LtsUtilsCore) # directory holding the generated header has to be visible tree-wide. The directory contains # only that generated header, so appending it cannot shadow an existing include. include_directories(${CMAKE_BINARY_DIR}/Lts/Common/LtsUtils/LtsUtilsSettings) +# LtsUtilsGui ConnectDialog's generated ltsutilsguiconnectdialog_export.h is included by bare +# name from connect_dialog.h / connect_dialog_nt.h; same tree-wide visibility as the dirs above. +include_directories(${CMAKE_BINARY_DIR}/Lts/Common/LtsUtils/LtsUtilsGui/ConnectDialog) # DDSConnector's generated ddsconnector_export.h is included by bare name from # dds_connector.h and pub_sub_base.h, and reaches targets (the AES ModuleTests) that include # DDSConnector headers without linking ddsconnector. Same shape as LtsUtilsSettings above: the @@ -192,6 +219,12 @@ INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR}/Lts) IF(BUILD_RTI) # Define BUILD_RTI as preprocessor macro for all targets ADD_COMPILE_DEFINITIONS(BUILD_RTI) + # External (RTI) DDS is available: compile the BUILD_WITH_EXTERNAL_DDS code paths + # (used by 73 guards across plugins, e.g. MrkCommon's MarkerManagementDialogModel / + # CustomViewMarker). Legacy always compiled this DDS code; the flag is a migration + # option that was never wired into CMake, so its absence silently dropped the + # definitions while the unguarded class declarations still referenced them (link error). + ADD_COMPILE_DEFINITIONS(BUILD_WITH_EXTERNAL_DDS) ENDIF() OPTION(BUILD_ARCGIS "Build ArcGIS SDK dependent modules" ON) OPTION(BUILD_FILTERMANAGEMENT "Build FilterManagement plugins (temporarily disabled for migration)" OFF) @@ -232,6 +265,11 @@ ELSE() IF(EXISTS "${ARCGIS_SDK_DIR}") LIST(APPEND CMAKE_PREFIX_PATH "${ARCGIS_SDK_DIR}") MESSAGE(STATUS "ArcGIS SDK found at: ${ARCGIS_SDK_DIR}") + # arcgisversion.h (a custom RME file in the SDK include dir) is pulled in via + # by many non-ArcGIS plugin targets (e.g. + # IsmResGuiPlugin); the ArcGIS::ArcGIS target include dir does not reach them, so + # expose the SDK include dir tree-wide when the SDK is present. + include_directories(${ARCGIS_SDK_DIR}/include) ELSE() MESSAGE(WARNING "ArcGIS SDK not found at: ${ARCGIS_SDK_DIR}") ENDIF() @@ -327,6 +365,14 @@ if(NOT TARGET Qt6::Core) find_package(Qt6 6.2 COMPONENTS Core REQUIRED) endif() +# Qt State Machine (QState/QStateMachine) was moved out of QtGui in Qt6 into the +# separate "Qt State Machine" add-on (the qtscxml package). In Qt5 the state +# machine classes lived inside QtGui/QtCore, so the ExerciseManagement state +# machines (exercise_state_base/exercise_state_machine) compiled without an +# explicit StateMachine dependency. Probe for the module now; if present the +# affected targets link Qt6::StateMachine (guarded per-target below). +find_package(Qt6 6.2 COMPONENTS StateMachine QUIET) + # Create imported targets for all available Qt6 libraries # Use Qt6 installation path from find_package or fall back to system paths if(Qt6Core_DIR) @@ -397,6 +443,30 @@ if(EXISTS "${QT6_LIB_DIR}/libQt6Widgets.so.6") message(STATUS "Manually configured Qt6 Widgets target") endif() +# Qt6::OpenGL - create manual target if not found (QOpenGLPaintDevice, used by ArcGIS SDK) +if(NOT TARGET Qt6::OpenGL AND EXISTS "${QT6_LIB_DIR}/libQt6OpenGL.so.6") + add_library(Qt6::OpenGL SHARED IMPORTED) + set_target_properties(Qt6::OpenGL PROPERTIES + IMPORTED_LOCATION "${QT6_LIB_DIR}/libQt6OpenGL.so.6" + INTERFACE_INCLUDE_DIRECTORIES "${QT6_INC_DIR}/QtGui;${QT6_INC_DIR}" + INTERFACE_LINK_LIBRARIES "Qt6::Core" + ) + message(STATUS "Manually configured Qt6 OpenGL target") +endif() + +# Qt6::OpenGLWidgets - create manual target if not found +# (QOpenGLWidget, used by the ArcGIS SDK MapGraphicsView/SceneGraphicsView objects; +# Qt6 splits QOpenGLWidget into its own libQt6OpenGLWidgets.so) +if(NOT TARGET Qt6::OpenGLWidgets AND EXISTS "${QT6_LIB_DIR}/libQt6OpenGLWidgets.so.6") + add_library(Qt6::OpenGLWidgets SHARED IMPORTED) + set_target_properties(Qt6::OpenGLWidgets PROPERTIES + IMPORTED_LOCATION "${QT6_LIB_DIR}/libQt6OpenGLWidgets.so.6" + INTERFACE_INCLUDE_DIRECTORIES "${QT6_INC_DIR}/QtWidgets;${QT6_INC_DIR}" + INTERFACE_LINK_LIBRARIES "Qt6::Core;Qt6::Gui;Qt6::Widgets" + ) + message(STATUS "Manually configured Qt6 OpenGLWidgets target") +endif() + # Qt6::Sql - create manual target if not found if(NOT TARGET Qt6::Sql AND EXISTS "${QT6_LIB_DIR}/libQt6Sql.so.6") add_library(Qt6::Sql SHARED IMPORTED) @@ -502,6 +572,30 @@ if(NOT TARGET Qt6::SerialPort) message(STATUS "Created stub target for Qt6::SerialPort (library not available)") endif() +# Qt6::WebEngineCore - real imported target if the library exists (stub below otherwise). +# The stub carries no library, so targets linking it (e.g. SmoSystemMonitorGuiPlugin) +# fail --no-undefined on QWebEngine* symbols. +if(NOT TARGET Qt6::WebEngineCore AND EXISTS "${QT6_LIB_DIR}/libQt6WebEngineCore.so.6") + add_library(Qt6::WebEngineCore SHARED IMPORTED) + set_target_properties(Qt6::WebEngineCore PROPERTIES + IMPORTED_LOCATION "${QT6_LIB_DIR}/libQt6WebEngineCore.so.6" + INTERFACE_INCLUDE_DIRECTORIES "${QT6_INC_DIR}/QtWebEngineCore;${QT6_INC_DIR}" + INTERFACE_LINK_LIBRARIES "Qt6::Core;Qt6::Gui" + ) + message(STATUS "Manually configured Qt6 WebEngineCore target") +endif() + +# Qt6::WebEngineWidgets - real imported target if the library exists. +if(NOT TARGET Qt6::WebEngineWidgets AND EXISTS "${QT6_LIB_DIR}/libQt6WebEngineWidgets.so.6") + add_library(Qt6::WebEngineWidgets SHARED IMPORTED) + set_target_properties(Qt6::WebEngineWidgets PROPERTIES + IMPORTED_LOCATION "${QT6_LIB_DIR}/libQt6WebEngineWidgets.so.6" + INTERFACE_INCLUDE_DIRECTORIES "${QT6_INC_DIR}/QtWebEngineWidgets;${QT6_INC_DIR}" + INTERFACE_LINK_LIBRARIES "Qt6::Core;Qt6::Gui;Qt6::Widgets;Qt6::WebEngineCore" + ) + message(STATUS "Manually configured Qt6 WebEngineWidgets target") +endif() + # Stub Qt6::WebEngineCore target if not available (needed by thp_viewer) if(NOT TARGET Qt6::WebEngineCore) add_library(Qt6::WebEngineCore INTERFACE IMPORTED) @@ -686,6 +780,26 @@ IF(BUILD_RTI) # reach the AutogenInfo MOC_INCLUDES. SET(CMAKE_AUTOMOC_INCLUDE_DIRECTORIES ${CMAKE_AUTOMOC_INCLUDE_DIRECTORIES} ${CMAKE_SOURCE_DIR}/Lts/Common) + # The TrainingAreaBase tab plugins (tabPluginHla / tabPluginWlsTetra / + # tabPluginDebugJsonDir / ...) declare Q_INTERFACES(TrainingAreaBase::Plugin::Plugin) + # and include . That include dir + # (Lts/Proxies) is only a target-level INTERFACE include of tabPluginInterface and + # is NOT part of the global include_directories that reach the AutogenInfo + # MOC_INCLUDES, so moc fails with "Undefined interface". Add the Lts/Proxies root + # explicitly so moc can resolve the interface. Must be set at root scope - subdir + # appends do not reach the AutogenInfo MOC_INCLUDES. + SET(CMAKE_AUTOMOC_INCLUDE_DIRECTORIES ${CMAKE_AUTOMOC_INCLUDE_DIRECTORIES} ${CMAKE_SOURCE_DIR}/Lts/Proxies) + + # Designer plugins (ltswidgetsplugin) declare Q_INTERFACES(QDesignerCustomWidgetInterface) + # and include . That interface's + # Q_DECLARE_INTERFACE lives in the Qt6 QtUiPlugin module, which moc cannot resolve + # without the Qt6 parent include dir (it is only a target-level INTERFACE include of + # Qt6::UiTools and does not reach the global AutogenInfo MOC_INCLUDES). Add Qt6::Core's + # interface include dirs (which expose the /header root) so moc finds the + # interface. Must be set at root scope. + get_target_property(_qt6_autmoc_incs Qt6::Core INTERFACE_INCLUDE_DIRECTORIES) + SET(CMAKE_AUTOMOC_INCLUDE_DIRECTORIES ${CMAKE_AUTOMOC_INCLUDE_DIRECTORIES} ${_qt6_autmoc_incs}) + # IMPORTED Targets für RTI Libraries erstellen # Debug und Release Varianten korrekt konfigurieren FOREACH(lib nddsc nddscore nddscpp nddscpp2 nddsctesthelpers) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Application/OpApp/main.cpp b/qt6-after/qt6-migrated-legatus/Lts/Application/OpApp/main.cpp index 799b0d113..99c070c49 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Application/OpApp/main.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Application/OpApp/main.cpp @@ -36,7 +36,6 @@ #include #include #include -#include #include #include @@ -175,7 +174,10 @@ public: // ------------------------------------------------------------------ int main(int argc, char **argv) // TODO: json strings to lower { - QRandomGenerator::global()->seed(time(nullptr)); + // (legacy: qsrand(time(nullptr));) — the Qt5 global RNG (qrand/qsrand) does not exist in Qt6. + // QRandomGenerator::global() is auto-seeded (non-deterministically) by Qt, and calling ->seed() + // on the global/system generator aborts in Qt 6.10 ("Attempted to overwrite a QRandomGenerator to + // system() or global()"), so no explicit seed is needed here. QCoreApplication::setAttribute(Qt::AA_UseDesktopOpenGL); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Application/THP/thpwidgets/thp_building_settings.cpp b/qt6-after/qt6-migrated-legatus/Lts/Application/THP/thpwidgets/thp_building_settings.cpp index bde8fe762..6e76feaa5 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Application/THP/thpwidgets/thp_building_settings.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Application/THP/thpwidgets/thp_building_settings.cpp @@ -9,7 +9,7 @@ #include "thp_building_settings.h" #include "ui_thp_building_settings.h" -#include +#include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/CodeGen/GrantleeWrappers.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/CodeGen/GrantleeWrappers.cpp index 8c2734e52..b88b66cdc 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/CodeGen/GrantleeWrappers.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/CodeGen/GrantleeWrappers.cpp @@ -69,7 +69,7 @@ QString MemberInformationWrapper::ddsToJsonElement() const return QStringLiteral("obj[QStringLiteral(\"") + cppMemberName() + QStringLiteral("\")] = ") + cppToJsonPre() + QStringLiteral("element.") + memberAccess + cppToJsonPost(); - const QString optionalAccess = cppMemberName() + QStringLiteral(".is_set()"); + const QString optionalAccess = cppMemberName() + QStringLiteral(".has_value()"); const QString getValue = cppMemberName(); return QStringLiteral("if (element.") + optionalAccess + QStringLiteral(") ") + QStringLiteral("obj[QStringLiteral(\"") + cppMemberName() + QStringLiteral("\")] = ") + cppToJsonPre() + diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/CMakeLists.txt b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/CMakeLists.txt index 96f2828ae..223a7f1e6 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/CMakeLists.txt +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/CMakeLists.txt @@ -17,7 +17,13 @@ SET(SRCS printing.h ) -if (KDReports_FOUND AND QT6_GUI_AVAILABLE AND BUILD_CODIFICATION) +# Legacy always built the real LtsPrinting when KDReports was available +# (FIND_PACKAGE(KDReports REQUIRED)); it is a common lib consumed by many +# targets (e.g. SitmapGuiPlugin::doPrint -> LtsPrinting::printImage), so it must +# NOT be gated on the BUILD_CODIFICATION product flag (which only bundles the +# CodificationManagement/ReportViewer plugins). Build the real lib whenever +# KDReports is found; keep the stub only as a KDReports-absent fallback. +if (KDReports_FOUND AND QT6_GUI_AVAILABLE) NGL_ADD_LIBRARY2(WS LtsPrinting SHARED ${SRCS}) NGL_TARGET_INCLUDE_DIRECTORIES(LtsPrinting PUBLIC @@ -38,5 +44,7 @@ if(QT6_GUI_AVAILABLE) endif() NGL_INSTALL_TARGET(LtsPrinting) else() - message(STATUS "KDReports not found or BUILD_RTI disabled; skipping LtsPrinting target") + message(STATUS "KDReports not found or Qt6 GUI unavailable; building LtsPrinting stub (link-only, no printing symbols)") + add_library(LtsPrinting SHARED lts_printing_stub.cpp) + NGL_INSTALL_TARGET(LtsPrinting) endif() diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/lts_printing_stub.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/lts_printing_stub.cpp new file mode 100644 index 000000000..d2b5ad628 --- /dev/null +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/lts_printing_stub.cpp @@ -0,0 +1,14 @@ +// LtsPrinting link stub for the Qt6 migration. +// +// The real LtsPrinting library requires KDReports (a Qt5/KDE print-reporting +// library that is not available in the Qt6 toolchain). When KDReports is not +// found the real library is skipped (see CMakeLists.txt); this stub provides a +// linkable `LtsPrinting` target so that consumers referencing the target name +// (e.g. SmoCheckButtonHandler) still link. It exports no printing symbols. +namespace lts_printing_stub +{ +int lts_printing_stub_marker() +{ + return 0; +} +} diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing.cpp index 45d5d77f0..cb6553321 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing.cpp @@ -84,7 +84,7 @@ void printView(LtsSession::LtsSession* session, QWidget* dialogParent, const QAb doc.setMetaInformation(QTextDocument::DocumentTitle, dialogParent->windowTitle()); LtsPrinting::Base nglPrinter(doc, dialogParent, QObject::tr("Print %1").arg(dialogParent->windowTitle()), - dialogParent->windowTitle(), QPrinter::A4, QPrinter::Landscape); + dialogParent->windowTitle(), QPageSize(QPageSize::A4), QPageLayout::Landscape); if (!nglPrinter.printer()) return; @@ -118,8 +118,8 @@ void printView(LtsSession::LtsSession* session, QWidget* dialogParent, QAbstract } void printImage(LtsSession::LtsSession* session, QWidget* dialogParent, const QImage& image, const QString& imageTitle, - const QString& description, const QPrinter::PageSize& pageSize, - const QPrinter::Orientation& pageOrientation) + const QString& description, const QPageSize& pageSize, + const QPageLayout::Orientation& pageOrientation) { QTextDocument doc; QTextCursor cursor(&doc); @@ -141,7 +141,7 @@ void printImage(LtsSession::LtsSession* session, QWidget* dialogParent, const QI void printImages(LtsSession::LtsSession* session, QWidget* dialogParent, const QString& docName, QVector& images, QVector& imageTitles, QVector& descriptions, - const QPrinter::PageSize& pageSize, const QPrinter::Orientation& pageOrientation) + const QPageSize& pageSize, const QPageLayout::Orientation& pageOrientation) { QTextDocument doc; @@ -181,8 +181,8 @@ void printPDFImages(QWidget* dialogParent, const QString& docName, const QString QPrinter printer; printer.setColorMode(QPrinter::ColorMode::Color); - printer.setOrientation(QPrinter::Orientation::Portrait); - printer.setPageSize(QPrinter::PageSize::A4); + printer.setPageOrientation(QPageLayout::Portrait); + printer.setPageSize(QPageSize(QPageSize::A4)); QString fn = docName; fn = fn.remove(QLatin1Char(' ')); fn = fn.remove(QLatin1String("..")); @@ -224,7 +224,7 @@ void printReport(LtsSession::LtsSession* session, QWidget* dialogParent, KDRepor doc.setMetaInformation(QTextDocument::DocumentTitle, dialogParent->windowTitle()); LtsPrinting::Base nglPrinter(doc, dialogParent, QObject::tr("Print %1").arg(dialogParent->windowTitle()), - dialogParent->windowTitle(), QPrinter::A3, QPrinter::Landscape); + dialogParent->windowTitle(), QPageSize(QPageSize::A3), QPageLayout::Landscape); if (!nglPrinter.printer()) return; @@ -233,8 +233,8 @@ void printReport(LtsSession::LtsSession* session, QWidget* dialogParent, KDRepor cursor.movePosition(QTextCursor::End); report.setWidthForEndlessPrinter(0); - report.setPageSize(QPrinter::A3); - report.setOrientation(QPrinter::Landscape); + report.setPageSize(QPageSize::A3); + report.setPageOrientation(QPageLayout::Landscape); LtsPrinting::Base::printReportData(doc, report); nglPrinter.print(&doc); @@ -249,8 +249,8 @@ void printWidget(LtsSession::LtsSession* session, QWidget* dialogParent, QWidget QString windowTitle = dialogParent->windowTitle(); doc.setMetaInformation(QTextDocument::DocumentTitle, dialogParent->windowTitle()); - LtsPrinting::Base nglPrinter(doc, dialogParent, QObject::tr("Print %1").arg(windowTitle), windowTitle, QPrinter::A3, - QPrinter::Landscape); + LtsPrinting::Base nglPrinter(doc, dialogParent, QObject::tr("Print %1").arg(windowTitle), windowTitle, + QPageSize(QPageSize::A3), QPageLayout::Landscape); if (!nglPrinter.printer()) return; @@ -271,8 +271,8 @@ void printMessage(LtsSession::LtsSession* session, QWidget* dialogParent, const QString windowTitle = subject; doc.setMetaInformation(QTextDocument::DocumentTitle, subject); - LtsPrinting::Base nglPrinter(doc, dialogParent, QObject::tr("Print %1").arg(windowTitle), windowTitle, QPrinter::A4, - QPrinter::Portrait); + LtsPrinting::Base nglPrinter(doc, dialogParent, QObject::tr("Print %1").arg(windowTitle), windowTitle, + QPageSize(QPageSize::A4), QPageLayout::Portrait); QString str = QString(QStringLiteral("

%1 %2

")).arg(subject).arg(subjectContent); str.append(QString(QStringLiteral("%1 %2
")).arg(time).arg(timeContent)); @@ -302,8 +302,8 @@ void printStoryboard(LtsSession::LtsSession* session, QWidget* dialogParent, QAb QString windowTitle = dialogParent->windowTitle(); doc.setMetaInformation(QTextDocument::DocumentTitle, dialogParent->windowTitle()); - LtsPrinting::Base nglPrinter(doc, dialogParent, QObject::tr("Print %1").arg(windowTitle), windowTitle, QPrinter::A4, - QPrinter::Portrait); + LtsPrinting::Base nglPrinter(doc, dialogParent, QObject::tr("Print %1").arg(windowTitle), windowTitle, + QPageSize(QPageSize::A4), QPageLayout::Portrait); if (!nglPrinter.printer()) return; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing.h b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing.h index cfb841b7e..61e5f236b 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing.h @@ -3,6 +3,8 @@ #pragma once #include +#include +#include #ifndef LTSPRINTING_EXPORT #ifdef BUILD_STATIC_LIBRARIES @@ -42,13 +44,13 @@ LTSPRINTING_EXPORT void printStoryboard(LtsSession::LtsSession* session, QWidget LTSPRINTING_EXPORT void printImage(LtsSession::LtsSession* session, QWidget* dialogParent, const QImage& image, const QString& imageTitle, const QString& description, - const QPrinter::PageSize& pageSize = QPrinter::A3, - const QPrinter::Orientation& pageOrientation = QPrinter::Landscape); + const QPageSize& pageSize = QPageSize(QPageSize::A3), + const QPageLayout::Orientation& pageOrientation = QPageLayout::Landscape); LTSPRINTING_EXPORT void printImages(LtsSession::LtsSession* session, QWidget* dialogParent, const QString& docName, QVector& images, QVector& imageTitles, - QVector& descriptions, const QPrinter::PageSize& pageSize = QPrinter::A3, - const QPrinter::Orientation& pageOrientation = QPrinter::Landscape); + QVector& descriptions, const QPageSize& pageSize = QPageSize(QPageSize::A3), + const QPageLayout::Orientation& pageOrientation = QPageLayout::Landscape); LTSPRINTING_EXPORT void printPDFImages(QWidget* dialogParent, const QString& docName, const QString& printPath, QVector& images); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing_base.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing_base.cpp index 728aeec48..94a89196d 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing_base.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing_base.cpp @@ -50,8 +50,8 @@ Base::Base(QTextDocument &doc, QWidget *dialogParent, const QString &dialogTitle, const QString &_fn, - QPrinter::PaperSize _ps, - QPrinter::Orientation _or, + QPageSize _ps, + QPageLayout::Orientation _or, QPrinter::ColorMode _cm) : m_printer(new QPrinter), m_painter(new QPainter), m_iconFilenameNr(0), @@ -61,9 +61,9 @@ Base::Base(QTextDocument &doc, headersize_(10), headerrule_(0.5), headertext_(HeaderText), footersize_(10), footerrule_(0.5), footertext_(FooterText), itemFontSize_(2), - m_settings(new NGL::Settings(NGL::findProjectConfigFile())).getNGLLogger("NGLPrinting")), - m_currentPage(1), - m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) + m_settings(new NGL::Settings(NGL::findProjectConfigFile())), + m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger().getNGLLogger("NGLPrinting")), + m_currentPage(1) { QString fn = _fn; fn = fn.remove(QLatin1Char(' ')); @@ -77,8 +77,8 @@ Base::Base(QTextDocument &doc, #endif m_printer->setOutputFormat(QPrinter::NativeFormat); - m_printer->setPaperSize(_ps); - m_printer->setOrientation(_or); + m_printer->setPageSize(_ps); + m_printer->setPageOrientation(_or); m_printer->setColorMode(_cm); m_printer->setFullPage(true); @@ -101,13 +101,13 @@ Base::Base(QTextDocument &doc, QAbstractPrintDialog::PrintCollateCopies; dialog->setOptions(op); QString title = dialogTitle; - if (_ps == QPrinter::A2) + if (_ps.id() == QPageSize::A2) title += QLatin1String(" (A2)"); - if (_ps == QPrinter::A3) + if (_ps.id() == QPageSize::A3) title += QLatin1String(" (A3)"); - if (_ps == QPrinter::A4) + if (_ps.id() == QPageSize::A4) title += QLatin1String(" (A4)"); - if (_ps == QPrinter::A5) + if (_ps.id() == QPageSize::A5) title += QLatin1String(" (A5)"); dialog->setWindowTitle(title); if (dialog->exec() != QDialog::Accepted) @@ -153,7 +153,7 @@ QString Base::styleSheet() QSize Base::printerPageSize() const { - return QSize(m_printer->pageRect().width() - 2 * DOC_MARGIN, m_printer->pageRect().height() - 2 * DOC_MARGIN); + return QSize(m_printer->pageRect(QPrinter::Point).width() - 2 * DOC_MARGIN, m_printer->pageRect(QPrinter::Point).height() - 2 * DOC_MARGIN); } bool Base::newPage() @@ -543,7 +543,7 @@ bool Base::printItemData(QString& str, const QAbstractItemModel* model, const QM displayString += vdata.toString(); QString fgColorString; - vdata = model->data(mi, Qt::TextColorRole); + vdata = model->data(mi, Qt::ForegroundRole); if (vdata.isValid()) fgColorString = vdata.value().name(); @@ -684,24 +684,24 @@ bool Base::printReportData(QTextDocument& doc, KDReports::Report& report) return true; } -QPrinter::PageSize Base::pageSize() const +QPageSize Base::pageSize() const { - return m_printer->pageSize(); + return m_printer->pageLayout().pageSize(); } -void Base::setPageSize(QPrinter::PageSize size) +void Base::setPageSize(QPageSize size) { m_printer->setPageSize(size); } -QPrinter::Orientation Base::orientation() const +QPageLayout::Orientation Base::orientation() const { - return m_printer->orientation(); + return m_printer->pageLayout().orientation(); } -void Base::setOrientation(QPrinter::Orientation orientation) +void Base::setOrientation(QPageLayout::Orientation orientation) { - m_printer->setOrientation(orientation); + m_printer->setPageOrientation(orientation); } double Base::leftMargin() const @@ -711,7 +711,7 @@ double Base::leftMargin() const void Base::setLeftMargin(double margin) { - if ((margin > 0) && (margin < m_printer->paperRect().width() / 2)) + if ((margin > 0) && (margin < m_printer->paperRect(QPrinter::Point).width() / 2)) leftmargin_ = margin; else leftmargin_ = 0; @@ -724,7 +724,7 @@ double Base::rightMargin() const void Base::setRightMargin(double margin) { - if ((margin > 0) && (margin < m_printer->paperRect().width() / 2)) + if ((margin > 0) && (margin < m_printer->paperRect(QPrinter::Point).width() / 2)) rightmargin_ = margin; else rightmargin_ = 0; @@ -737,7 +737,7 @@ double Base::topMargin() const void Base::setTopMargin(double margin) { - if ((margin > 0) && (margin < m_printer->paperRect().height() / 4)) + if ((margin > 0) && (margin < m_printer->paperRect(QPrinter::Point).height() / 4)) topmargin_ = margin; else topmargin_ = 0; @@ -750,7 +750,7 @@ double Base::bottomMargin() const void Base::setBottomMargin(double margin) { - if ((margin > 0) && (margin < m_printer->paperRect().height() / 4)) + if ((margin > 0) && (margin < m_printer->paperRect(QPrinter::Point).height() / 4)) bottommargin_ = margin; else bottommargin_ = 0; @@ -758,7 +758,7 @@ void Base::setBottomMargin(double margin) void Base::setMargins(double margin) { - if ((margin > 0) && (margin < m_printer->paperRect().height() / 2) && (margin < m_printer->paperRect().width() / 2)) + if ((margin > 0) && (margin < m_printer->paperRect(QPrinter::Point).height() / 2) && (margin < m_printer->paperRect(QPrinter::Point).width() / 2)) leftmargin_ = rightmargin_ = topmargin_ = bottommargin_ = margin; else leftmargin_ = rightmargin_ = topmargin_ = bottommargin_ = 0; @@ -771,7 +771,7 @@ double Base::spacing() const void Base::setSpacing(double spacing) { - if ((spacing > 0) && (spacing <= m_printer->paperRect().height() / 8)) + if ((spacing > 0) && (spacing <= m_printer->paperRect(QPrinter::Point).height() / 8)) spacing_ = spacing; else spacing_ = 0; @@ -784,7 +784,7 @@ double Base::headerSize() const void Base::setHeaderSize(double size) { - if ((size > 0) && (size <= m_printer->paperRect().height() / 8)) + if ((size > 0) && (size <= m_printer->paperRect(QPrinter::Point).height() / 8)) headersize_ = size; else headersize_ = 0; @@ -817,7 +817,7 @@ double Base::footerSize() const void Base::setFooterSize(double size) { - if ((size > 0) && (size <= m_printer->paperRect().height() / 8)) + if ((size > 0) && (size <= m_printer->paperRect(QPrinter::Point).height() / 8)) footersize_ = size; else footersize_ = 0; @@ -851,7 +851,7 @@ void Base::setItemFontSize(int itemFontSize) QRectF Base::paperRect(QPaintDevice* device) { - QRectF rect = m_printer->paperRect(); + QRectF rect = m_printer->paperRect(QPrinter::Point); rect.setWidth(rect.width() * device->logicalDpiX() / m_printer->logicalDpiX()); rect.setHeight(rect.height() * device->logicalDpiY() / m_printer->logicalDpiY()); @@ -930,7 +930,7 @@ void Base::printSinglePage() m_tempdoc->setPageSize(contentRect(m_printer).size()); QTextFrameFormat fmt = m_tempdoc->rootFrame()->frameFormat(); - fmt.setContentsMargins(0, 0, 0, 0); + fmt.setMargin(0); m_tempdoc->rootFrame()->setFrameFormat(fmt); int doccopies; @@ -938,11 +938,11 @@ void Base::printSinglePage() if (m_printer->collateCopies()) { doccopies = 1; - pagecopies = m_printer->numCopies(); + pagecopies = m_printer->copyCount(); } else { - doccopies = m_printer->numCopies(); + doccopies = m_printer->copyCount(); pagecopies = 1; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing_base.h b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing_base.h index ae079a054..37eba5e27 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing_base.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsPrinting/printing_base.h @@ -4,6 +4,8 @@ #include #include +#include +#include namespace NGL { @@ -50,7 +52,7 @@ class Base { public: Base(QTextDocument& doc, QWidget* dialogParent, const QString& dialogTitle, const QString& _fn, - QPrinter::PaperSize _ps = QPrinter::A4, QPrinter::Orientation _or = QPrinter::Portrait, + QPageSize _ps = QPageSize(QPageSize::A4), QPageLayout::Orientation _or = QPageLayout::Portrait, QPrinter::ColorMode _cm = QPrinter::Color); virtual ~Base(); @@ -61,13 +63,13 @@ class Base static QString styleSheet(); - QPrinter::PageSize pageSize() const; + QPageSize pageSize() const; - void setPageSize(QPrinter::PageSize size); + void setPageSize(QPageSize size); - QPrinter::Orientation orientation() const; + QPageLayout::Orientation orientation() const; - void setOrientation(QPrinter::Orientation orientation); + void setOrientation(QPageLayout::Orientation orientation); bool newPage(); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsProjectionWorkstation/WebSocket/messages.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsProjectionWorkstation/WebSocket/messages.cpp index 8a78e3761..bcafc97ce 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsProjectionWorkstation/WebSocket/messages.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsProjectionWorkstation/WebSocket/messages.cpp @@ -175,7 +175,13 @@ bool CTS::DisconnectRequest::hasValidData() const return true; } -LtsProjectionWorkstation::ErrorMessage::ErrorMessage(const QString& uuid, const QString& reason) +// Unqualified: we are already inside namespace LtsProjectionWorkstation, and the unity +// build concatenates lts_projection_workstation.cpp (which declares +// class LtsProjectionWorkstation in this same namespace) into this TU, so +// "LtsProjectionWorkstation::ErrorMessage" would resolve to the class (which has no +// such member) instead of the namespace. In a separate TU (legacy structure) the +// class is not visible here and the qualified name resolved to the namespace. +ErrorMessage::ErrorMessage(const QString& uuid, const QString& reason) : Message(nullptr, nullptr, JsonKeys::ERROR_MESSAGE(), uuid, QJsonValue()), m_reason(reason) { QJsonObject result; @@ -183,7 +189,7 @@ LtsProjectionWorkstation::ErrorMessage::ErrorMessage(const QString& uuid, const m_replyData = result; } -void LtsProjectionWorkstation::ErrorMessage::process() +void ErrorMessage::process() { if (!m_handler || !m_client) return; @@ -192,7 +198,7 @@ void LtsProjectionWorkstation::ErrorMessage::process() m_handler->handleMessage(this); } -bool LtsProjectionWorkstation::ErrorMessage::hasValidData() const +bool ErrorMessage::hasValidData() const { if (!m_handler || !m_client) return false; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsSession/lts_session.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsSession/lts_session.cpp index 10875a013..ff64d79e0 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsSession/lts_session.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsSession/lts_session.cpp @@ -916,6 +916,11 @@ void LtsSession::setExerciseData(const LtsWidgets::ExerciseData& exerciseData) emit signalExerciseDataChanged(); } +const LtsWidgets::ExerciseData* LtsSession::exerciseData() const +{ + return m_exerciseData; +} + void LtsSession::setProfilePicture(const QPixmap& pixmap) { // partitionType(); ?!? diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsSession/lts_session_lock_handler.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsSession/lts_session_lock_handler.cpp index b71b03ad1..e1c98d516 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsSession/lts_session_lock_handler.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsSession/lts_session_lock_handler.cpp @@ -1,4 +1,5 @@ #include "lts_session_lock_handler.h" +#include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsTimelineClassic/Event.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsTimelineClassic/Event.cpp index 0f09f059c..ed7c3bc5d 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsTimelineClassic/Event.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsTimelineClassic/Event.cpp @@ -1,6 +1,7 @@ #include "Event.h" +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsTimelineClassic/TimelineHeaderView.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsTimelineClassic/TimelineHeaderView.cpp index ebd48b819..1b66b590b 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsTimelineClassic/TimelineHeaderView.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsTimelineClassic/TimelineHeaderView.cpp @@ -1,6 +1,7 @@ #include "TimelineHeaderView.h" +#include #include "TimelineWidget.h" diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsUtils/LtsUtilsGui/LtsUtilsGuiDds/CMakeLists.txt b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsUtils/LtsUtilsGui/LtsUtilsGuiDds/CMakeLists.txt index 27ff46ed3..5590d0ffa 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsUtils/LtsUtilsGui/LtsUtilsGuiDds/CMakeLists.txt +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsUtils/LtsUtilsGui/LtsUtilsGuiDds/CMakeLists.txt @@ -53,6 +53,20 @@ NGL_TARGET_COMPILE_DEFINITIONS(LtsUtilsGuiDds REQUEST_HELPER_WITH_GUI ) +# The dds_vector_to_pixmap free functions (iconFromSvg / pixmapFromIcon / ...) are +# declared with LTSUTILSCORE_EXPORT, but this TU's include +# resolves to the SOURCE-tree header, +# where the macro expands to Q_DECL_IMPORT (empty on Linux) because +# MAKE_LTSUTILSCORE_LIB is only defined when building LtsUtilsCore itself. Under the +# project-wide -fvisibility=hidden they therefore compile as hidden symbols and, with +# USE_IPO=ON, LTO drops them from the DSO entirely (they are unreferenced inside this +# lib), breaking every consumer that links them (LtsMultiMonitor, LtsSession, ...). +# Legacy exported them because its include +# resolved to the GENERATED export header (visibility("default")). Restore that +# default visibility for this target only (same fix shape as the PluginInterfaces +# visibility preset); behavior-neutral. +set_target_properties(LtsUtilsGuiDds PROPERTIES CXX_VISIBILITY_PRESET default) + NGL_ADD_LIBRARY2(AAR HLA SV LtsUtilsDds SHARED request_helper.cpp request_helper.h) NGL_TARGET_INCLUDE_DIRECTORIES(LtsUtilsDds diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/CMakeLists.txt b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/CMakeLists.txt index f9df0badd..d248856db 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/CMakeLists.txt +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/CMakeLists.txt @@ -183,6 +183,13 @@ NGL_INSTALL_TARGET(LtsWidgets) SET(ltswidgetsplugin_SRCS ltswidgetsplugin.cpp ltswidgetsplugin.json) NGL_ADD_LIBRARY(WS ltswidgetsplugin MODULE ${ltswidgetsplugin_SRCS}) NGL_TARGET_LINK_LIBRARIES(ltswidgetsplugin LtsWidgets ltsCoordWidget LtsDataView LtsFileDialog LtsReportDisplay svcFlmCommon) +# ltswidgetsplugin.cpp unconditionally includes , +# which pulls KDReports -> #include . In Qt6 that forwarding header lives in +# /QtPrintSupport. With BUILD_CODIFICATION=OFF the LtsReportDisplay->KDReports +# include chain is not built, so expose the QtPrintSupport module dir directly. +if(DEFINED QT6_INC_DIR AND EXISTS "${QT6_INC_DIR}/QtPrintSupport") + NGL_TARGET_INCLUDE_DIRECTORIES(ltswidgetsplugin PRIVATE "${QT6_INC_DIR}/QtPrintSupport") +endif() NGL_SET_TARGET_PROPERTIES(ltswidgetsplugin PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib/designer) NGL_INSTALL_TARGET(ltswidgetsplugin DESTINATION lib/designer COMPONENT Devel) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_checkable_table_model.h b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_checkable_table_model.h index ed95fd18e..08e4684eb 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_checkable_table_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_checkable_table_model.h @@ -59,7 +59,7 @@ public: { const T &entry = LtsAbstractTableModel::m_vecData.at(row); if (entry.first) - ids << entry.second.id(); + ids << entry.second.id; } return ids; @@ -73,7 +73,7 @@ public: { const T &entry = LtsAbstractTableModel::m_vecData.at(row); if (!entry.first) - ids << entry.second.id(); + ids << entry.second.id; } return ids; @@ -84,7 +84,7 @@ public: for (int row = 0; row < LtsAbstractTableModel::rowCount(); ++row) { T &entry = LtsAbstractTableModel::m_vecData[row]; - bool bContains = vecCheckedIds.contains(entry.second.id()); + bool bContains = vecCheckedIds.contains(entry.second.id); if (entry.first != bContains) { entry.first = bContains; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_dialog.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_dialog.cpp index 1bf897677..c4d47a919 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_dialog.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_dialog.cpp @@ -7,6 +7,7 @@ */ #include "lts_dialog.h" +#include #include "lts_progress_dialog_helper.h" #include "lts_message_dialog.h" #include "lts_dialog_helper.h" diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_dialog.h b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_dialog.h index 906d4cf7b..9a0c8d4e9 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_dialog.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/lts_dialog.h @@ -327,7 +327,7 @@ protected: */ void translate(T *ui, const S &data, const QString &custom, const QString &title) // same as 'void translate(T *ui, const S &data, const QString &title)', but for topics without the 'name' entry { - translate(ui, QString::fromUtf8(typeid(data).name()), data.id(), custom /* can be empty */, title); + translate(ui, QString::fromUtf8(typeid(data).name()), data.id, custom /* can be empty */, title); } @@ -341,7 +341,7 @@ protected: */ void translate(T *ui, const S &data, const QString &title) { - translate(ui, data, QString::fromStdString(data.name()), title); // -> translate #5 + translate(ui, data, QString::fromStdString(data.name), title); // -> translate #5 } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/requirement_widget.cpp b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/requirement_widget.cpp deleted file mode 100644 index 7419a0905..000000000 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/requirement_widget.cpp +++ /dev/null @@ -1,142 +0,0 @@ - - -#include "requirement_widget.h" - -#include -#include -#include - -namespace LtsWidgets -{ -UiRequirement::UiRequirement(QLabel* descriptionLabel, const std::function& requirementCheck, - const QString& userWarningMessage) - : m_descriptionLabel(descriptionLabel), m_requirementCheck(requirementCheck), m_lastResult(true), - m_userWarningMessage(userWarningMessage) -{ - retranslate(); -} - -void UiRequirement::reset() -{ - if (!isValid()) - return; - m_descriptionLabel->setText(m_originalText); - m_descriptionLabel->setToolTip(m_originalTooltip); -} - -void UiRequirement::setTexts() -{ - if (!isValid()) - return; - if (!m_lastResult) - { - m_descriptionLabel->setText( - QStringLiteral("\u2022 %1").arg(m_originalText)); - - if (!m_userWarningMessage.isEmpty()) - { - m_descriptionLabel->setCursor(Qt::WhatsThisCursor); - m_descriptionLabel->setToolTip(m_userWarningMessage); - } - } - else - { - if (m_originalText.startsWith(QStringLiteral("\u2022 "))) - return; - - m_descriptionLabel->setText(QStringLiteral("\u2022 %1").arg(m_originalText)); - m_descriptionLabel->setCursor(Qt::ArrowCursor); - m_descriptionLabel->setToolTip(m_originalTooltip); - } -} - -void UiRequirement::retranslate() -{ - if (!isValid()) - return; - - if (m_originalText.startsWith(QStringLiteral("\u2022 "))) - return; - - auto x = m_descriptionLabel->text(); - if (x.startsWith(QStringLiteral("\u2022 "))) - return; - - m_originalText = x; - - m_originalTooltip = m_descriptionLabel->toolTip(); - setTexts(); -} - -bool UiRequirement::checkRequirement() -{ - if (!isValid()) - return m_lastResult; - - m_lastResult = m_requirementCheck(); - - if (!m_descriptionLabel->isVisible() && !m_descriptionLabel->property("checkMe").toBool()) - { - return true; - } - - setTexts(); - - return m_lastResult; -} - -bool UiRequirementList::checkRequirements(QWidget* messageOnThisParent) -{ - bool result = true; - for (auto i = m_requirementList.begin(); i != m_requirementList.end(); ++i) - { - UiRequirement& r = (*i); - - if (!r.isValid()) - continue; - - if (!r.checkRequirement()) - { - result = false; - } - } - - if (!result && messageOnThisParent) - { - LtsWidgets::LtsMessageDialog::showMessage( - messageOnThisParent, - QApplication::translate("LtsWidgets::LtsDialog", - "There are elements that have invalid or no value.
" - "Please change values in the elements which are marked with red text."), - QApplication::translate("LtsWidgets::LtsDialog", "Operation not complete")); - } - - return result; -} - -void UiRequirementList::addRequirement(const UiRequirement& uiRequirement) -{ - m_requirementList.append(uiRequirement); -} - -void UiRequirementList::clear() -{ - for (auto i = m_requirementList.begin(); i != m_requirementList.end(); ++i) - { - UiRequirement& uir = *i; - uir.reset(); - } - - m_requirementList.clear(); -} - -void UiRequirementList::retranslate() -{ - for (auto i = m_requirementList.begin(); i != m_requirementList.end(); ++i) - { - UiRequirement& r = (*i); - - r.retranslate(); - } -} -} // namespace LtsWidgets diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/requirement_widget.h b/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/requirement_widget.h deleted file mode 100644 index 26259bf3f..000000000 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/LtsWidgets/requirement_widget.h +++ /dev/null @@ -1,62 +0,0 @@ - - -#pragma once - -#include "lts_widgets_export.h" - -#include -#include -#include - -class QLabel; - -namespace LtsWidgets -{ - -class LTSWIDGETS_EXPORT UiRequirement -{ - public: - explicit UiRequirement() = default; - - UiRequirement(QLabel* descriptionLabel, const std::function& requirementCheck, - const QString& userWarningMessage = QString()); - - void reset(); - - bool checkRequirement(); - - bool isValid() const - { - return m_descriptionLabel != nullptr; - } - - void retranslate(); - - private: - void setTexts(); - - QLabel* m_descriptionLabel; - std::function m_requirementCheck; - QString m_originalText; - QString m_originalTooltip; - bool m_lastResult; - QString m_userWarningMessage; -}; - -class LTSWIDGETS_EXPORT UiRequirementList -{ - public: - UiRequirementList() = default; - - bool checkRequirements(QWidget* messageOnThisParent = nullptr); - - void addRequirement(const UiRequirement& uiRequirement); - - void clear(); - - void retranslate(); - - private: - QVector m_requirementList; -}; -} // namespace LtsWidgets diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/PluginInterfaces/CMakeLists.txt b/qt6-after/qt6-migrated-legatus/Lts/Common/PluginInterfaces/CMakeLists.txt index 9313918c1..0a5ce328a 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/PluginInterfaces/CMakeLists.txt +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/PluginInterfaces/CMakeLists.txt @@ -51,8 +51,27 @@ ADD_LIBRARY(TopicReplayInterface SHARED ${CMAKE_CURRENT_SOURCE_DIR}/topic_replay_interface.h ${CMAKE_CURRENT_SOURCE_DIR}/topic_replay_interface.cpp ) -TARGET_INCLUDE_DIRECTORIES(TopicReplayInterface PUBLIC +TARGET_INCLUDE_DIRECTORIES(TopicReplayInterface PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_BINARY_DIR}/Lts/Common/TopicEditorBase # topiceditorbase_export.h ) TARGET_LINK_LIBRARIES(TopicReplayInterface PUBLIC Qt6::Core TopicEditorBase) + +# These interface base classes (e.g. DataPluginBase::Plugin) are Q_OBJECT classes. The top-level +# CMAKE_CXX_VISIBILITY_PRESET hidden compiles their Q_OBJECT meta symbols (staticMetaObject/vtable/ +# qt_metacall/typeinfo) as GLOBAL HIDDEN, so they are not exported from the .so. A cross-DSO +# subclass (e.g. AsbDataPlugin) then fails with "undefined reference to ...::staticMetaObject". +# Compile these interface libs with default visibility so the meta symbols are exported to consumers +# (the legacy build, without LTO, exported them). This only widens the export surface of these tiny +# interface libs; it changes no runtime behaviour. +set_target_properties( + DataPluginInterface + GuiPluginInterface + ProjectPluginInterface + StylePluginInterface + RecordReplayPlugin + TopicReplayInterface + PROPERTIES + CXX_VISIBILITY_PRESET default + CXX_VISIBILITY_INLINES_HIDDEN OFF +) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/PluginInterfaces/gui_plugin_interface.h b/qt6-after/qt6-migrated-legatus/Lts/Common/PluginInterfaces/gui_plugin_interface.h index 00387ca36..ede043069 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/PluginInterfaces/gui_plugin_interface.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/PluginInterfaces/gui_plugin_interface.h @@ -132,12 +132,12 @@ class Interface protected: LtsSession::LtsSession* m_session; + NGL::INGLLogger& m_logger; private: QFlags m_flags; QStringList m_options; LtsAppDescriptor::App m_appId; - NGL::INGLLogger& m_logger; }; } // namespace GuiPluginBase diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/CMakeLists.txt b/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/CMakeLists.txt index 18158324c..a5ea91ab4 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/CMakeLists.txt +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/CMakeLists.txt @@ -45,6 +45,7 @@ NGL_ADD_LIBRARY2(WS TopicEditorBase SHARED ${topic_editor_base_SRCS}) NGL_TARGET_INCLUDE_DIRECTORIES(TopicEditorBase PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/../ + ${CMAKE_CURRENT_BINARY_DIR} # topiceditorbase_export.h (generated here) ${CMAKE_CURRENT_BINARY_DIR}/../ # auto-export file ${CMAKE_BINARY_DIR}/Z/src/NGLLogger # ngllogger_export.h ) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_editor_base.h b/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_editor_base.h index b94a27893..d6b5d007e 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_editor_base.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_editor_base.h @@ -2,7 +2,7 @@ #pragma once #include "topic_editor_utils.h" -#include "topiceditorbase_export.h" +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_editor_utils.h b/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_editor_utils.h index 47a6f4368..de610a721 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_editor_utils.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_editor_utils.h @@ -1,6 +1,6 @@ #pragma once -#include "topiceditorbase_export.h" +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_preview_widget.h b/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_preview_widget.h index 650cf9a4f..f8b1f7873 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_preview_widget.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_preview_widget.h @@ -1,6 +1,6 @@ #pragma once #include "topic_editor_utils.h" -#include "topiceditorbase_export.h" +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_previewer.h b/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_previewer.h index 1e2a10b79..5fb7448cb 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_previewer.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Common/TopicEditorBase/topic_previewer.h @@ -1,6 +1,6 @@ #pragma once #include "topic_editor_utils.h" -#include "topiceditorbase_export.h" +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/DDS/Core/pacemaker.cpp b/qt6-after/qt6-migrated-legatus/Lts/DDS/Core/pacemaker.cpp index 6dae85406..0c278e567 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/DDS/Core/pacemaker.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/DDS/Core/pacemaker.cpp @@ -59,7 +59,7 @@ void Pacemaker::addPort(unsigned short number, Core::CorePortType portType, cons void Pacemaker::addPortInternal(unsigned short number, Core::CorePortType portType, const QString& properties) { - if (!m_state.ports.is_set()) + if (!m_state.ports.has_value()) m_state.ports = std::vector(); m_state.ports.get().push_back(Core::PortInformation(number, portType, properties.toStdString())); diff --git a/qt6-after/qt6-migrated-legatus/Lts/DDS/DdsUnitTests/function_topic_tests.cpp b/qt6-after/qt6-migrated-legatus/Lts/DDS/DdsUnitTests/function_topic_tests.cpp index 180704fc0..05b41d155 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/DDS/DdsUnitTests/function_topic_tests.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/DDS/DdsUnitTests/function_topic_tests.cpp @@ -1,6 +1,7 @@ #include "function_topic_tests.h" +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/DDS/Generic/generic_data_writer.h b/qt6-after/qt6-migrated-legatus/Lts/DDS/Generic/generic_data_writer.h index 15db873ff..58d4773e6 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/DDS/Generic/generic_data_writer.h +++ b/qt6-after/qt6-migrated-legatus/Lts/DDS/Generic/generic_data_writer.h @@ -86,7 +86,7 @@ template class GenericDataWriter final return false; } - if (si.is_set()) + if (si.has_value()) { rti::pub::WriteParams writeParams; rti::core::SampleIdentity sampleIdentity(si.get()->source_guid(), si.get()->publication_sequence_number()); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Data/asb_data_plugin.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Data/asb_data_plugin.cpp index 58cb5672d..4bbf8287a 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Data/asb_data_plugin.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Data/asb_data_plugin.cpp @@ -17,7 +17,7 @@ namespace AdvancedSymbology AdvancedSymbology::SidcDefinitions::Identity roleToIdentity(const ParticipantManagement::Role role) { AdvancedSymbology::SidcDefinitions::Identity identity = AdvancedSymbology::SidcDefinitions::Identity::Unknown; - switch (role.underlying()) { + switch (role) { case ParticipantManagement::Role::Unknown: identity = AdvancedSymbology::SidcDefinitions::Identity::Unknown; break; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Data/asb_foreign_interface_impl.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Data/asb_foreign_interface_impl.cpp index 9d718adbc..870b30f5e 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Data/asb_foreign_interface_impl.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Data/asb_foreign_interface_impl.cpp @@ -6,7 +6,7 @@ #ifdef BUILD_WITH_EXTERNAL_DDS #include "AreaEffectSimulation/aes_dtc.h" -#include "ParticipantManagement/ppm.hpp" +#include "ParticipantManagement/ppm_dtc.h" #endif #include "Symbology/symbol_data_to_render_role.h" #include "SymbologyImpl/advanced_symbology_logging.h" @@ -18,6 +18,7 @@ ForeignInterfaceImpl::ForeignInterfaceImpl(const std::shared_ptr& aesDtc, const std::shared_ptr& guezIedDtc) : m_ppmDtc(ppmDtc), m_aesDtc(aesDtc), m_guezIedDtc(guezIedDtc) + , m_logger(getLogger("AdvancedSymbologyPlugin")) { if (!m_ppmDtc) { @@ -53,100 +54,100 @@ QSharedPointer ForeignInterfaceImpl::findImage(const SymbolDataToR QSharedPointer ForeignInterfaceImpl::findImage(const ParticipantManagement::Participant& participant, int sizeL, const QColor& desiredColor) const { - AdvancedSymbology::SymbolDataToRender symDataToRender(QString::fromStdString(participant.symbol()), sizeL); + AdvancedSymbology::SymbolDataToRender symDataToRender(QString::fromStdString(participant.symbol), sizeL); if (!m_ppmDtc) return findImage(symDataToRender); - const ParticipantManagement::Party& party = m_ppmDtc->party(participant.partyId()); - symDataToRender.role = AdvancedSymbology::roleToRole<>(party.role()); + const ParticipantManagement::Party& party = m_ppmDtc->party(participant.partyId); + symDataToRender.role = AdvancedSymbology::roleToRole<>(party.role); - symDataToRender.fillColor = desiredColor.isValid() ? desiredColor : QColor::fromRgb(QRgb(party.color())); + symDataToRender.fillColor = desiredColor.isValid() ? desiredColor : QColor::fromRgb(QRgb(party.color)); symDataToRender.fillColorReplace = true; QColor injuryColor = QColor(100, 100, 0); ProjectDataManagement::VulnerabilityState currentState = ProjectDataManagement::VulnerabilityState::VulnerabilityState_CombatReady; - const ParticipantManagement::DynamicParticipantData dData = m_ppmDtc->dynamicParticipantData(participant.id()); + const ParticipantManagement::DynamicParticipantData dData = m_ppmDtc->dynamicParticipantData(participant.id); - if (dData.stateHistory().size()) + if (dData.stateHistory.size()) { const ParticipantManagement::StateInformation& lastState = - m_ppmDtc->youngestStateInformation(dData.stateHistory()); - currentState = lastState.vulnerabilityState(); + m_ppmDtc->youngestStateInformation(dData.stateHistory); + currentState = lastState.vulnerabilityState; - switch (lastState.originatorType().underlying()) + switch (lastState.originatorType) { - case ProjectDataManagement::StateChangeOriginator::ImprovisedExplosiveDevice: { + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_ImprovisedExplosiveDevice: { if (m_guezIedDtc) { - const GuezIedManagement::Ied& gIed = m_guezIedDtc->iedForEquipmentNumber(lastState.originatorId()); - if (gIed.id() > 0) + const GuezIedManagement::Ied& gIed = m_guezIedDtc->iedForEquipmentNumber(lastState.originatorId); + if (gIed.id > 0) { - int injuryPartyId = gIed.partyId(); + int injuryPartyId = gIed.partyId; if (injuryPartyId >= 0) - injuryColor = m_ppmDtc->party(injuryPartyId).color(); + injuryColor = m_ppmDtc->party(injuryPartyId).color; } } break; } - case ProjectDataManagement::StateChangeOriginator::DusMine: { + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_DusMine: { if (!m_aesDtc) { WARNING_LOG(m_logger) << "Fetching 'm_aesDtc' failed, No color and injury information will be " "included in symbol created for participant.id() " - << participant.id(); + << participant.id; return findImage(symDataToRender); } - const int partyId = m_aesDtc->partyForDusMine(lastState.originatorId()); + const int partyId = m_aesDtc->partyForDusMine(lastState.originatorId); if (partyId >= 0) - injuryColor = m_ppmDtc->party(partyId).color(); + injuryColor = m_ppmDtc->party(partyId).color; break; } - case ProjectDataManagement::StateChangeOriginator::AreaEffectSimulation: - case ProjectDataManagement::StateChangeOriginator::FunctionalArea: { + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_AreaEffectSimulation: + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_FunctionalArea: { if (!m_aesDtc) { WARNING_LOG(m_logger) << "Fetching 'm_aesDtc' failed, No color and injury information will be " "included in symbol created for participant.id() " - << participant.id(); + << participant.id; return findImage(symDataToRender); } AreaEffectSimulation::AesItem aesItem; - m_aesDtc->aesItemFromId(lastState.originatorId(), aesItem); + m_aesDtc->aesItemFromId(lastState.originatorId, aesItem); - if (aesItem.partyId().is_set()) - injuryColor = m_ppmDtc->party(aesItem.partyId().get()).color(); + if (aesItem.partyId.has_value()) + injuryColor = m_ppmDtc->party(aesItem.partyId.get()).color; break; } - case ProjectDataManagement::StateChangeOriginator::Participant: { + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_Participant: { const ParticipantManagement::Participant& participantOrigin = - m_ppmDtc->participant(lastState.originatorId()); + m_ppmDtc->participant(lastState.originatorId); - if (participantOrigin.id()) - injuryColor = m_ppmDtc->party(participantOrigin.partyId()).color(); + if (participantOrigin.id) + injuryColor = m_ppmDtc->party(participantOrigin.partyId).color; break; } - case ProjectDataManagement::StateChangeOriginator::Party: { - const ParticipantManagement::Party& partyOrigin = m_ppmDtc->party(lastState.originatorId()); + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_Party: { + const ParticipantManagement::Party& partyOrigin = m_ppmDtc->party(lastState.originatorId); - if (partyOrigin.id()) - injuryColor = partyOrigin.color(); + if (partyOrigin.id) + injuryColor = partyOrigin.color; break; } - case ProjectDataManagement::StateChangeOriginator::ObserverController: - case ProjectDataManagement::StateChangeOriginator::ExerciseControl: - case ProjectDataManagement::StateChangeOriginator::Initialization: - injuryColor = m_ppmDtc->party(1).color(); + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_ObserverController: + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_ExerciseControl: + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_Initialization: + injuryColor = m_ppmDtc->party(1).color; break; - case ProjectDataManagement::StateChangeOriginator::WoundTreatmentDevice: - case ProjectDataManagement::StateChangeOriginator::MedicalTimeout: - case ProjectDataManagement::StateChangeOriginator::Sanitation: - case ProjectDataManagement::StateChangeOriginator::MaintainanceDevice: - case ProjectDataManagement::StateChangeOriginator::Unknown: + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_WoundTreatmentDevice: + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_MedicalTimeout: + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_Sanitation: + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_MaintainanceDevice: + case ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_Unknown: break; } } @@ -159,7 +160,7 @@ QSharedPointer ForeignInterfaceImpl::findImage(const ParticipantMa AdvancedSymbology::Injury ForeignInterfaceImpl::stateToInjury(const ProjectDataManagement::VulnerabilityState& state) { - switch (state.underlying()) + switch (state) { case ProjectDataManagement::VulnerabilityState::VulnerabilityState_CombatReady: case ProjectDataManagement::VulnerabilityState::VulnerabilityState_TemporarySeverance: diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_save_as_symbol.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_save_as_symbol.cpp index 08f383d6d..29afee21f 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_save_as_symbol.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_save_as_symbol.cpp @@ -70,10 +70,10 @@ void SaveAsSymbol::onInputChanged(const QString &input) void SaveAsSymbol::onFileContentChanged(const FileManagement::FileContent &data, DataModification modType) { - if (data.fileType() != FileManagement::FileType::OperatorDefinedSymbol) + if (data.fileType != FileManagement::FileType::OperatorDefinedSymbol) return; - QString name = QString::fromStdString(data.name()); + QString name = QString::fromStdString(data.name); if (modType == DataModification::eRemoved) m_takenNames.removeAll(name); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_select_text_dialog.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_select_text_dialog.h index 8c62bed75..4fd7f1428 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_select_text_dialog.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_select_text_dialog.h @@ -19,7 +19,7 @@ class SelectTextDialog final : public LtsWidgets::LtsFramelessDialog ~SelectTextDialog(); protected: - NGL::INGLLogger& m_logger; + //NGL::INGLLogger& m_logger; // unused (legacy: commented out) Ui_SelectTextDialog* ui; private: diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor.cpp index af6abd01d..324e74833 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor.cpp @@ -125,7 +125,7 @@ SymbolEditor::SymbolEditor(LtsSession::LtsSession *session, QWidget *parent) : LtsDialog(parent, LtsWidgets::ButtonCombination::OkApplyCancel) , m_ui(new Ui::SymbolEditor) , m_session(session) - .getNGLLogger("SymbolEditor")) + , m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger().getNGLLogger("SymbolEditor")) { DEBUG_LOG(m_logger) << "SymbolEditor(" << "parent=" << parent << ")"; m_ui->setupUi(this); @@ -227,9 +227,9 @@ bool SymbolEditor::init(const std::shared_ptr& f m_internal->m_symbolColorsPreview.clear(); m_internal->m_ppmDtc->partys([this](const ParticipantManagement::Party& data) { m_internal->m_symbolColorsPreview.append( - {ParticipantManagement::trPartyName(data.name()), QColor::fromRgb(data.color())}); - m_internal->m_symbolColorsPreview.append({tr("%1 (faded)").arg(ParticipantManagement::trPartyName(data.name())), - QColor::fromRgb(data.fadingColor())}); + {ParticipantManagement::trPartyName(data.name), QColor::fromRgb(data.color)}); + m_internal->m_symbolColorsPreview.append({tr("%1 (faded)").arg(ParticipantManagement::trPartyName(data.name)), + QColor::fromRgb(data.fadingColor)}); }); m_internal->m_toolButtonGroup.addButton(m_ui->ToolButtonRect); @@ -812,11 +812,9 @@ void SymbolEditor::updateSymbolAttributesWidgets() m_ui->ListViewMisc->clearSelection(); m_ui->ListViewTruppengattung->clearSelection(); - QLinkedList primitives = m_internal->m_symbol.getPrimitives(); - QLinkedListIterator pi(primitives); - while (pi.hasNext()) + auto primitives = m_internal->m_symbol.getPrimitives(); + for (auto* prim : primitives) { - SymbologyXML::Primitive* prim = pi.next(); int iconId = prim->icon(); SymbologyXML::SymbolTypes::t_icon_type iconType = prim->iconType(); SymbologyXML::SymbolTypes::t_sector_position sectorPosition = prim->position(); @@ -1445,7 +1443,7 @@ void SymbolEditor::slotImportTemplate() else { FileManagement::FileContent fc = m_internal->m_flmDtc->fileContent(fileId); - QString symbolName = QString::fromStdString(fc.name()); + QString symbolName = QString::fromStdString(fc.name); SymbologyXML::SymbolReader sr; pushUndo(); sr.read(content, m_internal->m_symbol); @@ -1453,7 +1451,7 @@ void SymbolEditor::slotImportTemplate() m_internal->m_lastFileId = fileId; m_internal->m_lastFileName = symbolName; - m_internal->m_lastFolderId = fc.folderId(); + m_internal->m_lastFolderId = fc.folderId; updateGUI(); __unchange__(); @@ -1850,7 +1848,7 @@ void SymbolEditor::onToolButtonTextClicked() void SymbolEditor::resetToolButtonGroupState() { - m_ui->ToolButtonSelect->animateClick(1); + m_ui->ToolButtonSelect->animateClick(); } void SymbolEditor::onPushButtonFillColorClicked() @@ -1934,11 +1932,9 @@ void SymbolEditor::copyElementsFromSymbol(const SymbologyXML::Symbol& tmpSymbol) m_internal->m_symbol.addBranch((SymbologyXML::SymbolTypes::t_branch)idx); } - QLinkedList prims = tmpSymbol.getPrimitives(); - QLinkedListIterator pi(prims); - while (pi.hasNext()) + auto prims = tmpSymbol.getPrimitives(); + for (auto* prim : prims) { - SymbologyXML::Primitive* prim = pi.next(); if ((prim->type() == SymbologyXML::Primitive::ICON) && m_internal->m_symbol.containsPrimitive(prim->iconType(), prim->position(), prim->icon())) continue; @@ -3016,8 +3012,8 @@ bool SymbolEditor::writeFile(bool saveAsNew) DEBUG_LOG(m_logger) << "Saved file with id = " << fileId; m_internal->m_lastFileId = fileId; FileManagement::FileContent fc = m_internal->m_flmDtc->fileContent(fileId); - m_internal->m_lastFolderId = fc.folderId(); - const QString fileName = QString::fromStdString(fc.name()); + m_internal->m_lastFolderId = fc.folderId; + const QString fileName = QString::fromStdString(fc.name); m_internal->m_lastFileName = fileName; m_internal->m_symbol.setName(fileName); bRet = true; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor.h index 6e003ef58..f8dd56675 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor.h @@ -6,7 +6,7 @@ #include #include #include -#include +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor_gui_plugin.h index 913a679ad..03960367c 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/asb_symbol_editor_gui_plugin.h @@ -5,7 +5,7 @@ #include #include -#include +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/flm_reply_handler.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/flm_reply_handler.cpp index 7bdb7a19b..12bae56de 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/flm_reply_handler.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/flm_reply_handler.cpp @@ -27,8 +27,8 @@ void FileManagementReplyHandler::requestReply(const Core::FunctionReplyObject &r void FileManagementReplyHandler::onGetFileContentDataReply(const FileManagement::GetFileContentDataReply &replyObject) { - m_content = replyObject.content(); - m_id = replyObject.id(); + m_content = replyObject.content; + m_id = replyObject.id; m_requestHelper->requestReply(replyObject); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/forms/asb_symbol_editor.ui b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/forms/asb_symbol_editor.ui index d8bfb39b4..a9eb5660a 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/forms/asb_symbol_editor.ui +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolEditor/forms/asb_symbol_editor.ui @@ -318,7 +318,7 @@ Qt::ScrollBarAsNeeded - QPainter::Antialiasing|QPainter::HighQualityAntialiasing|QPainter::SmoothPixmapTransform|QPainter::TextAntialiasing + QPainter::Antialiasing|QPainter::SmoothPixmapTransform|QPainter::TextAntialiasing @@ -576,7 +576,7 @@ Qt::ScrollBarAlwaysOff - QPainter::Antialiasing|QPainter::HighQualityAntialiasing|QPainter::SmoothPixmapTransform|QPainter::TextAntialiasing + QPainter::Antialiasing|QPainter::SmoothPixmapTransform|QPainter::TextAntialiasing diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_flm_subscriber.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_flm_subscriber.cpp index d88c881d8..e08604df9 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_flm_subscriber.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_flm_subscriber.cpp @@ -6,7 +6,7 @@ #include #include -#include +#include #include #include #include @@ -152,7 +152,7 @@ bool FlmSubscriber::createFlmSymbolProxy(int type_placeholder) #ifdef SKIP_SOME_TO_TEST_REFETCHING if (fileContentId >= 98) - request.fileContentId(-1); + request.fileContentId = -1; #endif #endif @@ -179,7 +179,7 @@ bool FlmSubscriber::createFlmSymbolProxy(int type_placeholder) void FlmSubscriber::onGetFileContentDataReply(const FileManagement::GetFileContentDataReply& reply) { - const int32_t fileContentId = reply.id(); + const int32_t fileContentId = reply.id; TRACE_LOG(m_logger) << Q_FUNC_INFO << " START, " << fileContentId; @@ -197,16 +197,16 @@ void FlmSubscriber::onGetFileContentDataReply(const FileManagement::GetFileConte DEBUG_LOG(m_logger) << Q_FUNC_INFO << " fileContentId=" << fileContentId << " name=" << name << " operatorName=" << operatorName << " lastModified=" << lastModified - << " #bytes =" << reply.content().size(); + << " #bytes =" << reply.content.size(); - fcData.monitoring.replyContentSize = reply.content().size(); + fcData.monitoring.replyContentSize = reply.content.size(); switch (fcData.type) { case FileContentStruct::SymbolType::EtsSymbol: { QImage image; - if (!svgToImage(QByteArray::fromRawData(reinterpret_cast(&reply.content().at(0)), - reply.content().size()), + if (!svgToImage(QByteArray::fromRawData(reinterpret_cast(&reply.content.at(0)), + reply.content.size()), image)) { ERROR_LOG(m_logger) << Q_FUNC_INFO << " svgToImage failed, fileContentId=" << fileContentId; @@ -225,7 +225,7 @@ void FlmSubscriber::onGetFileContentDataReply(const FileManagement::GetFileConte case FileContentStruct::SymbolType::XmlSymbol: { FlmSymbolProxy::SymbolData symbolData(name, operatorName, lastModified, - LtsUtils::toQByteArray(reply.content())); + LtsUtils::toQByteArray(reply.content)); if (symbolData.isXmlSymbol()) { @@ -277,7 +277,7 @@ bool FlmSubscriber::svgToImage(const QByteArray& svgByteArray, QImage& imageOut) QString FlmSubscriber::operatorName(int operatorId) { if (d->m_opmDtc) - return QString::fromStdString(d->m_opmDtc->user(operatorId).name()); + return QString::fromStdString(d->m_opmDtc->user(operatorId).name); return QStringLiteral("unknown user<%1>").arg(operatorId); } @@ -339,20 +339,20 @@ void FlmSubscriber::checkForReFetching() void FlmSubscriber::onFileContentChanged(const FileManagement::FileContent& data, DataModification modType) { - TRACE_LOG(m_logger) << Q_FUNC_INFO << " data.id=" << data.id() - << " data.fileStatus=" << data.fileStatus().underlying() << " modType=" << modType - << " data.name='" << data.name().c_str() << "'"; + TRACE_LOG(m_logger) << Q_FUNC_INFO << " data.id=" << data.id + << " data.fileStatus=" << data.fileStatus << " modType=" << modType + << " data.name='" << data.name.c_str() << "'"; if (!d->m_flmFtc) return; - if (data.isDeleted()) + if (data.isDeleted) return; - if (data.fileType().underlying() != FileManagement::FileType::OperatorDefinedSymbol) + if (data.fileType != FileManagement::FileType::OperatorDefinedSymbol) return; - if (data.fileStatus().underlying() == FileManagement::FileStatus::Deleted) + if (data.fileStatus == FileManagement::FileStatus::Deleted) { switch (modType) { @@ -367,7 +367,7 @@ void FlmSubscriber::onFileContentChanged(const FileManagement::FileContent& data } } - const int32_t fileContentId = data.id(); + const int32_t fileContentId = data.id; switch (modType) { case DataModification::eAdded: @@ -383,13 +383,13 @@ void FlmSubscriber::onFileContentChanged(const FileManagement::FileContent& data case DataModification::eRemoved: { DEBUG_LOG(m_logger) << Q_FUNC_INFO << " modType=" << modType << " fileContentId=" << fileContentId - << " fileContentName=" << data.name(); + << " fileContentName=" << data.name; d->m_fileContentMap.remove(fileContentId); if (!d->m_symbolProxy.removeSymbol(fileContentId)) ERROR_LOG(m_logger) << Q_FUNC_INFO << " removeSymbol failed" - << " fileContentId=" << fileContentId << " fileContentName='" << data.name() << "'" + << " fileContentId=" << fileContentId << " fileContentName='" << data.name << "'" << " contains=" << d->m_fileContentMap.contains(fileContentId); break; } @@ -400,35 +400,35 @@ void FlmSubscriber::updateFileContentMap(const FileManagement::FileContent& data { TRACE_LOG(m_logger) << Q_FUNC_INFO << " START" << " d->m_fileContentMap.size()=" << d->m_fileContentMap.size() - << " fileContentId=" << data.id() << " data.isDeleted()=" << data.isDeleted() - << " data.fileStatus().underlying()=" << data.fileStatus().underlying() << " data.name='" - << QString::fromStdString(data.name()) << "'"; + << " fileContentId=" << data.id << " data.isDeleted=" << data.isDeleted + << " data.fileStatus=" << data.fileStatus << " data.name='" + << QString::fromStdString(data.name) << "'"; - if (data.isDeleted()) + if (data.isDeleted) return; - if (data.fileStatus().underlying() == FileManagement::FileStatus::Deleted) + if (data.fileStatus == FileManagement::FileStatus::Deleted) return; - if (data.fileType() != FileManagement::FileType::OperatorDefinedSymbol) + if (data.fileType != FileManagement::FileType::OperatorDefinedSymbol) return; - const int32_t fileContentId = data.id(); + const int32_t fileContentId = data.id; FileContentStruct fcData; - fcData.name = QString::fromStdString(data.name()); + fcData.name = QString::fromStdString(data.name); fcData.type = FileContentStruct::SymbolType::UnsupportedSymbol; - fcData.operatorName = operatorName(data.operatorId()); - fcData.lastModified = data.lastModified(); + fcData.operatorName = operatorName(data.operatorId); + fcData.lastModified = data.lastModified; fcData.usrTags << QStringLiteral("file-id=%1").arg(fileContentId); - fcData.usrTags << QStringLiteral("exercise-id=%1").arg(data.exerciseId().is_set() ? data.exerciseId().get() : -1); + fcData.usrTags << QStringLiteral("exercise-id=%1").arg(data.exerciseId.has_value() ? data.exerciseId.get() : -1); fcData.usrTags << fcData.operatorName; - if (data.properties().size() != 0) + if (data.properties.size() != 0) { - const QByteArray attributesJson(QByteArray::fromRawData(data.properties().c_str(), data.properties().size())); + const QByteArray attributesJson(QByteArray::fromRawData(data.properties.c_str(), data.properties.size())); QJsonParseError parseError; QJsonDocument jDoc(QJsonDocument::fromJson(attributesJson, &parseError)); @@ -476,9 +476,9 @@ void FlmSubscriber::updateFileContentMap(const FileManagement::FileContent& data TRACE_LOG(m_logger) << Q_FUNC_INFO << " END" << " d->m_fileContentMap.size()=" << d->m_fileContentMap.size() - << " fileContentId=" << data.id() << " data.isDeleted()=" << data.isDeleted() - << " data.fileStatus().underlying()=" << data.fileStatus().underlying() << " data.name='" - << QString::fromStdString(data.name()) << "'"; + << " fileContentId=" << data.id << " data.isDeleted=" << data.isDeleted + << " data.fileStatus=" << data.fileStatus << " data.name='" + << QString::fromStdString(data.name) << "'"; } void FlmSubscriber::onLocalSymbolProxyEtsSymbolAdded(qint32 fileContentId, const QString& name, const QImage& image, diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_flm_subscriber.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_flm_subscriber.h index 11be5b551..2b207f0ba 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_flm_subscriber.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_flm_subscriber.h @@ -6,7 +6,7 @@ #include #include #include -#include +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_symbol_proxy_gui_plugin.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_symbol_proxy_gui_plugin.cpp index f5502cfac..58bf42e3e 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_symbol_proxy_gui_plugin.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/asb_symbol_proxy_gui_plugin.cpp @@ -10,7 +10,7 @@ #include #include "flm_symbol_proxy.h" -#include +#include #include namespace AdvancedSymbology diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/flm_symbol_proxy.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/flm_symbol_proxy.h index 3adbfcfc6..012565621 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/flm_symbol_proxy.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AdvancedSymbology/Gui/SymbolProxy/flm_symbol_proxy.h @@ -9,6 +9,7 @@ #include #include #include +#include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_config_alarm_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_config_alarm_model.cpp index e7dddac76..2b708b980 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_config_alarm_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_config_alarm_model.cpp @@ -63,58 +63,47 @@ QVariant ConfigAlarmModel::data(const QModelIndex& index, int role) const return QVariant(); const AlarmManagement::AlarmConfig& alarmConfig = m_vecData.at(index.row()); - if (alarmConfig.global() != m_global) + if (alarmConfig.global != m_global) return QVariant(); switch (index.column()) { case Id: - return alarmConfig.id(); + return alarmConfig.id; case EquipmentNumber: { - const int equipmentNumber = m_alarmHistoryModel->participantId2EquipNo(alarmConfig.participantId()); + const int equipmentNumber = m_alarmHistoryModel->participantId2EquipNo(alarmConfig.participantId); if (equipmentNumber == 0) return tr("All"); return equipmentNumber; } case Designator: - return m_alarmHistoryModel->getDesignator(alarmConfig.participantId()); + return m_alarmHistoryModel->getDesignator(alarmConfig.participantId); case TactIdentifier: - return m_alarmHistoryModel->getTactIdentifier(alarmConfig.participantId()); + return m_alarmHistoryModel->getTactIdentifier(alarmConfig.participantId); case VulnerabilityState: { QString vulnerabilityState = tr("All Types"); - if (alarmConfig.vulnerabilityState() >= 0) + if (alarmConfig.vulnerabilityState >= 0) { - // participant() existiert nicht mehr, suche in participantsList() - auto participantIt = std::find_if( - m_ppmDtc->participantsList().begin(), m_ppmDtc->participantsList().end(), - [id = alarmConfig.participantId()](const ParticipantManagement::Participant& p) { - return p.id() == id; - }); - - ParticipantManagement::TypeClass typeClass = ParticipantManagement::TypeClass::Other; - // STUB: type()-Methode nicht verfügbar - verwende Default-Wert - // if (participantIt != m_ppmDtc->participantsList().end()) - // { - // typeClass = m_ppmDtc->type(participantIt->typeId()).typeClass(); - // } + ParticipantManagement::TypeClass typeClass = + m_ppmDtc->type(m_ppmDtc->participant(alarmConfig.participantId).typeId).typeClass; const ProjectDataManagement::VulnerabilityClass vc = typeClass == ParticipantManagement::TypeClass::Human - ? ProjectDataManagement::VulnerabilityClass::SoldierInjuries - : ProjectDataManagement::VulnerabilityClass::VehicleDamages; + ? ProjectDataManagement::VulnerabilityClass::VulnerabilityClass_SoldierInjuries + : ProjectDataManagement::VulnerabilityClass::VulnerabilityClass_VehicleDamages; ProjectDataManagement::VulnerabilityState vs = - static_cast(alarmConfig.vulnerabilityState()); + static_cast(alarmConfig.vulnerabilityState); vulnerabilityState = ProjectDataManagement::toString(vs, vc); } return vulnerabilityState; } case EventType: - return ProjectDataManagement::toString(static_cast(alarmConfig.eventTypeId())); + return ProjectDataManagement::toString(static_cast(alarmConfig.eventTypeId)); case MessageWindow: - return alarmConfig.messageWindow() ? tr("Yes") : tr("No"); + return alarmConfig.messageWindow ? tr("Yes") : tr("No"); case SetMarker: - return alarmConfig.setMarker() ? tr("Yes") : tr("No"); + return alarmConfig.setMarker ? tr("Yes") : tr("No"); } return QVariant(); @@ -122,15 +111,15 @@ QVariant ConfigAlarmModel::data(const QModelIndex& index, int role) const void ConfigAlarmModel::onAlarmConfigChanged(const AlarmManagement::AlarmConfig& data, const DataModification modType) { - const int id = data.id(); - if (data.global() != m_global) + const int id = data.id; + if (data.global != m_global) return; int row = findRowForId(id); - const int eventTypeId = data.eventTypeId(); - const bool messageWindow = data.messageWindow(); - const bool setMarker = data.setMarker(); + const int eventTypeId = static_cast(data.eventTypeId); + const bool messageWindow = data.messageWindow; + const bool setMarker = data.setMarker; DEBUG_LOG(getLogger()) << "onAlarmConfigChanged: " << eventTypeId << " messageWindow=" << messageWindow << "setMarker" << setMarker; @@ -140,8 +129,8 @@ void ConfigAlarmModel::onAlarmConfigChanged(const AlarmManagement::AlarmConfig& DEBUG_LOG(getLogger()) << "AlarmConfig was removed: " << id; AlarmManagement::AlarmConfig data1 = data; - data1.setMessageWindow(false); - data1.setSetMarker(false); + data1.messageWindow = false; + data1.setMarker = false; setRowData(row, data1); removeRow(row); return; @@ -153,7 +142,7 @@ void ConfigAlarmModel::onAlarmConfigChanged(const AlarmManagement::AlarmConfig& return; } - if (m_alarmHistoryModel->participantId2EquipNo(data.participantId()) > 0) + if (m_alarmHistoryModel->participantId2EquipNo(data.participantId) > 0) setRowData(row, data); break; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_config_alarm_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_config_alarm_model.h index cbe441272..81370595d 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_config_alarm_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_config_alarm_model.h @@ -6,7 +6,6 @@ #include "almcommon_export.h" #include -#include #include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_history_alarm_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_history_alarm_model.cpp index bc01f79a4..b3c677858 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_history_alarm_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_history_alarm_model.cpp @@ -49,7 +49,7 @@ bool AlarmHistoryModel::initModel(const std::shared_ptrparticipants(cbParticipants); @@ -66,7 +66,7 @@ bool AlarmHistoryModel::initModel(const std::shared_ptrbcContaminations(cbAesItem); + m_aesDtc->bCContaminations(cbAesItem); m_aesDtc->boobyTraps(cbAesItem); m_aesDtc->offRouteMines(cbAesItem); @@ -84,7 +84,7 @@ QVariant AlarmHistoryModel::data(const QModelIndex& index, int role) const if (role == Qt::BackgroundRole) { - if (notificationEx.eventType() == ProjectDataManagement::PdmEventType::Alarm) + if (notificationEx.eventType == ProjectDataManagement::PdmEventType::EventType_EmergencyCall) return QColor(Qt::red); return QVariant(); } @@ -94,7 +94,7 @@ QVariant AlarmHistoryModel::data(const QModelIndex& index, int role) const case Id: return notificationEx.id; case Date: - return QDateTime::fromMSecsSinceEpoch(notificationEx.time()); + return QDateTime::fromMSecsSinceEpoch(notificationEx.time); case EquipmentNumber: if (notificationEx.equipmentNumber) return notificationEx.equipmentNumber; @@ -107,10 +107,10 @@ QVariant AlarmHistoryModel::data(const QModelIndex& index, int role) const return notificationEx.participantId; case Position: if (role == Qt::DisplayRole) - return LtsCoordTrans::mgrsFromGeographic(notificationEx.position().lon(), - notificationEx.position().lat()); + return LtsCoordTrans::mgrsFromGeographic(notificationEx.position.lon, + notificationEx.position.lat); else if (role == Qt::UserRole) - return QPointF(notificationEx.position().lon(), notificationEx.position().lat()); + return QPointF(notificationEx.position.lon, notificationEx.position.lat); break; case AesId: return notificationEx.aesId; @@ -124,9 +124,9 @@ QVariant AlarmHistoryModel::data(const QModelIndex& index, int role) const bool AlarmHistoryModel::isFiltered(const NotificationEx& data, DataModification modType) const { Q_UNUSED(modType); - if (data.operatorId() == 0) + if (data.operatorId == 0) return false; - return data.operatorId() != LtsSessionData::LtsSessionData::getInstance()->getOperatorId(); + return data.operatorId != LtsSessionData::LtsSessionData::getInstance()->getOperatorId(); } void AlarmHistoryModel::onNotificationChanged(const AlarmManagement::Notification& data, const DataModification modType) @@ -135,16 +135,16 @@ void AlarmHistoryModel::onNotificationChanged(const AlarmManagement::Notificatio return; NotificationEx notification(data); - const QByteArray properties = QByteArray::fromRawData(data.properties().c_str(), data.properties().size()); + const QByteArray properties = QByteArray::fromRawData(data.properties.c_str(), data.properties.size()); const QJsonDocument propertieJsonDoc = QJsonDocument::fromJson(properties); const QJsonObject propertieJsonObj = propertieJsonDoc.object(); - notification.equipmentNumber = data.equipmentNumber(); - if (data.participantId().has_value()) - notification.participantId = data.participantId().value(); - notification.eventTypeId = static_cast(data.eventType()); - if (data.aesId().has_value()) - notification.aesId = data.aesId().value(); + notification.equipmentNumber = data.equipmentNumber; + if (data.participantId.has_value()) + notification.participantId = data.participantId.value(); + notification.eventTypeId = static_cast(data.eventType); + if (data.aesId.has_value()) + notification.aesId = data.aesId.value(); const int global = propertieJsonObj[QStringLiteral("Global")].toInt(); const int friendlyFire = propertieJsonObj[QStringLiteral("FriendlyFire")].toInt(); @@ -155,19 +155,19 @@ void AlarmHistoryModel::onNotificationChanged(const AlarmManagement::Notificatio } void AlarmHistoryModel::onParticipantChanged(const ParticipantManagement::Participant& participant, - const ParticipantManagement::DataModification modType) + const DataModification modType) { - if (modType == ParticipantManagement::DataModification::eRemoved) + if (modType == DataModification::eRemoved) return; - QString designator = participant.designator(); - m_idDesignatorMap.insert(participant.id(), designator); + QString designator = QString::fromStdString(participant.designator); + m_idDesignatorMap.insert(participant.id, designator); const int equipNo = participant.equipmentNumber.has_value() ? participant.equipmentNumber.value() : 0; - m_partId2EquipNoMap.insert(participant.id(), equipNo); + m_partId2EquipNoMap.insert(participant.id, equipNo); - QString tacticalIdentifier = participant.tacticalIdentifier(); - m_idTactIdentifierMap.insert(participant.id(), tacticalIdentifier); - DEBUG_LOG(getLogger("AlarmHistoryModel")) << Q_FUNC_INFO << " id=" << participant.id() << " designator=" << designator + QString tacticalIdentifier = QString::fromStdString(participant.tacticalIdentifier); + m_idTactIdentifierMap.insert(participant.id, tacticalIdentifier); + DEBUG_LOG(getLogger("AlarmHistoryModel")) << Q_FUNC_INFO << " id=" << participant.id << " designator=" << designator << " tacticalIdentifier=" << tacticalIdentifier; } @@ -199,8 +199,8 @@ void AlarmHistoryModel::onBCContaminationChanged(const AreaEffectSimulation::BCC { if (modType == DataModification::eRemoved) return; - int id = data.id(); - QString name = QString::fromStdString(data.name()); + int id = data.id; + QString name = QString::fromStdString(data.name); m_aesNameMap[id] = name; DEBUG_LOG(getLogger("AlarmHistoryModel")) << "onBCContaminationChanged: id=" << id << " Name=" << name; } @@ -209,8 +209,8 @@ void AlarmHistoryModel::onBoobyTrapChanged(const AreaEffectSimulation::BoobyTrap { if (modType == DataModification::eRemoved) return; - int id = data.id(); - QString name = QString::fromStdString(data.name()); + int id = data.id; + QString name = QString::fromStdString(data.name); m_aesNameMap[id] = name; DEBUG_LOG(getLogger("AlarmHistoryModel")) << "BoobyTrap: id=" << id << " Name=" << name; } @@ -220,8 +220,8 @@ void AlarmHistoryModel::onOffRouteMineChanged(const AreaEffectSimulation::OffRou { if (modType == DataModification::eRemoved) return; - int id = data.id(); - QString name = QString::fromStdString(data.name()); + int id = data.id; + QString name = QString::fromStdString(data.name); m_aesNameMap[id] = name; DEBUG_LOG(getLogger("AlarmHistoryModel")) << "OffRouteMine: id=" << id << " Name=" << name; } @@ -230,8 +230,8 @@ void AlarmHistoryModel::onAesItemChanged(const AreaEffectSimulation::AesItem& it { if (modType == DataModification::eRemoved) return; - QString name = QString::fromStdString(item.name()); - int id = item.id(); + QString name = QString::fromStdString(item.name); + int id = item.id; m_aesNameMap[id] = name; DEBUG_LOG(getLogger("AlarmHistoryModel")) << "AreaEffectSimulation::AesItem onAesItemChanged: id=" << id << " Name=" << name; @@ -253,7 +253,7 @@ bool AlarmHistoryProxyModel::lessThan(const QModelIndex& source_left, const QMod switch (source_left.column()) { case AlarmHistoryModel::Date: - return dataLeft.time() < dataRight.time(); + return dataLeft.time < dataRight.time; case AlarmHistoryModel::Id: case AlarmHistoryModel::Incident: diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_history_alarm_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_history_alarm_model.h index 9c8f6f72b..0638999e2 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_history_alarm_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/Common/alm_history_alarm_model.h @@ -11,7 +11,8 @@ #include #include #include -#include +#include +#include namespace AlarmManagement { @@ -50,7 +51,7 @@ class ALMCOMMON_EXPORT AlarmHistoryModel final : public LtsWidgets::LtsAbstractT bool isFiltered(const NotificationEx& data, DataModification modType) const override; public slots: void onNotificationChanged(const AlarmManagement::Notification& data, const DataModification modType); - void onParticipantChanged(const ParticipantManagement::Participant& participant, const ParticipantManagement::DataModification modType); + void onParticipantChanged(const ParticipantManagement::Participant& participant, const DataModification modType); void onAesItemChanged(const AreaEffectSimulation::AesItem& item, const DataModification modType); void onBCContaminationChanged(const AreaEffectSimulation::BCContamination& data, const DataModification modType); void onBoobyTrapChanged(const AreaEffectSimulation::BoobyTrap& data, const DataModification modType); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_config_alarm_gui_plugin.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_config_alarm_gui_plugin.cpp index ccbd652b2..397828799 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_config_alarm_gui_plugin.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_config_alarm_gui_plugin.cpp @@ -57,24 +57,24 @@ void InterfaceImpl::clearInterfaces() void InterfaceImpl::showEmergencyMessage(const AlarmManagement::Notification &data) { - if (data.eventType() != ProjectDataManagement::PdmEventType::EventType_EmergencyCall) + if (data.eventType != ProjectDataManagement::PdmEventType::EventType_EmergencyCall) return; - const int issi = data.equipmentNumber(); - const QString &positionStr = LtsCoordTrans::mgrsFromGeographic(data.position().lon(), data.position().lat()); + const int issi = data.equipmentNumber; + const QString &positionStr = LtsCoordTrans::mgrsFromGeographic(data.position.lon, data.position.lat); new LtsWidgets::LtsMessageDialogNew(m_session->baseLayout(), tr("ISSI: %1 --- Position: %2\n").arg(issi).arg(positionStr), - tr("!!!!!! Emergency Call --- %1 !!!!!").arg(DTG::toStringMSec(data.time()))); + tr("!!!!!! Emergency Call --- %1 !!!!!").arg(DTG::toStringMSec(data.time))); } void InterfaceImpl::showAlarm(const AlarmManagement::Notification &data) { showEmergencyMessage(data); - if (data.operatorId() == LtsSessionData::LtsSessionData::getInstance()->getOperatorId() || - data.operatorId() == 0) + if (data.operatorId == LtsSessionData::LtsSessionData::getInstance()->getOperatorId() || + data.operatorId == 0) { bool bWidgetExists = m_session->widgetExists(menuGroup(), m_alarmHistoryDialogIdentifier, m_alarmHistoryDialogLayoutArea); if (!bWidgetExists) @@ -87,7 +87,7 @@ void InterfaceImpl::onNotificationChanged(const AlarmManagement::Notification &d if (mod != DataModification::eAdded) return; - INFO_LOG(m_logger) << "ALARM! data.operatorId(): " << data.operatorId() + INFO_LOG(m_logger) << "ALARM! data.operatorId(): " << data.operatorId << "currentOperatorId: " << LtsSessionData::LtsSessionData::getInstance()->getOperatorId(); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_config_alarm_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_config_alarm_gui_plugin.h index 069aad536..a1caf63b0 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_config_alarm_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_config_alarm_gui_plugin.h @@ -7,11 +7,12 @@ #include #include #include -#include -#include +#include +#include #include #include +#include namespace AlarmManagement { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_dialog.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_dialog.cpp index e4df3c5f9..443d47736 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_dialog.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_dialog.cpp @@ -2,14 +2,15 @@ #include "alm_dialog.h" +#include #include "alm_history.h" #include "ui_alm_dialog.h" #include #include #include -#include -#include +#include +#include #include #include @@ -19,7 +20,7 @@ namespace AlarmManagement AlarmDialog::AlarmDialog(QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::OkApplyCancel), m_configAlarmModel(nullptr), m_dtc(nullptr), m_ftc(nullptr), m_ui(new Ui::AlarmDialog), m_requestHelper(new LtsUtils::RequestHelper(this)), - m_operatorId(-1) + m_operatorId(-1), m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { AlarmCheckBox alarmCheckBox; LtsUtils::ProjectSettings* ps = LtsUtils::ProjectSettings::getInstance(); @@ -158,23 +159,23 @@ void AlarmDialog::retranslate() void AlarmDialog::onAlarmConfigChanged(const AlarmManagement::AlarmConfig& data, DataModification modType) { - bool setMarker = data.setMarker(); - bool messageWindow = data.messageWindow(); + bool setMarker = data.setMarker; + bool messageWindow = data.messageWindow; if (modType == DataModification::eRemoved) return; DEBUG_LOG(m_logger) << "************** onAlarmConfigChanged " - << " id=" << data.id() << " operatorId=" << data.operatorId() - << " m_operatorId=" << m_operatorId << " participantId=" << data.participantId() - << " eventTypeId=" << data.eventTypeId() << " messageWindow=" << messageWindow + << " id=" << data.id << " operatorId=" << data.operatorId + << " m_operatorId=" << m_operatorId << " participantId=" << data.participantId + << " eventTypeId=" << data.eventTypeId << " messageWindow=" << messageWindow << " setMarker=" << setMarker; - if (data.global() == false) + if (data.global == false) return; - if (data.operatorId() == m_operatorId) + if (data.operatorId == m_operatorId) { DEBUG_LOG(m_logger) << "************** onAlarmConfig zuweisen "; - switch (data.eventTypeId().underlying()) + switch (data.eventTypeId) { case ProjectDataManagement::PdmEventType::EventType_EnterNuclear: { DEBUG_LOG(m_logger) << "EnterNuclear zuweisen "; @@ -247,28 +248,28 @@ std::vector AlarmDialog::getCheckedValues() const ret.reserve(m_checkBoxes.size()); for (const AlarmCheckBox& item : std::as_const(m_checkBoxes)) { - alarmActionDds.eventTypeId(item.eventTypeId); + alarmActionDds.eventTypeId = item.eventTypeId; if (item.checkboxMarker->isChecked()) { - alarmActionDds.setMarker(true); + alarmActionDds.setMarker = true; DEBUG_LOG(m_logger) << item.name << " setMarker = true"; } else { - alarmActionDds.setMarker(false); + alarmActionDds.setMarker = false; DEBUG_LOG(m_logger) << item.name << " setMarker = false"; } if (item.checkboxWindow->isChecked()) { - alarmActionDds.messageWindow(true); + alarmActionDds.messageWindow = true; DEBUG_LOG(m_logger) << item.name << " messageWindow = true"; } else { - alarmActionDds.messageWindow(false); + alarmActionDds.messageWindow = false; DEBUG_LOG(m_logger) << item.name << " messageWindow = false"; } - if (alarmActionDds.setMarker() || alarmActionDds.messageWindow()) + if (alarmActionDds.setMarker || alarmActionDds.messageWindow) ret.push_back(alarmActionDds); } return ret; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_dialog.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_dialog.h index 124cf1200..5f7b42a00 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_dialog.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_dialog.h @@ -7,6 +7,7 @@ #include #include #include +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_history.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_history.cpp index caa9ac5cc..723b4c7fc 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_history.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigAlarm/alm_history.cpp @@ -2,11 +2,12 @@ #include "alm_history.h" +#include #include "ui_alm_history.h" #include #include -#include +#include #include namespace AlarmManagement @@ -14,7 +15,8 @@ namespace AlarmManagement AlarmView::AlarmView(LtsSession::LtsSession* session, QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::CloseOnly), m_alarmHistoryModel(nullptr), - m_dtc(nullptr), m_sitMapGuiIfc(nullptr), m_session(session), m_ui(new Ui::AlarmView) + m_dtc(nullptr), m_sitMapGuiIfc(nullptr), m_session(session), m_ui(new Ui::AlarmView), + m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << " --- AlarmView Konstruktor() "; m_ui->setupUi(this); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_config_participant_dialog.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_config_participant_dialog.cpp index a377723a7..e72fd980c 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_config_participant_dialog.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_config_participant_dialog.cpp @@ -50,13 +50,13 @@ ConfigParticipantsDialog::~ConfigParticipantsDialog() void ConfigParticipantsDialog::retranslate() { - if (!m_participantData.equipmentNumber().is_set()) + if (!m_participantData.equipmentNumber.has_value()) { - QString hierarchy = m_ppmDtc->hierarchyFromParticipant(m_participantData.id()); + QString hierarchy = m_ppmDtc->hierarchyFromParticipant(m_participantData.id); translate(m_ui, m_participantData, hierarchy, tr("Participant Alarm")); } else - translate(m_ui, m_participantData, QString::number(m_participantData.equipmentNumber().get()), + translate(m_ui, m_participantData, QString::number(m_participantData.equipmentNumber.get()), tr("Participant Alarm")); m_uiRequirements->clear(); @@ -82,12 +82,12 @@ bool ConfigParticipantsDialog::init(const std::shared_ptrgetOperatorId(); - m_ui->lbHierarchy->setText(m_ppmDtc->hierarchyFromParticipant(m_participantData.id())); + m_ui->lbHierarchy->setText(m_ppmDtc->hierarchyFromParticipant(m_participantData.id)); QString equipmentNumbersStr; - if (participantData.equipmentNumber().is_set()) + if (participantData.equipmentNumber.has_value()) { - equipmentNumbersStr.append(QString::number(participantData.equipmentNumber().get())); + equipmentNumbersStr.append(QString::number(participantData.equipmentNumber.get())); equipmentNumbersStr.append(QStringLiteral(": ")); } @@ -97,10 +97,10 @@ bool ConfigParticipantsDialog::init(const std::shared_ptrequipmentNoContent->setText(equipmentNumbersStr); - DEBUG_LOG(m_logger) << "current participantId = " << participantData.id(); + DEBUG_LOG(m_logger) << "current participantId = " << participantData.id; - m_typeClass = ppmDtc->type(participantData.typeId()).typeClass(); - DEBUG_LOG(m_logger) << "m_typeClass=" << m_typeClass << " TypeId=" << participantData.typeId(); + m_typeClass = ppmDtc->type(participantData.typeId).typeClass; + DEBUG_LOG(m_logger) << "m_typeClass=" << m_typeClass << " TypeId=" << participantData.typeId; fillCbx(); m_almDtc->alarmConfigs([this](const AlarmManagement::AlarmConfig& alarm) { setAlaramData(alarm); }); @@ -110,21 +110,21 @@ bool ConfigParticipantsDialog::init(const std::shared_ptrcbxDirectFire->setChecked(true); - m_ui->cbxSetMarker->setChecked(alarm.setMarker()); - m_ui->cbxMessageWindow->setChecked(alarm.messageWindow()); - if (alarm.vulnerabilityState() >= 0) + m_ui->cbxSetMarker->setChecked(alarm.setMarker); + m_ui->cbxMessageWindow->setChecked(alarm.messageWindow); + if (alarm.vulnerabilityState >= 0) { ProjectDataManagement::VulnerabilityState vulState = - static_cast(alarm.vulnerabilityState()); - int index = m_ui->cbStatusDirect->findData(QVariant(vulState.underlying())); + static_cast(alarm.vulnerabilityState); + int index = m_ui->cbStatusDirect->findData(QVariant(static_cast(vulState))); m_ui->cbStatusDirect->setCurrentIndex(index); } break; @@ -132,22 +132,22 @@ void ConfigParticipantsDialog::setAlaramData(const AlarmManagement::AlarmConfig& case ProjectDataManagement::PdmEventType::EventType_HitEffectSimulation: { DEBUG_LOG(m_logger) << "HitIndirect zuweisen "; m_ui->cbxIndirectFire->setChecked(true); - m_ui->cbxSetMarker->setChecked(alarm.setMarker()); - m_ui->cbxMessageWindow->setChecked(alarm.messageWindow()); + m_ui->cbxSetMarker->setChecked(alarm.setMarker); + m_ui->cbxMessageWindow->setChecked(alarm.messageWindow); break; } case ProjectDataManagement::PdmEventType::EventType_AirSupport: { DEBUG_LOG(m_logger) << "AirSupport zuweisen "; m_ui->cbxAirSupport->setChecked(true); - m_ui->cbxSetMarker->setChecked(alarm.setMarker()); - m_ui->cbxMessageWindow->setChecked(alarm.messageWindow()); + m_ui->cbxSetMarker->setChecked(alarm.setMarker); + m_ui->cbxMessageWindow->setChecked(alarm.messageWindow); break; } case ProjectDataManagement::PdmEventType::EventType_HitMine: { DEBUG_LOG(m_logger) << "HitMine zuweisen "; m_ui->cbxMines->setChecked(true); - m_ui->cbxSetMarker->setChecked(alarm.setMarker()); - m_ui->cbxMessageWindow->setChecked(alarm.messageWindow()); + m_ui->cbxSetMarker->setChecked(alarm.setMarker); + m_ui->cbxMessageWindow->setChecked(alarm.messageWindow); break; } case ProjectDataManagement::PdmEventType::EventType_HitB: @@ -155,20 +155,20 @@ void ConfigParticipantsDialog::setAlaramData(const AlarmManagement::AlarmConfig& case ProjectDataManagement::PdmEventType::EventType_HitC: { DEBUG_LOG(m_logger) << "Hit N/B/C zuweisen "; m_ui->cbxNbcAgent->setChecked(true); - m_ui->cbxSetMarker->setChecked(alarm.setMarker()); - m_ui->cbxMessageWindow->setChecked(alarm.messageWindow()); + m_ui->cbxSetMarker->setChecked(alarm.setMarker); + m_ui->cbxMessageWindow->setChecked(alarm.messageWindow); break; } case ProjectDataManagement::PdmEventType::EventType_FriendlyFire: { DEBUG_LOG(m_logger) << "FriendlyFire zuweisen "; m_ui->cbxFriendlyFire->setChecked(true); - m_ui->cbxSetMarker->setChecked(alarm.setMarker()); - m_ui->cbxMessageWindow->setChecked(alarm.messageWindow()); - if (alarm.vulnerabilityState() >= 0) + m_ui->cbxSetMarker->setChecked(alarm.setMarker); + m_ui->cbxMessageWindow->setChecked(alarm.messageWindow); + if (alarm.vulnerabilityState >= 0) { ProjectDataManagement::VulnerabilityState vulState = - static_cast(alarm.vulnerabilityState()); - int index = m_ui->cbStatusDirect->findData(QVariant(vulState.underlying())); + static_cast(alarm.vulnerabilityState); + int index = m_ui->cbStatusDirect->findData(QVariant(static_cast(vulState))); m_ui->cbStatusFriendly->setCurrentIndex(index); } break; @@ -176,22 +176,22 @@ void ConfigParticipantsDialog::setAlaramData(const AlarmManagement::AlarmConfig& case ProjectDataManagement::PdmEventType::EventType_Manipulation: { DEBUG_LOG(m_logger) << "Manipulation zuweisen "; m_ui->cbxManipulation->setChecked(true); - m_ui->cbxSetMarker->setChecked(alarm.setMarker()); - m_ui->cbxMessageWindow->setChecked(alarm.messageWindow()); + m_ui->cbxSetMarker->setChecked(alarm.setMarker); + m_ui->cbxMessageWindow->setChecked(alarm.messageWindow); break; } case ProjectDataManagement::PdmEventType::EventType_CrossGlobalBorderline: { DEBUG_LOG(m_logger) << "CrossGlobalBorderline zuweisen "; m_ui->cbxGlobalBorderLine->setChecked(true); - m_ui->cbxSetMarker->setChecked(alarm.setMarker()); - m_ui->cbxMessageWindow->setChecked(alarm.messageWindow()); + m_ui->cbxSetMarker->setChecked(alarm.setMarker); + m_ui->cbxMessageWindow->setChecked(alarm.messageWindow); break; } case ProjectDataManagement::PdmEventType::EventType_CrossLocalBorderline: { DEBUG_LOG(m_logger) << "CrossLocalBorderline zuweisen "; m_ui->cbxLocalBorderLine->setChecked(true); - m_ui->cbxSetMarker->setChecked(alarm.setMarker()); - m_ui->cbxMessageWindow->setChecked(alarm.messageWindow()); + m_ui->cbxSetMarker->setChecked(alarm.setMarker); + m_ui->cbxMessageWindow->setChecked(alarm.messageWindow); break; } default: { @@ -207,68 +207,68 @@ std::vector ConfigParticipantsDialog::getCheckedVa std::vector alarmsDds; - alarmActionDds.setMarker(m_ui->cbxSetMarker->isChecked()); - alarmActionDds.messageWindow(m_ui->cbxMessageWindow->isChecked()); - alarmActionDds.vulnerabilityState(-1); + alarmActionDds.setMarker = m_ui->cbxSetMarker->isChecked(); + alarmActionDds.messageWindow = m_ui->cbxMessageWindow->isChecked(); + alarmActionDds.vulnerabilityState = -1; - if (alarmActionDds.setMarker() || alarmActionDds.messageWindow()) + if (alarmActionDds.setMarker || alarmActionDds.messageWindow) { if (m_ui->cbxDirectFire->isChecked()) { - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_Hit); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_Hit; int statusDirect = -1; if (m_ui->cbStatusDirect->currentIndex() > 0) statusDirect = m_ui->cbStatusDirect->currentData().toInt(); - alarmActionDds.vulnerabilityState(statusDirect); + alarmActionDds.vulnerabilityState = statusDirect; alarmsDds.push_back(alarmActionDds); } if (m_ui->cbxFriendlyFire->isChecked()) { - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_FriendlyFire); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_FriendlyFire; int statusFriendly = -1; if (m_ui->cbStatusFriendly->currentIndex() > 0) statusFriendly = m_ui->cbStatusFriendly->currentData().toInt(); - alarmActionDds.vulnerabilityState(statusFriendly); + alarmActionDds.vulnerabilityState = statusFriendly; alarmsDds.push_back(alarmActionDds); } - alarmActionDds.vulnerabilityState(-1); + alarmActionDds.vulnerabilityState = -1; if (m_ui->cbxIndirectFire->isChecked()) { - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_HitEffectSimulation); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_HitEffectSimulation; alarmsDds.push_back(alarmActionDds); } if (m_ui->cbxAirSupport->isChecked()) { - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_AirSupport); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_AirSupport; alarmsDds.push_back(alarmActionDds); } if (m_ui->cbxMines->isChecked()) { - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_HitMine); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_HitMine; alarmsDds.push_back(alarmActionDds); } if (m_ui->cbxNbcAgent->isChecked()) { - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_HitN); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_HitN; alarmsDds.push_back(alarmActionDds); - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_HitB); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_HitB; alarmsDds.push_back(alarmActionDds); - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_HitC); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_HitC; alarmsDds.push_back(alarmActionDds); } if (m_ui->cbxManipulation->isChecked()) { - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_Manipulation); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_Manipulation; alarmsDds.push_back(alarmActionDds); } if (m_ui->cbxGlobalBorderLine->isChecked()) { - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_CrossGlobalBorderline); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_CrossGlobalBorderline; alarmsDds.push_back(alarmActionDds); } if (m_ui->cbxLocalBorderLine->isChecked()) { - alarmActionDds.eventTypeId(ProjectDataManagement::PdmEventType::EventType_CrossLocalBorderline); + alarmActionDds.eventTypeId = ProjectDataManagement::PdmEventType::EventType_CrossLocalBorderline; alarmsDds.push_back(alarmActionDds); } } @@ -279,11 +279,11 @@ bool ConfigParticipantsDialog::apply() { DEBUG_LOG(m_logger) << "apply"; AlarmManagement::ConfigureAlarmsRequest req; - req.participantIds(m_participantVector); - req.alarms(getCheckedValues()); - req.operatorId(m_operatorId); - req.global(false); - req.remove(false); + req.participantIds = m_participantVector; + req.alarms = getCheckedValues(); + req.operatorId = m_operatorId; + req.global = false; + req.remove = false; return m_requestHelper->startSingleRequest([req, this]() { return m_almFtc->configureAlarmsRequest(req, this); }); } @@ -298,9 +298,9 @@ void ConfigParticipantsDialog::fillCbx() ParticipantManagement::insertVulnerabilityStates(m_ui->cbStatusDirect, m_typeClass); ParticipantManagement::insertVulnerabilityStates(m_ui->cbStatusFriendly, m_typeClass); m_ui->cbStatusDirect->removeItem( - m_ui->cbStatusDirect->findData(ProjectDataManagement::VulnerabilityState::VulnerabilityState_TemporarySeverance)); + m_ui->cbStatusDirect->findData(static_cast(ProjectDataManagement::VulnerabilityState::VulnerabilityState_TemporarySeverance))); m_ui->cbStatusFriendly->removeItem( - m_ui->cbStatusDirect->findData(ProjectDataManagement::VulnerabilityState::VulnerabilityState_TemporarySeverance)); + m_ui->cbStatusDirect->findData(static_cast(ProjectDataManagement::VulnerabilityState::VulnerabilityState_TemporarySeverance))); } } // namespace ParticipantAlarms diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_dialog.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_dialog.cpp index 9f89efa1c..c6df740a9 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_dialog.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_dialog.cpp @@ -99,8 +99,8 @@ void ParticipantsDialog::onSelectionChanged() for (const QModelIndex& index : currentlySelectedParticipants) { const ParticipantManagement::ParticipantData data(m_participantModel->getParticipantData(index)); - if ((data.equipmentNumber().is_set() && data.equipmentNumber().get() > 0) || - m_ppmDtc->type(data.typeId()).typeClass() == ParticipantManagement::TypeClass::Unit) + if ((data.equipmentNumber.has_value() && data.equipmentNumber.get() > 0) || + m_ppmDtc->type(data.typeId).typeClass == ParticipantManagement::TypeClass::Unit) configureAlarms = true; DEBUG_LOG(m_logger) << "setChildrenSelected row =" << index.row() << " column=" << index.column(); } @@ -138,13 +138,13 @@ void ParticipantsDialog::onAddButtonClicked() QModelIndex participantIndex = m_ui->dvParticipants->currentIndex(); ParticipantManagement::ParticipantData data = m_participantModel->getParticipantData(participantIndex); - DEBUG_LOG(m_logger) << "current participantId = " << data.id(); - m_participantVector.push_back(data.id()); + DEBUG_LOG(m_logger) << "current participantId = " << data.id; + m_participantVector.push_back(data.id); const auto partData = m_participantModel->getParticipantData(participantIndex); addDialog(LtsWidgets::initDialog(new ConfigParticipantsDialog(this), m_ppmDtc, m_almDtc, m_almFtc, partData, m_participantVector, m_equipmentVector), - m_menuGroup, QStringLiteral("ConfigAlarms%1").arg(partData.id())); + m_menuGroup, QStringLiteral("ConfigAlarms%1").arg(partData.id)); } void ParticipantsDialog::onPrint() @@ -168,12 +168,12 @@ void ParticipantsDialog::setChildrenSelected(const QModelIndex& parent) DEBUG_LOG(m_logger) << "Setting row " << childIndex.row() << " selected"; ParticipantManagement::ParticipantData data = m_participantModel->getParticipantData(childIndex); - DEBUG_LOG(m_logger) << "append participantId = " << data.id(); - m_participantVector.push_back(data.id()); - if (data.equipmentNumber().is_set()) + DEBUG_LOG(m_logger) << "append participantId = " << data.id; + m_participantVector.push_back(data.id); + if (data.equipmentNumber.has_value()) { - DEBUG_LOG(m_logger) << "append equipmentNumber = " << data.equipmentNumber().get(); - m_equipmentVector.push_back(data.equipmentNumber().get()); + DEBUG_LOG(m_logger) << "append equipmentNumber = " << data.equipmentNumber.get(); + m_equipmentVector.push_back(data.equipmentNumber.get()); } m_ui->dvParticipants->selectionModel()->select(m_participantProxyModel->mapFromSource(childIndex), diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_gui_plugin.h index 428d6b4cd..bbe2d064b 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_gui_plugin.h @@ -8,6 +8,7 @@ #include #include +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_model.cpp index a3986188f..d49304806 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_model.cpp @@ -37,10 +37,10 @@ void ParticipantAlarmModel::onParticipantChanged(const ParticipantManagement::Pa DataModification modType) { Q_UNUSED(modType); - if (data.partyId() != partyId()) + if (data.partyId != partyId()) return; - INFO_LOG(m_logger) << "onParticipantChanged isSimulated=" << data.isSimulated(); + INFO_LOG(m_logger) << "onParticipantChanged isSimulated=" << data.isSimulated; onReinitModel(partyId()); emit newData(); } @@ -50,17 +50,17 @@ bool ParticipantAlarmModel::isSelectableByAlarm(const QModelIndex& index, bool* bool isSimulatable = false; const ParticipantManagement::ParticipantData data(getParticipantData(index)); - if ((data.equipmentNumber().is_set() && data.equipmentNumber().get() > 0) || - m_dtc->type(data.typeId()).typeClass() == ParticipantManagement::TypeClass::Unit) + if ((data.equipmentNumber.has_value() && data.equipmentNumber.get() > 0) || + m_dtc->type(data.typeId).typeClass == ParticipantManagement::TypeClass::Unit) isSimulatable = true; - DEBUG_LOG(m_logger) << "ParticipantId: " << data.id() << " isSimulated:" << data.isSimulated() - << " equipmentNo:" << data.equipmentNumber() << " typeId=" << data.typeId() - << " modId=" << data.modId() << " typeClass=" << m_dtc->type(data.typeId()).typeClass() + DEBUG_LOG(m_logger) << "ParticipantId: " << data.id << " isSimulated:" << data.isSimulated + << " equipmentNo:" << data.equipmentNumber << " typeId=" << data.typeId + << " modId=" << data.modId << " typeClass=" << m_dtc->type(data.typeId).typeClass << " isSimulatable=" << isSimulatable; if (bIsSimulated) - *bIsSimulated = data.isSimulated(); + *bIsSimulated = data.isSimulated; return isSimulatable; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_show_config.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_show_config.cpp index 46128d2cf..7299f3e37 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_show_config.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_show_config.cpp @@ -96,28 +96,28 @@ void ParticipantShowConfigView::onShowAlarm() void ParticipantShowConfigView::onRemoveAlarm() { DEBUG_LOG(m_logger) << "onRemoveAlarm" - << " id = " << m_configAlarmModel->getRowData(m_ui->widget->currentIndex().row()).id() + << " id = " << m_configAlarmModel->getRowData(m_ui->widget->currentIndex().row()).id << " eventTypeId = " - << m_configAlarmModel->getRowData(m_ui->widget->currentIndex().row()).eventTypeId() + << m_configAlarmModel->getRowData(m_ui->widget->currentIndex().row()).eventTypeId << " operatorId = " - << m_configAlarmModel->getRowData(m_ui->widget->currentIndex().row()).operatorId() + << m_configAlarmModel->getRowData(m_ui->widget->currentIndex().row()).operatorId << " participantId = " - << m_configAlarmModel->getRowData(m_ui->widget->currentIndex().row()).participantId(); + << m_configAlarmModel->getRowData(m_ui->widget->currentIndex().row()).participantId; const QModelIndex curIdx = m_ui->widget->currentIndex(); if (!curIdx.isValid()) return; const AlarmManagement::AlarmConfig& rowdata = m_configAlarmModel->getRowData(curIdx.row()); - int operatorId = rowdata.operatorId(); + int operatorId = rowdata.operatorId; std::vector ddsParticipantIds; - ddsParticipantIds.push_back(rowdata.participantId()); + ddsParticipantIds.push_back(rowdata.participantId); bool globalEvent = true; bool remove = true; std::vector alarmsDds; alarmsDds.resize(1); - alarmsDds[0].setMarker(false); - alarmsDds[0].messageWindow(false); - alarmsDds[0].eventTypeId(rowdata.eventTypeId()); + alarmsDds[0].setMarker = false; + alarmsDds[0].messageWindow = false; + alarmsDds[0].eventTypeId = rowdata.eventTypeId; AlarmManagement::ConfigureAlarmsRequest request(alarmsDds, operatorId, ddsParticipantIds, globalEvent, remove); m_requestHelper->startSingleRequest([request, this]() { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_show_config.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_show_config.h index ebd181123..a6982dc83 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_show_config.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/ConfigParticipantAlarm/alm_participant_show_config.h @@ -6,7 +6,7 @@ #include #include #include -#include +#include #include #include @@ -41,7 +41,6 @@ class ParticipantShowConfigView : public LtsWidgets::LtsDialog, void onPrint(); protected: - NGL::INGLLogger& m_logger; void onConfigureAlarmsReply(const Core::FunctionReplyObject& replyObject) override final; private: @@ -57,7 +56,8 @@ class ParticipantShowConfigView : public LtsWidgets::LtsDialog, Ui::ParticipantShowConfigView* m_ui; LtsUtils::RequestHelper* m_requestHelper; - AlarmManagement:: + AlarmManagement::LOGGER_T m_logger; + }; } // namespace ParticipantAlarms diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_dialog.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_dialog.cpp index 294446220..943a88083 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_dialog.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_dialog.cpp @@ -2,6 +2,7 @@ #include "alm_emergency_call_dialog.h" +#include #include "AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_model.h" #include "ui_alm_emergency_call_dialog.h" @@ -18,7 +19,8 @@ namespace AlarmManagement EmergencyCallDialog::EmergencyCallDialog(QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::CloseOnly), m_dtc(nullptr), m_ftc(nullptr), - m_session(nullptr), m_ui(new Ui::EmergencyCallDialog), m_requestHelper(new LtsUtils::RequestHelper(this)) + m_session(nullptr), m_ui(new Ui::EmergencyCallDialog), m_requestHelper(new LtsUtils::RequestHelper(this)), + m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { m_ui->setupUi(this); } @@ -104,10 +106,10 @@ void EmergencyCallDialog::enaDisa() m_buttonBox->setButtonEnabled(LtsWidgets::DialogButton::Show, false); const AlmEmergencyCall& sos = getSelectedSOS(); - if (sos.id() <= 0) + if (sos.id <= 0) return; - if (!sos.expired()) + if (!sos.expired) m_buttonBox->setButtonEnabled(LtsWidgets::DialogButton::Edit, true); m_buttonBox->setButtonEnabled(LtsWidgets::DialogButton::Show, true); @@ -158,7 +160,7 @@ void EmergencyCallDialog::onEditBtCliked() TRACE_LOG(m_logger) << Q_FUNC_INFO << " START"; const AlmEmergencyCall& sos = getSelectedSOS(); - if (sos.id() <= 0) + if (sos.id <= 0) return; setAcknowledgeUi(); @@ -181,16 +183,16 @@ void EmergencyCallDialog::onFindEmergencyOnMap() return; const AlmEmergencyCall& sos = getSelectedSOS(); - if (sos.id() <= 0) + if (sos.id <= 0) return; - m_sitMapGuiIfc->setCenterPoint(QPointF(sos.position().lon(), sos.position().lat())); + m_sitMapGuiIfc->setCenterPoint(QPointF(sos.position.lon, sos.position.lat)); } void EmergencyCallDialog::onEmergencyIndexDoubleClicked(const QModelIndex& index) { Q_UNUSED(index) - emit openInfoDlg(getSelectedSOS().id()); + emit openInfoDlg(getSelectedSOS().id); } void EmergencyCallDialog::sendAcknowledgeEmergency(const QString& comment) @@ -198,18 +200,18 @@ void EmergencyCallDialog::sendAcknowledgeEmergency(const QString& comment) TRACE_LOG(m_logger) << Q_FUNC_INFO << " START"; const AlmEmergencyCall& sos = getSelectedSOS(); - if (sos.id() <= 0 || sos.expired()) + if (sos.id <= 0 || sos.expired) return; EmergencyCallAcknowledgeRequest request; - request.id(sos.id()); - request.issi(sos.issi()); - request.name(sos.name()); - request.timestamp(QDateTime::currentMSecsSinceEpoch()); - request.incomingTime(sos.incomingTime()); - request.expired(true); - request.operatorId(LtsSessionData::LtsSessionData::getInstance()->getOperatorId()); - request.comment(comment.toStdString()); + request.id = sos.id; + request.issi = sos.issi; + request.name = sos.name; + request.timestamp = QDateTime::currentMSecsSinceEpoch(); + request.incomingTime = sos.incomingTime; + request.expired = true; + request.operatorId = LtsSessionData::LtsSessionData::getInstance()->getOperatorId(); + request.comment = comment.toStdString(); m_requestHelper->startSingleRequest( [this, request]() { return m_ftc->emergencyCallAcknowledgeRequest(request, this); }); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_gui_plugin.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_gui_plugin.cpp index 0ac366b90..1808bb324 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_gui_plugin.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_gui_plugin.cpp @@ -82,9 +82,9 @@ QVector InterfaceImpl::getActions() auto cb = [this](const AlmEmergencyCall &data) { - if (data.id() <= 0 || data.expired()) + if (data.id <= 0 || data.expired) return; - this->showEmergencyCallInfoWindow(data.id()); + this->showEmergencyCallInfoWindow(data.id); }; m_dtc->almEmergencyCalls(cb); @@ -111,10 +111,10 @@ void InterfaceImpl::onEmergencyCallChanged(const AlmEmergencyCall &data, DataMod { if (modType != DataModification::eAdded) return; - if (data.id() <= 0 || data.expired()) + if (data.id <= 0 || data.expired) return; - this->showEmergencyCallInfoWindow(data.id()); + this->showEmergencyCallInfoWindow(data.id); } void InterfaceImpl::onOpenInfoDlg(const int &id) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_info_dialog.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_info_dialog.cpp index 623fb1799..2cc456eef 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_info_dialog.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_info_dialog.cpp @@ -2,6 +2,7 @@ #include "alm_emergency_call_info_dialog.h" +#include #include "ui_alm_emergency_call_info_dialog.h" #include @@ -46,10 +47,11 @@ QImage renderEmergencySymbol(bool expired = false) EmergencyCallInfoDialog::EmergencyCallInfoDialog(int entryId, QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::CloseOnly), m_dtc(nullptr), m_ftc(nullptr), - m_requestHelper(new LtsUtils::RequestHelper(this)), m_ui(new Ui::EmergencyCallInfoDialog) + m_requestHelper(new LtsUtils::RequestHelper(this)), m_ui(new Ui::EmergencyCallInfoDialog), + m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { m_ui->setupUi(this); - m_emergency.id(entryId); + m_emergency.id = entryId; } EmergencyCallInfoDialog::~EmergencyCallInfoDialog() @@ -77,7 +79,7 @@ bool EmergencyCallInfoDialog::init(const std::shared_ptr& ftc, m_dtc->enableAlmEmergencyCall(); m_ftc->enableEmergencyCallAcknowledge(); - m_emergency = m_dtc->almEmergencyCall(m_emergency.id()); + m_emergency = m_dtc->almEmergencyCall(m_emergency.id); setUiValues(); connect(m_dtc.get(), &AlarmManagement::Interface::Dtc::almEmergencyCallChanged, this, @@ -92,34 +94,34 @@ bool EmergencyCallInfoDialog::init(const std::shared_ptr& ftc, QString EmergencyCallInfoDialog::emergencyIdentifier() const { - return QStringLiteral("emergency_") + QString::number(m_emergency.id()); + return QStringLiteral("emergency_") + QString::number(m_emergency.id); } bool EmergencyCallInfoDialog::setUiValues() { TRACE_LOG(m_logger) << Q_FUNC_INFO << " START"; - if (!m_dtc || !m_ftc || m_emergency.id() < 0) + if (!m_dtc || !m_ftc || m_emergency.id < 0) { ERROR_LOG(m_logger) << " >> unabled to init EmergencyCallInfoDialog"; return false; } - m_ui->lblEquipNr->setText(QString::number(m_emergency.issi())); - m_ui->lblIncomingTime->setText(DTG::toString(QDateTime::fromMSecsSinceEpoch(m_emergency.incomingTime()))); - m_ui->lblStatus->setText(m_emergency.expired() - ? DTG::toString(QDateTime::fromMSecsSinceEpoch(m_emergency.deleted())) + m_ui->lblEquipNr->setText(QString::number(m_emergency.issi)); + m_ui->lblIncomingTime->setText(DTG::toString(QDateTime::fromMSecsSinceEpoch(m_emergency.incomingTime))); + m_ui->lblStatus->setText(m_emergency.expired + ? DTG::toString(QDateTime::fromMSecsSinceEpoch(m_emergency.deleted)) : QStringLiteral("--")); - m_ui->lblComment->setText(QString::fromStdString(m_emergency.comment())); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(m_emergency.position().lon(), m_emergency.position().lat()); + m_ui->lblComment->setText(QString::fromStdString(m_emergency.comment)); + QString mgrs = LtsCoordTrans::mgrsFromGeographic(m_emergency.position.lon, m_emergency.position.lat); m_ui->lblPosition->setText(mgrs); const bool& hasOperatorRightEmergencyCall = LtsSessionData::LtsSessionData::getInstance()->hasOperatorRight(OperatorRights::EmergencyCall); m_ui->pbAckEmergency->setIcon(QIcon(QStringLiteral("icon:edit.svg"))); - m_ui->pbAckEmergency->setEnabled(m_emergency.expired() ? false : true); + m_ui->pbAckEmergency->setEnabled(m_emergency.expired ? false : true); m_ui->pbAckEmergency->setVisible(hasOperatorRightEmergencyCall); - QPixmap iconPixmap = QPixmap::fromImage(renderEmergencySymbol(m_emergency.expired())); + QPixmap iconPixmap = QPixmap::fromImage(renderEmergencySymbol(m_emergency.expired)); m_ui->lblIcon->setPixmap(iconPixmap); TRACE_LOG(m_logger) << Q_FUNC_INFO << " END"; @@ -129,7 +131,7 @@ bool EmergencyCallInfoDialog::setUiValues() void EmergencyCallInfoDialog::onEmergencyCallChanged(AlarmManagement::AlmEmergencyCall data, DataModification modType) { TRACE_LOG(m_logger) << Q_FUNC_INFO << " START"; - if (data.id() != m_emergency.id() || data.id() == 0) + if (data.id != m_emergency.id || data.id == 0) return; if (modType == DataModification::eRemoved) @@ -149,9 +151,9 @@ void EmergencyCallInfoDialog::onEmergencyCallChanged(AlarmManagement::AlmEmergen void EmergencyCallInfoDialog::onFindEmergencyOnMap() { - if (!m_sitMapGuiIfc || m_emergency.id() <= 0) + if (!m_sitMapGuiIfc || m_emergency.id <= 0) return; - m_sitMapGuiIfc->setCenterPoint(QPointF(m_emergency.position().lon(), m_emergency.position().lat())); + m_sitMapGuiIfc->setCenterPoint(QPointF(m_emergency.position.lon, m_emergency.position.lat)); } void EmergencyCallInfoDialog::onPbAckEmergencyClicked() @@ -191,18 +193,18 @@ void EmergencyCallInfoDialog::onPbAckEmergencyClicked() void EmergencyCallInfoDialog::sendAcknowledgeEmergencyCallRequest(const QString& comment) { - if (m_emergency.id() <= 0) + if (m_emergency.id <= 0) return; EmergencyCallAcknowledgeRequest request; - request.id(m_emergency.id()); - request.name(m_emergency.name()); - request.issi(m_emergency.issi()); - request.timestamp(QDateTime::currentMSecsSinceEpoch()); - request.incomingTime(m_emergency.incomingTime()); - request.expired(true); - request.operatorId(LtsSessionData::LtsSessionData::getInstance()->getOperatorId()); - request.comment(comment.toStdString()); + request.id = m_emergency.id; + request.name = m_emergency.name; + request.issi = m_emergency.issi; + request.timestamp = QDateTime::currentMSecsSinceEpoch(); + request.incomingTime = m_emergency.incomingTime; + request.expired = true; + request.operatorId = LtsSessionData::LtsSessionData::getInstance()->getOperatorId(); + request.comment = comment.toStdString(); bool ret = m_requestHelper->startSingleRequest( [this, request]() { return m_ftc->emergencyCallAcknowledgeRequest(request, this); }); @@ -212,8 +214,8 @@ void EmergencyCallInfoDialog::sendAcknowledgeEmergencyCallRequest(const QString& void EmergencyCallInfoDialog::retranslate() { - m_emergency = m_dtc->almEmergencyCall(m_emergency.id()); - const QString lbName = tr("SOS_%1").arg(m_emergency.issi()); + m_emergency = m_dtc->almEmergencyCall(m_emergency.id); + const QString lbName = tr("SOS_%1").arg(m_emergency.issi); translate(m_ui, lbName); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_model.cpp index 93148f0be..cd3e9f1b5 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AlarmManagement/Gui/EmergencyCalls/alm_emergency_call_model.cpp @@ -2,6 +2,7 @@ #include "alm_emergency_call_model.h" +#include #include #include @@ -24,6 +25,7 @@ EmergencyCallModel::EmergencyCallModel(QObject *parent) tr("Comment"), }, parent) , m_dtc(nullptr) + , m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) {} QVariant EmergencyCallModel::data(const QModelIndex &index, int role) const @@ -35,35 +37,35 @@ QVariant EmergencyCallModel::data(const QModelIndex &index, int role) const switch (index.column()) { case Columns::ID: - return almEmergency.id(); + return almEmergency.id; case SAMPLE_TIME: - return QDateTime::fromMSecsSinceEpoch(almEmergency.sampleTime()); + return QDateTime::fromMSecsSinceEpoch(almEmergency.sampleTime); case INCOMING_TIME: - return QDateTime::fromMSecsSinceEpoch(almEmergency.incomingTime()); + return QDateTime::fromMSecsSinceEpoch(almEmergency.incomingTime); case NAME: - return QString::fromStdString(almEmergency.name()); + return QString::fromStdString(almEmergency.name); case ISSI: - return almEmergency.issi(); + return almEmergency.issi; case POSITION: { - if (std::isnan(almEmergency.position().lat())) + if (std::isnan(almEmergency.position.lat)) return tr("---"); - const QString mgrs = LtsCoordTrans::mgrsFromGeographic(almEmergency.position().lon(), almEmergency.position().lat()); + const QString mgrs = LtsCoordTrans::mgrsFromGeographic(almEmergency.position.lon, almEmergency.position.lat); return mgrs; } case EXPIRED: - return almEmergency.expired(); + return almEmergency.expired; case OPERATION_ID: { - if (almEmergency.operatorId() == 0) + if (almEmergency.operatorId == 0) return QStringLiteral("-"); - return QString::fromStdString(m_opmDtc.get()->user(almEmergency.operatorId()).name()); + return QString::fromStdString(m_opmDtc.get()->user(almEmergency.operatorId).name); } case DELETED_TIMESTAMP: - return QDateTime::fromMSecsSinceEpoch(almEmergency.deleted()); + return QDateTime::fromMSecsSinceEpoch(almEmergency.deleted); case COMMENT: - return QString::fromStdString(almEmergency.comment()); + return QString::fromStdString(almEmergency.comment); default: break; } @@ -89,7 +91,7 @@ bool EmergencyCallModel::initModel(const std::shared_ptr &dtc, void EmergencyCallModel::onAlarmEmergencyCallChanged(const AlarmManagement::AlmEmergencyCall &data, const DataModification modType) { - const int id = data.id(); + const int id = data.id; int row = findRowForId(id); switch (modType) { @@ -148,7 +150,7 @@ bool EmergencyCallProxyModel::filterAcceptsRow(int source_row, const QModelIndex bool EmergencyCallProxyModel::checkFilter(int source_row) const { const auto sos = m_sourceModel->getRowData(source_row); - if ((sos.expired() && !showExpired()) || (exerciseStopped() && !sos.expired())) + if ((sos.expired && !showExpired()) || (exerciseStopped() && !sos.expired)) return false; return true; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_charge_effect_item_info.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_charge_effect_item_info.cpp index faa34a56d..924a92f06 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_charge_effect_item_info.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_charge_effect_item_info.cpp @@ -8,16 +8,16 @@ #include #include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include #include @@ -26,7 +26,7 @@ namespace AreaEffectSimulation AesChargeEffectItemInfo::AesChargeEffectItemInfo(int chargeEffectId, QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::CloseOnly), m_session(nullptr), - m_ChargeEffectId(chargeEffectId), m_ui(new Ui::AesChargeEffectItemInfo) + m_ChargeEffectId(chargeEffectId), m_ui(new Ui::AesChargeEffectItemInfo), m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { m_ui->setupUi(this); @@ -77,8 +77,8 @@ bool AesChargeEffectItemInfo::init(LtsSession::LtsSession* session) m_ui->lblOriginatorType->hide(); #endif - m_ui->lblOriginatorId->setText(QString::number(data.originatorId())); - m_ui->lblOriginatorType->setText(QString::number(data.originatorTypeId().underlying())); + m_ui->lblOriginatorId->setText(QString::number(data.originatorId)); + m_ui->lblOriginatorType->setText(QString::number(static_cast(data.originatorTypeId))); setOnlineHelpFilename(QStringLiteral("Info_Dialog-Charge_Effect")); @@ -93,7 +93,7 @@ bool AesChargeEffectItemInfo::init(LtsSession::LtsSession* session) void AesChargeEffectItemInfo::retranslate() { const ChargeEffect item = m_aesDtc->chargeEffect(m_ChargeEffectId); - translate(m_ui, tr("ChargeEffect: \"%1\"").arg(QString::fromStdString(item.name()), 1, QLatin1Char('?'))); + translate(m_ui, tr("ChargeEffect: \"%1\"").arg(QString::fromStdString(item.name), 1, QLatin1Char('?'))); } void AesChargeEffectItemInfo::onFindOnMap() const @@ -111,7 +111,7 @@ template bool AesChargeEffectItemInfo::tryShowStandardE std::shared_ptr ifc; if (m_session->getForeignGuiInterface(ifc)) { - AreaEffectSimulation::BaseEdit* dialog = ifc->showEditWindow(aiv.aesItemId(), this); + AreaEffectSimulation::BaseEdit* dialog = ifc->showEditWindow(aiv.aesItemId, this); if (dialog) { addDialog(dialog, dialog->menuGroup(), dialog->dialogIdentifier(), LtsWidgets::LayoutArea::eDialogTab); @@ -129,11 +129,11 @@ void AesChargeEffectItemInfo::onShowDetails() const ChargeEffect item = m_aesDtc->chargeEffect(m_ChargeEffectId); - if (item.originatorTypeId() == ProjectDataManagement::StateChangeOriginator::AreaEffectSimulation) + if (item.originatorTypeId == ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_AreaEffectSimulation) { AesItemView aiv; - m_aesDtc->aesItemViewFromEntityId(item.originatorId(), AreaEffectSimulation::AesType::AtUnknown, aiv); - DEBUG_LOG(m_logger) << "aiv.id():" << aiv.id() << ", aesType: " << aiv.aesTypeId(); + m_aesDtc->aesItemViewFromEntityId(item.originatorId, AreaEffectSimulation::AesType::AtUnknown, aiv); + DEBUG_LOG(m_logger) << "aiv.id():" << aiv.id << ", aesType: " << aiv.aesTypeId; auto registerDialog = [this](AreaEffectSimulation::BaseEdit* dialog) { if (dialog) @@ -142,7 +142,7 @@ void AesChargeEffectItemInfo::onShowDetails() } }; - switch (aiv.aesTypeId().underlying()) + switch (aiv.aesTypeId) { case AreaEffectSimulation::AesType::AtNContamination: { tryShowStandardEditDialog(aiv); @@ -179,11 +179,11 @@ void AesChargeEffectItemInfo::onShowDetails() std::shared_ptr ifc; if (m_session->getForeignGuiInterface(ifc)) { - const auto gearClass = m_pdmDtc->gearClassFromChargeTypeId(aiv.chargeStruct().chargeTypeId()); - if (gearClass == ProjectDataManagement::GearClass::Biological) - registerDialog(ifc->showEditWindow(aiv.aesItemId(), false, this)); - else if (gearClass == ProjectDataManagement::GearClass::Chemical) - registerDialog(ifc->showEditWindow(aiv.aesItemId(), true, this)); + const auto gearClass = m_pdmDtc->gearClassFromChargeTypeId(aiv.chargeStruct.chargeTypeId); + if (gearClass == ProjectDataManagement::GearClass::GearClass_Biological) + registerDialog(ifc->showEditWindow(aiv.aesItemId, false, this)); + else if (gearClass == ProjectDataManagement::GearClass::GearClass_Chemical) + registerDialog(ifc->showEditWindow(aiv.aesItemId, true, this)); } else WARNING_LOG(m_logger) @@ -194,7 +194,7 @@ void AesChargeEffectItemInfo::onShowDetails() case AreaEffectSimulation::AesType::AtBoobyTrapSecondary: { std::shared_ptr ifc; if (m_session->getForeignGuiInterface(ifc)) - registerDialog(ifc->showBoobyTrapEditWindow(aiv.aesItemId(), this)); + registerDialog(ifc->showBoobyTrapEditWindow(aiv.aesItemId, this)); else WARNING_LOG(m_logger) << Q_FUNC_INFO << " getForeignGuiInterface failed!"; @@ -204,7 +204,7 @@ void AesChargeEffectItemInfo::onShowDetails() case AreaEffectSimulation::AesType::AtOffRouteMineSecondary: { std::shared_ptr ifc; if (m_session->getForeignGuiInterface(ifc)) - registerDialog(ifc->showOffRouteMineEditWindow(aiv.aesItemId(), this)); + registerDialog(ifc->showOffRouteMineEditWindow(aiv.aesItemId, this)); else WARNING_LOG(m_logger) << Q_FUNC_INFO << " getForeignGuiInterface failed!"; @@ -216,8 +216,8 @@ void AesChargeEffectItemInfo::onShowDetails() if (m_session->getForeignGuiInterface(ifc)) { const bool isExplosionSingle = - (aiv.aesTypeId().underlying() == AreaEffectSimulation::AesType::AtExplosionSingle); - const auto gearClass = m_pdmDtc->gearClassFromChargeTypeId(aiv.chargeStruct().chargeTypeId()); + (aiv.aesTypeId == AreaEffectSimulation::AesType::AtExplosionSingle); + const auto gearClass = m_pdmDtc->gearClassFromChargeTypeId(aiv.chargeStruct.chargeTypeId); for (auto gc : {ProjectDataManagement::GearClass::GearClass_Artillery, ProjectDataManagement::GearClass::GearClass_Mortar, @@ -228,7 +228,7 @@ void AesChargeEffectItemInfo::onShowDetails() if (gearClass == gc) { - registerDialog(ifc->showEditWindow(aiv.aesItemId(), isExplosionSingle, false, gc, this)); + registerDialog(ifc->showEditWindow(aiv.aesItemId, isExplosionSingle, false, gc, this)); break; } } @@ -246,8 +246,8 @@ void AesChargeEffectItemInfo::onShowDetails() { AesItem ai; - m_aesDtc->aesItemFromId(aiv.aesItemId(), ai); - registerDialog(ifc->showEditWindow(aiv.aesItemId(), ai.effectSourceId(), this)); + m_aesDtc->aesItemFromId(aiv.aesItemId, ai); + registerDialog(ifc->showEditWindow(aiv.aesItemId, ai.effectSourceId, this)); } else WARNING_LOG(m_logger) @@ -274,7 +274,7 @@ void AesChargeEffectItemInfo::onShowDetails() break; case AreaEffectSimulation::AesType::AtUnknown: Q_ASSERT(false); - WARNING_LOG(m_logger) << "Unknown AesType found for aesEntityId: " << aiv.aesTypeId(); + WARNING_LOG(m_logger) << "Unknown AesType found for aesEntityId: " << aiv.aesTypeId; break; default: DEBUG_LOG(m_logger) << "Couldn't find AesItem to ChargeEffect (any more). Hiding the button"; @@ -298,33 +298,33 @@ void AesChargeEffectItemInfo::onShowDetails() void AesChargeEffectItemInfo::onChargeEffectChanged(const ChargeEffect& data, DataModification modType) { - DEBUG_LOG(m_logger) << " [onChargeEffectChanged] id: " << data.id(); - if (data.id() == m_ChargeEffectId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << " [onChargeEffectChanged] id: " << data.id; + if (data.id == m_ChargeEffectId && modType != DataModification::eRemoved) handleChargeEffect(data); } void AesChargeEffectItemInfo::handleChargeEffect(const ChargeEffect& data) { - m_ui->lblChargeEffectName->setText(QString::fromStdString(data.name())); + m_ui->lblChargeEffectName->setText(QString::fromStdString(data.name)); - m_ui->lblEffectStart->setText(DTG::toStringMSec(data.effectStart())); + m_ui->lblEffectStart->setText(DTG::toStringMSec(data.effectStart)); - m_ui->lblEffectDuration->setVisible(data.effectDuration() > 0); - m_ui->lbxEffectDuration->setVisible(data.effectDuration() > 0); + m_ui->lblEffectDuration->setVisible(data.effectDuration > 0); + m_ui->lbxEffectDuration->setVisible(data.effectDuration > 0); - m_ui->lblEffectDuration->setText(LtsWidgets::readableDuration(data.effectDuration())); + m_ui->lblEffectDuration->setText(LtsWidgets::readableDuration(data.effectDuration)); - AreaEffectSimulation::AesEffectState st = data.state(); + AreaEffectSimulation::AesEffectState st = data.state; m_ui->lblStatus->setText(AreaEffectSimulation::toString(st)); - m_ui->lblChargeTypeId->setText(QString::number(data.chargeTypeId())); + m_ui->lblChargeTypeId->setText(QString::number(data.chargeTypeId)); - m_ui->lblChargeType->setText(m_pdmDtc->trChargeTypeShortName(data.chargeTypeId())); - m_ui->lblChargeType->setToolTip(m_pdmDtc->trChargeTypeName(data.chargeTypeId())); + m_ui->lblChargeType->setText(m_pdmDtc->trChargeTypeShortName(data.chargeTypeId)); + m_ui->lblChargeType->setToolTip(m_pdmDtc->trChargeTypeName(data.chargeTypeId)); m_ui->lblPosition->show(); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.position().lon(), data.position().lat()); + QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.position.lon, data.position.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_danger_area_aes_item_info.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_danger_area_aes_item_info.cpp index 2e43716e4..eb71fcf2c 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_danger_area_aes_item_info.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_danger_area_aes_item_info.cpp @@ -18,7 +18,7 @@ namespace AreaEffectSimulation DangerAreaAesItemInfo::DangerAreaAesItemInfo(QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::CloseOnly), m_dtc(nullptr), m_session(nullptr), - m_ui(new Ui::DangerAreaAesItemInfo), m_aesItemId(-1) + m_ui(new Ui::DangerAreaAesItemInfo), m_aesItemId(-1), m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { m_ui->setupUi(this); } @@ -34,35 +34,35 @@ void DangerAreaAesItemInfo::retranslate() { std::unique_ptr item(new BCContamination(m_dtc->bCContamination(m_aesItemId))); - if (item->id() > 0) + if (item->id > 0) { translate(m_ui, m_dtc->bCContamination(m_aesItemId), tr("B/C-Contamination")); return; } item.reset(new NContamination(m_dtc->nContamination(m_aesItemId))); - if (item->id() > 0) + if (item->id > 0) { translate(m_ui, m_dtc->nContamination(m_aesItemId), tr("N-Contamination")); return; } item.reset(new ExplosionArea(m_dtc->explosionArea(m_aesItemId))); - if (item->id() > 0) + if (item->id > 0) { translate(m_ui, m_dtc->explosionArea(m_aesItemId), tr("Explosion Area")); return; } item.reset(new ExplosionSingle(m_dtc->explosionSingle(m_aesItemId))); - if (item->id() > 0) + if (item->id > 0) { translate(m_ui, m_dtc->explosionSingle(m_aesItemId), tr("Single Explosion")); return; } item.reset(new MineArea(m_dtc->mineArea(m_aesItemId))); - if (item->id() > 0) + if (item->id > 0) { translate(m_ui, m_dtc->mineArea(m_aesItemId), tr("Mine Area")); return; @@ -114,7 +114,7 @@ void DangerAreaAesItemInfo::insertAesItem(int aesItemId) { AesItem* item; item = new BCContamination(m_dtc->bCContamination(aesItemId)); - if (item->id() > 0) + if (item->id > 0) { m_aesItems.insert(aesItemId, AesStruct(AesType::AtBCContamination, item)); return; @@ -131,7 +131,7 @@ void DangerAreaAesItemInfo::setText() for (const AesStruct& aesStruct : std::as_const(m_aesItems)) { - if (aesStruct.item->effectStateId() == AreaEffectSimulation::AesEffectState::EsActivated) + if (aesStruct.item->effectStateId == AreaEffectSimulation::AesEffectState::EsActivated) aesItemInfo(aesStruct.item); } } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_info_dialog.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_info_dialog.cpp index 366704d44..8f2c0e06e 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_info_dialog.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AesInfo/aes_info_dialog.cpp @@ -11,18 +11,18 @@ #include #include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include #include #include @@ -34,7 +34,7 @@ AesInfoDialog::AesInfoDialog(int aesEntityId, AesType aesType, QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::CloseOnly), m_aesEntityId(aesEntityId), m_aesType(aesType), m_bcChargeTypeId(-1), m_singleExpChargeTypeId(-1), m_areaExpChargeTypeId(-1), m_session(nullptr), m_dtc(nullptr), m_ftc(nullptr), m_pdmDtc(nullptr), m_ui(new Ui::AesInfoDialog), - m_requestHelper(new LtsUtils::RequestHelper(this)) + m_requestHelper(new LtsUtils::RequestHelper(this)), m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { DEBUG_LOG(m_logger) << "ctor AesInfoDialog() "; m_ui->setupUi(this); @@ -64,18 +64,18 @@ void AesInfoDialog::retranslate() bool AesInfoDialog::cbFunc(const AreaEffectSimulation::AesItemView& aesItemView) { - if (aesItemView.aesItemId() != m_aesEntityId) + if (aesItemView.aesItemId != m_aesEntityId) return false; DEBUG_LOG(m_logger) << "AesItemView found for aesEntityId: " << m_aesEntityId - << " AesItemView.aesTypeId(): " << aesItemView.aesTypeId(); + << " AesItemView.aesTypeId(): " << aesItemView.aesTypeId; - if (aesItemView.aesTypeId() != m_aesType) + if (aesItemView.aesTypeId != m_aesType) { return false; } - switch (aesItemView.aesTypeId().underlying()) + switch (aesItemView.aesTypeId) { case AreaEffectSimulation::AesType::AtNContamination: { handleNContamination(aesItemView); @@ -245,7 +245,7 @@ bool AesInfoDialog::cbFunc(const AreaEffectSimulation::AesItemView& aesItemView) break; case AreaEffectSimulation::AesType::AtUnknown: WARNING_LOG(m_logger) << "Unknown AesType found for aesEntityId " << m_aesEntityId << ": " - << aesItemView.aesTypeId(); + << aesItemView.aesTypeId; Q_ASSERT(false); break; } @@ -311,7 +311,7 @@ bool AesInfoDialog::init(LtsSession::LtsSession* session, const std::shared_ptr< void AesInfoDialog::handleNContamination(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleNContamination(m_dtc->nContamination(m_aesEntityId)); } @@ -319,19 +319,19 @@ void AesInfoDialog::handleNContamination(const AesItemView& aesItemView) void AesInfoDialog::handleNContamination(const AreaEffectSimulation::NContamination& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::NContamination)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtNContamination); m_ui->lblPosition->show(); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.impactPosition().lon(), data.impactPosition().lat()); + QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.impactPosition.lon, data.impactPosition.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); } void AesInfoDialog::handleBCContamination(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleBCContamination(m_dtc->bCContamination(m_aesEntityId)); } @@ -339,21 +339,21 @@ void AesInfoDialog::handleBCContamination(const AesItemView& aesItemView) void AesInfoDialog::handleBCContamination(const AreaEffectSimulation::BCContamination& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::BCContamination)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtBCContamination); - m_bcChargeTypeId = data.chargeStruct().chargeTypeId(); + m_bcChargeTypeId = data.chargeStruct.chargeTypeId; m_ui->lblPosition->show(); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.impactPosition().lon(), data.impactPosition().lat()); + QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.impactPosition.lon, data.impactPosition.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); } void AesInfoDialog::handleBoobyTrap(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleBoobyTrap(m_dtc->boobyTrap(m_aesEntityId)); } @@ -361,11 +361,11 @@ void AesInfoDialog::handleBoobyTrap(const AesItemView& aesItemView) void AesInfoDialog::handleBoobyTrap(const AreaEffectSimulation::BoobyTrap& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::BoobyTrap)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtBoobyTrap); - m_bcChargeTypeId = data.chargeStruct().chargeTypeId(); + m_bcChargeTypeId = data.chargeStruct.chargeTypeId; m_ui->lblChargeType->setText(m_pdmDtc->trChargeTypeShortName(m_bcChargeTypeId, true)); m_ui->lblChargeType->setToolTip(m_pdmDtc->trChargeTypeName(m_bcChargeTypeId, true)); @@ -373,14 +373,14 @@ void AesInfoDialog::handleBoobyTrap(const AreaEffectSimulation::BoobyTrap& data) m_ui->lblChargeTypeId->setText(QString::number(m_bcChargeTypeId)); m_ui->lblPosition->show(); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.impactPosition().lon(), data.impactPosition().lat()); + QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.impactPosition.lon, data.impactPosition.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); } void AesInfoDialog::handleOffRouteMine(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleOffRouteMine(m_dtc->offRouteMine(m_aesEntityId)); } @@ -388,11 +388,11 @@ void AesInfoDialog::handleOffRouteMine(const AesItemView& aesItemView) void AesInfoDialog::handleOffRouteMine(const AreaEffectSimulation::OffRouteMine& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::OffRouteMine)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtOffRouteMine); - m_bcChargeTypeId = data.chargeStruct().chargeTypeId(); + m_bcChargeTypeId = data.chargeStruct.chargeTypeId; m_ui->lblChargeType->setText(m_pdmDtc->trChargeTypeShortName(m_bcChargeTypeId, true)); m_ui->lblChargeType->setToolTip(m_pdmDtc->trChargeTypeName(m_bcChargeTypeId, true)); @@ -401,14 +401,14 @@ void AesInfoDialog::handleOffRouteMine(const AreaEffectSimulation::OffRouteMine& m_ui->lblPosition->show(); QString mgrs = - LtsCoordTrans::mgrsFromGeographic(data.area().cornerBottomLeft().lon(), data.area().cornerBottomLeft().lat()); + LtsCoordTrans::mgrsFromGeographic(data.area.cornerBottomLeft.lon, data.area.cornerBottomLeft.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); } void AesInfoDialog::handleExplosionArea(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleExplosionArea(m_dtc->explosionArea(m_aesEntityId)); } @@ -416,19 +416,19 @@ void AesInfoDialog::handleExplosionArea(const AesItemView& aesItemView) void AesInfoDialog::handleExplosionArea(const AreaEffectSimulation::ExplosionArea& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::ExplosionArea)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtExplosionArea); - m_areaExpChargeTypeId = data.chargeStruct().chargeTypeId(); + m_areaExpChargeTypeId = data.chargeStruct.chargeTypeId; - const Area& area = data.area(); - if (!qFuzzyCompare(area.cornerBottomLeft().lon(), 0) || !qFuzzyCompare(area.cornerBottomLeft().lat(), 0)) + const Area& area = data.area; + if (!qFuzzyCompare(area.cornerBottomLeft.lon, 0) || !qFuzzyCompare(area.cornerBottomLeft.lat, 0)) { m_ui->lblPosition->show(); - QPointF bottomLeft(area.cornerBottomLeft().lon(), area.cornerBottomLeft().lat()); + QPointF bottomLeft(area.cornerBottomLeft.lon, area.cornerBottomLeft.lat); const QPointF& center = - Polygons::bottomLeft2CenterPoint(bottomLeft, area.width(), area.height(), area.rotation()); + Polygons::bottomLeft2CenterPoint(bottomLeft, area.width, area.height, area.rotation); QString mgrs = LtsCoordTrans::mgrsFromGeographic(center.x(), center.y()); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); } @@ -437,66 +437,66 @@ void AesInfoDialog::handleExplosionArea(const AreaEffectSimulation::ExplosionAre void AesInfoDialog::handleExplosionSingle(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleExplosionSingle(m_dtc->explosionSingle(m_aesEntityId)); } void AesInfoDialog::handleExplosionSingle(const AreaEffectSimulation::ExplosionSingle& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::ExplosionSingle)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtExplosionSingle); - m_singleExpChargeTypeId = data.chargeStruct().chargeTypeId(); + m_singleExpChargeTypeId = data.chargeStruct.chargeTypeId; m_ui->lblPosition->show(); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.impactPosition().lon(), data.impactPosition().lat()); + QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.impactPosition.lon, data.impactPosition.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); } void AesInfoDialog::handleMineArea(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleMineArea(m_dtc->mineArea(m_aesEntityId)); } void AesInfoDialog::handleMineArea(const AreaEffectSimulation::MineArea& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::MineArea)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtMineArea); m_ui->lblPosition->show(); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.boundingRectCorner().lon(), data.boundingRectCorner().lat()); + QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.boundingRectCorner.lon, data.boundingRectCorner.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); bool bResetVisbile = - (data.isDus() || data.isConcrete()) && + (data.isDus || data.isConcrete) && LtsSessionData::LtsSessionData::getInstance()->hasOperatorRight(OperatorRights::MineAreasResetDusMines) && ((m_session->app() == LtsAppDescriptor::App::Situation || m_session->app() == LtsAppDescriptor::App::SituationTablet) && (!m_session->isReplayPartition())); m_ui->pbResetDusMines->setVisible(bResetVisbile); - m_mineIsReactivatable = data.isReactivatable(); - m_ui->pbResetDusMines->setToolTip(data.isDus() ? tr("Reset DUS Mines matched to this Minearea") + m_mineIsReactivatable = data.isReactivatable; + m_ui->pbResetDusMines->setToolTip(data.isDus ? tr("Reset DUS Mines matched to this Minearea") : tr("Reset Concrete Mines matched to this Minearea")); } void AesInfoDialog::handleMineCorridor(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleMineCorridor(m_dtc->mineCorridor(m_aesEntityId)); } void AesInfoDialog::handleMineCorridor(const AreaEffectSimulation::MineCorridor& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::MineArea)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtMineCorridor); @@ -510,14 +510,14 @@ void AesInfoDialog::handleMineCorridor(const AreaEffectSimulation::MineCorridor& void AesInfoDialog::handleGasPipe(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " handleGasPipe: aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " handleGasPipe: aesItemView.aesItemId(): " << aesItemView.aesItemId; handleGasPipe(m_dtc->gasPipe(m_aesEntityId)); } void AesInfoDialog::handleGasPipe(const AreaEffectSimulation::GasPipe& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::GasPipe)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtGasPipe); @@ -531,23 +531,23 @@ void AesInfoDialog::handleGasPipe(const AreaEffectSimulation::GasPipe& data) void AesInfoDialog::handleDangerArea(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleDangerArea(m_dtc->dangerArea(m_aesEntityId)); } void AesInfoDialog::handleDangerArea(const AreaEffectSimulation::DangerArea& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::DangerArea)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtDangerArea); - const auto& qv = data.segments(); + const auto& qv = data.segments; if (qv.size() > 0) { m_ui->lblPosition->show(); const Core::GeoPosition2D& pos = qv.at(0); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(pos.lon(), pos.lat()); + QString mgrs = LtsCoordTrans::mgrsFromGeographic(pos.lon, pos.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); } @@ -558,23 +558,23 @@ void AesInfoDialog::handleDangerArea(const AreaEffectSimulation::DangerArea& dat void AesInfoDialog::handleBorderline(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleBorderline(m_dtc->borderline(m_aesEntityId)); } void AesInfoDialog::handleBorderline(const AreaEffectSimulation::Borderline& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::Borderline)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtBorderline); - const auto& qv = data.segments(); + const auto& qv = data.segments; if (qv.size() > 0) { m_ui->lblPosition->show(); const Core::GeoPosition2D& pos = qv.at(0); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(pos.lon(), pos.lat()); + QString mgrs = LtsCoordTrans::mgrsFromGeographic(pos.lon, pos.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); } } @@ -582,30 +582,30 @@ void AesInfoDialog::handleBorderline(const AreaEffectSimulation::Borderline& dat void AesInfoDialog::handleFunctionalArea(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleFunctionalArea(m_dtc->functionalArea(m_aesEntityId)); } void AesInfoDialog::handleFunctionalArea(const FunctionalArea& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::FunctionalArea)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtFunctionalArea); QStringList chargeTypesNames; QStringList chargeTypesShortNames; - if (data.medicMode() != AesOperatingMode::OmNotUsed) + if (data.medicMode != AesOperatingMode::OmNotUsed) { chargeTypesNames << m_pdmDtc->trChargeTypeName(411, true); chargeTypesShortNames << m_pdmDtc->trChargeTypeShortName(411, true); } - if (data.maintMode() != AesOperatingMode::OmNotUsed) + if (data.maintMode != AesOperatingMode::OmNotUsed) { chargeTypesNames << m_pdmDtc->trChargeTypeName(412, true); chargeTypesShortNames << m_pdmDtc->trChargeTypeShortName(412, true); } - if (data.deconMode() != AesOperatingMode::OmNotUsed) + if (data.deconMode != AesOperatingMode::OmNotUsed) { chargeTypesNames << m_pdmDtc->trChargeTypeName(413, true); chargeTypesShortNames << m_pdmDtc->trChargeTypeShortName(413, true); @@ -614,9 +614,9 @@ void AesInfoDialog::handleFunctionalArea(const FunctionalArea& data) m_ui->lblChargeType->setToolTip(chargeTypesShortNames.join(QLatin1String(", "))); m_ui->lblPosition->show(); - const QPointF bottomLeft(data.area().cornerBottomLeft().lon(), data.area().cornerBottomLeft().lat()); + const QPointF bottomLeft(data.area.cornerBottomLeft.lon, data.area.cornerBottomLeft.lat); const QPointF centerpoint = - Polygons::bottomLeft2CenterPoint(bottomLeft, data.area().width(), data.area().height(), 0.0); + Polygons::bottomLeft2CenterPoint(bottomLeft, data.area.width, data.area.height, 0.0); const QString mgrs = LtsCoordTrans::mgrsFromGeographic(centerpoint.x(), centerpoint.y()); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); } @@ -624,25 +624,25 @@ void AesInfoDialog::handleFunctionalArea(const FunctionalArea& data) void AesInfoDialog::handleAirSupportImpact(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleAirSupportImpact(m_dtc->airSupportImpact(m_aesEntityId)); } void AesInfoDialog::handleAirSupportImpact(const AirSupportImpact& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::FunctionalArea)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtAirSupportImpact); m_ui->lblPosition->show(); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.impactPosition().lon(), data.impactPosition().lat()); + QString mgrs = LtsCoordTrans::mgrsFromGeographic(data.impactPosition.lon, data.impactPosition.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); m_ui->lbFlightTime->show(); m_ui->lblFlightTime->show(); - m_ui->lblFlightTime->setText(LtsWidgets::readableDuration(data.flightTime())); + m_ui->lblFlightTime->setText(LtsWidgets::readableDuration(data.flightTime)); } void AesInfoDialog::handleMineAraeSingleMine() @@ -651,14 +651,14 @@ void AesInfoDialog::handleMineAraeSingleMine() if (!m_dtc->aesItemViewFromEntityId(0, m_aesType, itemView)) return; const DusMineState dms = m_dtc->dusMineState(0); - for (size_t i = 0; i < dms.mines().size(); ++i) + for (size_t i = 0; i < dms.mines.size(); ++i) { - const DusMine& mine = dms.mines().at(i); - if (mine.eqId() == m_aesEntityId) + const DusMine& mine = dms.mines.at(i); + if (mine.eqId == m_aesEntityId) { - if (itemView.form().size() <= i) + if (itemView.form.size() <= i) return; - handleMineAraeSingleMine(itemView.form().at(i), mine); + handleMineAraeSingleMine(itemView.form.at(i), mine); return; } } @@ -679,12 +679,12 @@ void AesInfoDialog::handleMineAraeSingleMine(const Core::GeoPosition2D& position m_ui->lblAesDuration->hide(); m_ui->pbDetails->hide(); - m_aesEntityName = QString::number(mine.eqId()); + m_aesEntityName = QString::number(mine.eqId); - m_ui->lblAesTypeId->setText(QString::number(m_aesType.underlying())); + m_ui->lblAesTypeId->setText(QString::number(static_cast(m_aesType))); m_ui->lblAesType->setText(toString(m_aesType)); - const int ctId = mine.chargeTypeId(); + const int ctId = mine.chargeTypeId; if (ctId != 0) { m_ui->lblChargeType->setText(m_pdmDtc->trChargeTypeShortName(ctId, true)); @@ -699,11 +699,11 @@ void AesInfoDialog::handleMineAraeSingleMine(const Core::GeoPosition2D& position else m_ui->lbAesId->setText(tr("Mine Id:")); - m_ui->lblAesId->setText(QString::number(mine.eqId())); + m_ui->lblAesId->setText(QString::number(mine.eqId)); bool bResetVisible = false; - if (mine.triggered() && isDus) + if (mine.triggered && isDus) { m_ui->lblStatus->setText(tr("Inactive")); if (LtsSessionData::LtsSessionData::getInstance()->hasOperatorRight(OperatorRights::MineAreasResetDusMines) @@ -723,7 +723,7 @@ void AesInfoDialog::handleMineAraeSingleMine(const Core::GeoPosition2D& position m_ui->pbResetDusMines->setToolTip(isDus ? tr("Reset DUS Mines matched to this Minearea") : tr("Reset Concrete Mines matched to this Minearea")); - const QString mgrs = LtsCoordTrans::mgrsFromGeographic(position.lon(), position.lat()); + const QString mgrs = LtsCoordTrans::mgrsFromGeographic(position.lon, position.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); m_ui->lblPosition->show(); @@ -747,21 +747,21 @@ void AesInfoDialog::handleSingleDusMine() m_ui->lblAesDuration->hide(); m_ui->pbDetails->hide(); - m_aesEntityName = QString::number(dsm.id()); + m_aesEntityName = QString::number(dsm.id); - m_ui->lblAesTypeId->setText(QString::number(m_aesType.underlying())); + m_ui->lblAesTypeId->setText(QString::number(static_cast(m_aesType))); m_ui->lblAesType->setText(toString(m_aesType)); - const int ctId = dsm.chargeStruct().chargeTypeId(); + const int ctId = dsm.chargeStruct.chargeTypeId; m_ui->lblChargeType->setText(m_pdmDtc->trChargeTypeShortName(ctId)); m_ui->lblChargeType->setToolTip(m_pdmDtc->trChargeTypeName(ctId)); m_ui->lblChargeType->show(); m_ui->lblChargeTypeId->setText(QString::number(ctId)); m_ui->lbAesId->setText(tr("DUS Mine Id:")); - m_ui->lblAesId->setText(QString::number(dsm.id())); + m_ui->lblAesId->setText(QString::number(dsm.id)); - switch (dsm.effectStateId().underlying()) + switch (dsm.effectStateId) { case AesEffectState::EsExpired: m_ui->lblStatus->setText(tr("Inactive")); @@ -792,7 +792,7 @@ void AesInfoDialog::handleSingleDusMine() break; } - const QString mgrs = LtsCoordTrans::mgrsFromGeographic(dsm.position().lon(), dsm.position().lat()); + const QString mgrs = LtsCoordTrans::mgrsFromGeographic(dsm.position.lon, dsm.position.lat); m_ui->lblPosition->setText(tr("Position: %1").arg(mgrs)); m_ui->lblPosition->show(); @@ -802,18 +802,18 @@ void AesInfoDialog::handleSingleDusMine() void AesInfoDialog::handleExplosionCluster(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleExplosionCluster(m_dtc->explosionCluster(m_aesEntityId)); } void AesInfoDialog::handleExplosionCluster(const ExplosionCluster& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::ExplosionCluster)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtExplosionCluster); - const int m_explosionClusterChargeTypeId = data.chargeStruct().chargeTypeId(); + const int m_explosionClusterChargeTypeId = data.chargeStruct.chargeTypeId; m_ui->lblChargeType->setText(m_pdmDtc->trChargeTypeShortName(m_explosionClusterChargeTypeId, true)); m_ui->lblChargeType->setToolTip(m_pdmDtc->trChargeTypeName(m_explosionClusterChargeTypeId, true)); m_ui->lblChargeType->show(); @@ -823,32 +823,32 @@ void AesInfoDialog::handleExplosionCluster(const ExplosionCluster& data) void AesInfoDialog::handleEffectCluster(const AesItemView& aesItemView) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AesItemView)" - << " aesItemView.aesItemId(): " << aesItemView.aesItemId(); + << " aesItemView.aesItemId(): " << aesItemView.aesItemId; handleEffectCluster(m_dtc->effectCluster(m_aesEntityId)); } void AesInfoDialog::handleEffectCluster(const EffectCluster& data) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << "(AreaEffectSimulation::EffectCluster)" - << " data.id(): " << data.id(); + << " data.id(): " << data.id; handleAesItem(data, AesType::AtEffectCluster); } void AesInfoDialog::handleAesItem(const AesItem& aesData, AesType aesTypeId) { - m_aesEntityName = QString::fromStdString(aesData.name()); - m_aesEffectSource = aesData.effectSourceId(); + m_aesEntityName = QString::fromStdString(aesData.name); + m_aesEffectSource = aesData.effectSourceId; - m_ui->lblAesItemId->setText(QString::number(aesData.id())); + m_ui->lblAesItemId->setText(QString::number(aesData.id)); - m_ui->lblAesTypeId->setText(QString::number(aesTypeId.underlying())); + m_ui->lblAesTypeId->setText(QString::number(static_cast(aesTypeId))); const ProjectDataManagement::GearClass gearClass = - m_pdmDtc->gearClassFromChargeTypeId(aesData.chargeStruct().chargeTypeId()); - switch (gearClass.underlying()) + m_pdmDtc->gearClassFromChargeTypeId(aesData.chargeStruct.chargeTypeId); + switch (gearClass) { - case ProjectDataManagement::GearClass::Biological: - case ProjectDataManagement::GearClass::Chemical: + case ProjectDataManagement::GearClass::GearClass_Biological: + case ProjectDataManagement::GearClass::GearClass_Chemical: m_ui->lblAesType->setText(ProjectDataManagement::toString(gearClass)); break; default: @@ -857,28 +857,28 @@ void AesInfoDialog::handleAesItem(const AesItem& aesData, AesType aesTypeId) m_ui->lblAesName->setText(m_aesEntityName); - if (aesData.effectStart().is_set()) - m_ui->lblAesStart->setText(DTG::toStringMSec(aesData.effectStart().get())); + if (aesData.effectStart.has_value()) + m_ui->lblAesStart->setText(DTG::toStringMSec(aesData.effectStart.get())); else m_ui->lblAesStart->setText(tr("None")); - if (aesData.effectDuration() == 0) + if (aesData.effectDuration == 0) { m_ui->lbAesDuration->hide(); m_ui->lblAesDuration->hide(); } - if (aesTypeId == AesType::AtEffectCluster && aesData.effectDuration() == DEFAULT_EFFECT_DURATION) + if (aesTypeId == AesType::AtEffectCluster && aesData.effectDuration == DEFAULT_EFFECT_DURATION) m_ui->lblAesDuration->setText(QStringLiteral("---")); else - m_ui->lblAesDuration->setText(LtsWidgets::readableDuration(aesData.effectDuration())); + m_ui->lblAesDuration->setText(LtsWidgets::readableDuration(aesData.effectDuration)); - AreaEffectSimulation::AesEffectState st = aesData.effectStateId(); + AreaEffectSimulation::AesEffectState st = aesData.effectStateId; m_ui->lblStatus->setText(toString(st)); - m_ui->lblChargeTypeId->setText(QString::number(aesData.chargeStruct().chargeTypeId())); + m_ui->lblChargeTypeId->setText(QString::number(aesData.chargeStruct.chargeTypeId)); - m_ui->lblChargeType->setText(m_pdmDtc->trChargeTypeShortName(aesData.chargeStruct().chargeTypeId())); - m_ui->lblChargeType->setToolTip(m_pdmDtc->trChargeTypeName(aesData.chargeStruct().chargeTypeId())); + m_ui->lblChargeType->setText(m_pdmDtc->trChargeTypeShortName(aesData.chargeStruct.chargeTypeId)); + m_ui->lblChargeType->setToolTip(m_pdmDtc->trChargeTypeName(aesData.chargeStruct.chargeTypeId)); } void AesInfoDialog::onFindOnMap() @@ -895,7 +895,7 @@ void AesInfoDialog::onShowDetails() { DEBUG_LOG(m_logger) << Q_FUNC_INFO; - switch (m_aesType.underlying()) + switch (m_aesType) { case AreaEffectSimulation::AesType::AtNContamination: { std::shared_ptr ifc; @@ -916,7 +916,7 @@ void AesInfoDialog::onShowDetails() if (m_session->getForeignGuiInterface(ifc)) { const auto gearClass = m_pdmDtc->gearClassFromChargeTypeId(m_bcChargeTypeId); - if (gearClass == ProjectDataManagement::GearClass::Biological) + if (gearClass == ProjectDataManagement::GearClass::GearClass_Biological) { AreaEffectSimulation::BaseEdit* dialog = ifc->showEditWindow(m_aesEntityId, false, this); if (dialog) @@ -925,7 +925,7 @@ void AesInfoDialog::onShowDetails() break; } - if (gearClass == ProjectDataManagement::GearClass::Chemical) + if (gearClass == ProjectDataManagement::GearClass::GearClass_Chemical) { AreaEffectSimulation::BaseEdit* dialog = ifc->showEditWindow(m_aesEntityId, true, this); if (dialog) @@ -1162,118 +1162,118 @@ bool AesInfoDialog::onResetDusMines() void AesInfoDialog::onNContaminationChanged(const AreaEffectSimulation::NContamination& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleNContamination(data); } void AesInfoDialog::onBCContaminationChanged(const AreaEffectSimulation::BCContamination& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleBCContamination(data); } void AesInfoDialog::onBoobyTrapChanged(const AreaEffectSimulation::BoobyTrap& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleBoobyTrap(data); } void AesInfoDialog::onOffRouteMineChanged(const AreaEffectSimulation::OffRouteMine& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleOffRouteMine(data); } void AesInfoDialog::onExplosionAreaChanged(const AreaEffectSimulation::ExplosionArea& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleExplosionArea(data); } void AesInfoDialog::onExplosionSingleChanged(const AreaEffectSimulation::ExplosionSingle& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleExplosionSingle(data); } void AesInfoDialog::onMineAreaChanged(const AreaEffectSimulation::MineArea& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleMineArea(data); } void AesInfoDialog::onMineCorridorChanged(const MineCorridor& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleMineCorridor(data); } void AesInfoDialog::onGasPipeChanged(const GasPipe& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleGasPipe(data); } void AesInfoDialog::onDangerAreaChanged(const AreaEffectSimulation::DangerArea& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleDangerArea(data); } void AesInfoDialog::onBorderlineChanged(const AreaEffectSimulation::Borderline& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleBorderline(data); } void AesInfoDialog::onFunctionalAreaChanged(const FunctionalArea& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleFunctionalArea(data); } void AesInfoDialog::onAirSupportImpactChanged(const AirSupportImpact& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleAirSupportImpact(data); } void AesInfoDialog::onDusMineStateChanged(const DusMineState& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; if (modType == DataModification::eRemoved) return; - if (data.id() != 0) + if (data.id != 0) return; AesItemView itemView; if (!m_dtc->aesItemViewFromEntityId(0, m_aesType, itemView)) return; - for (size_t i = 0; i < data.mines().size(); ++i) + for (size_t i = 0; i < data.mines.size(); ++i) { - const DusMine& mine = data.mines().at(i); - if (mine.eqId() == m_aesEntityId) + const DusMine& mine = data.mines.at(i); + if (mine.eqId == m_aesEntityId) { - if (itemView.form().size() <= i) + if (itemView.form.size() <= i) return; - handleMineAraeSingleMine(itemView.form().at(i), mine); + handleMineAraeSingleMine(itemView.form.at(i), mine); return; } } @@ -1281,22 +1281,22 @@ void AesInfoDialog::onDusMineStateChanged(const DusMineState& data, DataModifica void AesInfoDialog::onDusSingleMineChanged(const DusSingleMine& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleSingleDusMine(); } void AesInfoDialog::onExplosionClusterChanged(const ExplosionCluster& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleExplosionCluster(data); } void AesInfoDialog::onEffectClusterChanged(const EffectCluster& data, DataModification modType) { - DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id(); - if (data.id() == m_aesEntityId && modType != DataModification::eRemoved) + DEBUG_LOG(m_logger) << Q_FUNC_INFO << " id: " << data.id; + if (data.id == m_aesEntityId && modType != DataModification::eRemoved) handleEffectCluster(data); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/CustomView/aes_air_support_impact.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/CustomView/aes_air_support_impact.cpp index 87f560091..d830a0b73 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/CustomView/aes_air_support_impact.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/CustomView/aes_air_support_impact.cpp @@ -61,17 +61,17 @@ bool CustomViewAirSupportImpact::init(const QModelIndex &idx) bool CustomViewAirSupportImpact::calculateIcon(const AirSupportImpact &asi, const QColor &color) { Database::AesAirSupportImpact dbAsi; - dbAsi.impactPosition = QPointF(asi.impactPosition().lon(), asi.impactPosition().lat()); + dbAsi.impactPosition = QPointF(asi.impactPosition.lon, asi.impactPosition.lat); std::shared_ptr pdmDtc; if (!m_session->getDtc(pdmDtc)) return false; - double radius = pdmDtc->impactRadius(asi.chargeStruct().chargeTypeId(), - asi.chargeStruct().igniterTypeId(), - asi.chargeStruct().igniterFunctionId()); + double radius = pdmDtc->impactRadius(asi.chargeStruct.chargeTypeId, + asi.chargeStruct.igniterTypeId, + asi.chargeStruct.igniterFunctionId); QPolygonF poly = AreaEffectSimulation::Polygons::airSupportImpact(dbAsi, radius); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(asi.effectStateId()); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(asi.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_list.h index 1ef93df63..1193807c1 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include #include "aes_air_support_9liner_model.h" namespace Ui diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_model.cpp index 6a1e8760c..97e953f89 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_model.cpp @@ -48,36 +48,36 @@ QVariant AirSupport9LinerModel::data(const QModelIndex &index, int role) const switch (index.column()) { case ParticipantId: - return item.participantId(); + return item.participantId; case Participant: { if (!m_ppmDtc) return QString(); - return m_ppmDtc->hierarchyFromParticipant(item.participantId()); + return m_ppmDtc->hierarchyFromParticipant(item.participantId); } case Timestamp: - return QDateTime::fromMSecsSinceEpoch(item.sampleTime()); + return QDateTime::fromMSecsSinceEpoch(item.sampleTime); case AttackHeading: { - if (item.finalAttackHeading() < 0) + if (item.finalAttackHeading < 0) return QVariant(); - if (item.finalAttackHeadingHigh() < 0) + if (item.finalAttackHeadingHigh < 0) return tr("%1 degree") - .arg(item.finalAttackHeading()); + .arg(item.finalAttackHeading); return tr("%1 degree (low: %2 degree, high: %3 degreee)", "degree as symbol!") - .arg(item.finalAttackHeading()) - .arg(item.finalAttackHeadingLow()) - .arg(item.finalAttackHeadingHigh()); + .arg(item.finalAttackHeading) + .arg(item.finalAttackHeadingLow) + .arg(item.finalAttackHeadingHigh); } case TargetPosition: { - if (std::isnan(item.targetPosition().lat())) + if (std::isnan(item.targetPosition.lat)) return tr("---"); - LtsCoordTrans::UtmCoordinate coord(LtsCoordTrans::UtmCoordinate::fromGeographic(item.targetPosition().lon(), - item.targetPosition().lat())); + LtsCoordTrans::UtmCoordinate coord(LtsCoordTrans::UtmCoordinate::fromGeographic(item.targetPosition.lon, + item.targetPosition.lat)); QString ret = coord.mgrs(); - if (item.targetPosition().z() > 0) - ret += QLatin1Char(' ') + QString::number(qRound(item.targetPosition().z())); + if (item.targetPosition.z > 0) + ret += QLatin1Char(' ') + QString::number(qRound(item.targetPosition.z)); return ret; } } @@ -131,7 +131,7 @@ bool AirSupport9LinerProxyModel::filterAcceptsRow(int source_row, const QModelIn return true; const qint64 m_offset = 5 * 60 * 1000; - if ((data.sampleTime() + m_offset) > m_session->partitionTime()) + if ((data.sampleTime + m_offset) > m_session->partitionTime()) return true; return false; } @@ -150,27 +150,27 @@ bool AirSupport9LinerProxyModel::lessThan(const QModelIndex &source_left, const switch (source_left.column()) { case AirSupport9LinerModel::ParticipantId: - if (left.participantId() != right.participantId()) - return left.participantId() < right.participantId(); - return left.sampleTime() < right.sampleTime(); + if (left.participantId != right.participantId) + return left.participantId < right.participantId; + return left.sampleTime < right.sampleTime; case AirSupport9LinerModel::Participant: { const auto l = source_left.data(); const auto r = source_right.data(); if (l != r) return LtsUtils::lessThan(l, r); - return left.sampleTime() < right.sampleTime(); + return left.sampleTime < right.sampleTime; } case AirSupport9LinerModel::Timestamp: - return left.sampleTime() < right.sampleTime(); + return left.sampleTime < right.sampleTime; case AirSupport9LinerModel::AttackHeading: - if (left.finalAttackHeading() != right.finalAttackHeading()) - return left.finalAttackHeading() < right.finalAttackHeading(); - if (left.finalAttackHeadingLow() != right.finalAttackHeadingLow()) - return left.finalAttackHeadingLow() < right.finalAttackHeadingLow(); - if (left.finalAttackHeadingHigh() != right.finalAttackHeadingHigh()) - return left.finalAttackHeadingHigh() < right.finalAttackHeadingHigh(); - return left.sampleTime() < right.sampleTime(); + if (left.finalAttackHeading != right.finalAttackHeading) + return left.finalAttackHeading < right.finalAttackHeading; + if (left.finalAttackHeadingLow != right.finalAttackHeadingLow) + return left.finalAttackHeadingLow < right.finalAttackHeadingLow; + if (left.finalAttackHeadingHigh != right.finalAttackHeadingHigh) + return left.finalAttackHeadingHigh < right.finalAttackHeadingHigh; + return left.sampleTime < right.sampleTime; } return LtsWidgets::LtsColumnFilterProxyModel::lessThan(source_left, source_right); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_model.h index d149abd6f..3f44ee21e 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_9liner_model.h @@ -7,6 +7,7 @@ #include #include #include +#include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_gui_plugin.h index 6b07e94ec..82e30b50d 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include #include "aes_air_support_gui_plugin_interface.h" diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_list.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_list.cpp index 25622d131..2920058eb 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_list.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_list.cpp @@ -107,7 +107,7 @@ void AirSupportExplosionClusterImpactList::createModel() { m_model = new AesItemSortFilterProxyModelTmpl(m_session, this); - m_effectClusterModel = new EffectClusterModel({ProjectDataManagement::GearClass::AirSupport}, this); + m_effectClusterModel = new EffectClusterModel({ProjectDataManagement::GearClass::GearClass_AirSupport}, this); m_effectClusterModel->initModel(m_session); m_model->setSourceModel(m_effectClusterModel); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_list.h index 16b64f375..6358a3079 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_list.h @@ -3,9 +3,9 @@ #pragma once -#include -#include -#include +#include +#include +#include #include "aes_air_support_impact_model.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_model.h index c7ea43149..7d2c254e9 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/AirSupport/aes_air_support_impact_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/CustomView/aes_bccontamination.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/CustomView/aes_bccontamination.cpp index 75eb0f8d0..09d428611 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/CustomView/aes_bccontamination.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/CustomView/aes_bccontamination.cpp @@ -66,19 +66,19 @@ bool CustomViewBCContamination::init(const QModelIndex &idx) bool CustomViewBCContamination::calculateIcon(const BCContamination &bcContamination, const QColor &color) { Database::AesBCContamination bcContaOut; - bcContaOut.id = bcContamination.id(); - bcContaOut.chargeTypeId = bcContamination.chargeStruct().chargeTypeId(); - bcContaOut.effectStart = QDateTime::fromMSecsSinceEpoch(bcContamination.effectStart().is_set() ? bcContamination.effectStart().get() : 0); - bcContaOut.impactPosition = QPointF(bcContamination.impactPosition().lon(), bcContamination.impactPosition().lat()); - bcContaOut.impactRadius = bcContamination.impactRadius(); - bcContaOut.propagationDirection = bcContamination.propagationDirection(); + bcContaOut.id = bcContamination.id; + bcContaOut.chargeTypeId = bcContamination.chargeStruct.chargeTypeId; + bcContaOut.effectStart = QDateTime::fromMSecsSinceEpoch(bcContamination.effectStart.has_value() ? bcContamination.effectStart.get() : 0); + bcContaOut.impactPosition = QPointF(bcContamination.impactPosition.lon, bcContamination.impactPosition.lat); + bcContaOut.impactRadius = bcContamination.impactRadius; + bcContaOut.propagationDirection = bcContamination.propagationDirection; const QPolygonF poly = AreaEffectSimulation::Polygons::bcContamination(bcContaOut, - ProjectDataManagement::VolatilityType::get_default(), - bcContamination.impactRadius(), + ProjectDataManagement::VolatilityType::Unknown, + bcContamination.impactRadius, QDateTime::currentDateTime()); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(bcContamination.effectStateId()); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(bcContamination.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/InfoView/aes_bccontamination_info.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/InfoView/aes_bccontamination_info.cpp index 27e876514..9bfbb4002 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/InfoView/aes_bccontamination_info.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/InfoView/aes_bccontamination_info.cpp @@ -4,7 +4,7 @@ #include "aes_bccontamination_info.h" #include "ui_aes_bccontamination_info.h" -#include +#include #include #include #include @@ -33,13 +33,13 @@ bool BCContaminationInfo::setData(const BCContamination *item) { m_ui->wBaseData->setData(item); - m_ui->lblImpactRadius->setText(QString::number(item->impactRadius())); - m_ui->lblImpactPosition->setText(LtsCoordTrans::mgrsFromGeographic(item->impactPosition().lon(), item->impactPosition().lat())); - m_ui->lblPropagationDirection->setText(tr("%1° = %2 mil").arg(item->propagationDirection(), 0, 'f', 2) - .arg(item->propagationDirection() * 6400 / 360.0, 0, 'f', 0)); - m_ui->lblWindSpeed->setText(QString::number(item->windSpeed(), 'f', 2)); - m_ui->lblWeatherTimestamp->setText(QDateTime::fromMSecsSinceEpoch(item->weatherTimestamp()).toString()); - m_ui->lblWeatherPosition->setText(LtsCoordTrans::mgrsFromGeographic(item->weatherPosition().lon(), item->weatherPosition().lat())); + m_ui->lblImpactRadius->setText(QString::number(item->impactRadius)); + m_ui->lblImpactPosition->setText(LtsCoordTrans::mgrsFromGeographic(item->impactPosition.lon, item->impactPosition.lat)); + m_ui->lblPropagationDirection->setText(tr("%1° = %2 mil").arg(item->propagationDirection, 0, 'f', 2) + .arg(item->propagationDirection * 6400 / 360.0, 0, 'f', 0)); + m_ui->lblWindSpeed->setText(QString::number(item->windSpeed, 'f', 2)); + m_ui->lblWeatherTimestamp->setText(QDateTime::fromMSecsSinceEpoch(item->weatherTimestamp).toString()); + m_ui->lblWeatherPosition->setText(LtsCoordTrans::mgrsFromGeographic(item->weatherPosition.lon, item->weatherPosition.lat)); return true; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_edit.cpp index ec0a25f2d..93aae29b6 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_edit.cpp @@ -69,8 +69,8 @@ BCContaminationEdit::BCContaminationEdit(const QString &menuGroup, bool isChemic - m_ui->cbWeather->addItem(toString(AesWeatherSource::AwsDynamic), AesWeatherSource::AwsDynamic); - m_ui->cbWeather->addItem(toString(AesWeatherSource::AwsStatic), AesWeatherSource::AwsStatic); + m_ui->cbWeather->addItem(toString(AesWeatherSource::AwsDynamic), static_cast(AesWeatherSource::AwsDynamic)); + m_ui->cbWeather->addItem(toString(AesWeatherSource::AwsStatic), static_cast(AesWeatherSource::AwsStatic)); LtsUtils::ProjectSettings *ps = LtsUtils::ProjectSettings::getInstance(); const bool enableShowMeteoDataStations = ps->value(QStringLiteral("mdm"), @@ -132,15 +132,15 @@ void BCContaminationEdit::enableUiElements(bool enable) m_ui->cbWeather->setEnabled(enable); m_ui->pbClear->setEnabled(enable); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->bCContamination(m_aesItem.id()); + auto baseData = m_dtc->bCContamination(m_aesItem.id); setData(baseData, false); __unchange__(); if (name != m_ui->leIdentifier->text()) @@ -193,8 +193,8 @@ bool BCContaminationEdit::init(int aesItemId, bool copy, auto cb = [this](const DangerAreaCorrelatedAesItem &item) { - if (item.aesItemId() == m_aesItem.id()) - m_dangerAreaIds << item.dangerAreaId(); + if (item.aesItemId == m_aesItem.id) + m_dangerAreaIds << item.dangerAreaId; }; m_dtc->dangerAreaCorrelatedAesItems(cb); setPbDangerAreaText(); @@ -211,8 +211,8 @@ bool BCContaminationEdit::init(int aesItemId, bool copy, auto cbDangerArea = [this](const DangerArea &data) { - if (data.effectStateId() != AesEffectState::EsRemoved && data.associatedAesId() == m_aesItem.id()) - m_associatedDangerId = data.id(); + if (data.effectStateId != AesEffectState::EsRemoved && data.associatedAesId == m_aesItem.id) + m_associatedDangerId = data.id; }; m_dtc->dangerAreas(cbDangerArea); if (m_associatedDangerId) @@ -229,7 +229,7 @@ void BCContaminationEdit::setPbDangerAreaText() sl.reserve(m_dangerAreaIds.size()); for (int idx : std::as_const(m_dangerAreaIds)) { - sl << QString::fromStdString(m_dtc->dangerArea(idx).name()); + sl << QString::fromStdString(m_dtc->dangerArea(idx).name); } m_ui->pbDangerArea->setEnabled(sl.size()); m_ui->pbDangerArea->setText(sl.join(QStringLiteral(", "))); @@ -237,14 +237,14 @@ void BCContaminationEdit::setPbDangerAreaText() void BCContaminationEdit::onDangerAreaChanged(const DangerAreaCorrelatedAesItem &data, DataModification modType) { - if (data.aesItemId() != m_aesItem.id()) + if (data.aesItemId != m_aesItem.id) return; if (modType == DataModification::eAdded) - m_dangerAreaIds += data.dangerAreaId(); + m_dangerAreaIds += data.dangerAreaId; if (modType == DataModification::eRemoved) - m_dangerAreaIds -= data.dangerAreaId(); + m_dangerAreaIds -= data.dangerAreaId; setPbDangerAreaText(); @@ -259,7 +259,7 @@ void BCContaminationEdit::onPbDangerAreaClicked() if (!m_session->getForeignGuiInterface(infoGuiInterface)) return; - LtsWidgets::LtsDialog *dialog = infoGuiInterface->showDangerAreaAesItemInfo(m_dangerAreaIds, {m_aesItem.id()}); + LtsWidgets::LtsDialog *dialog = infoGuiInterface->showDangerAreaAesItemInfo(m_dangerAreaIds, {m_aesItem.id}); addDialog(dialog, m_menuGroup, tr("Danger Areas for %1 %2").arg(m_isChemical ? tr("C-Contamination") : tr("B-Contamination"), m_ui->leIdentifier->text()), LtsWidgets::LayoutArea::eInfoTab); } @@ -269,23 +269,23 @@ void BCContaminationEdit::setData(const BCContamination &contamination, bool cop m_aesItem = contamination; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromStdString(contamination.name())); - m_ui->dteEffectStart->setMsecsSinceEpoch(contamination.effectStart().is_set() ? contamination.effectStart().get() : 0); - m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(contamination.chargeStruct().chargeTypeId())); - m_ui->sbDurationHours->setValue(contamination.effectDuration() / 1000 / 60/ 60); - m_ui->sbRadius->setValue(contamination.impactRadius()); - m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(contamination.partyId().is_set() ? contamination.partyId().get() : 0)); - m_ui->cbWeather->setCurrentIndex(contamination.weatherSource().underlying()); + m_ui->leIdentifier->setText(QString::fromStdString(contamination.name)); + m_ui->dteEffectStart->setMsecsSinceEpoch(contamination.effectStart.has_value() ? contamination.effectStart.get() : 0); + m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(contamination.chargeStruct.chargeTypeId)); + m_ui->sbDurationHours->setValue(contamination.effectDuration / 1000 / 60/ 60); + m_ui->sbRadius->setValue(contamination.impactRadius); + m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(contamination.partyId.has_value() ? contamination.partyId.get() : 0)); + m_ui->cbWeather->setCurrentIndex(static_cast(contamination.weatherSource)); - QPointF impactPosition(contamination.impactPosition().lon(), contamination.impactPosition().lat()); + QPointF impactPosition(contamination.impactPosition.lon, contamination.impactPosition.lat); if (!impactPosition.isNull()) m_ui->positionEdit->setCoordinate(impactPosition); - m_ui->sbAltitude->setValue(contamination.upperOffset()); - m_ui->cbLowerLimit->setChecked(qFuzzyIsNull(contamination.lowerOffset())); + m_ui->sbAltitude->setValue(contamination.upperOffset); + m_ui->cbLowerLimit->setChecked(qFuzzyIsNull(contamination.lowerOffset)); } @@ -341,9 +341,9 @@ bool BCContaminationEdit::apply() const Core::GeoPosition2D pos(p.x(), p.y()); - const BCContaminationModifyRequest req(m_aesItem.id(), + const BCContaminationModifyRequest req(m_aesItem.id, name, - LtsUtils::toOptional(effectStart), + LtsUtils::toOptional(static_cast(effectStart)), duration, chargeType, pos, @@ -354,18 +354,18 @@ bool BCContaminationEdit::apply() dds::core::optional(), dds::core::optional(), dds::core::optional(), - dds::core::optional(), - dds::core::optional(), + dds::core::optional(), + dds::core::optional(), extrusionHeight, lowerOffset, m_ui->chbDangerArea->isChecked()); INFO_LOG(m_logger) << "apply " << " extrusionHeight=" << extrusionHeight - << " req.upperOffset=" << req.upperOffset() + << " req.upperOffset=" << req.upperOffset << " lowerOf" "fset=" << lowerOffset - << " req.lowerOffset=" << req.lowerOffset(); + << " req.lowerOffset=" << req.lowerOffset; m_requestHelper->addRequest([this,req]() { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_edit.h index 8e463fa60..ba9dfea87 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include @@ -29,8 +29,8 @@ public: QString dialogIdentifier() const override { if (m_isChemical) - return m_aesItem.id() <= 0 ? QStringLiteral("AddCContamination") : QStringLiteral("EditCContamination%1").arg(m_aesItem.id()); - return m_aesItem.id() <= 0 ? QStringLiteral("AddBContamination") : QStringLiteral("EditBContamination%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddCContamination") : QStringLiteral("EditCContamination%1").arg(m_aesItem.id); + return m_aesItem.id <= 0 ? QStringLiteral("AddBContamination") : QStringLiteral("EditBContamination%1").arg(m_aesItem.id); } bool init(int aesItemId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_gui_plugin.h index 008bf6b8a..224dfaac2 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_bccontamination_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_list.h index c43eea3db..0a578ccb1 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontamination_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontaminations_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontaminations_model.h index 7b2161960..fd74e8495 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontaminations_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/BCContamination/aes_bccontaminations_model.h @@ -4,7 +4,7 @@ #pragma once #include -#include +#include #include namespace LtsSession diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/CMakeLists.txt b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/CMakeLists.txt index 615c2e8b2..a51102cd3 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/CMakeLists.txt +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/CMakeLists.txt @@ -36,6 +36,11 @@ NGL_WRAP_UI(aes_base_gui_SRCS ) NGL_ADD_LIBRARY2(WS AesBaseGui SHARED ${aes_base_gui_SRCS}) +# aes_base_edit.h includes LtsWidgets/ui_requirement.h (a handwritten header, not a +# UI file). Qt6's strict AUTOUIC auto-scan then demands a requirement.ui that does not +# exist and fails the autogen step. The real .ui files are wrapped explicitly above via +# NGL_WRAP_UI (qt6_wrap_ui), so disable the auto-scan (same approach as LtsWidgets). +set_target_properties(AesBaseGui PROPERTIES AUTOUIC OFF) NGL_TARGET_INCLUDE_DIRECTORIES(AesBaseGui PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/../../../Services/ diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/InfoView/aes_base_info.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/InfoView/aes_base_info.cpp index d4ca2c006..0994fa7e4 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/InfoView/aes_base_info.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/InfoView/aes_base_info.cpp @@ -71,23 +71,23 @@ bool BaseInfo::setData(const AesItem *item) if (!m_session->getDtc(pdmDtc) || !pdmDtc ) return false; - setEffectDuration(item->effectDuration()); - m_ui->lblIdentifier->setText(QString::fromStdString(item->name().c_str())); - m_ui->lblChargeType->setText(pdmDtc->trChargeTypeShortName(item->chargeStruct().chargeTypeId(), true)); - m_ui->lblChargeType->setToolTip(pdmDtc->trChargeTypeName(item->chargeStruct().chargeTypeId(), true)); - m_ui->lblEffectState->setText(AreaEffectSimulation::toString(item->effectStateId())); + setEffectDuration(item->effectDuration); + m_ui->lblIdentifier->setText(QString::fromStdString(item->name.c_str())); + m_ui->lblChargeType->setText(pdmDtc->trChargeTypeShortName(item->chargeStruct.chargeTypeId, true)); + m_ui->lblChargeType->setToolTip(pdmDtc->trChargeTypeName(item->chargeStruct.chargeTypeId, true)); + m_ui->lblEffectState->setText(AreaEffectSimulation::toString(item->effectStateId)); - setEffectStart(item->effectStart().is_set() ? item->effectStart().get() : 0); + setEffectStart(item->effectStart.has_value() ? item->effectStart.get() : 0); - if (item->participantId().is_set()) + if (item->participantId.has_value()) { if (!ppmDtc) - m_ui->lblParticipant->setText(tr("ID: %1").arg(item->participantId().get())); + m_ui->lblParticipant->setText(tr("ID: %1").arg(item->participantId.get())); else { - ParticipantManagement::Participant participant = ppmDtc->participant(item->partyId().get()); - m_ui->lblParticipant->setText(QString::fromStdString(participant.name())); + ParticipantManagement::Participant participant = ppmDtc->participant(item->partyId.get()); + m_ui->lblParticipant->setText(QString::fromStdString(participant.name)); } } else @@ -96,14 +96,14 @@ bool BaseInfo::setData(const AesItem *item) m_ui->lbxParticipant->hide(); } - if (item->partyId().is_set()) + if (item->partyId.has_value()) { if (!ppmDtc) - m_ui->lblParty->setText(tr("ID: %1").arg(item->partyId().get())); + m_ui->lblParty->setText(tr("ID: %1").arg(item->partyId.get())); else { - ParticipantManagement::Party party = ppmDtc->party(item->partyId().get()); - m_ui->lblParty->setText(ParticipantManagement::trPartyName(party.name())); + ParticipantManagement::Party party = ppmDtc->party(item->partyId.get()); + m_ui->lblParty->setText(ParticipantManagement::trPartyName(party.name)); } } else diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_edit.cpp index c8f900a83..0e4b813c7 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_edit.cpp @@ -22,7 +22,7 @@ BaseEdit::BaseEdit(const QString& menuGroup, const QString& loggerName, QWidget* m_sitMapGuiIfc(nullptr), m_ppmGuiCbxIfc(nullptr), m_session(nullptr), m_menuGroup(menuGroup), m_requestHelper(new LtsUtils::RequestHelper(this)), m_logger(getLogger(loggerName)) { - m_aesItem.id(0); + m_aesItem.id = 0; connect(this, &BaseEdit::visibilityChanged, this, &BaseEdit::onVisibilityChanged); } @@ -50,7 +50,7 @@ void BaseEdit::onAesItemModifyReply(const Core::FunctionReplyObject& replyObject bool BaseEdit::isModifiable() const { - AesEffectState effectState = m_aesItem.effectStateId(); + AesEffectState effectState = m_aesItem.effectStateId; return (effectState == AreaEffectSimulation::AesEffectState::EsPaused || effectState == AreaEffectSimulation::AesEffectState::EsActivated || effectState == AreaEffectSimulation::AesEffectState::EsPrepared || @@ -62,7 +62,7 @@ bool BaseEdit::isModifiable() const bool BaseEdit::isOnlyNameModifiable() const { - AesEffectState effectState = m_aesItem.effectStateId(); + AesEffectState effectState = m_aesItem.effectStateId; return (effectState == AreaEffectSimulation::AesEffectState::EsPaused || effectState == AreaEffectSimulation::AesEffectState::EsActivated) && (!m_session->isReplayPartition()) && (m_session->app() != LtsAppDescriptor::App::OC); @@ -166,10 +166,10 @@ void BaseEdit::setEffectStartEnabled(LtsWidgets::LtsDateTimeEdit* dte, bool enab m_session->getDtc(exmDtc); ExerciseManagement::Exercise exercise = exmDtc->exercise(exerciseId); - enable = (exercise.state() == ExerciseManagement::ExerciseState::Started || - exercise.state() == ExerciseManagement::ExerciseState::Paused); + enable = (exercise.state == ExerciseManagement::ExerciseState::Started || + exercise.state == ExerciseManagement::ExerciseState::Paused); - if (exercise.state() == ExerciseManagement::ExerciseState::Created) + if (exercise.state == ExerciseManagement::ExerciseState::Created) dte->setChecked(false); else dte->setChecked(dte->msecsSinceEpoch() > 0); @@ -217,7 +217,7 @@ void BaseEdit::setCoordinates(const std::vector& coords) clearCoordinates(); const auto cWidgets(coordWidgets()); for (size_t i = 0; i < cWidgets.size() && i < static_cast(coords.size()); ++i) - cWidgets.at(i)->setCoordinate(coords.at(i).lon(), coords.at(i).lat()); + cWidgets.at(i)->setCoordinate(coords.at(i).lon, coords.at(i).lat); } std::vector BaseEdit::getCoordinates() const @@ -265,10 +265,10 @@ void BaseEdit::enabledCoordinates(bool enable) void BaseEdit::onAreaChanged(const AesItem& data, DataModification modType) { - if (data.id() != m_aesItem.id()) + if (data.id != m_aesItem.id) return; - if (modType == DataModification::eRemoved || data.effectStateId() == AesEffectState::EsRemoved) + if (modType == DataModification::eRemoved || data.effectStateId == AesEffectState::EsRemoved) { __unchange__(); @@ -287,7 +287,7 @@ bool BaseEdit::init(int aesItemId, LtsSession::LtsSession* session) return false; } m_session = session; - m_aesItem.id(aesItemId); + m_aesItem.id = aesItemId; if (!m_session->getDtc(m_dtc)) return false; @@ -302,7 +302,7 @@ bool BaseEdit::init(int aesItemId, LtsSession::LtsSession* session) if (aesItemId == 0) { - m_aesItem.effectSourceId(ProjectDataManagement::EffectSource::ES_Internal); + m_aesItem.effectSourceId = ProjectDataManagement::EffectSource::ES_Internal; m_buttonBox->setText(LtsWidgets::DialogButton::Ok, tr("Add")); } @@ -311,8 +311,8 @@ bool BaseEdit::init(int aesItemId, LtsSession::LtsSession* session) double BaseEdit::distance(const Core::GeoPosition2D& p1, const Core::GeoPosition2D& p2) { - LtsCoordTrans::UtmCoordinate start = LtsCoordTrans::UtmCoordinate::fromGeographic(p1.lon(), p1.lat()); - LtsCoordTrans::UtmCoordinate end = LtsCoordTrans::UtmCoordinate::fromGeographic(p2.lon(), p2.lat(), start.zone); + LtsCoordTrans::UtmCoordinate start = LtsCoordTrans::UtmCoordinate::fromGeographic(p1.lon, p1.lat); + LtsCoordTrans::UtmCoordinate end = LtsCoordTrans::UtmCoordinate::fromGeographic(p2.lon, p2.lat, start.zone); double dx = start.x - end.x; double dy = start.y - end.y; return std::sqrt(dx * dx + dy * dy); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_edit.h index ecc3b91e2..2a91a5b2f 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_edit.h @@ -7,7 +7,7 @@ #include #include #include -#include +#include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_model.cpp index aaea755b4..d02f3c5bd 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_model.cpp @@ -1,6 +1,7 @@ #include "aes_base_model.h" +#include #include #include @@ -15,7 +16,8 @@ namespace AreaEffectSimulation { -AesGuiBasHelpers::AesGuiBasHelpers() : m_aesDtc(nullptr), m_pdmDtc(nullptr), m_ppmDtc(nullptr) {} +AesGuiBasHelpers::AesGuiBasHelpers() : m_aesDtc(nullptr), m_pdmDtc(nullptr), m_ppmDtc(nullptr) , m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) +{} bool AesGuiBasHelpers::initModel(LtsSession::LtsSession* session) { @@ -38,24 +40,24 @@ bool AesGuiBasHelpers::initModel(LtsSession::LtsSession* session) QVariant AesGuiBasHelpers::stringFromPartyId(const dds::core::optional& id) const { - if (!id.is_set()) + if (!id.has_value()) return QObject::tr("---"); auto it = m_partyNames.find(id.get()); if (it != m_partyNames.end()) return it.value(); - const QString name = ParticipantManagement::trPartyName(m_ppmDtc->party(id.get()).name()); + const QString name = ParticipantManagement::trPartyName(m_ppmDtc->party(id.get()).name); m_partyNames.insert(id.get(), name); return name; } QIcon AesGuiBasHelpers::iconFromPartyId(const dds::core::optional& id) const { - if (!id.is_set() || !m_ppmGuiCbxIfc) + if (!id.has_value() || !m_ppmGuiCbxIfc) return QIcon(); auto it = m_partyIcons.find(id.get()); if (it != m_partyIcons.end()) return it.value(); - const QRgb col = QRgb(m_ppmDtc->party(id.get()).color()); + const QRgb col = QRgb(m_ppmDtc->party(id.get()).color); const QIcon icon = m_ppmGuiCbxIfc->pixmapFromParty(col); m_partyIcons.insert(id.get(), icon); return icon; @@ -63,7 +65,7 @@ QIcon AesGuiBasHelpers::iconFromPartyId(const dds::core::optional& id) cons QVariant AesGuiBasHelpers::hierarchyFromParticipantId(const dds::core::optional& id) const { - if (!id.is_set()) + if (!id.has_value()) return QObject::tr("---"); auto it = m_participantHierarchy.find(id.get()); if (it != m_participantHierarchy.end()) @@ -109,7 +111,9 @@ void AesGuiBasHelpers::updateEffectStateComboboxFilterData(bool bWithPause) { if (!bWithPause && es == AesEffectState::EsPaused) continue; - cfd.data = es; + // Qt6 removed Qt5's QVariant template operator=, so store the enum via setValue + // (requires the Q_DECLARE_METATYPE added to aes_base_model.h). + cfd.data.setValue(es); cfd.text = AreaEffectSimulation::toString(es); cfc.data.push_back(cfd); } @@ -134,7 +138,7 @@ void AesGuiBasHelpers::updateComboboxFilterData(const QSet& availablePartyI for (const int i : std::as_const(availablePartyIds)) { cfd.data = i; - cfd.text = ParticipantManagement::trPartyName(m_ppmDtc->party(i).name()); + cfd.text = ParticipantManagement::trPartyName(m_ppmDtc->party(i).name); cfd.icon = iconFromPartyId(i); cfc.data.push_back(cfd); } @@ -164,7 +168,7 @@ void AesGuiBasHelpers::fillAvailableChargeIds(ProjectDataManagement::GearClass g m_availableChargeIds.clear(); const QVector availableCharges = m_pdmDtc->chargesForGearClass(gc); for (const auto& charge : availableCharges) - m_availableChargeIds += charge.id(); + m_availableChargeIds += charge.id; if (m_availableChargeIds.isEmpty()) m_availableChargeIds += 0; @@ -178,7 +182,7 @@ void AesGuiBasHelpers::fillAvailableChargeIds(const QVector& availableCharges = m_pdmDtc->chargesForGearClass(gc); for (const auto& charge : std::as_const(availableCharges)) - m_availableChargeIds += charge.id(); + m_availableChargeIds += charge.id; } if (m_availableChargeIds.isEmpty()) @@ -192,7 +196,7 @@ AesItemSortFilterProxyModel::AesItemSortFilterProxyModel(LtsSession::LtsSession* if (m_session->getDtc(ppmDtc)) { auto cb = [this](const ParticipantManagement::Party& party) { - m_partyColors[party.id()] = QColor::fromRgb(QRgb(party.color())); + m_partyColors[party.id] = QColor::fromRgb(QRgb(party.color)); }; ppmDtc->partys(cb); } @@ -236,11 +240,11 @@ bool AesItemSortFilterProxyModel::lessThan(const QModelIndex& source_left, const case AesGuiBasHelpers::BcEffectStart: { const auto effectStartLeft = aesEffectStart(source_left.row()); const auto effectStartRight = aesEffectStart(source_right.row()); - if (effectStartLeft.is_set() && effectStartRight.is_set()) + if (effectStartLeft.has_value() && effectStartRight.has_value()) return effectStartLeft.get() < effectStartRight.get(); - if (effectStartRight.is_set()) + if (effectStartRight.has_value()) return true; - if (effectStartLeft.is_set()) + if (effectStartLeft.has_value()) return false; return aesId(source_left.row()) < aesId(source_right.row()); } @@ -307,10 +311,10 @@ bool AesItemSortFilterProxyModel::checkFilter(int source_row) const const auto effectStart = aesEffectStart(source_row); qint64 effectEnd = 0; - if (effectStart.is_set()) + if (effectStart.has_value()) effectEnd = effectStart.get() + aesEffectDuration(source_row); - if (effectStart.is_set() && effectEnd + m_offset > m_session->partitionTime()) + if (effectStart.has_value() && effectEnd + m_offset > m_session->partitionTime()) return true; return false; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_model.h index 17b99a755..40a3ca732 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_base_model.h @@ -22,6 +22,12 @@ #include #include +// Qt6's QVariant no longer has Qt5's permissive template operator, so a scoped +// enum must be registered to be stored in / retrieved from a QVariant. The effect-state +// combobox filter (ComboboxFilterData::data) and the model's ComboboxFilterRole both +// hold AesEffectState in a QVariant for filtering, so register the meta-type here. +Q_DECLARE_METATYPE(AreaEffectSimulation::AesEffectState) + const static int DEFAULT_EFFECT_DURATION = 777777; namespace LtsSession @@ -141,9 +147,9 @@ protected: QSet availablePartyIds; for (const T &data : std::as_const(AesGuiBaseModel::m_vecData)) { - availabelChargeIds.insert(data.chargeStruct().chargeTypeId()); - if (data.partyId().is_set()) - availablePartyIds.insert(data.partyId().get()); + availabelChargeIds.insert(data.chargeStruct.chargeTypeId); + if (data.partyId.has_value()) + availablePartyIds.insert(data.partyId.get()); } updateComboboxFilterData(availablePartyIds, availabelChargeIds); } @@ -195,22 +201,22 @@ protected: case BcIsCentral: return QVariant(); case BcChargeType: - return QObject::tr("Id: %1").arg(item.chargeStruct().chargeTypeId()); + return QObject::tr("Id: %1").arg(item.chargeStruct.chargeTypeId); case BcEffectDuration: { - if (item.effectDuration() == DEFAULT_EFFECT_DURATION) + if (item.effectDuration == DEFAULT_EFFECT_DURATION) return QStringLiteral("---"); else - return QObject::tr("%1 secs").arg(QString::number(item.effectDuration() / 1000.0, 'f', 3)); + return QObject::tr("%1 secs").arg(QString::number(item.effectDuration / 1000.0, 'f', 3)); } case BcEffectState: - return QObject::tr("Id: %1").arg(item.effectStateId().underlying()); + return QObject::tr("Id: %1").arg(static_cast(item.effectStateId)); case BcEffectSource: - return QObject::tr("Id: %1").arg(item.effectSourceId().underlying()); + return QObject::tr("Id: %1").arg(static_cast(item.effectSourceId)); case BcParty: - return QObject::tr("Id: %1").arg(item.partyId().is_set() ? item.partyId().get() : -1); + return QObject::tr("Id: %1").arg(item.partyId.has_value() ? item.partyId.get() : -1); case BcParticipant: - return QObject::tr("Id: %1").arg(item.participantId().is_set() ? item.participantId().get() : -1); + return QObject::tr("Id: %1").arg(item.participantId.has_value() ? item.participantId.get() : -1); } } @@ -219,28 +225,28 @@ protected: switch (column) { case BcId: - return item.id(); + return item.id; case BcName: - return QString::fromUtf8(item.name().c_str()); + return QString::fromUtf8(item.name.c_str()); case BcChargeType: - return chargeTypeName(item.chargeStruct().chargeTypeId()); + return chargeTypeName(item.chargeStruct.chargeTypeId); case BcEffectDuration: - if (item.effectDuration() == DEFAULT_EFFECT_DURATION) + if (item.effectDuration == DEFAULT_EFFECT_DURATION) return QStringLiteral("---"); else - return LtsWidgets::readableDuration(item.effectDuration()); + return LtsWidgets::readableDuration(item.effectDuration); case BcEffectStart: - return item.effectStart().is_set() ? DTG::toStringMSec(item.effectStart().get()) : QObject::tr("---"); + return item.effectStart.has_value() ? DTG::toStringMSec(item.effectStart.get()) : QObject::tr("---"); case BcEffectState: - return AreaEffectSimulation::toString(item.effectStateId()); + return AreaEffectSimulation::toString(item.effectStateId); case BcEffectSource: - return ProjectDataManagement::toString(item.effectSourceId()); + return ProjectDataManagement::toString(item.effectSourceId); case BcParty: - return stringFromPartyId(item.partyId()); + return stringFromPartyId(item.partyId); case BcParticipant: - return hierarchyFromParticipantId(item.participantId()); + return hierarchyFromParticipantId(item.participantId); case BcIsCentral: - return simulationTypeText(item.isCentral()); + return simulationTypeText(item.isCentral); } return QVariant(); } @@ -250,7 +256,7 @@ protected: switch (column) { case BcParty: - return iconFromPartyId(item.partyId()); + return iconFromPartyId(item.partyId); default: break; } @@ -262,13 +268,17 @@ protected: switch (column) { case BcChargeType: - return item.chargeStruct().chargeTypeId(); + return item.chargeStruct.chargeTypeId; case BcEffectState: - return item.effectStateId().underlying(); + // Qt6 cannot implicitly construct a QVariant from a scoped enum; use the + // meta-type-aware helper (needs the Q_DECLARE_METATYPE above). A free + // qVariantFromValue is not visible at this template's definition point, so + // use the QVariant::fromValue member instead. + return QVariant::fromValue(item.effectStateId); case BcParty: - return item.partyId().is_set() ? item.partyId().get() : -1; + return item.partyId.has_value() ? item.partyId.get() : -1; case BcIsCentral: - return simulationTypeText(item.isCentral()); + return simulationTypeText(item.isCentral); default: break; } @@ -284,7 +294,7 @@ public: protected: bool isFiltered(const T &data, DataModification modType) const override { - if (!m_availableChargeIds.isEmpty() && !m_availableChargeIds.contains(data.chargeStruct().chargeTypeId())) + if (!m_availableChargeIds.isEmpty() && !m_availableChargeIds.contains(data.chargeStruct.chargeTypeId)) return true; return LtsWidgets::LtsAbstractTableModel::isFiltered(data, modType); } @@ -342,10 +352,10 @@ public: } T aesItem(int row) const { return m_sourceModel->aesItem(row); } - int aesId(int row) const override { return aesItem(row).id(); } + int aesId(int row) const override { return aesItem(row).id; } bool isExpired(int row) const override { - const auto es = aesItem(row).effectStateId(); + const auto es = aesItem(row).effectStateId; return es != AreaEffectSimulation::AesEffectState::EsCreated && es != AreaEffectSimulation::AesEffectState::EsPrepared && @@ -355,14 +365,14 @@ public: } bool isExternal(int row) const override { - return aesItem(row).externalId() > 0; + return aesItem(row).externalId > 0; } protected: - AesEffectState aesEffectStateId(int row) const override { return aesItem(row).effectStateId(); } - ProjectDataManagement::EffectSource aesEffectSourceId(int row) const override { return aesItem(row).effectSourceId(); } - dds::core::optional aesEffectStart(int row) const override { return aesItem(row).effectStart(); } - int32_t aesEffectDuration(int row) const override { return aesItem(row).effectDuration(); } - virtual int32_t partyId(int row) const override { return aesItem(row).partyId().is_set()?aesItem(row).partyId().get():-1; } + AesEffectState aesEffectStateId(int row) const override { return aesItem(row).effectStateId; } + ProjectDataManagement::EffectSource aesEffectSourceId(int row) const override { return aesItem(row).effectSourceId; } + dds::core::optional aesEffectStart(int row) const override { return aesItem(row).effectStart; } + int32_t aesEffectDuration(int row) const override { return aesItem(row).effectDuration; } + virtual int32_t partyId(int row) const override { return aesItem(row).partyId.has_value()?aesItem(row).partyId.get():-1; } AesGuiBaseModel *m_sourceModel = nullptr; }; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_itemlist.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_itemlist.cpp index d3be4e2bb..fdc4a6b97 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_itemlist.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_itemlist.cpp @@ -1,6 +1,7 @@ #include "aes_itemlist.h" +#include #include "aes_base_model.h" #include "ui_aes_itemlist.h" @@ -27,6 +28,7 @@ AesItemList::AesItemList(const QString& menuGroup, QWidget* parent) m_menuGroup(menuGroup), m_requestHelper(new LtsUtils::RequestHelper(this)), m_showExpired(false), m_bHasAddEditOperatorRights(true), m_bHasAddAdlerOperatorRights(false), m_session(nullptr), m_ui(new Ui::AesItemList) +, m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { m_ui->setupUi(this); @@ -174,15 +176,15 @@ void AesItemList::onAdlerBtn() DEBUG_LOG(m_logger) << "onAdlerBtn aesEffectState=" << aesEffectState; - switch (aesEffectState.underlying()) + switch (aesEffectState) { case AreaEffectSimulation::AesEffectState::EsReceived: { - switch (effectSource.underlying()) + switch (effectSource) { case ProjectDataManagement::EffectSource::ES_ADLER: { AcknowledgeExternalAesItemRequest req; int aesId = model()->aesId(currentRow()); - req.aesId(aesId); + req.aesId = aesId; m_requestHelper->startSingleRequest( [req, this]() { return m_ftc->acknowledgeExternalAesItemRequest(req, this); }); @@ -191,7 +193,7 @@ void AesItemList::onAdlerBtn() default: { ExplosionClusterReleaseReceivedRequest req; int aesId = model()->aesId(currentRow()); - req.id(aesId); + req.id = aesId; m_requestHelper->startSingleRequest( [req, this]() { return m_ftc->explosionClusterReleaseReceivedRequest(req, this); }); break; @@ -206,10 +208,10 @@ void AesItemList::onAdlerBtn() effectSource == ProjectDataManagement::EffectSource::ES_ADLER_STANDALONE) { AreaEffectSimulation::SetAesItemEffectorStateRequest req; - req.aesId(model()->aesId(currentRow())); - req.newEffectorState(AesEffectorState::EsReadyToFire); - DEBUG_LOG(m_logger) << "Send setAesItemEffectorStateRequest with aesId: " << req.aesId() - << ", AesEffectorState: " << req.newEffectorState(); + req.aesId = model()->aesId(currentRow()); + req.newEffectorState = AesEffectorState::EsReadyToFire; + DEBUG_LOG(m_logger) << "Send setAesItemEffectorStateRequest with aesId: " << req.aesId + << ", AesEffectorState: " << req.newEffectorState; m_requestHelper->startSingleRequest( [req, this]() { return m_ftc->setAesItemEffectorStateRequest(req, this); }); @@ -227,7 +229,7 @@ void AesItemList::onHandleAdler() DEBUG_LOG(m_logger) << "onHandleAdler aesEffectState=" << aesEffectState; auto* adlerBtn = m_buttonBox->getButton(ADLER_BTN); - switch (aesEffectState.underlying()) + switch (aesEffectState) { case AreaEffectSimulation::AesEffectState::EsReceived: { adlerBtn->setText(tr("Mark received")); @@ -238,11 +240,11 @@ void AesItemList::onHandleAdler() case AreaEffectSimulation::AesEffectState::EsCreated: case AreaEffectSimulation::AesEffectState::EsPrepared: { ProjectDataManagement::EffectSource effectSource = model()->aesEffectSourceId(currentRow()); - if (effectSource.underlying() == ProjectDataManagement::EffectSource::ES_ADLER || - effectSource.underlying() == ProjectDataManagement::EffectSource::ES_ADLER_STANDALONE) + if (effectSource == ProjectDataManagement::EffectSource::ES_ADLER || + effectSource == ProjectDataManagement::EffectSource::ES_ADLER_STANDALONE) { const EffectCluster& ecData = m_dtc->effectCluster(model()->aesId(currentRow())); - if (ecData.effectorState() == AreaEffectSimulation::AesEffectorState::EsNotReadyToFire) + if (ecData.effectorState == AreaEffectSimulation::AesEffectorState::EsNotReadyToFire) { adlerBtn->setText(tr("Ready To Fire")); adlerBtn->show(); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_pixmap_label.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_pixmap_label.cpp index d8446e74b..b901b90cc 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_pixmap_label.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Base/aes_pixmap_label.cpp @@ -33,7 +33,7 @@ QPixmap PixmapLabel::scaledPixmap(const QSize &size, const Qt::AspectRatioMode & Qt::BrushStyle PixmapLabel::checkForBrushStyle(const AesEffectState &state) { - switch(state.underlying()) + switch(state) { case AesEffectState::EsUnknown: return Qt::BrushStyle::NoBrush; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/CustomView/aes_borderline.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/CustomView/aes_borderline.cpp index 740703820..c77b62df7 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/CustomView/aes_borderline.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/CustomView/aes_borderline.cpp @@ -45,15 +45,15 @@ bool CustomViewBorderline::init(const QModelIndex &idx) bool CustomViewBorderline::calculateIcon(const AreaEffectSimulation::Borderline &line, const QColor &color) { - if (line.segments().size() == 0) + if (line.segments.size() == 0) return false; QVector segments; - segments.reserve(line.segments().size()); + segments.reserve(line.segments.size()); int setZone = -1; - for (const Core::GeoPosition2D &s : line.segments()) + for (const Core::GeoPosition2D &s : line.segments) { - const LtsCoordTrans::UtmCoordinate coord(LtsCoordTrans::UtmCoordinate::fromGeographic(s.lon(), s.lat(), setZone)); + const LtsCoordTrans::UtmCoordinate coord(LtsCoordTrans::UtmCoordinate::fromGeographic(s.lon, s.lat, setZone)); if (setZone < 0) setZone = coord.zone; segments.append(QPointF(coord.x, coord.y)); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_edit.cpp index 1c83fd3b5..d8a00f275 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_edit.cpp @@ -83,15 +83,15 @@ void BorderlineEdit::enableUiElements(bool enable) m_ui->leIdentifier->setEnabled(enable || isOnlyNameModifiable()); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->borderline(m_aesItem.id()); + auto baseData = m_dtc->borderline(m_aesItem.id); setData(baseData, false); __unchange__(); if (name != m_ui->leIdentifier->text()) @@ -148,26 +148,26 @@ bool BorderlineEdit::init(int aesItemId, bool copy, LtsSession::LtsSession *sess void BorderlineEdit::setData(const Borderline &borderline, bool copy) { - DEBUG_LOG(m_logger) << LOGFUNCTION << "borderlineId: " << borderline.id() - << " operatorId: " << borderline.operatorId(); + DEBUG_LOG(m_logger) << LOGFUNCTION << "borderlineId: " << borderline.id + << " operatorId: " << borderline.operatorId; m_aesItem = borderline; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromStdString(borderline.name())); - if ( borderline.partyId().is_set()) - m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(borderline.partyId().get())); - m_ui->lbBorderlineId->setText(QString::number(borderline.id())); + m_ui->leIdentifier->setText(QString::fromStdString(borderline.name)); + if ( borderline.partyId.has_value()) + m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(borderline.partyId.get())); + m_ui->lbBorderlineId->setText(QString::number(borderline.id)); - if (borderline.operatorId() > 0) + if (borderline.operatorId > 0) m_ui->cbLocalBorderline->setChecked(true); else m_ui->cbLocalBorderline->setChecked(false); - setCoordinates(borderline.segments()); + setCoordinates(borderline.segments); } @@ -226,7 +226,7 @@ bool BorderlineEdit::apply() LtsSessionData::LtsSessionData::getInstance()->getOperatorId() : 0); - const BorderlineModifyRequest req(m_aesItem.id(), + const BorderlineModifyRequest req(m_aesItem.id, operatorId, m_ui->cbParty->currentData().toInt(), m_ui->leIdentifier->text().toStdString(), @@ -252,7 +252,7 @@ QByteArray BorderlineEdit::borderlineToJson() QJsonObject obj; obj[QStringLiteral("XmlType")] = FileManagement::toString(FileManagement::XmlType::AESBorderlineEdit); - obj[QStringLiteral("id")] = m_aesItem.id(); + obj[QStringLiteral("id")] = m_aesItem.id; obj[QStringLiteral("operatorId")] = operatorId; obj[QStringLiteral("cbParty")] = m_ui->cbParty->currentData().toInt(); obj[QStringLiteral("leIdentifier")] = m_ui->leIdentifier->text(); @@ -262,8 +262,8 @@ QByteArray BorderlineEdit::borderlineToJson() for (const Core::GeoPosition2D &segment : segments) { QJsonObject innerSeg; - innerSeg[QStringLiteral("lat")] = segment.lat(); - innerSeg[QStringLiteral("lon")] = segment.lon(); + innerSeg[QStringLiteral("lat")] = segment.lat; + innerSeg[QStringLiteral("lon")] = segment.lon; arrSeg += innerSeg; } @@ -280,31 +280,31 @@ Borderline BorderlineEdit::jsonToBorderline(const QByteArray &content) const QJsonDocument doc(QJsonDocument::fromJson(content)); const QJsonObject obj(doc.object()); - borderline.chargeStruct().chargeTypeId(obj[QStringLiteral("chargeTypeId")].toInt()); - borderline.effectDuration(obj[QStringLiteral("effectDuration")].toDouble()); - borderline.effectMarkingInTa(obj[QStringLiteral("effectMarkingInTa")].toInt()); - borderline.effectStart(obj[QStringLiteral("effectStart")].toDouble()); + borderline.chargeStruct.chargeTypeId = obj[QStringLiteral("chargeTypeId")].toInt(); + borderline.effectDuration = obj[QStringLiteral("effectDuration")].toDouble(); + borderline.effectMarkingInTa = obj[QStringLiteral("effectMarkingInTa")].toInt(); + borderline.effectStart = obj[QStringLiteral("effectStart")].toDouble(); int effectStateId = obj[QStringLiteral("effectStateId")].toInt(); - borderline.effectStateId(static_cast(effectStateId)); - borderline.operatorId(obj[QStringLiteral("operatorId")].toInt()); - borderline.id(0); - borderline.name(obj[QStringLiteral("leIdentifier")].toString().toStdString()); + borderline.effectStateId = static_cast(effectStateId); + borderline.operatorId = obj[QStringLiteral("operatorId")].toInt(); + borderline.id = 0; + borderline.name = obj[QStringLiteral("leIdentifier")].toString().toStdString(); if (obj.contains(QStringLiteral("participantId")) ) - borderline.participantId(obj[QStringLiteral("participantId")].toDouble()); + borderline.participantId = obj[QStringLiteral("participantId")].toDouble(); if (obj.contains(QStringLiteral("partyId")) ) - borderline.partyId(obj[QStringLiteral("partyId")].toDouble()); - borderline.sampleTime(obj[QStringLiteral("sampleTime")].toDouble()); + borderline.partyId = obj[QStringLiteral("partyId")].toDouble(); + borderline.sampleTime = obj[QStringLiteral("sampleTime")].toDouble(); const QJsonArray arrSeg = (obj.value(QStringLiteral("segments")).toArray()); - borderline.segments().reserve(arrSeg.size()); + borderline.segments.reserve(arrSeg.size()); for (const auto &ele : arrSeg) { const QJsonObject objSeg(ele.toObject()); Core::GeoPosition2D segment; - segment.lat(objSeg[QStringLiteral("lat")].toDouble()); - segment.lon(objSeg[QStringLiteral("lon")].toDouble()); - borderline.segments().push_back(std::move(segment)); + segment.lat = objSeg[QStringLiteral("lat")].toDouble(); + segment.lon = objSeg[QStringLiteral("lon")].toDouble(); + borderline.segments.push_back(std::move(segment)); } @@ -343,7 +343,7 @@ void BorderlineEdit::onImportButtonClicked() { Borderline borderline = jsonToBorderline(content); setData( borderline, true); - setCoordinates(borderline.segments()); + setCoordinates(borderline.segments); QPolygonF coordinates = getCoordinatesQPointF(); onPolylineData(coordinates); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_edit.h index c72563038..bd537f105 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include #include #include @@ -37,7 +37,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddBorderline") : QStringLiteral("EditBorderline%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddBorderline") : QStringLiteral("EditBorderline%1").arg(m_aesItem.id); } bool init(int aesItemId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_gui_plugin.h index d4142950b..36e7e144b 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_borderline_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_list.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_list.cpp index 90060b252..465defc86 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_list.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_list.cpp @@ -156,13 +156,13 @@ void BorderlineList::onImportButtonClicked() for(const auto &borderline : requests) { BorderlineModifyRequest request; - request.id(0); - request.name(borderline.name()); - request.operatorId(borderline.operatorId()); - if (borderline.partyId().is_set()) - request.partyId(borderline.partyId().get()); - request.name(borderline.name()); - request.segments(borderline.segments()); + request.id = 0; + request.name = borderline.name; + request.operatorId = borderline.operatorId; + if (borderline.partyId.has_value()) + request.partyId = borderline.partyId.get(); + request.name = borderline.name; + request.segments = borderline.segments; m_requestHelper->startSingleRequest([this, request]() { return m_ftc->borderlineModifyRequest(request, this); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_list.h index 90f59e512..35937a0cd 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderline_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include #include #include "aes_borderlines_model.h" diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderlines_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderlines_model.cpp index 0f4fabb38..f3f359e76 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderlines_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderlines_model.cpp @@ -59,7 +59,7 @@ QVariant BorderlinesModel::data(const QModelIndex &index, int role) const switch (index.column()) { case ColOperatorId: - if (item.operatorId() == 0) + if (item.operatorId == 0) return tr("Global"); return tr("Local"); default: @@ -72,8 +72,8 @@ QVariant BorderlinesModel::data(const QModelIndex &index, int role) const bool BorderlinesModel::isFiltered(const Borderline &data, DataModification modType) const { - if ((data.operatorId() != LtsSessionData::LtsSessionData::getInstance()->getOperatorId()) && - (data.operatorId() != 0)) + if ((data.operatorId != LtsSessionData::LtsSessionData::getInstance()->getOperatorId()) && + (data.operatorId != 0)) return true; return AesGuiBaseModel::isFiltered(data, modType); @@ -92,29 +92,29 @@ QByteArray BorderlinesModel::borderlinesToJson() QJsonObject inner; const Borderline &borderline = m_vecData.at(row); - inner[QStringLiteral("chargeTypeId")] = borderline.chargeStruct().chargeTypeId(); - inner[QStringLiteral("effectDuration")] = borderline.effectDuration(); - inner[QStringLiteral("effectMarkingInTa")] = borderline.effectMarkingInTa(); + inner[QStringLiteral("chargeTypeId")] = borderline.chargeStruct.chargeTypeId; + inner[QStringLiteral("effectDuration")] = borderline.effectDuration; + inner[QStringLiteral("effectMarkingInTa")] = borderline.effectMarkingInTa; - inner[QStringLiteral("effectStateId")] = borderline.effectStateId().underlying(); - inner[QStringLiteral("id")] = borderline.id(); - inner[QStringLiteral("isDeleted")] = borderline.isDeleted(); - inner[QStringLiteral("isUsed")] = borderline.isUsed(); - inner[QStringLiteral("name")] = QString::fromStdString(borderline.name()); - inner[QStringLiteral("operatorId")] = borderline.operatorId(); - if ( borderline.participantId().is_set()) - inner[QStringLiteral("participantId")] = borderline.participantId().get(); - if ( borderline.partyId().is_set()) - inner[QStringLiteral("partyId")] = borderline.partyId().get(); - inner[QStringLiteral("sampleTime")] = borderline.sampleTime(); + inner[QStringLiteral("effectStateId")] = static_cast(borderline.effectStateId); + inner[QStringLiteral("id")] = borderline.id; + inner[QStringLiteral("isDeleted")] = borderline.isDeleted; + inner[QStringLiteral("isUsed")] = borderline.isUsed; + inner[QStringLiteral("name")] = QString::fromStdString(borderline.name); + inner[QStringLiteral("operatorId")] = borderline.operatorId; + if ( borderline.participantId.has_value()) + inner[QStringLiteral("participantId")] = borderline.participantId.get(); + if ( borderline.partyId.has_value()) + inner[QStringLiteral("partyId")] = borderline.partyId.get(); + inner[QStringLiteral("sampleTime")] = static_cast(borderline.sampleTime); arrSeg = {}; - for (const Core::GeoPosition2D &segment : borderline.segments()) + for (const Core::GeoPosition2D &segment : borderline.segments) { QJsonObject innerSeg; - innerSeg[QStringLiteral("lat")] = segment.lat(); - innerSeg[QStringLiteral("lon")] = segment.lon(); + innerSeg[QStringLiteral("lat")] = segment.lat; + innerSeg[QStringLiteral("lon")] = segment.lon; arrSeg += innerSeg; } @@ -139,31 +139,31 @@ QVector BorderlinesModel::jsonToBorderlineVector(const QByteArray &c { const QJsonObject objArr(ele.toObject()); Borderline borderline; - borderline.chargeStruct().chargeTypeId(objArr[QStringLiteral("chargeTypeId")].toInt()); - borderline.effectDuration(objArr[QStringLiteral("effectDuration")].toDouble()); - borderline.effectMarkingInTa(objArr[QStringLiteral("effectMarkingInTa")].toInt()); - borderline.effectStart(objArr[QStringLiteral("effectStart")].toDouble()); + borderline.chargeStruct.chargeTypeId = objArr[QStringLiteral("chargeTypeId")].toInt(); + borderline.effectDuration = objArr[QStringLiteral("effectDuration")].toDouble(); + borderline.effectMarkingInTa = objArr[QStringLiteral("effectMarkingInTa")].toInt(); + borderline.effectStart = objArr[QStringLiteral("effectStart")].toDouble(); int effectStateId = objArr[QStringLiteral("effectStateId")].toInt(); - borderline.effectStateId(static_cast(effectStateId)); - borderline.operatorId(objArr[QStringLiteral("operatorId")].toInt()); - borderline.id(0); - borderline.name(objArr[QStringLiteral("name")].toString().toStdString()); + borderline.effectStateId = static_cast(effectStateId); + borderline.operatorId = objArr[QStringLiteral("operatorId")].toInt(); + borderline.id = 0; + borderline.name = objArr[QStringLiteral("name")].toString().toStdString(); if (objArr.contains(QStringLiteral("participantId")) ) - borderline.participantId(objArr[QStringLiteral("participantId")].toDouble()); + borderline.participantId = objArr[QStringLiteral("participantId")].toDouble(); if (objArr.contains(QStringLiteral("partyId")) ) - borderline.partyId(objArr[QStringLiteral("partyId")].toDouble()); - borderline.sampleTime(objArr[QStringLiteral("sampleTime")].toDouble()); + borderline.partyId = objArr[QStringLiteral("partyId")].toDouble(); + borderline.sampleTime = objArr[QStringLiteral("sampleTime")].toDouble(); const QJsonArray arrSeg = (objArr.value(QStringLiteral("segments")).toArray()); - borderline.segments().reserve(arrSeg.size()); + borderline.segments.reserve(arrSeg.size()); for (const auto &seg : arrSeg) { const QJsonObject objSeg(seg.toObject()); Core::GeoPosition2D segment; - segment.lat(objSeg[QStringLiteral("lat")].toDouble()); - segment.lon(objSeg[QStringLiteral("lon")].toDouble()); - borderline.segments().push_back(std::move(segment)); + segment.lat = objSeg[QStringLiteral("lat")].toDouble(); + segment.lon = objSeg[QStringLiteral("lon")].toDouble(); + borderline.segments.push_back(std::move(segment)); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderlines_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderlines_model.h index 3ea1bc655..ea1872516 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderlines_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Borderline/aes_borderlines_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace LtsSession { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_adler_list.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_adler_list.cpp index 95c493179..49b6c0941 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_adler_list.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_adler_list.cpp @@ -21,7 +21,7 @@ namespace AreaEffectSimulation ChargeAdministrationAdlerList::ChargeAdministrationAdlerList(QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::CloseOnly), m_model(nullptr), m_sourceModel(nullptr), - m_session(nullptr), m_requestHelper(new LtsUtils::RequestHelper(this)), m_ui(new Ui::ChargeAdministrationList) + m_session(nullptr), m_requestHelper(new LtsUtils::RequestHelper(this)), m_ui(new Ui::ChargeAdministrationList), m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { m_ui->setupUi(this); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_adler_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_adler_model.cpp index 513ab3bfe..3092c43af 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_adler_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_adler_model.cpp @@ -48,7 +48,7 @@ void ChargeAdministrationAdlerSortFilterProxyModel::setParty(int party) ChargeAdministrationAdlerModel::ChargeAdministrationAdlerModel(QObject* parent) : LtsWidgets::LtsAbstractTableModel( {tr("Id"), tr("Charge Type Id"), tr("Changed"), tr("Charge Type Name"), tr("Total Stock"), tr("Gear Class")}, - parent) + parent), m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { } @@ -78,7 +78,7 @@ bool ChargeAdministrationAdlerModel::initModel(LtsSession::LtsSession* session) for (const ParticipantManagement::Party& p : std::as_const(parties)) { - updateItem(p.id()); + updateItem(p.id); } connect(m_ppmDtc.get(), &ParticipantManagement::Interface::Dtc::dynamicParticipantDataChanged, this, @@ -99,7 +99,7 @@ void ChargeAdministrationAdlerModel::onStateChanged(const ParticipantManagement: DEBUG_LOG(m_logger) << "+++++++++ DataModification --> " << modType; updateParticipantChargeTypeMap(data); - updateItem(m_ppmDtc->participant(data.participantId()).partyId()); + updateItem(m_ppmDtc->participant(data.participantId).partyId); break; } case DataModification::eRemoved: { @@ -112,10 +112,10 @@ void ChargeAdministrationAdlerModel::onParticipantChanged(const ParticipantManag DataModification modType) { Q_UNUSED(modType) - qint32 typeId = data.typeId(); - qint32 participantId = data.id(); + qint32 typeId = data.typeId; + qint32 participantId = data.id; - if (!data.isDeleted() || (!m_ppmDtc->isAdlerType(typeId) && (m_ppmDtc->type(typeId).typeClass().underlying() != + if (!data.isDeleted || (!m_ppmDtc->isAdlerType(typeId) && (m_ppmDtc->type(typeId).typeClass != ParticipantManagement::TypeClass::Unit))) return; @@ -133,39 +133,39 @@ void ChargeAdministrationAdlerModel::onParticipantChanged(const ParticipantManag m_participantChargeTypeMap.remove(participantId); } - updateItem(data.partyId()); + updateItem(data.partyId); } void ChargeAdministrationAdlerModel::updateParticipantChargeTypeMap( const ParticipantManagement::DynamicParticipantData& data) { - qint32 participantId = data.participantId(); - qint64 sampleTime = data.sampleTime(); - qint32 typeId = m_ppmDtc->participant(participantId).typeId(); - bool isDeleted = m_ppmDtc->participant(participantId).isDeleted(); + qint32 participantId = data.participantId; + qint64 sampleTime = data.sampleTime; + qint32 typeId = m_ppmDtc->participant(participantId).typeId; + bool isDeleted = m_ppmDtc->participant(participantId).isDeleted; if (isDeleted || (!m_ppmDtc->isAdlerType(typeId) && - (m_ppmDtc->type(typeId).typeClass().underlying() != ParticipantManagement::TypeClass::Unit))) + (m_ppmDtc->type(typeId).typeClass != ParticipantManagement::TypeClass::Unit))) return; QMap chargeTypeGearData; - for (const ParticipantManagement::GearInformation& ct : data.gear()) + for (const ParticipantManagement::GearInformation& ct : data.gear) { - if (m_pdmDtc->adlerChargeTypeName(ct.chargeTypeId()).isEmpty()) + if (m_pdmDtc->adlerChargeTypeName(ct.chargeTypeId).isEmpty()) continue; GearData gearData; - gearData.remain = ct.remain(); - gearData.lastUpdate = ct.lastUpdate(); - if (chargeTypeGearData.contains(ct.chargeTypeId())) + gearData.remain = ct.remain; + gearData.lastUpdate = ct.lastUpdate; + if (chargeTypeGearData.contains(ct.chargeTypeId)) { - gearData.remain += chargeTypeGearData.value(ct.chargeTypeId()).remain; + gearData.remain += chargeTypeGearData.value(ct.chargeTypeId).remain; } - chargeTypeGearData.insert(ct.chargeTypeId(), gearData); + chargeTypeGearData.insert(ct.chargeTypeId, gearData); } m_participantChargeTypeMap.insert( participantId, - ChargeStruct(participantId, m_ppmDtc->participant(participantId).partyId(), sampleTime, chargeTypeGearData)); + ChargeStruct(participantId, m_ppmDtc->participant(participantId).partyId, sampleTime, chargeTypeGearData)); } void ChargeAdministrationAdlerModel::updateItem(int partyId) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_gui_plugin.h index 7d8cd85f7..4154d915d 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_list.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_list.cpp index a18515d6e..d80834f7c 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_list.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_list.cpp @@ -25,7 +25,7 @@ namespace AreaEffectSimulation ChargeAdministrationList::ChargeAdministrationList(QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::CloseOnly), m_model(nullptr), m_sourceModel(nullptr), m_session(nullptr), m_ftc(nullptr), m_requestHelper(new LtsUtils::RequestHelper(this)), - m_ui(new Ui::ChargeAdministrationList) + m_ui(new Ui::ChargeAdministrationList), m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { m_ui->setupUi(this); @@ -154,15 +154,15 @@ void ChargeAdministrationList::onEditCharge() { ChargeAdministration item = m_sourceModel->getRowData(m_ui->widget->currentIndex().row()); - if (item.id() < 0) + if (item.id < 0) return; - ProjectDataManagement::ChargeType ct = m_sourceModel->chargeType(item.chargeTypeId()); + ProjectDataManagement::ChargeType ct = m_sourceModel->chargeType(item.chargeTypeId); const QModelIndex temp = m_ui->widget->currentIndex(); const QModelIndex mi = temp.sibling(temp.row(), ChargeAdministrationModel::ColTypeName); - auto ce = new ChargeEdit(ct.id(), m_sourceModel->data(mi).toString(), item.amount(), this); + auto ce = new ChargeEdit(ct.id, m_sourceModel->data(mi).toString(), item.amount, this); connect(ce, &ChargeEdit::newStock, this, &ChargeAdministrationList::onChargeEditFinished); connect(ce, &ChargeEdit::newStock, ce, &ChargeEdit::deleteLater); ce->show(); @@ -172,16 +172,16 @@ void ChargeAdministrationList::onChargeEditFinished(int chargeId, int newStock) { ChargeAdministration item = m_sourceModel->getRowData(m_ui->widget->currentIndex().row()); - if (item.chargeTypeId() != chargeId) + if (item.chargeTypeId != chargeId) return; - if (item.amount() == newStock) + if (item.amount == newStock) return; - item.amount(newStock); + item.amount = newStock; bool amountChangedByOperator = true; - const ChargeAdministrationModifyRequest req(item.id(), item.chargeTypeId(), item.partyId(), item.effectSourceId(), - item.amount(), amountChangedByOperator); + const ChargeAdministrationModifyRequest req(item.id, item.chargeTypeId, item.partyId, item.effectSourceId, + item.amount, amountChangedByOperator); m_requestHelper->addRequest([this, req]() { return m_ftc->chargeAdministrationModifyRequest(req, this); }); m_requestHelper->startRequests(); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_model.cpp index 10dfcc8e7..29affa117 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeAdministration/aes_charge_administration_model.cpp @@ -28,7 +28,7 @@ bool ChargeAdministrationSortFilterProxyModel::filterAcceptsRow(int source_row, return LtsWidgets::LtsColumnFilterProxyModel::filterAcceptsRow(source_row, source_parent); const ChargeAdministration& item = m_sourceModel->m_vecData.at(source_row); - if (item.partyId() != m_party) + if (item.partyId != m_party) return false; return LtsWidgets::LtsColumnFilterProxyModel::filterAcceptsRow(source_row, source_parent); } @@ -49,7 +49,7 @@ ChargeAdministrationModel::ChargeAdministrationModel(QObject* parent) : LtsWidgets::LtsAbstractTableModel({tr("Id"), tr("Charge Type Id"), tr("Changed"), tr("Charge Type Name"), tr("Total Stock"), tr("Planned"), tr("Available"), tr("Used"), tr("Gear Class")}, - parent) + parent), m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { } @@ -80,12 +80,12 @@ bool ChargeAdministrationModel::initModel(LtsSession::LtsSession* session, QVector> chargesInserted; auto cb = [this, &chargesInserted](const ChargeAdministration& item) { - const int chargeTypeId = item.chargeTypeId(); + const int chargeTypeId = item.chargeTypeId; if (m_pdmDtc->isAdlerChargeType(chargeTypeId)) return; insertRow(item); - chargesInserted.append(qMakePair(item.chargeTypeId(), item.partyId())); + chargesInserted.append(QPair(item.chargeTypeId, item.partyId)); }; m_aesDtc->chargeAdministrations(cb); @@ -98,22 +98,22 @@ bool ChargeAdministrationModel::initModel(LtsSession::LtsSession* session, } QVector chargesForGearClass = - m_pdmDtc->chargesForGearClass(ProjectDataManagement::GearClass::Artillery) + - m_pdmDtc->chargesForGearClass(ProjectDataManagement::GearClass::Mortar); + m_pdmDtc->chargesForGearClass(ProjectDataManagement::GearClass::GearClass_Artillery) + + m_pdmDtc->chargesForGearClass(ProjectDataManagement::GearClass::GearClass_Mortar); LtsUtils::ProjectSettings* ps = LtsUtils::ProjectSettings::getInstance(); const bool enableRocket = ps->value(QStringLiteral("aes"), QStringLiteral("enableRocket"), false).toBool(); if (enableRocket) - chargesForGearClass += m_pdmDtc->chargesForGearClass(ProjectDataManagement::GearClass::Rocket); + chargesForGearClass += m_pdmDtc->chargesForGearClass(ProjectDataManagement::GearClass::GearClass_Rocket); for (const ParticipantManagement::Party& p : std::as_const(parties)) { for (const ProjectDataManagement::ChargeType& ct : std::as_const(chargesForGearClass)) { - if (chargesInserted.contains(qMakePair(ct.id(), p.id())) || isDummy(ct) || - m_pdmDtc->isAdlerChargeType(ct.id())) + if (chargesInserted.contains(qMakePair(ct.id, p.id)) || isDummy(ct) || + m_pdmDtc->isAdlerChargeType(ct.id)) continue; - reqs << ChargeAdministrationModifyRequest(0, ct.id(), p.id(), + reqs << ChargeAdministrationModifyRequest(0, ct.id, p.id, ProjectDataManagement::EffectSource::ES_Internal, 0, true); } } @@ -122,7 +122,7 @@ bool ChargeAdministrationModel::initModel(LtsSession::LtsSession* session, bool ChargeAdministrationModel::isDummy(const ProjectDataManagement::ChargeType& ct) { - return LtsUtils::JsonObject::fromJson(ct.properties()).valueOr("isDummy", false); + return LtsUtils::JsonObject::fromJson(ct.properties).valueOr("isDummy", false); } QVariant ChargeAdministrationModel::data(const QModelIndex& index, int role) const @@ -135,23 +135,23 @@ QVariant ChargeAdministrationModel::data(const QModelIndex& index, int role) con switch (index.column()) { case ColId: - return item.id(); + return item.id; case ColTypeId: - return item.chargeTypeId(); + return item.chargeTypeId; case ColChanged: - return QDateTime::fromMSecsSinceEpoch(item.sampleTime()); + return QDateTime::fromMSecsSinceEpoch(item.sampleTime); case ColTypeName: - return m_pdmDtc->trChargeTypeShortName(item.chargeTypeId(), true); + return m_pdmDtc->trChargeTypeShortName(item.chargeTypeId, true); case ColStock: - return item.amount(); + return item.amount; case ColAvailable: - return item.amount() - item.planned(); + return item.amount - item.planned; case ColPlanned: - return item.planned(); + return item.planned; case ColUsed: - return item.used(); + return item.used; case ColGearClass: - return ProjectDataManagement::toString(m_pdmDtc->gearClassFromChargeTypeId(item.chargeTypeId())); + return ProjectDataManagement::toString(m_pdmDtc->gearClassFromChargeTypeId(item.chargeTypeId)); } return QVariant(); } @@ -160,7 +160,7 @@ void ChargeAdministrationModel::onChargeAdministrationChanged(const ChargeAdmini DataModification modType) { - if (m_pdmDtc->isAdlerChargeType(data.chargeTypeId())) + if (m_pdmDtc->isAdlerChargeType(data.chargeTypeId)) return; onDataChanged(data, modType); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_edit.cpp index 8789cb5b5..a804eac66 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_edit.cpp @@ -163,15 +163,15 @@ void ChargeEffectEdit::onSelectionChanged() return; const ParticipantManagement::ParticipantData data(m_participantModel->getParticipantData(m_ui->dvParticipants->selectedRows().first())); - DEBUG_LOG(m_logger) << "ParticipantId: " << data.id(); + DEBUG_LOG(m_logger) << "ParticipantId: " << data.id; - if (m_ppmDtc->type(data.typeId()).typeClass() == ParticipantManagement::TypeClass::Unit) + if (m_ppmDtc->type(data.typeId).typeClass == ParticipantManagement::TypeClass::Unit) return; - DEBUG_LOG(m_logger) << "typeClass: " << m_ppmDtc->type(data.typeId()).typeClass() - << " eqNr.isSet(): " << data.equipmentNumber().is_set(); + DEBUG_LOG(m_logger) << "typeClass: " << m_ppmDtc->type(data.typeId).typeClass + << " eqNr.isSet(): " << data.equipmentNumber.has_value(); - if (data.equipmentNumber().is_set()) + if (data.equipmentNumber.has_value()) { if (m_ui->cbChargeType->count()) m_ui->pbPosition->setEnabled(true); @@ -216,8 +216,8 @@ void ChargeEffectEdit::onGetCoordinate(const QPointF &coordinate) const int chargeTypeId = m_ui->cbChargeType->currentData().toInt(); const int partyId = m_ui->cbParty->currentData().toInt(); - DEBUG_LOG(m_logger) << "ParticipantId=" << participantData.id() - << " EquipmentNr=" << participantData.equipmentNumber() + DEBUG_LOG(m_logger) << "ParticipantId=" << participantData.id + << " EquipmentNr=" << participantData.equipmentNumber << " partyId=" << partyId << " chargeType=" << chargeTypeId << " onGetCoordinate x=" << coordinate.x() << " y=" << coordinate.y(); @@ -227,8 +227,8 @@ void ChargeEffectEdit::onGetCoordinate(const QPointF &coordinate) int gearType = 0; for (const auto >c : m_pdmDtc->gearTypeChargeTypes()) { - if (gtc.chargeTypeId() == chargeTypeId) - gearType = gtc.gearTypeId(); + if (gtc.chargeTypeId == chargeTypeId) + gearType = gtc.gearTypeId; } const auto chargeType = m_pdmDtc->chargeType(chargeTypeId); @@ -240,25 +240,25 @@ void ChargeEffectEdit::onGetCoordinate(const QPointF &coordinate) ProjectDataManagement::StateChangeOriginator originatorTypeId; if (m_ui->cbPlayer->isChecked()) { - id = participantData.id(); - originatorTypeId = ProjectDataManagement::StateChangeOriginator::Participant; + id = participantData.id; + originatorTypeId = ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_Participant; } else { id = partyId; - originatorTypeId = ProjectDataManagement::StateChangeOriginator::Party; + originatorTypeId = ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_Party; } - request.name(chargeType.shortName()); - request.chargeTypeId(chargeTypeId); - request.igniterTypeId(0); - request.gearTypeId(gearType); - request.originatorId(id); - request.originatorTypeId(originatorTypeId); - request.effectDuration(1000); - request.effectStart(m_session->partitionTime() + 6000); - request.position(Core::GeoPosition(coordinate.x(), coordinate.y(), 0.0)); + request.name = chargeType.shortName; + request.chargeTypeId = chargeTypeId; + request.igniterTypeId = 0; + request.gearTypeId = gearType; + request.originatorId = id; + request.originatorTypeId = originatorTypeId; + request.effectDuration = 1000; + request.effectStart = m_session->partitionTime() + 6000; + request.position = Core::GeoPosition(coordinate.x(), coordinate.y(), 0.0); m_requestHelper->addRequest([this,request]() { @@ -288,10 +288,10 @@ void ChargeEffectEdit::fillCharges() for (const auto &charge : m_pdmDtc->chargeTypes()) { - if(!m_pdmDtc->isVirtuallyFireable(charge.id())) + if(!m_pdmDtc->isVirtuallyFireable(charge.id)) continue; - m_ui->cbChargeType->addItem(QString::fromStdString(charge.name()), charge.id()); + m_ui->cbChargeType->addItem(QString::fromStdString(charge.name), charge.id); } m_ui->cbChargeType->setEnabled(m_ui->cbChargeType->count() > 1); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_edit.h index c249ad7ff..61064d7a5 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_edit.h @@ -3,9 +3,10 @@ #pragma once -#include +#include #include #include +#include #include #include #include @@ -36,7 +37,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddChargeEffect") : QStringLiteral("EditChargeEffect%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddChargeEffect") : QStringLiteral("EditChargeEffect%1").arg(m_aesItem.id); } bool init(int areaId, bool copy, LtsSession::LtsSession *session); void onChargeEffectModifyReply(const Core::FunctionReplyObject &replyObject) override final { onAesItemModifyReply(replyObject); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_gui_plugin.h index 8a46af9b4..8f150ee10 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/ChargeEffect/aes_charge_effect_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_charge_effect_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/CustomView/aes_danger_area.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/CustomView/aes_danger_area.cpp index 68b97295d..23a1bbda3 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/CustomView/aes_danger_area.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/CustomView/aes_danger_area.cpp @@ -47,22 +47,22 @@ bool CustomViewDangerArea::init(const QModelIndex &idx) bool CustomViewDangerArea::calculateIcon(const AreaEffectSimulation::DangerArea &area, const QColor &color) { - if (area.segments().size() == 0) + if (area.segments.size() == 0) return false; QVector segments; - segments.reserve(area.segments().size()); + segments.reserve(area.segments.size()); int setZone = -1; - for (const Core::GeoPosition2D &s : area.segments()) + for (const Core::GeoPosition2D &s : area.segments) { - const LtsCoordTrans::UtmCoordinate coord(LtsCoordTrans::UtmCoordinate::fromGeographic(s.lon(), s.lat(), setZone)); + const LtsCoordTrans::UtmCoordinate coord(LtsCoordTrans::UtmCoordinate::fromGeographic(s.lon, s.lat, setZone)); if (setZone < 0) setZone = coord.zone; segments.append(QPointF(coord.x, coord.y)); } QPolygonF poly = AreaEffectSimulation::Polygons::dangerArea(segments); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(area.effectStateId()); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(area.effectStateId); const auto pix = Polygons::pixmapFromPolygon(poly, color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_edit.cpp index 74bcd12b3..12069d48b 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_edit.cpp @@ -66,15 +66,15 @@ void DangerAreaEdit::enableUiElements(bool enable) m_ui->pbClear->setEnabled(enable); m_ui->leIdentifier->setEnabled(enable || isOnlyNameModifiable()); setEffectStartEnabled(m_ui->dteEffectStart, enable); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->dangerArea(m_aesItem.id()); + auto baseData = m_dtc->dangerArea(m_aesItem.id); setData(baseData, false); __unchange__(); if (name != m_ui->leIdentifier->text()) @@ -112,8 +112,8 @@ bool DangerAreaEdit::init(int aesItemId, bool copy, auto cb = [this](const DangerAreaCorrelatedAesItem &item) { - if (item.dangerAreaId() == m_aesItem.id()) - m_otherAesItemIds << item.aesItemId(); + if (item.dangerAreaId == m_aesItem.id) + m_otherAesItemIds << item.aesItemId; }; m_dtc->dangerAreaCorrelatedAesItems(cb); setPbAesItemsText(); @@ -136,12 +136,12 @@ void DangerAreaEdit::setPbAesItemsText() { AesItem item; m_dtc->aesItemFromId(idx, item); - if (item.id() <= 0) + if (item.id <= 0) continue; - if (item.effectStateId() != AesEffectState::EsActivated) + if (item.effectStateId != AesEffectState::EsActivated) continue; - sl << QString::fromStdString(item.name().c_str()); + sl << QString::fromStdString(item.name.c_str()); } m_ui->pbAesItems->setEnabled(sl.size()); m_ui->pbAesItems->setText(sl.join(QStringLiteral(", "))); @@ -152,12 +152,12 @@ void DangerAreaEdit::setData(const DangerArea &aesItem, bool copy) m_aesItem = aesItem; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromStdString(aesItem.name())); - m_ui->dteEffectStart->setMsecsSinceEpoch(aesItem.effectStart().is_set() ? aesItem.effectStart().get() : 0); - setCoordinates(aesItem.segments()); + m_ui->leIdentifier->setText(QString::fromStdString(aesItem.name)); + m_ui->dteEffectStart->setMsecsSinceEpoch(aesItem.effectStart.has_value() ? aesItem.effectStart.get() : 0); + setCoordinates(aesItem.segments); } void DangerAreaEdit::getPolygon() @@ -194,11 +194,11 @@ bool DangerAreaEdit::apply() { std::string name = m_ui->leIdentifier->text().toStdString(); qint64 effectStart = m_ui->dteEffectStart->msecsSinceEpoch(); - const DangerAreaModifyRequest req(m_aesItem.id(), + const DangerAreaModifyRequest req(m_aesItem.id, name, 0, 311, - LtsUtils::toOptional(effectStart), + LtsUtils::toOptional(static_cast(effectStart)), getCoordinates(), dds::core::optional(), dds::core::optional(), @@ -213,14 +213,14 @@ bool DangerAreaEdit::apply() void DangerAreaEdit::onCorrelatedItemsChanged(const DangerAreaCorrelatedAesItem &data, DataModification modType) { - if (data.dangerAreaId() != m_aesItem.id()) + if (data.dangerAreaId != m_aesItem.id) return; if (modType == DataModification::eAdded) - m_otherAesItemIds += data.aesItemId(); + m_otherAesItemIds += data.aesItemId; if (modType == DataModification::eRemoved) - m_otherAesItemIds -= data.aesItemId(); + m_otherAesItemIds -= data.aesItemId; setPbAesItemsText(); @@ -235,7 +235,7 @@ void DangerAreaEdit::onPbAesItemsClicked() if (!m_session->getForeignGuiInterface(infoGuiInterface)) return; - LtsWidgets::LtsDialog *dialog = infoGuiInterface->showDangerAreaAesItemInfo({m_aesItem.id()}, m_otherAesItemIds); + LtsWidgets::LtsDialog *dialog = infoGuiInterface->showDangerAreaAesItemInfo({m_aesItem.id}, m_otherAesItemIds); addDialog(dialog, m_menuGroup, tr("Danger Areas for BC Contamination %1").arg(m_ui->leIdentifier->text()), LtsWidgets::LayoutArea::eInfoTab); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_edit.h index f0603c1ea..cc03620ad 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include class QDoubleSpinBox; @@ -28,7 +28,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddDangerArea") : QStringLiteral("EditDangerArea%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddDangerArea") : QStringLiteral("EditDangerArea%1").arg(m_aesItem.id); } bool init(int aesItemId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_gui_plugin.h index aec5693fa..3aeaf74f6 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_danger_area_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_list.h index aa9635103..8871a10f4 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_area_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_areas_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_areas_model.h index b3541e160..b710be43e 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_areas_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/DangerArea/aes_danger_areas_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace LtsSession { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/CMakeLists.txt b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/CMakeLists.txt index aae0777a8..85ec45d88 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/CMakeLists.txt +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/CMakeLists.txt @@ -8,6 +8,15 @@ # # LIBRARY for AesEffectClusterModel (which is used at AirSupportPlugin) # +# Build the targets in this directory as separate translation units (NOT a unity +# build). aes_explosions_edit_adler.cpp and +# aes_explosions_edit_adler_standalone.cpp each define the same file-scope statics +# (VALUE_VALID_PROPERTY_NAME / LAST_VALUE / s_timeUntilMinimumSec, internal linkage, +# both in namespace AreaEffectSimulation). Separate TUs keep the copies independent +# (legacy structure); a unity TU sees two definitions in one scope and fails with +# "redefinition of '... AreaEffectSimulation::...'" (behavior-neutral to disable). +set(CMAKE_UNITY_BUILD FALSE) + # Make ${Qt6_Widgets} optional if(QT6_GUI_AVAILABLE AND TARGET Qt6::Widgets) set(Qt6_Widgets ${Qt6_Widgets}) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/CustomView/aes_explosion.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/CustomView/aes_explosion.cpp index c9b95b735..c48ff3727 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/CustomView/aes_explosion.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/CustomView/aes_explosion.cpp @@ -74,14 +74,14 @@ bool CustomViewExplosion::init(const QModelIndex &idx) bool CustomViewExplosion::calculateIcon(const ExplosionArea &area, const QColor &color) { Database::AesExplosionArea ea; - ea.impactPosition = QPointF(area.area().cornerBottomLeft().lon(), - area.area().cornerBottomLeft().lat()); - ea.rotationAngle = area.area().rotation(); - ea.impactWidth = area.area().width(); - ea.impactLength = area.area().height(); + ea.impactPosition = QPointF(area.area.cornerBottomLeft.lon, + area.area.cornerBottomLeft.lat); + ea.rotationAngle = area.area.rotation; + ea.impactWidth = area.area.width; + ea.impactLength = area.area.height; QPolygonF poly = AreaEffectSimulation::Polygons::explosionArea(ea); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(area.effectStateId()); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(area.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); @@ -91,17 +91,17 @@ bool CustomViewExplosion::calculateIcon(const ExplosionArea &area, const QColor bool CustomViewExplosion::calculateIcon(const ExplosionSingle &single, const QColor &color) { Database::AesExplosionSingle es; - es.impactPosition = QPointF(single.impactPosition().lon(), single.impactPosition().lat()); + es.impactPosition = QPointF(single.impactPosition.lon, single.impactPosition.lat); std::shared_ptr pdmDtc; if (!m_session->getDtc(pdmDtc)) return false; - double radius = pdmDtc->impactRadius(single.chargeStruct().chargeTypeId(), - single.chargeStruct().igniterTypeId(), - single.chargeStruct().igniterFunctionId()); + double radius = pdmDtc->impactRadius(single.chargeStruct.chargeTypeId, + single.chargeStruct.igniterTypeId, + single.chargeStruct.igniterFunctionId); QPolygonF poly = AreaEffectSimulation::Polygons::explosionSingle(es, radius); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(single.effectStateId()); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(single.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/_aes_explosions_single_central_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/_aes_explosions_single_central_model.h index 7cd8c9e44..b86130b85 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/_aes_explosions_single_central_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/_aes_explosions_single_central_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effect_cluster_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effect_cluster_model.cpp index 7b7ef758b..d77bcd28d 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effect_cluster_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effect_cluster_model.cpp @@ -61,32 +61,32 @@ bool EffectClusterModel::initModel(LtsSession::LtsSession *session) EffectCluster EffectClusterModel::toEffectCluster(const ExplosionCluster &data) { EffectCluster ec; - ec.id(data.id()); - ec.name(data.name()); - ec.effectSourceId(data.effectSourceId()); - ec.effectStateId(data.effectStateId()); - ec.chargeStruct(data.chargeStruct()); - ec.effectDuration(data.effectDuration()); - ec.effectStart(data.effectStart()); - ec.area(data.area()); - ec.esmParticipantIds(data.esmParticipantIds()); - ec.explosionGeometry(data.explosionGeometry()); - ec.element(data.element()); - ec.firePurposeId(data.firePurposeId()); - ec.firingPosition(data.firingPosition()); - ec.fireRequestTime(data.fireRequestTime()); - ec.tla(data.tla()); - ec.sampleTime(data.sampleTime()); - ec.effectMarkingInTa(data.effectMarkingInTa()); - ec.externalId(data.externalId()); - ec.remainExplosionNumber(data.remainExplosionNumber()); - ec.participantId(data.participantId()); - ec.partyId(data.partyId()); - ec.properties(data.properties()); + ec.id = data.id; + ec.name = data.name; + ec.effectSourceId = data.effectSourceId; + ec.effectStateId = data.effectStateId; + ec.chargeStruct = data.chargeStruct; + ec.effectDuration = data.effectDuration; + ec.effectStart = data.effectStart; + ec.area = data.area; + ec.esmParticipantIds = data.esmParticipantIds; + ec.explosionGeometry = data.explosionGeometry; + ec.element = data.element; + ec.firePurposeId = data.firePurposeId; + ec.firingPosition = data.firingPosition; + ec.fireRequestTime = data.fireRequestTime; + ec.tla = data.tla; + ec.sampleTime = data.sampleTime; + ec.effectMarkingInTa = data.effectMarkingInTa; + ec.externalId = data.externalId; + ec.remainExplosionNumber = data.remainExplosionNumber; + ec.participantId = data.participantId; + ec.partyId = data.partyId; + ec.properties = data.properties; - ec.isCentral(data.isCentral()); - ec.isDeleted(data.isDeleted()); - ec.isUsed(data.isUsed()); + ec.isCentral = data.isCentral; + ec.isDeleted = data.isDeleted; + ec.isUsed = data.isUsed; return ec; } @@ -115,29 +115,29 @@ QVariant EffectClusterModel::data(const QModelIndex &idx, int role) const { case ColGearType: { - const int chargeTypeId = ec.chargeStruct().chargeTypeId(); + const int chargeTypeId = ec.chargeStruct.chargeTypeId; const int gearTypeId = m_pdmDtc->gearTypeIdFromChargeTypeId(chargeTypeId).value(0, 0); return m_pdmDtc->trGearTypeName(gearTypeId); } break; case ColIgniterType: - return m_pdmDtc->trIgniterTypeShortName(ec.chargeStruct().igniterTypeId()); + return m_pdmDtc->trIgniterTypeShortName(ec.chargeStruct.igniterTypeId); break; case ColFiringPosition: { - const Core::GeoPosition &firingPositionRef = ec.firingPosition(); - QString mgrs = LtsCoordTrans::mgrsFromGeographic(firingPositionRef.lon(), firingPositionRef.lat()); - if (!qFuzzyIsNull(firingPositionRef.z())) - mgrs.append(QStringLiteral(" ") + QString::number(firingPositionRef.z(), 'f', 2)); + const Core::GeoPosition &firingPositionRef = ec.firingPosition; + QString mgrs = LtsCoordTrans::mgrsFromGeographic(firingPositionRef.lon, firingPositionRef.lat); + if (!qFuzzyIsNull(firingPositionRef.z)) + mgrs.append(QStringLiteral(" ") + QString::number(firingPositionRef.z, 'f', 2)); return mgrs; } break; case ColExplosionGeometry: - return AreaEffectSimulation::toString(ec.explosionGeometry()); + return AreaEffectSimulation::toString(ec.explosionGeometry); break; case ColTlaZog: - return ec.tla(); + return ec.tla; break; @@ -149,11 +149,11 @@ QVariant EffectClusterModel::data(const QModelIndex &idx, int role) const case ColAnnotationString: - return QString::fromStdString(ec.annotationString()); + return QString::fromStdString(ec.annotationString); break; case ColZpElement: - return QString::fromStdString(ec.element()); + return QString::fromStdString(ec.element); break; @@ -174,11 +174,11 @@ QVariant EffectClusterModel::data(const QModelIndex &idx, int role) const QString tooltip(QStringLiteral("")); const QString &hdr = this->headerData(BcName, Qt::Horizontal, Qt::DisplayRole).toString(); - tooltip.append(QStringLiteral("

%1: %2

").arg(hdr, QString::fromStdString(ec.name()))); + tooltip.append(QStringLiteral("

%1: %2

").arg(hdr, QString::fromStdString(ec.name))); - bool bIsArtilleryOrMortar = m_gearClasses.contains(ProjectDataManagement::GearClass::Artillery) - || m_gearClasses.contains(ProjectDataManagement::GearClass::Mortar) - || m_gearClasses.contains(ProjectDataManagement::GearClass::Rocket); + bool bIsArtilleryOrMortar = m_gearClasses.contains(ProjectDataManagement::GearClass::GearClass_Artillery) + || m_gearClasses.contains(ProjectDataManagement::GearClass::GearClass_Mortar) + || m_gearClasses.contains(ProjectDataManagement::GearClass::GearClass_Rocket); toolTipHelper(this, idx, ColGearType, tooltip); if (bIsArtilleryOrMortar) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effect_cluster_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effect_cluster_model.h index ae1b4fd14..0639ac5e4 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effect_cluster_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effect_cluster_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effector.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effector.cpp index 8485747ab..2df735335 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effector.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_effector.cpp @@ -46,7 +46,7 @@ void AesEffector::setState(const AreaEffectSimulation::AesEffectorState &newStat { m_state = newState; - switch(newState.underlying()) + switch(newState) { case AreaEffectSimulation::AesEffectorState::EsNotReadyToFire: m_ui->lblState->setText(tr("Not ready to fire")); @@ -76,7 +76,7 @@ void AesEffector::setState(const AreaEffectSimulation::AesEffectorState &newStat void AesEffector::onPbNextStateClicked() { - switch (m_state.underlying()) { + switch (m_state) { case AreaEffectSimulation::AesEffectorState::EsFired: emit reportFired(); break; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_edit.cpp index 447431586..981037fb7 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_edit.cpp @@ -137,7 +137,7 @@ ExplosionEdit::ExplosionEdit(const QString &menuGroup, ExplosionType type, Proje m_ui->cbParty->setEnabled(false); } else - m_uiRequirements->addRequirement({m_ui->lbxParticipant, [this]() { return (m_participant.id() != 0); }}); + m_uiRequirements->addRequirement({m_ui->lbxParticipant, [this]() { return (m_participant.id != 0); }}); enaDisa(); @@ -181,7 +181,7 @@ void ExplosionEdit::retranslate() { QString title; - switch (m_gearClass.underlying()) + switch (m_gearClass) { case ProjectDataManagement::GearClass::GearClass_Artillery: if (m_type == etSingle) @@ -217,7 +217,7 @@ void ExplosionEdit::retranslate() m_ui->lblDimension->setText(tr("Dimension [m]:")); } - setFireButton(m_aesItem.effectStateId()); + setFireButton(m_aesItem.effectStateId); updateMaxLabel(false); } @@ -274,40 +274,40 @@ void ExplosionEdit::enableUiElements(bool enable) if (!enable) { bool hasChanges = hasUnsavedChanges(); - m_ui->sbDurationSeconds->setValue(m_aesItem.effectDuration() / 1000); + m_ui->sbDurationSeconds->setValue(m_aesItem.effectDuration / 1000); if (!hasChanges) __unchange__(); } - setFireButton(m_aesItem.effectStateId()); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + setFireButton(m_aesItem.effectStateId); + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); AesItem baseData; if (m_type == etSingle) { - ExplosionSingle singleData = m_dtc->explosionSingle(m_aesItem.id()); + ExplosionSingle singleData = m_dtc->explosionSingle(m_aesItem.id); setSingleData(singleData); baseData = singleData; } else if (m_type == etArea) { - ExplosionArea areaData = m_dtc->explosionArea(m_aesItem.id()); + ExplosionArea areaData = m_dtc->explosionArea(m_aesItem.id); setAreaData(areaData); baseData = areaData; } setBaseData(baseData, false); - setFireButton(baseData.effectStateId()); + setFireButton(baseData.effectStateId); __unchange__(); if (name != m_ui->leIdentifier->text()) m_ui->leIdentifier->setText(name); } - if (m_aesItem.effectStateId() == AesEffectState::EsPaused) + if (m_aesItem.effectStateId == AesEffectState::EsPaused) __unchange__(); } @@ -322,23 +322,23 @@ void ExplosionEdit::setBaseData(const AesItem &baseData, bool copy) m_aesItem = baseData; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromUtf8(baseData.name().c_str())); - int idx = m_ui->cbChargeType->findData(baseData.chargeStruct().chargeTypeId()); + m_ui->leIdentifier->setText(QString::fromUtf8(baseData.name.c_str())); + int idx = m_ui->cbChargeType->findData(baseData.chargeStruct.chargeTypeId); if (idx < 0) { - auto ct = m_chargeTypeMap[baseData.chargeStruct().chargeTypeId()].chargeType; - m_ui->cbChargeType->addItem(m_pdmDtc->trChargeTypeShortName(ct.id(), true), ct.id()); - idx = m_ui->cbChargeType->findData(ct.id()); + auto ct = m_chargeTypeMap[baseData.chargeStruct.chargeTypeId].chargeType; + m_ui->cbChargeType->addItem(m_pdmDtc->trChargeTypeShortName(ct.id, true), ct.id); + idx = m_ui->cbChargeType->findData(ct.id); } m_ui->cbChargeType->setCurrentIndex(idx); - m_ui->dteEffectStart->setMsecsSinceEpoch(baseData.effectStart().is_set() ? baseData.effectStart().get() : 0); - m_ui->sbDurationSeconds->setValue(baseData.effectDuration() / 1000); + m_ui->dteEffectStart->setMsecsSinceEpoch(baseData.effectStart.has_value() ? baseData.effectStart.get() : 0); + m_ui->sbDurationSeconds->setValue(baseData.effectDuration / 1000); m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(partyForItem(baseData))); - m_ui->cbEffectMarkingInTa->setChecked(baseData.effectMarkingInTa()); + m_ui->cbEffectMarkingInTa->setChecked(baseData.effectMarkingInTa); m_editable = m_editable && isModifiable() && !isOnlyNameModifiable() && m_session->app() != LtsAppDescriptor::App::OC; } @@ -362,7 +362,7 @@ bool ExplosionEdit::init(int aesItemId, bool copy, return false; bool readable = false; - switch (m_gearClass.underlying()) + switch (m_gearClass) { case ProjectDataManagement::GearClass::GearClass_Artillery: m_editable = (LtsSessionData::LtsSessionData::getInstance()->hasOperatorRight(OperatorRights::SingleExplosionsEditArtillery) && m_type == etSingle) || @@ -427,18 +427,18 @@ bool ExplosionEdit::init(int aesItemId, bool copy, const auto firePurposes = m_pdmDtc->firePurposes(); for (const auto &firePurpose : firePurposes) - m_ui->cbPurpose->addItem(m_pdmDtc->trFirePurposeName(firePurpose.id()), firePurpose.id()); + m_ui->cbPurpose->addItem(m_pdmDtc->trFirePurposeName(firePurpose.id), firePurpose.id); const auto chargesForGearClass = m_pdmDtc->chargesForGearClass(m_gearClass); for (const ProjectDataManagement::ChargeType &chargeType : chargesForGearClass) - m_chargeTypeMap[chargeType.id()].chargeType = chargeType; + m_chargeTypeMap[chargeType.id].chargeType = chargeType; const auto chargeAdmins = m_dtc->chargeAdministrations(); for (const ChargeAdministration &val : chargeAdmins) { - if (!m_chargeTypeMap.contains(val.chargeTypeId())) + if (!m_chargeTypeMap.contains(val.chargeTypeId)) continue; - m_chargeTypeMap[val.chargeTypeId()].available.insert(val.partyId(), val.amount() - val.planned()); + m_chargeTypeMap[val.chargeTypeId].available.insert(val.partyId, val.amount - val.planned); } m_ppmGuiCbxIfc->fillPartyComboBox(m_ui->cbParty); @@ -460,7 +460,7 @@ bool ExplosionEdit::init(int aesItemId, bool copy, baseData = areaData; } setBaseData(baseData, copy); - setFireButton(baseData.effectStateId()); + setFireButton(baseData.effectStateId); } else setFireButton(AreaEffectSimulation::AesEffectState::EsUnknown); @@ -479,22 +479,22 @@ bool ExplosionEdit::init(int aesItemId, bool copy, QString ExplosionEdit::dialogIdentifier() const { - switch (m_gearClass.underlying()) + switch (m_gearClass) { case ProjectDataManagement::GearClass::GearClass_Artillery: if (m_type == etSingle) - return m_aesItem.id() <= 0 ? QStringLiteral("AddExplosionSingleArtillery") : QStringLiteral("EditExplosionSingleArtillery%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddExplosionSingleArtillery") : QStringLiteral("EditExplosionSingleArtillery%1").arg(m_aesItem.id); else if (m_type == etArea) - return m_aesItem.id() <= 0 ? QStringLiteral("AddExplosionAreaArtillery") : QStringLiteral("EditExplosionAreaArtillery%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddExplosionAreaArtillery") : QStringLiteral("EditExplosionAreaArtillery%1").arg(m_aesItem.id); else - return m_aesItem.id() <= 0 ? QStringLiteral("AddExplosionSingleCentralArtillery") : QStringLiteral("EditExplosionSingleCentralArtillery%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddExplosionSingleCentralArtillery") : QStringLiteral("EditExplosionSingleCentralArtillery%1").arg(m_aesItem.id); case ProjectDataManagement::GearClass::GearClass_Mortar: if (m_type == etSingle) - return m_aesItem.id() <= 0 ? QStringLiteral("AddExplosionSingleMortar") : QStringLiteral("EditExplosionSingleMortar%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddExplosionSingleMortar") : QStringLiteral("EditExplosionSingleMortar%1").arg(m_aesItem.id); else if (m_type == etArea) - return m_aesItem.id() <= 0 ? QStringLiteral("AddExplosionAreaMortar") : QStringLiteral("EditExplosionAreaMortar%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddExplosionAreaMortar") : QStringLiteral("EditExplosionAreaMortar%1").arg(m_aesItem.id); else - return m_aesItem.id() <= 0 ? QStringLiteral("AddExplosionSingleCentralMortar") : QStringLiteral("EditExplosionSingleCentralMortar%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddExplosionSingleCentralMortar") : QStringLiteral("EditExplosionSingleCentralMortar%1").arg(m_aesItem.id); default: Q_ASSERT(false); break; @@ -506,13 +506,13 @@ QString ExplosionEdit::dialogIdentifier() const void ExplosionEdit::onChargeCountChanged(const AreaEffectSimulation::ChargeAdministration &data, DataModification modType) { - if (!m_chargeTypeMap.contains(data.chargeTypeId())) + if (!m_chargeTypeMap.contains(data.chargeTypeId)) return; - if (modType == DataModification::eRemoved || data.amount() - data.planned() <= 0) - m_chargeTypeMap[data.chargeTypeId()].available.remove(data.partyId()); + if (modType == DataModification::eRemoved || data.amount - data.planned <= 0) + m_chargeTypeMap[data.chargeTypeId].available.remove(data.partyId); else - m_chargeTypeMap[data.chargeTypeId()].available.insert(data.partyId(), data.amount() - data.planned()); + m_chargeTypeMap[data.chargeTypeId].available.insert(data.partyId, data.amount - data.planned); onPartyChanged(); updateCannonsRounds(true); updateMaxLabel(true); @@ -549,7 +549,7 @@ void ExplosionEdit::setFireButton(AreaEffectSimulation::AesEffectState effectSta effectState == AesEffectState::EsPrepared || effectState == AesEffectState::EsCreated || effectState == AesEffectState::EsPaused) - && m_aesItem.id() > 0) + && m_aesItem.id > 0) m_ui->pbFire->setEnabled(true); else m_ui->pbFire->setEnabled(false); @@ -558,7 +558,7 @@ void ExplosionEdit::setFireButton(AreaEffectSimulation::AesEffectState effectSta void ExplosionEdit::updateCannonsRounds(bool modifiedFromExternal) { - if (m_ui->sbCannons->value() > maxAvailableRounds() && m_editable && m_aesItem.id() <= 0) + if (m_ui->sbCannons->value() > maxAvailableRounds() && m_editable && m_aesItem.id <= 0) { m_ui->sbCannons->setValue(1); m_ui->sbRounds->setValue(1); @@ -586,64 +586,64 @@ void ExplosionEdit::updateMaxLabel(bool modifiedFromExternal) quint32 ExplosionEdit::partyForItem(const AesItem &aesItem) const { - if (aesItem.participantId().is_set()) + if (aesItem.participantId.has_value()) { - if (m_participant.id() == aesItem.participantId().get()) - return m_participant.partyId(); + if (m_participant.id == aesItem.participantId.get()) + return m_participant.partyId; else - return m_ppmDtc->participant(aesItem.participantId().get()).partyId(); + return m_ppmDtc->participant(aesItem.participantId.get()).partyId; } - else if (aesItem.partyId().is_set()) - return aesItem.partyId().get(); + else if (aesItem.partyId.has_value()) + return aesItem.partyId.get(); return {}; } void ExplosionEdit::setSingleData(const ExplosionSingle &singleData) { - QPointF impactPosition(singleData.impactPosition().lon(), singleData.impactPosition().lat()); + QPointF impactPosition(singleData.impactPosition.lon, singleData.impactPosition.lat); if (!impactPosition.isNull()) m_ui->positionEdit->setCoordinate(impactPosition); - m_ui->dteRequestTime->setMsecsSinceEpoch(singleData.fireRequestTime()); - m_ui->cbPurpose->setCurrentText(QString::fromUtf8(singleData.purpose().c_str())); - m_ui->sbAltitude->setValue(singleData.altitude()); + m_ui->dteRequestTime->setMsecsSinceEpoch(singleData.fireRequestTime); + m_ui->cbPurpose->setCurrentText(QString::fromUtf8(singleData.purpose.c_str())); + m_ui->sbAltitude->setValue(singleData.altitude); - if (m_aesItem.id() > 0) - m_chargeTypeMap[singleData.chargeStruct().chargeTypeId()].available[partyForItem(singleData)] += 1; + if (m_aesItem.id > 0) + m_chargeTypeMap[singleData.chargeStruct.chargeTypeId].available[partyForItem(singleData)] += 1; - const double radius = m_pdmDtc->impactRadius(singleData.chargeStruct().chargeTypeId(),singleData.chargeStruct().igniterTypeId(), singleData.chargeStruct().igniterFunctionId()); + const double radius = m_pdmDtc->impactRadius(singleData.chargeStruct.chargeTypeId,singleData.chargeStruct.igniterTypeId, singleData.chargeStruct.igniterFunctionId); m_ui->sbDimensionX->setValue(2 * radius); } void ExplosionEdit::setAreaData(const ExplosionArea &areaData, bool copy) { - const Area &area = areaData.area(); - if (!qFuzzyCompare(area.cornerBottomLeft().lon(), 0) || - !qFuzzyCompare(area.cornerBottomLeft().lat(), 0)) + const Area &area = areaData.area; + if (!qFuzzyCompare(area.cornerBottomLeft.lon, 0) || + !qFuzzyCompare(area.cornerBottomLeft.lat, 0)) { - QPointF bottomLeft(area.cornerBottomLeft().lon(), area.cornerBottomLeft().lat()); - m_ui->positionEdit->setCoordinate(Polygons::bottomLeft2CenterPoint(bottomLeft, area.width(), area.height(), area.rotation())); + QPointF bottomLeft(area.cornerBottomLeft.lon, area.cornerBottomLeft.lat); + m_ui->positionEdit->setCoordinate(Polygons::bottomLeft2CenterPoint(bottomLeft, area.width, area.height, area.rotation)); } - m_ui->sbDimensionX->setValue(area.width()); - m_ui->sbDimensionY->setValue(area.height()); - m_ui->sbAimingAxis->setValue(fmod((90.0 + area.rotation()) * 6400 / 360, 6400)); - m_ui->sbCannons->setValue(areaData.cannonCount() == 0 ? 4 : areaData.cannonCount()); - m_ui->sbRounds->setValue(areaData.cannonRounds() == 0 ? 9 : areaData.cannonRounds()); - if (m_aesItem.id() > 0 && !copy) + m_ui->sbDimensionX->setValue(area.width); + m_ui->sbDimensionY->setValue(area.height); + m_ui->sbAimingAxis->setValue(fmod((90.0 + area.rotation) * 6400 / 360, 6400)); + m_ui->sbCannons->setValue(areaData.cannonCount == 0 ? 4 : areaData.cannonCount); + m_ui->sbRounds->setValue(areaData.cannonRounds == 0 ? 9 : areaData.cannonRounds); + if (m_aesItem.id > 0 && !copy) { - if (!m_chargeTypeMap.contains(areaData.chargeStruct().chargeTypeId())) - ERROR_LOG(m_logger) << "SetAreaData called with a charge Type, that has doesn't match. Id " << areaData.chargeStruct().chargeTypeId() << "is not in m_chargeTypeMap"; - if (!areaData.partyId().is_set()) + if (!m_chargeTypeMap.contains(areaData.chargeStruct.chargeTypeId)) + ERROR_LOG(m_logger) << "SetAreaData called with a charge Type, that has doesn't match. Id " << areaData.chargeStruct.chargeTypeId << "is not in m_chargeTypeMap"; + if (!areaData.partyId.has_value()) ERROR_LOG(m_logger) << "SetAreaData called without a party set. m_chargeTypeMap might be corrupted."; - m_chargeTypeMap[areaData.chargeStruct().chargeTypeId()].available[areaData.partyId().get()] += areaData.cannonCount() * areaData.cannonRounds(); + m_chargeTypeMap[areaData.chargeStruct.chargeTypeId].available[areaData.partyId.get()] += areaData.cannonCount * areaData.cannonRounds; } - m_ui->dteRequestTime->setMsecsSinceEpoch(areaData.fireRequestTime()); - m_ui->cbPurpose->setCurrentText(QString::fromUtf8(areaData.purpose().c_str())); - m_ui->sbAltitude->setValue(areaData.altitude()); + m_ui->dteRequestTime->setMsecsSinceEpoch(areaData.fireRequestTime); + m_ui->cbPurpose->setCurrentText(QString::fromUtf8(areaData.purpose.c_str())); + m_ui->sbAltitude->setValue(areaData.altitude); } @@ -723,7 +723,7 @@ void ExplosionEdit::onPartyChanged() for (const Charges &charge : std::as_const(m_chargeTypeMap)) { if (charge.available.contains(partyId) && charge.available[partyId] > 0) - m_ui->cbChargeType->addItem(m_pdmDtc->trChargeTypeShortName(charge.chargeType.id(), true), charge.chargeType.id()); + m_ui->cbChargeType->addItem(m_pdmDtc->trChargeTypeShortName(charge.chargeType.id, true), charge.chargeType.id); } m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(chargeTypeId) < 0 ? 0 : m_ui->cbChargeType->findData(chargeTypeId)); @@ -761,19 +761,19 @@ bool ExplosionEdit::apply() if (m_type == etSingle) { - const ExplosionSingleModifyRequest req(m_aesItem.id(), + const ExplosionSingleModifyRequest req(m_aesItem.id, name, - LtsUtils::toOptional(effectStart), - m_aesItem.effectSourceId(), + LtsUtils::toOptional(static_cast(effectStart)), + m_aesItem.effectSourceId, chargeType, pos, LtsUtils::toOptional(partyId), LtsUtils::toOptional(0), - fireRequestTime, + static_cast(fireRequestTime), altitude, purpose, m_ui->cbEffectMarkingInTa->isChecked(), - dds::core::optional()); + dds::core::optional()); m_requestHelper->addRequest([this, req]() { @@ -782,22 +782,22 @@ bool ExplosionEdit::apply() } else if (m_type == etArea) { - const ExplosionAreaModifyRequest req(m_aesItem.id(), + const ExplosionAreaModifyRequest req(m_aesItem.id, name, - LtsUtils::toOptional(effectStart), + LtsUtils::toOptional(static_cast(effectStart)), duration, - m_aesItem.effectSourceId(), + m_aesItem.effectSourceId, chargeType, area, LtsUtils::toOptional(partyId), LtsUtils::toOptional(0), cannons, rounds, - fireRequestTime, + static_cast(fireRequestTime), altitude, purpose, m_ui->cbEffectMarkingInTa->isChecked(), - dds::core::optional()); + dds::core::optional()); m_requestHelper->addRequest([this, req]() { return m_ftc->explosionAreaModifyRequest(req, this); @@ -810,16 +810,16 @@ bool ExplosionEdit::apply() void ExplosionEdit::onFireClicked() { m_ui->pbFire->setEnabled(false); - if ((m_aesItem.effectStateId() != AesEffectState::EsActivated && - m_aesItem.effectStateId() != AesEffectState::EsPaused && - m_aesItem.effectStateId() != AesEffectState::EsCreated && - m_aesItem.effectStateId() != AesEffectState::EsPrepared) - || m_aesItem.id() <= 0) + if ((m_aesItem.effectStateId != AesEffectState::EsActivated && + m_aesItem.effectStateId != AesEffectState::EsPaused && + m_aesItem.effectStateId != AesEffectState::EsCreated && + m_aesItem.effectStateId != AesEffectState::EsPrepared) + || m_aesItem.id <= 0) return; - if (m_aesItem.effectStateId() == AesEffectState::EsCreated || - m_aesItem.effectStateId() == AesEffectState::EsPrepared) + if (m_aesItem.effectStateId == AesEffectState::EsCreated || + m_aesItem.effectStateId == AesEffectState::EsPrepared) { m_ui->dteEffectStart->setMsecsSinceEpoch(m_session->partitionTime() + 3000); m_ui->dteEffectStart->setChecked(true); @@ -835,9 +835,9 @@ void ExplosionEdit::onFireClicked() m_requestHelper->addRequest([ = ]() { - return m_ftc->explosionAreaPauseResumeRequest(ExplosionAreaPauseResumeRequest(m_aesItem.id(), - m_aesItem.effectStateId() != AesEffectState::EsActivated, - dds::core::optional(), + return m_ftc->explosionAreaPauseResumeRequest(ExplosionAreaPauseResumeRequest(m_aesItem.id, + m_aesItem.effectStateId != AesEffectState::EsActivated, + dds::core::optional(), dds::core::optional(), dds::core::optional()) , this); @@ -849,7 +849,7 @@ void ExplosionEdit::onParticipantClicked() { ParticipantManagement::ParticipantSelection *ps = new ParticipantManagement::ParticipantSelection(m_session, this); ps->init(); - ps->setParticipantSelected(m_participant.partyId(), m_participant.id()); + ps->setParticipantSelected(m_participant.partyId, m_participant.id); connect(ps, &ParticipantManagement::ParticipantSelection::selectedParticipants, this, &ExplosionEdit::onParticipant); ps->exec(); @@ -860,16 +860,16 @@ void ExplosionEdit::onParticipant(const QVector &participants) if (participants.isEmpty()) return; - if (participants[0] == m_participant.id()) + if (participants[0] == m_participant.id) return; m_participant = m_ppmDtc->participant(participants[0]); m_symbolWatcher->setSymbolResult(m_asbIfc->findImage(m_participant)); - m_ui->lblDesignator->setText(QString::fromStdString(m_participant.designator())); - m_ui->lblTactIdentifier->setText(QString::fromStdString(m_participant.tacticalIdentifier())); + m_ui->lblDesignator->setText(QString::fromStdString(m_participant.designator)); + m_ui->lblTactIdentifier->setText(QString::fromStdString(m_participant.tacticalIdentifier)); - m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(m_participant.partyId())); + m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(m_participant.partyId)); slotChangesMade(); } } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_edit.h index 51206b43d..ed984f7df 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_gui_plugin.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_gui_plugin.cpp index 07edb270f..461cd2c2d 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_gui_plugin.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_gui_plugin.cpp @@ -232,7 +232,7 @@ AreaEffectSimulation::BaseEdit *InterfaceImpl::showEditWindow(int aesEntityId, b BaseEdit *InterfaceImpl::showEditWindow(int aesEntityId, ProjectDataManagement::EffectSource effectSource, QWidget *parent) { - switch (effectSource.underlying()) + switch (effectSource) { case ProjectDataManagement::EffectSource::ES_ADLER_STANDALONE: { @@ -326,9 +326,9 @@ LtsWidgets::LtsDialog *InterfaceImpl::onShowExplosionClusterListDialog(QWidget * ExplosionList *listWidget; listWidget = new ExplosionClusterList(menuGroup(), - {ProjectDataManagement::GearClass::Artillery, - ProjectDataManagement::GearClass::Mortar, - ProjectDataManagement::GearClass::Rocket}, + {ProjectDataManagement::GearClass::GearClass_Artillery, + ProjectDataManagement::GearClass::GearClass_Mortar, + ProjectDataManagement::GearClass::GearClass_Rocket}, parent); if (listWidget->init(m_session)) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_gui_plugin.h index ea2e2ead9..bffab2775 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_explosion_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_list.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_list.cpp index c53d59af2..a3a2bfd10 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_list.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_list.cpp @@ -27,7 +27,7 @@ bool ExplosionList::init(LtsSession::LtsSession *session) return false; m_bHasAddEditOperatorRights = false; - switch (m_gearClass.underlying()) + switch (m_gearClass) { case ProjectDataManagement::GearClass::GearClass_Artillery: @@ -288,7 +288,7 @@ void ExplosionAreaList::createModel() ExplosionClusterList::ExplosionClusterList(const QString &menuGroup, const QVector &gcs, QWidget *parent) - : ExplosionList(menuGroup, etExplosionCluster, ProjectDataManagement::GearClass::Artillery, parent), m_model(nullptr), m_gearClasses(gcs) + : ExplosionList(menuGroup, etExplosionCluster, ProjectDataManagement::GearClass::GearClass_Artillery, parent), m_model(nullptr), m_gearClasses(gcs) { } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_list.h index ad7cee195..814d52db5 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosion_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_area_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_area_model.h index b4c337704..9faee5830 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_area_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_area_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit.cpp index 20b25aec6..7a4897044 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit.cpp @@ -81,8 +81,8 @@ QPair getMinMaxDistance(ProjectDataManagement::GearClass gearClass, in static QHash> contraintsDistance; if (contraintsDistance.isEmpty()) { - contraintsDistance.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {3500, 40000}); - contraintsDistance.insert(static_cast(ProjectDataManagement::GearClass::Mortar), {800, 7800}); + contraintsDistance.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {3500, 40000}); + contraintsDistance.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Mortar), {800, 7800}); } @@ -90,8 +90,8 @@ QPair getMinMaxDistance(ProjectDataManagement::GearClass gearClass, in static QHash> contraintsDistanceVulcano; if (contraintsDistanceVulcano.isEmpty()) { - contraintsDistanceVulcano.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {10000, 70000}); - contraintsDistanceVulcano.insert(static_cast(ProjectDataManagement::GearClass::Rocket), {10000, 70000}); + contraintsDistanceVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {10000, 70000}); + contraintsDistanceVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Rocket), {10000, 70000}); } if (chargeTypeIdIsVulcano(chargeTypeId)) { @@ -121,15 +121,15 @@ QPair getMinMaxFlightDurationSec(ProjectDataManagement::GearClass gear static QHash> contraintsFlightDuration; if (contraintsFlightDuration.isEmpty()) { - contraintsFlightDuration.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {6, 150}); - contraintsFlightDuration.insert(static_cast(ProjectDataManagement::GearClass::Mortar), {20, 60}); + contraintsFlightDuration.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {6, 150}); + contraintsFlightDuration.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Mortar), {20, 60}); } static QHash> contraintsFlightDurationVulcano; if (contraintsFlightDurationVulcano.isEmpty()) { - contraintsFlightDurationVulcano.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {0, 999}); - contraintsFlightDurationVulcano.insert(static_cast(ProjectDataManagement::GearClass::Rocket), {0, 999}); + contraintsFlightDurationVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {0, 999}); + contraintsFlightDurationVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Rocket), {0, 999}); } if (chargeTypeIdIsVulcano(chargeTypeId)) { @@ -165,15 +165,15 @@ QPair getMinMaxPeakHeight(ProjectDataManagement::GearClass gearClass, static QHash> contraintsPeak; if (contraintsPeak.isEmpty()) { - contraintsPeak.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {250, 15000}); - contraintsPeak.insert(static_cast(ProjectDataManagement::GearClass::Mortar), {500, 3000}); + contraintsPeak.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {250, 15000}); + contraintsPeak.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Mortar), {500, 3000}); } static QHash> contraintsPeakVulcano; if (contraintsPeakVulcano.isEmpty()) { - contraintsPeakVulcano.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {1000, 37500}); - contraintsPeakVulcano.insert(static_cast(ProjectDataManagement::GearClass::Rocket), {1000, 37500}); + contraintsPeakVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {1000, 37500}); + contraintsPeakVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Rocket), {1000, 37500}); } if (chargeTypeIdIsVulcano(chargeTypeId)) { @@ -278,7 +278,7 @@ ExplosionsEdit::ExplosionsEdit(const QString &menuGroup, QWidget *parent) - if (!m_explosionClusterData.isObjectModifiable()) + if (!m_explosionClusterData.isObjectModifiable) return true; bool bEffectStartValid = true; @@ -416,7 +416,7 @@ bool ExplosionsEdit::init(int aesItemId, bool copy, LtsSession::LtsSession *sess } - m_explosionClusterData.explosionGeometry(AreaEffectSimulation::AesExplosionGeometry::EgArea); + m_explosionClusterData.explosionGeometry = AreaEffectSimulation::AesExplosionGeometry::EgArea; onGeometrySelected(static_cast(AreaEffectSimulation::AesExplosionGeometry::EgArea)); @@ -464,14 +464,14 @@ bool ExplosionsEdit::init(int aesItemId, bool copy, LtsSession::LtsSession *sess { const ExplosionCluster &exData = m_dtc->explosionCluster(aesItemId); setExplosionClusterData(exData); - m_ui->gbEffectMarkingInTa->setChecked(exData.effectMarkingInTa()); + m_ui->gbEffectMarkingInTa->setChecked(exData.effectMarkingInTa); if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); - m_explosionClusterData.id(m_aesItem.id()); - m_explosionClusterData.effectStateId(m_aesItem.effectStateId()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; + m_explosionClusterData.id = m_aesItem.id; + m_explosionClusterData.effectStateId = m_aesItem.effectStateId; } } connect(m_ppmDtc.get(), &ParticipantManagement::Interface::Dtc::participantChanged, this, &ExplosionsEdit::onPartyChanged, Qt::UniqueConnection); @@ -514,7 +514,7 @@ bool ExplosionsEdit::init(int aesItemId, bool copy, LtsSession::LtsSession *sess doCalculations(); - RocketUtility::enaDisaWirkmittel(m_ui->cbGearClass, m_currentGeometry.underlying()); + RocketUtility::enaDisaWirkmittel(m_ui->cbGearClass, m_currentGeometry); DEBUG_LOG(m_logger) << LOGFUNCTION << " END"; @@ -525,12 +525,12 @@ void ExplosionsEdit::setExplosionClusterData(const ExplosionCluster &ecData) { DEBUG_LOG(m_logger) << LOGFUNCTION << " START, ecData=" << ecData; - m_ui->leZpNumber->setText(QString::fromStdString(ecData.name())); - m_ui->leElement->setText(QString::fromStdString(ecData.element())); - m_ui->dteEffectStart->setMsecsSinceEpoch(ecData.effectStart().is_set() ? ecData.effectStart().get() : 0); + m_ui->leZpNumber->setText(QString::fromStdString(ecData.name)); + m_ui->leElement->setText(QString::fromStdString(ecData.element)); + m_ui->dteEffectStart->setMsecsSinceEpoch(ecData.effectStart.has_value() ? ecData.effectStart.get() : 0); - const AreaEffectSimulation::AesExplosionGeometry geometryType = static_cast(ecData.explosionGeometry()); + const AreaEffectSimulation::AesExplosionGeometry geometryType = static_cast(ecData.explosionGeometry); switch (geometryType) { case AreaEffectSimulation::AesExplosionGeometry::EgAimPoint: @@ -554,40 +554,40 @@ void ExplosionsEdit::setExplosionClusterData(const ExplosionCluster &ecData) } onGeometrySelected(static_cast(geometryType)); - m_ui->sbDurationSec->setValue(ecData.effectDuration() / 1000); + m_ui->sbDurationSec->setValue(ecData.effectDuration / 1000); { QSignalBlocker locked(m_ui->cbGearClass); - ProjectDataManagement::GearClass gc = m_pdmDtc->gearClassFromChargeTypeId(ecData.chargeStruct().chargeTypeId()); - m_ui->cbGearClass->setCurrentIndex(m_ui->cbGearClass->findData(static_cast(gc.underlying()))); + ProjectDataManagement::GearClass gc = m_pdmDtc->gearClassFromChargeTypeId(ecData.chargeStruct.chargeTypeId); + m_ui->cbGearClass->setCurrentIndex(m_ui->cbGearClass->findData(static_cast(gc))); onGearClassChanged(); } { QSignalBlocker locked(m_ui->cbParty); - if (ecData.partyId().is_set()) + if (ecData.partyId.has_value()) { - m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(ecData.partyId().get())); + m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(ecData.partyId.get())); onPartyChanged(); } } { - if (ecData.participantId().is_set()) + if (ecData.participantId.has_value()) { - m_ui->cbParticipantUnits->setCurrentIndex(m_ui->cbParticipantUnits->findData(ecData.participantId().get())); + m_ui->cbParticipantUnits->setCurrentIndex(m_ui->cbParticipantUnits->findData(ecData.participantId.get())); onParticipantUnitChanged({}); } } FlightCurve fc(-1, -1, -1, -1, -1, -1, -1, -1); - if (ecData.flightCurve().is_set()) - fc = ecData.flightCurve().get(); + if (ecData.flightCurve.has_value()) + fc = ecData.flightCurve.get(); - if (fc.dropAngle() <= s_dropAngleDown) + if (fc.dropAngle <= s_dropAngleDown) { m_ui->rbDropAngleDown->setChecked(true); m_ui->rbDropAngleUp->setChecked(false); @@ -598,65 +598,65 @@ void ExplosionsEdit::setExplosionClusterData(const ExplosionCluster &ecData) m_ui->rbDropAngleUp->setChecked(true); } - m_ui->sbCannons->setValue(ecData.impactCount()); - m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(ecData.chargeStruct().chargeTypeId())); - m_ui->cbIgniterType->setCurrentIndex(m_ui->cbIgniterType->findData(ecData.chargeStruct().igniterTypeId())); - m_ui->cbFirePurpose->setCurrentIndex(m_ui->cbFirePurpose->findData(ecData.firePurposeId())); + m_ui->sbCannons->setValue(ecData.impactCount); + m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(ecData.chargeStruct.chargeTypeId)); + m_ui->cbIgniterType->setCurrentIndex(m_ui->cbIgniterType->findData(ecData.chargeStruct.igniterTypeId)); + m_ui->cbFirePurpose->setCurrentIndex(m_ui->cbFirePurpose->findData(ecData.firePurposeId)); - m_ui->sbZog->setValue(ecData.tla()); + m_ui->sbZog->setValue(ecData.tla); - const AreaEffectSimulation::Area &areaRef = ecData.area(); - const QPointF bottomLeft(areaRef.cornerBottomLeft().lon(), areaRef.cornerBottomLeft().lat()); - const QPointF centerpoint = Polygons::bottomLeft2CenterPoint(bottomLeft, areaRef.width(), areaRef.height(), areaRef.rotation()); + const AreaEffectSimulation::Area &areaRef = ecData.area; + const QPointF bottomLeft(areaRef.cornerBottomLeft.lon, areaRef.cornerBottomLeft.lat); + const QPointF centerpoint = Polygons::bottomLeft2CenterPoint(bottomLeft, areaRef.width, areaRef.height, areaRef.rotation); if (!bottomLeft.isNull()) { m_ui->positionEdit->setCoordinate(centerpoint); setCoord(centerpoint); } - if (ecData.explosionGeometry().underlying() == AreaEffectSimulation::AesExplosionGeometry::EgRadial) + if (ecData.explosionGeometry == AreaEffectSimulation::AesExplosionGeometry::EgRadial) { - m_ui->sbDimensionY_Tiefe->setValue(areaRef.height() / 2); - m_ui->sbDimensionX_BreiteRadius->setValue(areaRef.width() / 2); + m_ui->sbDimensionY_Tiefe->setValue(areaRef.height / 2); + m_ui->sbDimensionX_BreiteRadius->setValue(areaRef.width / 2); m_ui->sbAimingAxis->setValue(0); } else { - m_ui->sbDimensionY_Tiefe->setValue(areaRef.height()); - m_ui->sbDimensionX_BreiteRadius->setValue(areaRef.width()); - m_ui->sbAimingAxis->setValue(fmod((90.0 + areaRef.rotation()) * 6400 / 360, 6400)); + m_ui->sbDimensionY_Tiefe->setValue(areaRef.height); + m_ui->sbDimensionX_BreiteRadius->setValue(areaRef.width); + m_ui->sbAimingAxis->setValue(fmod((90.0 + areaRef.rotation) * 6400 / 360, 6400)); } - if (!ecData.esmParticipantIds().empty()) + if (!ecData.esmParticipantIds.empty()) { - m_ui->cbActors->setCurrentIndex(m_ui->cbActors->findData(ecData.esmParticipantIds().at(0))); - if (ecData.esmParticipantIds().size() > 1) - m_ui->cbActors_2->setCurrentIndex(m_ui->cbActors_2->findData(ecData.esmParticipantIds().at(1))); + m_ui->cbActors->setCurrentIndex(m_ui->cbActors->findData(ecData.esmParticipantIds.at(0))); + if (ecData.esmParticipantIds.size() > 1) + m_ui->cbActors_2->setCurrentIndex(m_ui->cbActors_2->findData(ecData.esmParticipantIds.at(1))); } { - if (fc.requestedFlightDuration() > 0) + if (fc.requestedFlightDuration > 0) { switchTo(FlighDurationOrPeakHeight::FDPH_flightDuration); - setValueAccordingContraints(fc.requestedFlightDuration() / 1000.0, FlighDurationOrPeakHeight::FDPH_flightDuration); + setValueAccordingContraints(fc.requestedFlightDuration / 1000.0, FlighDurationOrPeakHeight::FDPH_flightDuration); } - if (fc.requestedRelativePeakHeight() > 0) + if (fc.requestedRelativePeakHeight > 0) { switchTo(FlighDurationOrPeakHeight::FDPH_peakHeight); - setValueAccordingContraints(fc.requestedRelativePeakHeight(), FlighDurationOrPeakHeight::FDPH_peakHeight); + setValueAccordingContraints(fc.requestedRelativePeakHeight, FlighDurationOrPeakHeight::FDPH_peakHeight); } LaserGuiding lg(0, 0, -1, std::numeric_limits::min()); - if (ecData.laserGuiding().is_set()) - lg = ecData.laserGuiding().get(); + if (ecData.laserGuiding.has_value()) + lg = ecData.laserGuiding.get(); - m_ui->sbLcAttack_Prf->setValue(lg.lcAttack()); - m_ui->sbLcTermination_Prf->setValue(lg.lcTermination()); + m_ui->sbLcAttack_Prf->setValue(lg.lcAttack); + m_ui->sbLcTermination_Prf->setValue(lg.lcTermination); - m_ui->spCloudBase->setValue(lg.cloudBase()); + m_ui->spCloudBase->setValue(lg.cloudBase); onExplosionClusterChanged(ecData, DataModification::eAdded); } @@ -700,7 +700,7 @@ void ExplosionsEdit::onChargeTypeChanged() setMinMaxConstraints(phfd, gearClassType, chargeTypeId); - if (m_currentGeometry.underlying() == AreaEffectSimulation::AesExplosionGeometry::EgPoint) + if (m_currentGeometry == AreaEffectSimulation::AesExplosionGeometry::EgPoint) { int igniterTypeId = m_ui->cbIgniterType->currentData().toInt(); const double impactRadius = m_pdmDtc->impactRadius(chargeTypeId, igniterTypeId, 0); @@ -790,7 +790,7 @@ void ExplosionsEdit::getPosition() m_previewPolygon.clear(); m_previewCircleRadius = 0.0; - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AreaEffectSimulation::AesExplosionGeometry::EgArea: { @@ -920,7 +920,7 @@ void ExplosionsEdit::onPolylineData(const QPolygonF &polyline) m_ui->sbDimensionX_BreiteRadius->setValue(distance); const Core::GeoPosition coordGeo2(utm2.geographic().x(), utm2.geographic().y(), 0); - const double height2 = getElevation(coordGeo2.lon(), coordGeo2.lat()); + const double height2 = getElevation(coordGeo2.lon, coordGeo2.lat); m_ui->sbHeight2SBox->setValue(height2); DEBUG_LOG(m_logger) << "sbHeight2SBox setValue=" << height2; @@ -948,7 +948,7 @@ void ExplosionsEdit::setCoord(const QPointF &coord) const Core::GeoPosition coordGeo(coord.x(), coord.y(), 0); m_coordGeo = coordGeo; - const double height = getElevation(coordGeo.lon(), coordGeo.lat()); + const double height = getElevation(coordGeo.lon, coordGeo.lat); m_ui->sbHeight1SBox->setValue(height); updateActorComboBox(coordGeo); @@ -986,8 +986,8 @@ void ExplosionsEdit::fillParticipantUnit() for (auto &superiorId : superiorIds) { const ParticipantManagement::Participant &part = m_ppmDtc->participant(superiorId); - unitList.push_back(std::tuple(QString::fromStdString(part.designator()) + QStringLiteral(" (%1)").arg(units.value(superiorId).count()), - part.id(), + unitList.push_back(std::tuple(QString::fromStdString(part.designator) + QStringLiteral(" (%1)").arg(units.value(superiorId).count()), + part.id, units.value(superiorId).count())); } std::sort(unitList.begin(), unitList.end()); @@ -1065,7 +1065,7 @@ void ExplosionsEdit::onAimingAxisChanged(int aimingAxis) m_ui->positionEdit_2->setCoordinate(utm2New.geographic()); const Core::GeoPosition coordGeo(utm2New.geographic().x(), utm2New.geographic().y(), 0); - const double height = getElevation(coordGeo.lon(), coordGeo.lat()); + const double height = getElevation(coordGeo.lon, coordGeo.lat); m_ui->sbHeight1SBox->setValue(height); } @@ -1273,7 +1273,7 @@ void ExplosionsEdit::doCalculations(bool executeEnableUiElements) return; - if ((m_explosionClusterData.effectStateId() == AesEffectState::EsPaused) || (m_explosionClusterData.effectStateId() == AesEffectState::EsExpired)) + if ((m_explosionClusterData.effectStateId == AesEffectState::EsPaused) || (m_explosionClusterData.effectStateId == AesEffectState::EsExpired)) return; DoCalculationsExitGuard exitGuard(this, executeEnableUiElements); @@ -1421,7 +1421,7 @@ void ExplosionsEdit::doCalculations(bool executeEnableUiElements) return; } - const qint64 calculatedFlightDurationMsec = trajectoryOut.back().relativeTime(); + const qint64 calculatedFlightDurationMsec = trajectoryOut.back().relativeTime; m_temporaryData.m_estimatedFlightDurationMsec = Polygons::explosionClusterEstimatedMaxFlightDuration2DMSec(calculatedFlightDurationMsec); m_temporaryData.m_idealTapAbsoluteGeoOut = idealTapAbsoluteGeoOut; @@ -1435,7 +1435,7 @@ void ExplosionsEdit::doCalculations(bool executeEnableUiElements) .arg(std::round(betaRad * LtsCoordTrans::rad2deg() * 10) / 10) .arg(std::round(vOut)) .arg(std::round(calculatedFlightDurationMsec / 1000.0)) - .arg(std::round(m_temporaryData.m_idealTapAbsoluteGeoOut.z())); + .arg(std::round(m_temporaryData.m_idealTapAbsoluteGeoOut.z)); QSignalBlocker locked(m_ui->sBox_flightDuration); m_ui->sBox_flightDuration->setValue(std::round(calculatedFlightDurationMsec / 1000.0)); @@ -1601,12 +1601,12 @@ void ExplosionsEdit::onPartitionTimeChanged(qint64 newPartitionTimeMsec) QString ExplosionsEdit::dialogIdentifier() const { - return m_aesItem.id() <= 0 ? QStringLiteral("AddExplosionsArtillery") : QStringLiteral("EditExplosionsArtillery%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddExplosionsArtillery") : QStringLiteral("EditExplosionsArtillery%1").arg(m_aesItem.id); } void ExplosionsEdit::onExplosionClusterChanged(const ExplosionCluster &ecData, DataModification modType) { - if (ecData.id() != m_aesItem.id()) + if (ecData.id != m_aesItem.id) return; BaseEdit::onAreaChanged(ecData, modType); @@ -1620,7 +1620,7 @@ void ExplosionsEdit::onExplosionClusterChanged(const ExplosionCluster &ecData, D if ( - (!ecData.isObjectModifiable())) + (!ecData.isObjectModifiable)) { INFO_LOG(m_logger) << " object becames not modifiable"; enableUiFireButton(); @@ -1635,13 +1635,13 @@ void ExplosionsEdit::onExplosionClusterChanged(const ExplosionCluster &ecData, D } m_explosionClusterData = ecData; - m_currentGeometry = m_explosionClusterData.explosionGeometry(); + m_currentGeometry = m_explosionClusterData.explosionGeometry; - if (ecData.flightCurve().is_set()) + if (ecData.flightCurve.has_value()) { - const FlightCurve &fc = ecData.flightCurve().get(); - m_ui->leCalcFlightDuration->setText(QString(QStringLiteral("%1 sec")).arg(fc.calculatedFlightDuration() / 1000.0)); - m_ui->leCalcPeakHeight->setText(QString(QStringLiteral("%1 m abs")).arg(fc.calculatedPeakHeightAbs())); + const FlightCurve &fc = ecData.flightCurve.get(); + m_ui->leCalcFlightDuration->setText(QString(QStringLiteral("%1 sec")).arg(fc.calculatedFlightDuration / 1000.0)); + m_ui->leCalcPeakHeight->setText(QString(QStringLiteral("%1 m abs")).arg(fc.calculatedPeakHeightAbs)); } else { @@ -1649,13 +1649,13 @@ void ExplosionsEdit::onExplosionClusterChanged(const ExplosionCluster &ecData, D m_ui->leCalcPeakHeight->setText(QString(QStringLiteral("- m abs"))); } - m_ui->leDescription->setText(QString::fromStdString(ecData.annotationString())); + m_ui->leDescription->setText(QString::fromStdString(ecData.annotationString)); m_ui->leDescription->setToolTip(m_ui->leDescription->text()); if (!m_ui->sbDurationSec->isEnabled()) { const bool hasChanges = hasUnsavedChanges(); - m_ui->sbDurationSec->setValue(m_explosionClusterData.effectDuration() / 1000); + m_ui->sbDurationSec->setValue(m_explosionClusterData.effectDuration / 1000); if (!hasChanges) __unchange__(); } @@ -1740,10 +1740,10 @@ void ExplosionsEdit::retranslate() void ExplosionsEdit::enableUiElements() { DEBUG_LOG(m_logger) << " enableUiElements()" - << ", m_explosionClusterData.id() = " << m_explosionClusterData.id() << ", isModifiable() = " << isModifiable() + << ", m_explosionClusterData.id() = " << m_explosionClusterData.id << ", isModifiable() = " << isModifiable() << ", isOnlyNameModifiable() = " << isOnlyNameModifiable() << ", ena = " << (isModifiable() && !isOnlyNameModifiable()); - if (m_explosionClusterData.id() == 0) + if (m_explosionClusterData.id == 0) enableUiElements(true); else enableUiElements(isModifiable() && !isOnlyNameModifiable()); @@ -1792,8 +1792,8 @@ void ExplosionsEdit::enableUiElements(bool enable) - m_ui->leZpNumber->setEnabled((enable || isOnlyNameModifiable()) && m_aesItem.effectStateId() != AesEffectState::EsActivated); - m_ui->leElement->setEnabled((enable || isOnlyNameModifiable()) && m_aesItem.effectStateId() != AesEffectState::EsActivated); + m_ui->leZpNumber->setEnabled((enable || isOnlyNameModifiable()) && m_aesItem.effectStateId != AesEffectState::EsActivated); + m_ui->leElement->setEnabled((enable || isOnlyNameModifiable()) && m_aesItem.effectStateId != AesEffectState::EsActivated); m_ui->pbClear->setEnabled(enable); @@ -1804,15 +1804,15 @@ void ExplosionsEdit::enableUiElements(bool enable) int numberTrajectoriesRef = 0; { - const int simToRestrict = m_aesItem.id(); + const int simToRestrict = m_aesItem.id; auto cb = [simToRestrict, &numberTrajectoriesRef](const AreaEffectSimulation::TrajectoryTimeAware &traj) { - if (traj.originatorTypeId() != ProjectDataManagement::StateChangeOriginator::AreaEffectSimulation) + if (traj.originatorTypeId != ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_AreaEffectSimulation) return; - const int aesItemId = traj.originatorId(); + const int aesItemId = traj.originatorId; if (simToRestrict == aesItemId) ++numberTrajectoriesRef; }; @@ -1821,7 +1821,7 @@ void ExplosionsEdit::enableUiElements(bool enable) DEBUG_LOG(m_logger) << "************* enableUiElements numberTrajectoriesRef=" << numberTrajectoriesRef; - if ((numberTrajectoriesRef > 0) && !isPointSimilar(m_explosionClusterData.explosionGeometry())) + if ((numberTrajectoriesRef > 0) && !isPointSimilar(m_explosionClusterData.explosionGeometry)) { enableUiFireButton(); @@ -1829,7 +1829,7 @@ void ExplosionsEdit::enableUiElements(bool enable) else { - m_ui->pbFire->setEnabled(enable && m_aesItem.id() > 0); + m_ui->pbFire->setEnabled(enable && m_aesItem.id > 0); } @@ -1871,7 +1871,7 @@ void ExplosionsEdit::enableUiFireButton() - bool enableBasics = (m_aesItem.id() > 0) + bool enableBasics = (m_aesItem.id > 0) && isDataSufficiant(); INFO_LOG(m_logger) << " enableBasics = " << enableBasics; @@ -1879,17 +1879,17 @@ void ExplosionsEdit::enableUiFireButton() if (!enableBasics) return; - if (m_explosionClusterData.effectStateId() == AreaEffectSimulation::AesEffectState::EsExpired) + if (m_explosionClusterData.effectStateId == AreaEffectSimulation::AesEffectState::EsExpired) return; int numberTrajectoriesRef = 0; { - const int simToRestrict = m_aesItem.id(); + const int simToRestrict = m_aesItem.id; auto cb = [simToRestrict, &numberTrajectoriesRef](const AreaEffectSimulation::TrajectoryTimeAware &traj) { - if ((traj.originatorTypeId() == ProjectDataManagement::StateChangeOriginator::AreaEffectSimulation) && (simToRestrict == traj.originatorId())) + if ((traj.originatorTypeId == ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_AreaEffectSimulation) && (simToRestrict == traj.originatorId)) ++numberTrajectoriesRef; }; m_dtc->trajectoryTimeAwares(cb); @@ -1900,12 +1900,12 @@ void ExplosionsEdit::enableUiFireButton() - if ((numberTrajectoriesRef <= 0) && (m_explosionClusterData.effectDuration() == m_explosionClusterData.originalEffectDuration())) + if ((numberTrajectoriesRef <= 0) && (m_explosionClusterData.effectDuration == m_explosionClusterData.originalEffectDuration)) { INFO_LOG(m_logger) << " Firing has NOT started yet"; return; } - else if (numberTrajectoriesRef >= m_explosionClusterData.impactCount()) + else if (numberTrajectoriesRef >= m_explosionClusterData.impactCount) { INFO_LOG(m_logger) << " Firing has finished"; return; @@ -1927,7 +1927,7 @@ void ExplosionsEdit::enableUiFireButton() else { - if (m_explosionClusterData.effectStateId() == AesEffectState::EsPaused) + if (m_explosionClusterData.effectStateId == AesEffectState::EsPaused) bPause = false; } } @@ -1944,7 +1944,7 @@ void ExplosionsEdit::enableUiFireButton() { - if ((m_explosionClusterData.impactCount() > 1) && (m_explosionClusterData.impactCount() >= m_explosionClusterData.remainExplosionNumber())) + if ((m_explosionClusterData.impactCount > 1) && (m_explosionClusterData.impactCount >= m_explosionClusterData.remainExplosionNumber)) { m_ui->pbFire->setEnabled(true); m_ui->pbFire->setText(tr("Start")); @@ -1964,7 +1964,7 @@ void ExplosionsEdit::showPreviewObject() if (!has2DMap(false)) return; - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AreaEffectSimulation::AesExplosionGeometry::EgArea: if (m_previewPolygon.isEmpty()) @@ -2011,7 +2011,7 @@ bool ExplosionsEdit::isDataSufficiant() bool bHasTargetArea = !m_coord.isNull(); - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AreaEffectSimulation::AesExplosionGeometry::EgArea: bHasTargetArea &= m_ui->sbDimensionX_BreiteRadius->value() > 0; @@ -2036,32 +2036,32 @@ bool ExplosionsEdit::isDataSufficiant() bool ExplosionsEdit::apply() { ExplosionClusterModifyRequest request; - request.id(m_aesItem.id()); - request.element(m_ui->leElement->text().toStdString()); - request.name(m_ui->leZpNumber->text().toStdString()); + request.id = m_aesItem.id; + request.element = m_ui->leElement->text().toStdString(); + request.name = m_ui->leZpNumber->text().toStdString(); if (m_ui->dteEffectStart->isChecked()) - request.effectStart().set(m_ui->dteEffectStart->msecsSinceEpoch()); + request.effectStart.set(m_ui->dteEffectStart->msecsSinceEpoch()); if (m_ui->sbDurationSec->isVisible()) - request.effectDuration(m_ui->sbDurationSec->value() * 1000); + request.effectDuration = m_ui->sbDurationSec->value() * 1000; const bool bIsPoint = isPointSimilar(m_currentGeometry); - request.explosionGeometry(m_currentGeometry); + request.explosionGeometry = m_currentGeometry; Core::GeoPosition2D bottomLeftGeo; - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AesExplosionGeometry::EgRadial: { QPointF bottomLeft(Polygons::centerPoint2BottomLeft(m_coord, m_ui->sbDimensionX_BreiteRadius->value() * 2, m_ui->sbDimensionY_Tiefe->value() * 2, 0.0)); bottomLeftGeo = Core::GeoPosition2D(bottomLeft.x(), bottomLeft.y()); - request.area().cornerBottomLeft(bottomLeftGeo); - request.area().height(m_ui->sbDimensionY_Tiefe->value() * 2); - request.area().width(m_ui->sbDimensionX_BreiteRadius->value() * 2); + request.area.cornerBottomLeft = bottomLeftGeo; + request.area.height = m_ui->sbDimensionY_Tiefe->value() * 2; + request.area.width = m_ui->sbDimensionX_BreiteRadius->value() * 2; break; } @@ -2075,9 +2075,9 @@ bool ExplosionsEdit::apply() (m_ui->sbAimingAxis->value() - 1600) * 360.0 / 6400)); bottomLeftGeo = Core::GeoPosition2D(bottomLeft.x(), bottomLeft.y()); - request.area().cornerBottomLeft(bottomLeftGeo); - request.area().height(m_ui->sbDimensionY_Tiefe->value()); - request.area().width(m_ui->sbDimensionX_BreiteRadius->value()); + request.area.cornerBottomLeft = bottomLeftGeo; + request.area.height = m_ui->sbDimensionY_Tiefe->value(); + request.area.width = m_ui->sbDimensionX_BreiteRadius->value(); break; } @@ -2092,9 +2092,9 @@ bool ExplosionsEdit::apply() (m_ui->sbAimingAxis->value() - 1600) * 360.0 / 6400)); bottomLeftGeo = Core::GeoPosition2D(bottomLeft.x(), bottomLeft.y()); - request.area().cornerBottomLeft(bottomLeftGeo); - request.area().height(m_ui->sbDimensionY_Tiefe->value()); - request.area().width(m_ui->sbDimensionX_BreiteRadius->value()); + request.area.cornerBottomLeft = bottomLeftGeo; + request.area.height = m_ui->sbDimensionY_Tiefe->value(); + request.area.width = m_ui->sbDimensionX_BreiteRadius->value(); break; } @@ -2111,24 +2111,24 @@ bool ExplosionsEdit::apply() if (esmParticipantId1 > 0 || esmParticipantId2 > 0) { - request.esmParticipantIds().reserve(2); + request.esmParticipantIds.reserve(2); if (esmParticipantId1 > 0) - request.esmParticipantIds().push_back(esmParticipantId1); + request.esmParticipantIds.push_back(esmParticipantId1); if (esmParticipantId2 > 0 && esmParticipantId1 != esmParticipantId2 && m_ui->cbActors_2->isEnabled()) - request.esmParticipantIds().push_back(esmParticipantId2); + request.esmParticipantIds.push_back(esmParticipantId2); } - if (bIsPoint || m_currentGeometry.underlying() == AreaEffectSimulation::AesExplosionGeometry::EgRadial) - request.area().rotation(0); + if (bIsPoint || m_currentGeometry == AreaEffectSimulation::AesExplosionGeometry::EgRadial) + request.area.rotation = 0; else - request.area().rotation((m_ui->sbAimingAxis->value() - 1600) * 360.0 / 6400); + request.area.rotation = (m_ui->sbAimingAxis->value() - 1600) * 360.0 / 6400; - request.tla(m_ui->sbZog->value()); + request.tla = m_ui->sbZog->value(); if (bIsPoint) { - request.mhpCount(1); + request.mhpCount = 1; } else { @@ -2144,43 +2144,43 @@ bool ExplosionsEdit::apply() } if (mtpCount > sbCannonsCount) - request.mhpCount(sbCannonsCount); + request.mhpCount = sbCannonsCount; else - request.mhpCount(mtpCount); + request.mhpCount = mtpCount; } } - request.partyId().set(m_ui->cbParty->currentData().toInt()); + request.partyId.set(m_ui->cbParty->currentData().toInt()); bool bOk = false; - request.participantId().set(m_ui->cbParticipantUnits->currentData(Qt::UserRole).toInt(&bOk)); + request.participantId.set(m_ui->cbParticipantUnits->currentData(Qt::UserRole).toInt(&bOk)); if (!bOk) - request.participantId(0); + request.participantId = 0; - request.impactCount(m_ui->sbCannons->value()); + request.impactCount = m_ui->sbCannons->value(); - request.chargeStruct().chargeTypeId(m_ui->cbChargeType->currentData().toInt()); - request.chargeStruct().igniterTypeId(m_ui->cbIgniterType->currentData().toInt()); - request.firePurposeId(m_ui->cbFirePurpose->currentData().toInt()); + request.chargeStruct.chargeTypeId = m_ui->cbChargeType->currentData().toInt(); + request.chargeStruct.igniterTypeId = m_ui->cbIgniterType->currentData().toInt(); + request.firePurposeId = m_ui->cbFirePurpose->currentData().toInt(); { - request.peakHeight(-1); - request.flightDuration(-1); + request.peakHeight = -1; + request.flightDuration = -1; const bool usePeakHeight = m_ui->sBox_peakHeight->styleSheet().isEmpty(); const bool useFlightDuration = m_ui->sBox_flightDuration->styleSheet().isEmpty(); if (usePeakHeight == useFlightDuration) - request.peakHeight(m_ui->sBox_peakHeight->value()); + request.peakHeight = m_ui->sBox_peakHeight->value(); else if (useFlightDuration) - request.flightDuration(m_ui->sBox_flightDuration->value() * 1000); + request.flightDuration = m_ui->sBox_flightDuration->value() * 1000; else - request.peakHeight(m_ui->sBox_peakHeight->value()); + request.peakHeight = m_ui->sBox_peakHeight->value(); } - if (request.flightDuration() >= 600 * 1000) + if (request.flightDuration >= 600 * 1000) { for (int i = 0; i < 10; ++i) FATAL_LOG(m_logger) << LOGFUNCTION << " !!!!!!!!!!!!!!" @@ -2188,29 +2188,29 @@ bool ExplosionsEdit::apply() << " m_ui->sBox_flightDuration->value() " << m_ui->sBox_flightDuration->value(); } - request.partyId().set(m_ui->cbParty->currentData().toInt()); - request.effectMarkingInTa(m_ui->gbEffectMarkingInTa->isChecked()); - request.effectSourceId(ProjectDataManagement::EffectSource::ES_Internal); + request.partyId.set(m_ui->cbParty->currentData().toInt()); + request.effectMarkingInTa = m_ui->gbEffectMarkingInTa->isChecked(); + request.effectSourceId = ProjectDataManagement::EffectSource::ES_Internal; if (isGuiVulcano()) { - request.launchVelocity(TrajectoryGeneratorVulcano::defaultv0()); - request.launchAngleDeg(0); - request.dropAngle(currentDropAngleDegree()); + request.launchVelocity = TrajectoryGeneratorVulcano::defaultv0(); + request.launchAngleDeg = 0; + request.dropAngle = currentDropAngleDegree(); - if (request.effectStart().is_set()) - request.tapTime(request.effectStart().get() - (TrajectoryGeneratorVulcano::defaultTapTimeSec() * 1000)); + if (request.effectStart.has_value()) + request.tapTime = request.effectStart.get() - (TrajectoryGeneratorVulcano::defaultTapTimeSec() * 1000); - request.lcAttack(m_ui->sbLcAttack_Prf->value()); - request.lcTermination(m_ui->sbLcTermination_Prf->value()); + request.lcAttack = m_ui->sbLcAttack_Prf->value(); + request.lcTermination = m_ui->sbLcTermination_Prf->value(); const int cloudBaseValue = m_ui->spCloudBase->value(); if (cloudBaseValue == m_ui->spCloudBase->minimum()) - request.cloudBase(std::numeric_limits::min()); + request.cloudBase = std::numeric_limits::min(); else - request.cloudBase(cloudBaseValue); + request.cloudBase = cloudBaseValue; } @@ -2229,7 +2229,7 @@ void ExplosionsEdit::onGeometrySelected(int explosionGeometryInt) m_currentGeometry = newGeometry; - RocketUtility::enaDisaWirkmittel(m_ui->cbGearClass, m_currentGeometry.underlying()); + RocketUtility::enaDisaWirkmittel(m_ui->cbGearClass, m_currentGeometry); if (m_sitMapGuiIfc) @@ -2247,7 +2247,7 @@ void ExplosionsEdit::onGeometrySelected(int explosionGeometryInt) if (m_sitMapGuiIfc) m_sitMapGuiIfc->removePreviewObject(); - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AreaEffectSimulation::AesExplosionGeometry::EgAimPoint: case AreaEffectSimulation::AesExplosionGeometry::EgPoint: @@ -2351,13 +2351,13 @@ void ExplosionsEdit::onGeometrySelected(int explosionGeometryInt) void ExplosionsEdit::onFireClicked() { TRACE_LOG(m_logger) << LOGFUNCTION << " START"; - if (((m_aesItem.effectStateId() == AesEffectState::EsUnknown) || - (m_aesItem.effectStateId() == AesEffectState::EsError) || (m_aesItem.effectStateId() == AesEffectState::EsExpired) - || (m_aesItem.effectStateId() == AesEffectState::EsRemoved) || (m_aesItem.effectStateId() == AesEffectState::EsReceived) - || (m_aesItem.effectStateId() == AesEffectState::EsFired) + if (((m_aesItem.effectStateId == AesEffectState::EsUnknown) || + (m_aesItem.effectStateId == AesEffectState::EsError) || (m_aesItem.effectStateId == AesEffectState::EsExpired) + || (m_aesItem.effectStateId == AesEffectState::EsRemoved) || (m_aesItem.effectStateId == AesEffectState::EsReceived) + || (m_aesItem.effectStateId == AesEffectState::EsFired) ) - || m_aesItem.id() <= 0) + || m_aesItem.id <= 0) return; if (!isDataSufficiant()) @@ -2373,9 +2373,9 @@ void ExplosionsEdit::onFireClicked() m_ui->pbFire->setEnabled(false); - const bool bIsObjectModifiable = m_explosionClusterData.isObjectModifiable(); + const bool bIsObjectModifiable = m_explosionClusterData.isObjectModifiable; - if ((m_aesItem.effectStateId() == AesEffectState::EsCreated || m_aesItem.effectStateId() == AesEffectState::EsPrepared) && bIsObjectModifiable) + if ((m_aesItem.effectStateId == AesEffectState::EsCreated || m_aesItem.effectStateId == AesEffectState::EsPrepared) && bIsObjectModifiable) { m_ui->dteEffectStart->setMsecsSinceEpoch(m_session->partitionTime() + m_temporaryData.m_estimatedFlightDurationMsec + 5000); m_ui->dteEffectStart->setChecked(true); @@ -2415,9 +2415,9 @@ void ExplosionsEdit::onFireClicked() m_requestHelper->addRequest( [=]() { - return m_ftc->explosionClusterPauseResumeRequest(ExplosionClusterPauseResumeRequest(m_aesItem.id(), + return m_ftc->explosionClusterPauseResumeRequest(ExplosionClusterPauseResumeRequest(m_aesItem.id, resumeExecution, - dds::core::optional(), + dds::core::optional(), dds::core::optional(), dds::core::optional()), this); @@ -2441,7 +2441,7 @@ void ExplosionsEdit::onGearClassChanged() fillParties(); onPartyChanged(); - ProjectDataManagement::GearClass lastGearClassType = ProjectDataManagement::GearClass::Mortar; + ProjectDataManagement::GearClass lastGearClassType = ProjectDataManagement::GearClass::GearClass_Mortar; QVariant lastVal = m_ui->cbGearClass->property(LAST_VALUE); if (!lastVal.isNull()) lastGearClassType = static_cast(lastVal.toInt()); @@ -2482,7 +2482,7 @@ void ExplosionsEdit::onGearClassChanged() } - m_ui->cbGearClass->setProperty(LAST_VALUE, newGearClassType); + m_ui->cbGearClass->setProperty(LAST_VALUE, static_cast(newGearClassType)); doCalculations(); } @@ -2501,24 +2501,24 @@ void ExplosionsEdit::gatherParticipantUnits(const int &partyId, QHashconvertParticipantToParticipantData(part); - const ParticipantManagement::Type &ppType = m_ppmDtc->type(ppData.typeId()); + const ParticipantManagement::Type &ppType = m_ppmDtc->type(ppData.typeId); - if (m_ppmDtc->isAdlerVerbund(ppType.id())) + if (m_ppmDtc->isAdlerVerbund(ppType.id)) return; - const QJsonObject typeProperties(QJsonDocument::fromJson(QByteArray::fromStdString(ppType.properties())).object()); + const QJsonObject typeProperties(QJsonDocument::fromJson(QByteArray::fromStdString(ppType.properties)).object()); - if (typeProperties.isEmpty() || ppType.typeClass() == ParticipantManagement::TypeClass::Unit || + if (typeProperties.isEmpty() || ppType.typeClass == ParticipantManagement::TypeClass::Unit || !typeProperties[QStringLiteral("isArtillery")].toBool(false) || typeProperties[QStringLiteral("gearClassId")].toInt(-1) != gearClassId) return; - units[part.superiorId()] += part.id(); + units[part.superiorId] += part.id; }; m_ppmDtc->participants(cb); @@ -2526,9 +2526,9 @@ void ExplosionsEdit::gatherParticipantUnits(const int &partyId, QHashparticipant(it.key()); - const ParticipantManagement::Type &typ = m_ppmDtc->type(pp.typeId()); - const QJsonObject typeProperties(QJsonDocument::fromJson(QByteArray::fromStdString(typ.properties())).object()); - if ((typ.typeClass() != ParticipantManagement::TypeClass::Unit && typ.typeClass() != ParticipantManagement::TypeClass::GroundVehicle) + const ParticipantManagement::Type &typ = m_ppmDtc->type(pp.typeId); + const QJsonObject typeProperties(QJsonDocument::fromJson(QByteArray::fromStdString(typ.properties)).object()); + if ((typ.typeClass != ParticipantManagement::TypeClass::Unit && typ.typeClass != ParticipantManagement::TypeClass::GroundVehicle) || !typeProperties[QStringLiteral("isArtillery")].toBool(false)) it = units.erase(it++); else @@ -2563,11 +2563,11 @@ bool ExplosionsEdit::isValidParty(qint32 partyId) return m_ppmDtc->participants(static_cast>( [this, partyId, gearClassId](const ParticipantManagement::Participant &participant) { - if (participant.partyId() != partyId || participant.isDeleted()) + if (participant.partyId != partyId || participant.isDeleted) return false; - const ParticipantManagement::Type type = m_ppmDtc->type(participant.typeId()); - const QJsonObject typeProperties = QJsonDocument::fromJson(QByteArray::fromStdString(type.properties())).object(); + const ParticipantManagement::Type type = m_ppmDtc->type(participant.typeId); + const QJsonObject typeProperties = QJsonDocument::fromJson(QByteArray::fromStdString(type.properties)).object(); const qint32 typeGearClass = typeProperties.value(QStringLiteral("gearClassId")).toInt(-1); return typeGearClass == gearClassId; @@ -2601,17 +2601,17 @@ void ExplosionsEdit::fillCharges() for (const ProjectDataManagement::ChargeType &chargeType : std::as_const(chargesForGearClass)) { - const bool bIsVulcano = chargeTypeIdIsVulcano(chargeType.id()); + const bool bIsVulcano = chargeTypeIdIsVulcano(chargeType.id); - const double impactRadius4Debug = m_pdmDtc->impactRadius(chargeType.id(), 0, 0); - bool isAdlerChargeType = m_pdmDtc->isAdlerChargeType(chargeType.id()); + const double impactRadius4Debug = m_pdmDtc->impactRadius(chargeType.id, 0, 0); + bool isAdlerChargeType = m_pdmDtc->isAdlerChargeType(chargeType.id); DEBUG_LOG(m_logger) << " fillCharges" - << ", id=" << chargeType.id() << ", name= " << chargeType.name() << ", bIsPoint " << bIsPoint << ", bIsVulcano " << bIsVulcano + << ", id=" << chargeType.id << ", name= " << chargeType.name << ", bIsPoint " << bIsPoint << ", bIsVulcano " << bIsVulcano << ", impactRadius4Debug = " << impactRadius4Debug << ", isAdlerChargeType = " << isAdlerChargeType; - if (isAdlerChargeType || (bIsVulcano && !bIsPoint && curGearClassType != ProjectDataManagement::GearClass::Artillery)) + if (isAdlerChargeType || (bIsVulcano && !bIsPoint && curGearClassType != ProjectDataManagement::GearClass::GearClass_Artillery)) continue; - m_ui->cbChargeType->addItem(QString::fromStdString(chargeType.name()), chargeType.id()); + m_ui->cbChargeType->addItem(QString::fromStdString(chargeType.name), chargeType.id); } @@ -2630,8 +2630,8 @@ void ExplosionsEdit::fillGearClasses() const auto &gearClasses = m_pdmDtc->gearTypes(); for (auto type : std::as_const(gearClasses)) { - if (m_gearClassFilter.contains(type.gearClassId()) && m_pdmDtc->getAdlerWeaponSystemId(type.id()) <= 3) - m_ui->cbGearClass->addItem(m_pdmDtc->trGearTypeName(type.id()), type.gearClassId().underlying()); + if (m_gearClassFilter.contains(type.gearClassId) && m_pdmDtc->getAdlerWeaponSystemId(type.id) <= 3) + m_ui->cbGearClass->addItem(m_pdmDtc->trGearTypeName(type.id), static_cast(type.gearClassId)); } } @@ -2649,7 +2649,7 @@ bool ExplosionsEdit::isOnlyNameModifiable() const { - const bool ret = BaseClass::isOnlyNameModifiable() || !m_explosionClusterData.isObjectModifiable(); + const bool ret = BaseClass::isOnlyNameModifiable() || !m_explosionClusterData.isObjectModifiable; return ret; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit.h index f8f7f162b..664f1716c 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit.h @@ -4,7 +4,7 @@ #pragma once -#include +#include #include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler.cpp index 88b4ba587..94a9ec02d 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler.cpp @@ -95,11 +95,11 @@ ExplosionsEditAdler::ExplosionsEditAdler(const QString &menuGroup, QWidget *pare m_geometrieButtonGroup->addButton(m_ui->geometrieRadialBtn, static_cast(AreaEffectSimulation::AesExplosionGeometry::EgRadial)); m_geometrieButtonGroup->setExclusive(true); - m_gearClassFilter = {ProjectDataManagement::GearClass::Artillery, ProjectDataManagement::GearClass::Mortar}; + m_gearClassFilter = {ProjectDataManagement::GearClass::GearClass_Artillery, ProjectDataManagement::GearClass::GearClass_Mortar}; LtsUtils::ProjectSettings *ps = LtsUtils::ProjectSettings::getInstance(); const bool enableRocket = ps->value(QStringLiteral("aes"), QStringLiteral("enableRocket"), false).toBool(); if (enableRocket) - m_gearClassFilter += ProjectDataManagement::GearClass::Rocket; + m_gearClassFilter += ProjectDataManagement::GearClass::GearClass_Rocket; m_uiRequirements->addRequirement( {m_ui->lbxActors, @@ -186,12 +186,12 @@ bool ExplosionsEditAdler::init(int aesItemId, bool copy, LtsSession::LtsSession if (aesItemId > 0) { const EffectCluster &ecData = m_dtc->effectCluster(aesItemId); - DEBUG_LOG(m_logger) << "chargeTypeId: " << ecData.chargeStruct().chargeTypeId(); + DEBUG_LOG(m_logger) << "chargeTypeId: " << ecData.chargeStruct.chargeTypeId; m_effectClusterData = ecData; setEffectClusterData(ecData); setPbStateChangeName(); - m_ui->gbEffectMarkingInTa->setChecked(m_aesItem.effectMarkingInTa()); // always true for explosion cluster + m_ui->gbEffectMarkingInTa->setChecked(m_aesItem.effectMarkingInTa); // always true for explosion cluster } connect(m_dtc.get(), &AreaEffectSimulation::Interface::Dtc::effectClusterChanged, this, &ExplosionsEditAdler::onEffectClusterChanged, Qt::UniqueConnection); @@ -218,7 +218,7 @@ void ExplosionsEditAdler::showPreviewObject() if (!has2DMap(false)) // showMsgBoxIfNot2D return; - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AreaEffectSimulation::AesExplosionGeometry::EgArea: if (m_previewPolygon.isEmpty()) @@ -258,7 +258,7 @@ bool ExplosionsEditAdler::isDataSufficiant() // target: bool bHasTargetArea = !m_coord.isNull(); - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AreaEffectSimulation::AesExplosionGeometry::EgArea: bHasTargetArea &= m_ui->lblDimensionYDepth->text().toInt() > 0; @@ -283,25 +283,25 @@ void ExplosionsEditAdler::setEffectClusterData(const EffectCluster &ecData) m_aesItem = ecData; DEBUG_LOG(m_logger) << LOGFUNCTION << " START, ecData=" << ecData; - m_ui->lblZpNumber->setText(QString::fromStdString(ecData.name())); + m_ui->lblZpNumber->setText(QString::fromStdString(ecData.name)); qint64 effectStart = 0; - if (ecData.effectStart().is_set()) + if (ecData.effectStart.has_value()) { - const QJsonObject propsObj(QJsonDocument::fromJson(QByteArray::fromStdString(ecData.properties())).object()); + const QJsonObject propsObj(QJsonDocument::fromJson(QByteArray::fromStdString(ecData.properties)).object()); const FiringType firingType = static_cast(propsObj[AdlerJson::JsonKeys::ABFEUERUNGSART()].toInt()); - effectStart = ecData.effectStart().get(); + effectStart = ecData.effectStart.get(); if (firingType == FiringType::FireWithIndicationTTF) - effectStart -= ecData.effectors().size() ? ecData.effectors().at(0).flightTime() : 0; + effectStart -= ecData.effectors.size() ? ecData.effectors.at(0).flightTime : 0; } m_ui->dteEffectStart->setMsecsSinceEpoch(effectStart); // Geometry/Area - const AreaEffectSimulation::AesExplosionGeometry geometryType = static_cast(ecData.explosionGeometry()); + const AreaEffectSimulation::AesExplosionGeometry geometryType = static_cast(ecData.explosionGeometry); switch (geometryType) { case AreaEffectSimulation::AesExplosionGeometry::EgAimPoint: @@ -324,26 +324,26 @@ void ExplosionsEditAdler::setEffectClusterData(const EffectCluster &ecData) break; } // switch - if (ecData.effectDuration() == DEFAULT_EFFECT_DURATION) + if (ecData.effectDuration == DEFAULT_EFFECT_DURATION) m_ui->lblDuration->setText(QStringLiteral("---")); else - m_ui->lblDuration->setText(QString::number(ecData.effectDuration() / 1000)); // msecs -> secs + m_ui->lblDuration->setText(QString::number(ecData.effectDuration / 1000)); // msecs -> secs // 1st GearClass - ProjectDataManagement::GearClass gc = m_pdmDtc->gearClassFromChargeTypeId(ecData.chargeStruct().chargeTypeId()); + ProjectDataManagement::GearClass gc = m_pdmDtc->gearClassFromChargeTypeId(ecData.chargeStruct.chargeTypeId); m_ui->lblGearClass->setText(ProjectDataManagement::toString(gc)); // 2nd Party - if (ecData.partyId().is_set()) - m_ui->lblParty->setText(ParticipantManagement::trPartyName(m_ppmDtc->party(ecData.partyId().get()).name())); + if (ecData.partyId.has_value()) + m_ui->lblParty->setText(ParticipantManagement::trPartyName(m_ppmDtc->party(ecData.partyId.get()).name)); // 3rd Originator - if (ecData.participantId().is_set()) - m_ui->lblParticipantUnits->setText(QString::fromStdString(m_ppmDtc->participant(ecData.participantId().get()).name())); + if (ecData.participantId.has_value()) + m_ui->lblParticipantUnits->setText(QString::fromStdString(m_ppmDtc->participant(ecData.participantId.get()).name)); - m_ui->lblChargeType->setText(m_pdmDtc->adlerChargeTypeName(ecData.chargeStruct().chargeTypeId())); - m_ui->lblIgniterType->setText(m_pdmDtc->adlerIgniterTypeName(ecData.chargeStruct().igniterTypeId())); - m_ui->lblIgniterFunction->setText(m_pdmDtc->adlerIgniterFunctionName(ecData.chargeStruct().igniterFunctionId())); + m_ui->lblChargeType->setText(m_pdmDtc->adlerChargeTypeName(ecData.chargeStruct.chargeTypeId)); + m_ui->lblIgniterType->setText(m_pdmDtc->adlerIgniterTypeName(ecData.chargeStruct.igniterTypeId)); + m_ui->lblIgniterFunction->setText(m_pdmDtc->adlerIgniterFunctionName(ecData.chargeStruct.igniterFunctionId)); int impactCount = 0; @@ -355,55 +355,55 @@ void ExplosionsEditAdler::setEffectClusterData(const EffectCluster &ecData) delete item->widget(); delete item; } - for (const auto &effectorData : ecData.effectors()) + for (const auto &effectorData : ecData.effectors) { - setEffector(effectorData.participantId(), m_dtc->effector(effectorData.participantId()).effectorState()); - impactCount += effectorData.chargeAmount(); + setEffector(effectorData.participantId, m_dtc->effector(effectorData.participantId).effectorState); + impactCount += effectorData.chargeAmount; } m_ui->layoutEffectors->setColumnStretch(m_effectorNumber + 1 % m_maxColumns, 1); m_ui->lblCannons->setText(QString::number(impactCount)); - m_ui->lblFirePurpose->setText(m_pdmDtc->trFirePurposeName(ecData.firePurposeId())); + m_ui->lblFirePurpose->setText(m_pdmDtc->trFirePurposeName(ecData.firePurposeId)); - m_ui->lblZog->setText(QString::number(ecData.tla())); // tla == zog + m_ui->lblZog->setText(QString::number(ecData.tla)); // tla == zog - const AreaEffectSimulation::Area &areaRef = ecData.area(); - const QPointF bottomLeft(areaRef.cornerBottomLeft().lon(), areaRef.cornerBottomLeft().lat()); - const QPointF centerpoint = Polygons::bottomLeft2CenterPoint(bottomLeft, areaRef.width(), areaRef.height(), areaRef.rotation()); + const AreaEffectSimulation::Area &areaRef = ecData.area; + const QPointF bottomLeft(areaRef.cornerBottomLeft.lon, areaRef.cornerBottomLeft.lat); + const QPointF centerpoint = Polygons::bottomLeft2CenterPoint(bottomLeft, areaRef.width, areaRef.height, areaRef.rotation); if (!bottomLeft.isNull()) { m_ui->positionEdit->setCoordinate(centerpoint); m_coord = centerpoint; const Core::GeoPosition coordGeo(centerpoint.x(), centerpoint.y(), 0); - bool isSmoke = m_pdmDtc->isSmoke(ecData.chargeStruct().chargeTypeId(), ecData.chargeStruct().igniterTypeId(), ecData.chargeStruct().igniterFunctionId()); + bool isSmoke = m_pdmDtc->isSmoke(ecData.chargeStruct.chargeTypeId, ecData.chargeStruct.igniterTypeId, ecData.chargeStruct.igniterFunctionId); m_esmActorCbx->fillActorComboBox(m_ui->cbActors, coordGeo, isSmoke, 0); m_esmActorCbx->fillActorComboBox(m_ui->cbActors_2, coordGeo, isSmoke, 0); } - if (ecData.explosionGeometry().underlying() == AreaEffectSimulation::AesExplosionGeometry::EgRadial) + if (ecData.explosionGeometry == AreaEffectSimulation::AesExplosionGeometry::EgRadial) { - m_ui->lblDimensionYDepth->setText(QString::number(static_cast(std::round(areaRef.height() / 2)))); - m_ui->lblWidthRadius->setText(QString::number(static_cast(std::round(areaRef.width() / 2)))); + m_ui->lblDimensionYDepth->setText(QString::number(static_cast(std::round(areaRef.height / 2)))); + m_ui->lblWidthRadius->setText(QString::number(static_cast(std::round(areaRef.width / 2)))); m_ui->lblAimingAxis->setText(QString::number(0)); } else { - m_ui->lblDimensionYDepth->setText(QString::number(static_cast(std::round(areaRef.height())))); - m_ui->lblWidthRadius->setText(QString::number(static_cast(std::round(areaRef.width())))); - m_ui->lblAimingAxis->setText(QString::number(static_cast(std::round(fmod((areaRef.rotation()) * 6400 / 360, 6400))))); + m_ui->lblDimensionYDepth->setText(QString::number(static_cast(std::round(areaRef.height)))); + m_ui->lblWidthRadius->setText(QString::number(static_cast(std::round(areaRef.width)))); + m_ui->lblAimingAxis->setText(QString::number(static_cast(std::round(fmod((areaRef.rotation) * 6400 / 360, 6400))))); } - setEffectClusterDataFromJson(ecData.properties()); - if (!ecData.esmParticipantIds().empty()) + setEffectClusterDataFromJson(ecData.properties); + if (!ecData.esmParticipantIds.empty()) { - m_ui->cbActors->setCurrentIndex(m_ui->cbActors->findData(ecData.esmParticipantIds().at(0))); - if (ecData.esmParticipantIds().size() > 1) - m_ui->cbActors_2->setCurrentIndex(m_ui->cbActors_2->findData(ecData.esmParticipantIds().at(1))); + m_ui->cbActors->setCurrentIndex(m_ui->cbActors->findData(ecData.esmParticipantIds.at(0))); + if (ecData.esmParticipantIds.size() > 1) + m_ui->cbActors_2->setCurrentIndex(m_ui->cbActors_2->findData(ecData.esmParticipantIds.at(1))); } - if (ecData.effectors().size()) - setOWUWFromTrajectory(ecData.effectors().at(0).trajectoryRelative()); + if (ecData.effectors.size()) + setOWUWFromTrajectory(ecData.effectors.at(0).trajectoryRelative); // enable second Actor if possible - const int amountFireMarker = m_pdmDtc->getAmountFireMarkers(ecData.firePurposeId()); + const int amountFireMarker = m_pdmDtc->getAmountFireMarkers(ecData.firePurposeId); m_ui->cbActors_2->setEnabled(amountFireMarker > 1); DEBUG_LOG(m_logger) << LOGFUNCTION << " END"; @@ -414,7 +414,7 @@ void ExplosionsEditAdler::setEffector(int participantId, const AreaEffectSimulat const ParticipantManagement::Participant &part = m_ppmDtc->participant(participantId); auto *effectorWidget = new AesEffector(this); - effectorWidget->init(participantId, QString::fromStdString(part.tacticalIdentifier()), QString::fromStdString(part.name()), effectorState); + effectorWidget->init(participantId, QString::fromStdString(part.tacticalIdentifier), QString::fromStdString(part.name), effectorState); effectorWidget->setStateButtonVisible(false); const int row = m_effectorNumber / m_maxColumns; @@ -430,7 +430,7 @@ void ExplosionsEditAdler::setEffector(int participantId, const AreaEffectSimulat QString ExplosionsEditAdler::dialogIdentifier() const { DEBUG_LOG(m_logger) << "dialogIdentifier"; - return m_aesItem.id() <= 0 ? QStringLiteral("AddExplosionsArtillery") : QStringLiteral("EditExplosionsArtillery%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddExplosionsArtillery") : QStringLiteral("EditExplosionsArtillery%1").arg(m_aesItem.id); } void ExplosionsEditAdler::onAcknowledgeExternalAesItemReply(const Core::FunctionReplyObject &replyObject) @@ -442,7 +442,7 @@ void ExplosionsEditAdler::onAcknowledgeExternalAesItemReply(const Core::Function void ExplosionsEditAdler::onEffectClusterChanged(const EffectCluster &ecData, DataModification modType) { DEBUG_LOG(m_logger) << "onExplosionClusterChanged"; - if (ecData.id() != m_aesItem.id()) + if (ecData.id != m_aesItem.id) return; BaseEdit::onAreaChanged(ecData, modType); @@ -454,15 +454,15 @@ void ExplosionsEditAdler::onEffectClusterChanged(const EffectCluster &ecData, Da } m_effectClusterData = ecData; - m_currentGeometry = m_effectClusterData.explosionGeometry(); + m_currentGeometry = m_effectClusterData.explosionGeometry; setEffectClusterData(ecData); setPbStateChangeName(); - if (m_effectClusterData.effectDuration() == DEFAULT_EFFECT_DURATION) + if (m_effectClusterData.effectDuration == DEFAULT_EFFECT_DURATION) m_ui->lblDuration->setText(QStringLiteral("---")); else - m_ui->lblDuration->setText(QString::number(m_effectClusterData.effectDuration() / 1000)); // msec -> sec + m_ui->lblDuration->setText(QString::number(m_effectClusterData.effectDuration / 1000)); // msec -> sec enableUiElements(); if (unchangeable()) @@ -556,10 +556,10 @@ void ExplosionsEditAdler::enableUiElements(bool enable) m_ui->rbAngleGroupLower->setEnabled(enable); m_ui->rbAngleGroupUpper->setEnabled(enable); - if (m_aesItem.effectStateId() == AesEffectState::EsReceived) + if (m_aesItem.effectStateId == AesEffectState::EsReceived) m_ui->pbStateChange->setEnabled(true); else - m_ui->pbStateChange->setEnabled(m_effectClusterData.effectorState() != AreaEffectSimulation::AesEffectorState::EsReadyToFire); + m_ui->pbStateChange->setEnabled(m_effectClusterData.effectorState != AreaEffectSimulation::AesEffectorState::EsReadyToFire); } /*! @@ -573,17 +573,17 @@ bool ExplosionsEditAdler::apply() int esmParticipantId2 = m_ui->cbActors_2->currentData().toInt(); // participant ID EffectClusterModifyActorRequest request; - request.aesId(m_aesItem.id()); + request.aesId = m_aesItem.id; DEBUG_LOG(m_logger) << "currentIndex: " << m_ui->cbActors->currentIndex() << ", currentText: " << m_ui->cbActors->currentText() << ", participantId1: " << esmParticipantId1; if (esmParticipantId1 > 0 || esmParticipantId2 > 0) { - request.esmParticipantIds().reserve(2); + request.esmParticipantIds.reserve(2); if (esmParticipantId1 > 0) - request.esmParticipantIds().push_back(esmParticipantId1); + request.esmParticipantIds.push_back(esmParticipantId1); if (esmParticipantId2 > 0 && esmParticipantId1 != esmParticipantId2 && m_ui->cbActors_2->isEnabled()) - request.esmParticipantIds().push_back(esmParticipantId2); + request.esmParticipantIds.push_back(esmParticipantId2); } m_requestHelper->addRequest([this, request]() { return m_ftc->effectClusterModifyActorRequest(request, this); }); @@ -593,28 +593,28 @@ bool ExplosionsEditAdler::apply() // void ExplosionsEditAdler::setPbStateChangeName() { - DEBUG_LOG(m_logger) << "onPbStateChangeName: AesEffectState: " << m_aesItem.effectStateId(); + DEBUG_LOG(m_logger) << "onPbStateChangeName: AesEffectState: " << m_aesItem.effectStateId; - if ((m_aesItem.effectStateId() != AesEffectState::EsReceived && m_aesItem.effectStateId() != AesEffectState::EsCreated) || m_aesItem.id() <= 0) + if ((m_aesItem.effectStateId != AesEffectState::EsReceived && m_aesItem.effectStateId != AesEffectState::EsCreated) || m_aesItem.id <= 0) return; m_ui->pbStateChange->show(); - if (m_aesItem.effectStateId() == AesEffectState::EsReceived) + if (m_aesItem.effectStateId == AesEffectState::EsReceived) m_ui->pbStateChange->setText(tr("Acknowledge")); else { m_ui->pbStateChange->setText(tr("Ready to fire")); - m_ui->pbStateChange->setEnabled(m_effectClusterData.effectorState() != AreaEffectSimulation::AesEffectorState::EsReadyToFire); + m_ui->pbStateChange->setEnabled(m_effectClusterData.effectorState != AreaEffectSimulation::AesEffectorState::EsReadyToFire); } } void ExplosionsEditAdler::onPbStateChangeClicked() { - if ((m_aesItem.effectStateId() != AesEffectState::EsReceived && m_aesItem.effectStateId() != AesEffectState::EsCreated) || m_aesItem.id() <= 0) + if ((m_aesItem.effectStateId != AesEffectState::EsReceived && m_aesItem.effectStateId != AesEffectState::EsCreated) || m_aesItem.id <= 0) return; - DEBUG_LOG(m_logger) << " onPbStateChangeClicked: AesEffectState = " << m_aesItem.effectStateId(); + DEBUG_LOG(m_logger) << " onPbStateChangeClicked: AesEffectState = " << m_aesItem.effectStateId; m_ui->pbStateChange->setDisabled(true); @@ -622,21 +622,21 @@ void ExplosionsEditAdler::onPbStateChangeClicked() apply(); // Re-Enable PB, so we can call it another time, if it does not react... - QTimer::singleShot(2000, [this]() { m_ui->pbStateChange->setEnabled(m_effectClusterData.effectorState() != AreaEffectSimulation::AesEffectorState::EsReadyToFire); }); + QTimer::singleShot(2000, [this]() { m_ui->pbStateChange->setEnabled(m_effectClusterData.effectorState != AreaEffectSimulation::AesEffectorState::EsReadyToFire); }); - if (m_aesItem.effectStateId() == AesEffectState::EsReceived) + if (m_aesItem.effectStateId == AesEffectState::EsReceived) { AreaEffectSimulation::AcknowledgeExternalAesItemRequest request; - request.aesId(m_aesItem.id()); - DEBUG_LOG(m_logger) << "Send acknowledgeExternalAesItemRequest with aesId: " << request.aesId(); + request.aesId = m_aesItem.id; + DEBUG_LOG(m_logger) << "Send acknowledgeExternalAesItemRequest with aesId: " << request.aesId; m_requestHelper->addRequest([this, request]() { return m_ftc->acknowledgeExternalAesItemRequest(request, this); }); } else { AreaEffectSimulation::SetAesItemEffectorStateRequest request; - request.aesId(m_aesItem.id()); - request.newEffectorState(AesEffectorState::EsReadyToFire); - DEBUG_LOG(m_logger) << "Send setAesItemEffectorStateRequest with aesId: " << request.aesId() << ", AesEffectorState: " << request.newEffectorState(); + request.aesId = m_aesItem.id; + request.newEffectorState = AesEffectorState::EsReadyToFire; + DEBUG_LOG(m_logger) << "Send setAesItemEffectorStateRequest with aesId: " << request.aesId << ", AesEffectorState: " << request.newEffectorState; m_requestHelper->addRequest([this, request]() { return m_ftc->setAesItemEffectorStateRequest(request, this); }); } @@ -645,7 +645,7 @@ void ExplosionsEditAdler::onPbStateChangeClicked() void ExplosionsEditAdler::onEffectorChanged(const AreaEffectSimulation::Effector &data, DataModification modType) { - if (data.aesItemId() != m_aesItem.id()) + if (data.aesItemId != m_aesItem.id) return; for (int i = 0; i < m_ui->layoutEffectors->count(); ++i) @@ -655,24 +655,24 @@ void ExplosionsEditAdler::onEffectorChanged(const AreaEffectSimulation::Effector { if (AesEffector *effectorWidget = qobject_cast(widget)) { - if (effectorWidget->effectorId() != data.id()) + if (effectorWidget->effectorId() != data.id) continue; - effectorWidget->setState(data.effectorState()); + effectorWidget->setState(data.effectorState); return; } } } if (modType == DataModification::eAdded) - setEffector(data.participantId(), data.effectorState()); + setEffector(data.participantId, data.effectorState); } bool ExplosionsEditAdler::isOnlyNameModifiable() const { // BaseClass::isOnlyNameModifiable() -> EsPaused || EsActivated // m_effectClusterData.isObjectModifiable -> since PreStart and s_calculationOffsetMSec - const bool ret = BaseClass::isOnlyNameModifiable() || !m_effectClusterData.isObjectModifiable(); + const bool ret = BaseClass::isOnlyNameModifiable() || !m_effectClusterData.isObjectModifiable; return ret; } @@ -694,9 +694,9 @@ void ExplosionsEditAdler::setOWUWFromTrajectory(const std::vectorlblTargetSubType->setText(m_pdmDtc->trTargetSubTypeName(targetSubTypeId)); const int angleGroup = propsObj[AdlerJson::JsonKeys::WINKELGRUPPE()].toInt(); - if (angleGroup == ProjectDataManagement::L43_AngleGroup::Lower) + if (angleGroup == static_cast(ProjectDataManagement::L43_AngleGroup::Lower)) m_ui->rbAngleGroupLower->setChecked(true); else m_ui->rbAngleGroupUpper->setChecked(true); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler.h index 2a48bbd75..cc4febda4 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler.h @@ -4,7 +4,7 @@ #pragma once #include -#include +#include #include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler_standalone.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler_standalone.cpp index 302fb8896..063caa8a1 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler_standalone.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler_standalone.cpp @@ -86,17 +86,17 @@ QPair ExplosionsEditAdlerStandAlone::getMinMaxDistance(ProjectDataMana static QHash> contraintsDistance; if (contraintsDistance.isEmpty()) { - contraintsDistance.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {3500, 40000}); // Haubitze - contraintsDistance.insert(static_cast(ProjectDataManagement::GearClass::Mortar), {800, 7800}); // Mörser - // contraints.insert(static_cast(ProjectDataManagement::GearClass::Mortar), {15000, 90000}); // Rakete - // contraints.insert(static_cast(ProjectDataManagement::GearClass::Mortar), {10000, 38400}); // Minenrakete + contraintsDistance.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {3500, 40000}); // Haubitze + contraintsDistance.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Mortar), {800, 7800}); // Mörser + // contraints.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Mortar), {15000, 90000}); // Rakete + // contraints.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Mortar), {10000, 38400}); // Minenrakete } static QHash> contraintsDistanceVulcano; if (contraintsDistanceVulcano.isEmpty()) { - contraintsDistanceVulcano.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {10000, 70000}); // Haubitze - contraintsDistanceVulcano.insert(static_cast(ProjectDataManagement::GearClass::Rocket), {10000, 70000}); // Rakete + contraintsDistanceVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {10000, 70000}); // Haubitze + contraintsDistanceVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Rocket), {10000, 70000}); // Rakete } if (chargeTypeIdIsVulcano(chargeTypeId)) { @@ -132,15 +132,15 @@ QPair ExplosionsEditAdlerStandAlone::getMinMaxFlightDurationSec(Projec static QHash> contraintsFlightDuration; if (contraintsFlightDuration.isEmpty()) { - contraintsFlightDuration.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {6, 150}); // Haubitze - contraintsFlightDuration.insert(static_cast(ProjectDataManagement::GearClass::Mortar), {20, 60}); // Mörser + contraintsFlightDuration.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {6, 150}); // Haubitze + contraintsFlightDuration.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Mortar), {20, 60}); // Mörser } static QHash> contraintsFlightDurationVulcano; if (contraintsFlightDurationVulcano.isEmpty()) { - contraintsFlightDurationVulcano.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {0, 999}); // Haubitze - contraintsFlightDurationVulcano.insert(static_cast(ProjectDataManagement::GearClass::Rocket), {0, 999}); // Rakete + contraintsFlightDurationVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {0, 999}); // Haubitze + contraintsFlightDurationVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Rocket), {0, 999}); // Rakete } if (chargeTypeIdIsVulcano(chargeTypeId)) { @@ -176,15 +176,15 @@ QPair ExplosionsEditAdlerStandAlone::getMinMaxPeakHeight(ProjectDataMa static QHash> contraintsPeak; if (contraintsPeak.isEmpty()) { - contraintsPeak.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {250, 15000}); // Haubitze - contraintsPeak.insert(static_cast(ProjectDataManagement::GearClass::Mortar), {500, 3000}); // Mörser + contraintsPeak.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {250, 15000}); // Haubitze + contraintsPeak.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Mortar), {500, 3000}); // Mörser } static QHash> contraintsPeakVulcano; if (contraintsPeakVulcano.isEmpty()) { - contraintsPeakVulcano.insert(static_cast(ProjectDataManagement::GearClass::Artillery), {1000, 37500}); // Haubitze - contraintsPeakVulcano.insert(static_cast(ProjectDataManagement::GearClass::Rocket), {1000, 37500}); // Rakete + contraintsPeakVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Artillery), {1000, 37500}); // Haubitze + contraintsPeakVulcano.insert(static_cast(ProjectDataManagement::GearClass::GearClass_Rocket), {1000, 37500}); // Rakete } if (chargeTypeIdIsVulcano(chargeTypeId)) { @@ -212,8 +212,8 @@ int ExplosionsEditAdlerStandAlone::getMaxPeakHeight(ProjectDataManagement::GearC bool ExplosionsEditAdlerStandAlone::isPointSimilar(AreaEffectSimulation::AesExplosionGeometry geometry) { - return (geometry.underlying() == AreaEffectSimulation::AesExplosionGeometry::EgAimPoint) - || (geometry.underlying() == AreaEffectSimulation::AesExplosionGeometry::EgPoint); + return (geometry == AreaEffectSimulation::AesExplosionGeometry::EgAimPoint) + || (geometry == AreaEffectSimulation::AesExplosionGeometry::EgPoint); } /*! @@ -278,11 +278,11 @@ ExplosionsEditAdlerStandAlone::ExplosionsEditAdlerStandAlone(const QString &menu m_geometrieButtonGroup->addButton(m_ui->geometrieRadialBtn, static_cast(AreaEffectSimulation::AesExplosionGeometry::EgRadial)); m_geometrieButtonGroup->setExclusive(true); - m_gearClassFilter = {ProjectDataManagement::GearClass::Artillery, ProjectDataManagement::GearClass::Mortar}; + m_gearClassFilter = {ProjectDataManagement::GearClass::GearClass_Artillery, ProjectDataManagement::GearClass::GearClass_Mortar}; LtsUtils::ProjectSettings *ps = LtsUtils::ProjectSettings::getInstance(); const bool enableRocket = ps->value(QStringLiteral("aes"), QStringLiteral("enableRocket"), false).toBool(); if (enableRocket) - m_gearClassFilter += ProjectDataManagement::GearClass::Rocket; + m_gearClassFilter += ProjectDataManagement::GearClass::GearClass_Rocket; m_uiRequirements->addRequirement({m_ui->lblPosition, [this]() { return (!m_coord.isNull()); }}); m_uiRequirements->addRequirement({m_ui->lblPosition_2, [this]() { // Im Fall (Zielgeometrie == Linear) ist positionEdit_2 enabled. Ansonsten disabled. @@ -328,10 +328,10 @@ ExplosionsEditAdlerStandAlone::ExplosionsEditAdlerStandAlone(const QString &menu cadence = m_pdmDtc->cadence(gearTypeIds.at(0)); const int unitParticipantId = m_ui->cbParticipantUnits->currentData(Qt::UserRole).toInt(); const auto &unitParticipant = m_ppmDtc->participant(unitParticipantId); - if (!unitParticipant.inferiorIds().size()) + if (!unitParticipant.inferiorIds.size()) return false; // ceiling - const int maxRoundEffector = std::ceil((double)m_ui->sbCannons->value() / unitParticipant.inferiorIds().size()); + const int maxRoundEffector = std::ceil((double)m_ui->sbCannons->value() / unitParticipant.inferiorIds.size()); DEBUG_LOG(m_logger) << "Checking cadence wiht duration: cadence[ms]: " << cadence << " duration[ms]: " << m_ui->sbDurationSec->value() * 1000 << " maxRoundsForEffector: " << maxRoundEffector; // when using the effect duration, we need enough time to spread the volleys inside the duration. @@ -507,7 +507,7 @@ bool ExplosionsEditAdlerStandAlone::init(int aesItemId, bool copy, LtsSession::L m_ui->startBtn->setEnabled(false); // initial adjustment: - m_effectClusterData.explosionGeometry(AreaEffectSimulation::AesExplosionGeometry::EgArea); + m_effectClusterData.explosionGeometry = AreaEffectSimulation::AesExplosionGeometry::EgArea; onGeometrySelected(static_cast(AreaEffectSimulation::AesExplosionGeometry::EgArea)); // pay attention!!! firePurposeId vs purpose !!! @@ -559,20 +559,20 @@ bool ExplosionsEditAdlerStandAlone::init(int aesItemId, bool copy, LtsSession::L if (aesItemId > 0) { const EffectCluster &exData = m_dtc->effectCluster(aesItemId); - if (!exData.annotationString().empty() && + if (!exData.annotationString.empty() && !copy) // do not copy annotationString while creating using a template (E01562-404: Fix for E01562-293) { - newAnnotation = QString::fromStdString(exData.annotationString()); + newAnnotation = QString::fromStdString(exData.annotationString); } - m_ui->gbEffectMarkingInTa->setChecked(exData.effectMarkingInTa()); + m_ui->gbEffectMarkingInTa->setChecked(exData.effectMarkingInTa); m_data = exData; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); - m_effectClusterData.id(m_aesItem.id()); - m_effectClusterData.effectStateId(m_aesItem.effectStateId()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; + m_effectClusterData.id = m_aesItem.id; + m_effectClusterData.effectStateId = m_aesItem.effectStateId; } setEffectClusterData(exData); } @@ -610,7 +610,7 @@ bool ExplosionsEditAdlerStandAlone::init(int aesItemId, bool copy, LtsSession::L if (!newAnnotation.isEmpty()) addAnnotationStr(newAnnotation); - RocketUtility::enaDisaWirkmittel(m_ui->cbGearClass, m_currentGeometry.underlying()); + RocketUtility::enaDisaWirkmittel(m_ui->cbGearClass, m_currentGeometry); DEBUG_LOG(m_logger) << LOGFUNCTION << " END"; return true; @@ -621,11 +621,11 @@ void ExplosionsEditAdlerStandAlone::setEffectClusterData(const EffectCluster &ec DEBUG_LOG(m_logger) << LOGFUNCTION << " START, ecData=" << ecData; - m_ui->leZpNumber->setText(QString::fromStdString(ecData.name())); - m_ui->leElement->setText(QString::fromStdString(ecData.element())); + m_ui->leZpNumber->setText(QString::fromStdString(ecData.name)); + m_ui->leElement->setText(QString::fromStdString(ecData.element)); // Geometry/Area - const AreaEffectSimulation::AesExplosionGeometry geometryType = static_cast(ecData.explosionGeometry()); + const AreaEffectSimulation::AesExplosionGeometry geometryType = static_cast(ecData.explosionGeometry); switch (geometryType) { case AreaEffectSimulation::AesExplosionGeometry::EgAimPoint: @@ -649,31 +649,31 @@ void ExplosionsEditAdlerStandAlone::setEffectClusterData(const EffectCluster &ec } // switch onGeometrySelected(static_cast(geometryType)); // which in turn calls fillCharges(); - m_ui->sbDurationSec->setValue(ecData.effectDuration() / 1000); // msecs -> secs + m_ui->sbDurationSec->setValue(ecData.effectDuration / 1000); // msecs -> secs // 1st GearClass { QSignalBlocker locked(m_ui->cbGearClass); - ProjectDataManagement::GearClass gc = m_pdmDtc->gearClassFromChargeTypeId(ecData.chargeStruct().chargeTypeId()); - m_ui->cbGearClass->setCurrentIndex(m_ui->cbGearClass->findData(static_cast(gc.underlying()))); + ProjectDataManagement::GearClass gc = m_pdmDtc->gearClassFromChargeTypeId(ecData.chargeStruct.chargeTypeId); + m_ui->cbGearClass->setCurrentIndex(m_ui->cbGearClass->findData(static_cast(gc))); onGearClassChanged(); // update depending comboBox } // 2nd Party { QSignalBlocker locked(m_ui->cbParty); - if (ecData.partyId().is_set()) + if (ecData.partyId.has_value()) { - m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(ecData.partyId().get())); + m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(ecData.partyId.get())); onPartyChanged(); // update depending comboBox } } // 3rd Originator { - if (ecData.participantId().is_set()) + if (ecData.participantId.has_value()) { - m_ui->cbParticipantUnits->setCurrentIndex(m_ui->cbParticipantUnits->findData(ecData.participantId().get())); + m_ui->cbParticipantUnits->setCurrentIndex(m_ui->cbParticipantUnits->findData(ecData.participantId.get())); onParticipantUnitChanged({}); } } @@ -682,21 +682,21 @@ void ExplosionsEditAdlerStandAlone::setEffectClusterData(const EffectCluster &ec QStringList tooltip; std::vector flightTimes; - for (const auto &effectorData : ecData.effectors()) + for (const auto &effectorData : ecData.effectors) { - const ParticipantManagement::Participant &part = m_ppmDtc->participant(effectorData.participantId()); - tooltip << tr("%1: %2s\n").arg(QString::fromStdString(part.tacticalIdentifier())).arg(effectorData.flightTime() / 1000, 0, 'f', 2); - flightTimes.push_back(effectorData.flightTime()); + const ParticipantManagement::Participant &part = m_ppmDtc->participant(effectorData.participantId); + tooltip << tr("%1: %2s\n").arg(QString::fromStdString(part.tacticalIdentifier)).arg(effectorData.flightTime / 1000, 0, 'f', 2); + flightTimes.push_back(effectorData.flightTime); - if (m_aesItem.id() > 0) - setEffector(part, m_dtc->effector(effectorData.participantId()).effectorState()); + if (m_aesItem.id > 0) + setEffector(part, m_dtc->effector(effectorData.participantId).effectorState); if (impactCount == 0) { - m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(effectorData.chargeStruct().chargeTypeId())); - m_ui->cbIgniterType->setCurrentIndex(m_ui->cbIgniterType->findData(effectorData.chargeStruct().igniterTypeId())); - m_ui->cbIgniterFunction->setCurrentIndex(m_ui->cbIgniterFunction->findData(effectorData.chargeStruct().igniterFunctionId())); + m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(effectorData.chargeStruct.chargeTypeId)); + m_ui->cbIgniterType->setCurrentIndex(m_ui->cbIgniterType->findData(effectorData.chargeStruct.igniterTypeId)); + m_ui->cbIgniterFunction->setCurrentIndex(m_ui->cbIgniterFunction->findData(effectorData.chargeStruct.igniterFunctionId)); } - impactCount += effectorData.chargeAmount(); + impactCount += effectorData.chargeAmount; } auto pair = std::minmax_element(flightTimes.cbegin(), flightTimes.cend()); @@ -706,9 +706,9 @@ void ExplosionsEditAdlerStandAlone::setEffectClusterData(const EffectCluster &ec m_ui->layoutEffectors->setColumnStretch(m_effectorNumber + 1 % m_maxColumns, 1); m_ui->sbCannons->setValue(impactCount); - m_ui->cbFirePurpose->setCurrentIndex(m_ui->cbFirePurpose->findData(ecData.firePurposeId())); + m_ui->cbFirePurpose->setCurrentIndex(m_ui->cbFirePurpose->findData(ecData.firePurposeId)); // with firingType - setEffectClusterDataFromJson(ecData.properties()); + setEffectClusterDataFromJson(ecData.properties); const FiringType firingType = static_cast(m_ui->cbFiringType->currentData().toInt()); if (firingType == FiringType::FireWithIndicationTTF) @@ -718,39 +718,39 @@ void ExplosionsEditAdlerStandAlone::setEffectClusterData(const EffectCluster &ec } else { - m_ui->dteEffectStart->setMsecsSinceEpoch(ecData.effectStart().is_set() ? ecData.effectStart().get() : 0); + m_ui->dteEffectStart->setMsecsSinceEpoch(ecData.effectStart.has_value() ? ecData.effectStart.get() : 0); m_ui->lblEffectStart->setText(tr("Impact Time:")); } - m_ui->sbZog->setValue(ecData.tla()); // tla == zog + m_ui->sbZog->setValue(ecData.tla); // tla == zog - const AreaEffectSimulation::Area &areaRef = ecData.area(); - const QPointF bottomLeft(areaRef.cornerBottomLeft().lon(), areaRef.cornerBottomLeft().lat()); - const QPointF centerpoint = Polygons::bottomLeft2CenterPoint(bottomLeft, areaRef.width(), areaRef.height(), areaRef.rotation()); + const AreaEffectSimulation::Area &areaRef = ecData.area; + const QPointF bottomLeft(areaRef.cornerBottomLeft.lon, areaRef.cornerBottomLeft.lat); + const QPointF centerpoint = Polygons::bottomLeft2CenterPoint(bottomLeft, areaRef.width, areaRef.height, areaRef.rotation); if (!bottomLeft.isNull()) { m_ui->positionEdit->setCoordinate(centerpoint); setCoord(centerpoint); } - if (ecData.explosionGeometry().underlying() == AreaEffectSimulation::AesExplosionGeometry::EgRadial) + if (ecData.explosionGeometry == AreaEffectSimulation::AesExplosionGeometry::EgRadial) { - m_ui->sbDimensionY_Tiefe->setValue(areaRef.height() / 2); - m_ui->sbDimensionX_BreiteRadius->setValue(areaRef.width() / 2); + m_ui->sbDimensionY_Tiefe->setValue(areaRef.height / 2); + m_ui->sbDimensionX_BreiteRadius->setValue(areaRef.width / 2); m_ui->sbAimingAxis->setValue(0); } else { - m_ui->sbDimensionY_Tiefe->setValue(areaRef.height()); - m_ui->sbDimensionX_BreiteRadius->setValue(areaRef.width()); - m_ui->sbAimingAxis->setValue(fmod((90.0 + areaRef.rotation()) * 6400 / 360, 6400)); + m_ui->sbDimensionY_Tiefe->setValue(areaRef.height); + m_ui->sbDimensionX_BreiteRadius->setValue(areaRef.width); + m_ui->sbAimingAxis->setValue(fmod((90.0 + areaRef.rotation) * 6400 / 360, 6400)); } - if (!ecData.esmParticipantIds().empty()) + if (!ecData.esmParticipantIds.empty()) { - m_ui->cbActors->setCurrentIndex(m_ui->cbActors->findData(ecData.esmParticipantIds().at(0))); - if (ecData.esmParticipantIds().size() > 1) - m_ui->cbActors_2->setCurrentIndex(m_ui->cbActors_2->findData(ecData.esmParticipantIds().at(1))); + m_ui->cbActors->setCurrentIndex(m_ui->cbActors->findData(ecData.esmParticipantIds.at(0))); + if (ecData.esmParticipantIds.size() > 1) + m_ui->cbActors_2->setCurrentIndex(m_ui->cbActors_2->findData(ecData.esmParticipantIds.at(1))); } onEffectClusterChanged(ecData, DataModification::eAdded); @@ -762,7 +762,7 @@ void ExplosionsEditAdlerStandAlone::setEffectClusterData(const EffectCluster &ec void ExplosionsEditAdlerStandAlone::setEffector(const ParticipantManagement::Participant &part, const AreaEffectSimulation::AesEffectorState &effectorState) { auto *effectorWidget = new AesEffector(this); - effectorWidget->init(part.id(), QString::fromStdString(part.tacticalIdentifier()), QString::fromStdString(part.name()), effectorState); + effectorWidget->init(part.id, QString::fromStdString(part.tacticalIdentifier), QString::fromStdString(part.name), effectorState); effectorWidget->setStateButtonVisible(false); const int row = m_effectorNumber / m_maxColumns; @@ -798,7 +798,7 @@ void ExplosionsEditAdlerStandAlone::onChargeTypeChanged() setMinMaxConstraints(phfd, gearClassType, chargeTypeId); // only for geometryType::Point: - if (m_currentGeometry.underlying() == AreaEffectSimulation::AesExplosionGeometry::EgPoint) + if (m_currentGeometry == AreaEffectSimulation::AesExplosionGeometry::EgPoint) { int igniterTypeId = m_ui->cbIgniterType->currentData().toInt(); int igniterFunctionId = m_ui->cbIgniterFunction->currentData().toInt(); @@ -838,7 +838,7 @@ void ExplosionsEditAdlerStandAlone::onLoadTypeChanged() { const int chargeTypeId = m_ui->cbChargeType->currentData().toInt(); const int loadTypeId = m_ui->cbLoadType->currentData().toInt(); - const auto numbersVec = m_pdmDtc->getChargeTypeLoadType(chargeTypeId, loadTypeId).numbers(); + const auto numbersVec = m_pdmDtc->getChargeTypeLoadType(chargeTypeId, loadTypeId).numbers; m_ui->cbLoadNumber->clear(); m_ui->cbLoadNumber->addItem(emptyEntryComboBox, -1); @@ -914,7 +914,7 @@ void ExplosionsEditAdlerStandAlone::getPosition() m_previewPolygon.clear(); m_previewCircleRadius = 0.0; - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AreaEffectSimulation::AesExplosionGeometry::EgArea: { @@ -1055,7 +1055,7 @@ void ExplosionsEditAdlerStandAlone::onPolylineData(const QPolygonF &polyline) m_ui->sbDimensionX_BreiteRadius->setValue(distance); const Core::GeoPosition coordGeo2(utm2.geographic().x(), utm2.geographic().y(), 0); - const double height2 = getElevation(coordGeo2.lon(), coordGeo2.lat()); + const double height2 = getElevation(coordGeo2.lon, coordGeo2.lat); m_ui->sbHeight2SBox->setValue(height2); DEBUG_LOG(m_logger) << "sbHeight2SBox setValue=" << height2; @@ -1082,7 +1082,7 @@ void ExplosionsEditAdlerStandAlone::setCoord(const QPointF &coord) const Core::GeoPosition coordGeo(coord.x(), coord.y(), 0); m_coordGeo = coordGeo; - const double height = getElevation(coordGeo.lon(), coordGeo.lat()); + const double height = getElevation(coordGeo.lon, coordGeo.lat); m_ui->sbHeight1SBox->setValue(height); updateActorComboBox(coordGeo); @@ -1121,8 +1121,8 @@ void ExplosionsEditAdlerStandAlone::fillParticipantUnit() for (auto &superiorId : superiorIds) { const ParticipantManagement::Participant &part = m_ppmDtc->participant(superiorId); - unitList.push_back(std::tuple(QString::fromStdString(part.designator()) + QStringLiteral(" (%1)").arg(units.value(superiorId).count()), - part.id(), + unitList.push_back(std::tuple(QString::fromStdString(part.designator) + QStringLiteral(" (%1)").arg(units.value(superiorId).count()), + part.id, units.value(superiorId).count())); } std::sort(unitList.begin(), unitList.end()); @@ -1305,7 +1305,7 @@ void ExplosionsEditAdlerStandAlone::doCalculationsAdlerStandAlone(bool executeEn return; // do not update while EsPause or similar: - if ((m_effectClusterData.effectStateId() == AesEffectState::EsPaused) || (m_effectClusterData.effectStateId() == AesEffectState::EsExpired)) + if ((m_effectClusterData.effectStateId == AesEffectState::EsPaused) || (m_effectClusterData.effectStateId == AesEffectState::EsExpired)) return; doCalculationsAdlerStandAloneExitGuard exitGuard(this, executeEnableUiElements); @@ -1603,7 +1603,7 @@ void ExplosionsEditAdlerStandAlone::onPartitionTimeChanged(qint64 newPartitionTi QString ExplosionsEditAdlerStandAlone::dialogIdentifier() const { DEBUG_LOG(m_logger) << "dialogIdentifier"; - return m_aesItem.id() <= 0 ? QStringLiteral("AddExplosionsArtillery") : QStringLiteral("EditExplosionsArtillery%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddExplosionsArtillery") : QStringLiteral("EditExplosionsArtillery%1").arg(m_aesItem.id); } void ExplosionsEditAdlerStandAlone::onSetAesItemEffectorStateReply(const Core::FunctionReplyObject &replyObject) @@ -1615,7 +1615,7 @@ void ExplosionsEditAdlerStandAlone::onSetAesItemEffectorStateReply(const Core::F void ExplosionsEditAdlerStandAlone::onEffectClusterChanged(const EffectCluster &ecData, DataModification modType) { DEBUG_LOG(m_logger) << "onEffectClusterChanged "; - if (ecData.id() != m_aesItem.id()) + if (ecData.id != m_aesItem.id) return; BaseEdit::onAreaChanged(ecData, modType); @@ -1629,16 +1629,16 @@ void ExplosionsEditAdlerStandAlone::onEffectClusterChanged(const EffectCluster & m_effectClusterData = ecData; m_aesItem = ecData; - if (m_effectClusterData.remainExplosionNumber() <= 2) + if (m_effectClusterData.remainExplosionNumber <= 2) m_ui->sbCannons->setMinimum(0); - if (m_aesItem.id()) // Only on edit/show not during create - m_ui->sbCannons->setValue(m_effectClusterData.remainExplosionNumber()); + if (m_aesItem.id) // Only on edit/show not during create + m_ui->sbCannons->setValue(m_effectClusterData.remainExplosionNumber); // detect, if isObjectModifiable() changes to false: if ( // (m_explosionClusterData.isObjectModifiable()) && - (!ecData.isObjectModifiable())) + (!ecData.isObjectModifiable)) { INFO_LOG(m_logger) << " object becames not modifiable"; enableUiFireButton(); // "Start" -> "Pause"... @@ -1651,9 +1651,9 @@ void ExplosionsEditAdlerStandAlone::onEffectClusterChanged(const EffectCluster & m_enableStartBtnTimer->start(); } - m_currentGeometry = m_effectClusterData.explosionGeometry(); + m_currentGeometry = m_effectClusterData.explosionGeometry; - // if (ecData.flightCurve().is_set()) + // if (ecData.flightCurve().has_value()) //{ // const FlightCurve &fc = ecData.flightCurve().get(); // m_ui->leCalcFlightDuration->setText(QString(QStringLiteral("%1 sec")).arg(fc.calculatedFlightDuration()/1000.0)); @@ -1668,7 +1668,7 @@ void ExplosionsEditAdlerStandAlone::onEffectClusterChanged(const EffectCluster & if (!m_ui->sbDurationSec->isEnabled()) { const bool hasChanges = hasUnsavedChanges(); - m_ui->sbDurationSec->setValue(m_effectClusterData.effectDuration() / 1000); // msec -> sec + m_ui->sbDurationSec->setValue(m_effectClusterData.effectDuration / 1000); // msec -> sec if (!hasChanges) __unchange__(); } @@ -1676,12 +1676,12 @@ void ExplosionsEditAdlerStandAlone::onEffectClusterChanged(const EffectCluster & m_uiRequirements->checkRequirements(this); doCalculationsAdlerStandAlone(true); - if (m_aesItem.effectStateId() == AreaEffectSimulation::AesEffectState::EsCreated || - m_aesItem.effectStateId() == AreaEffectSimulation::AesEffectState::EsPrepared) + if (m_aesItem.effectStateId == AreaEffectSimulation::AesEffectState::EsCreated || + m_aesItem.effectStateId == AreaEffectSimulation::AesEffectState::EsPrepared) enableUiElements(!unchangeable()); - else if (m_aesItem.effectStateId() == AreaEffectSimulation::AesEffectState::EsExpired || - m_aesItem.effectStateId() == AreaEffectSimulation::AesEffectState::EsFired || - m_aesItem.effectStateId() == AreaEffectSimulation::AesEffectState::EsActivated) + else if (m_aesItem.effectStateId == AreaEffectSimulation::AesEffectState::EsExpired || + m_aesItem.effectStateId == AreaEffectSimulation::AesEffectState::EsFired || + m_aesItem.effectStateId == AreaEffectSimulation::AesEffectState::EsActivated) { if (hasUnsavedChanges()) __unchange__(); @@ -1747,8 +1747,8 @@ void ExplosionsEditAdlerStandAlone::retranslate() QString title = tr("ADLER Artillery"); translate(m_ui, m_aesItem, title); - if (m_aesItem.effectStateId() == AreaEffectSimulation::AesEffectState::EsCreated || - m_aesItem.effectStateId() == AreaEffectSimulation::AesEffectState::EsPrepared) + if (m_aesItem.effectStateId == AreaEffectSimulation::AesEffectState::EsCreated || + m_aesItem.effectStateId == AreaEffectSimulation::AesEffectState::EsPrepared) enableUiElements(!unchangeable()); if (!unchangeable()) @@ -1759,10 +1759,10 @@ void ExplosionsEditAdlerStandAlone::retranslate() void ExplosionsEditAdlerStandAlone::enableUiElements() { DEBUG_LOG(m_logger) << " enableUiElements()" - << ", m_effectClusterData.id() = " << m_effectClusterData.id() << ", isModifiable() = " << isModifiable() + << ", m_effectClusterData.id() = " << m_effectClusterData.id << ", isModifiable() = " << isModifiable() << ", isOnlyNameModifiable() = " << isOnlyNameModifiable() << ", ena = " << (isModifiable() && !isOnlyNameModifiable()); - if (m_effectClusterData.id() == 0) // while creation, not modification + if (m_effectClusterData.id == 0) // while creation, not modification enableUiElements(true); else enableUiElements(isModifiable() && !isOnlyNameModifiable()); @@ -1776,7 +1776,7 @@ void ExplosionsEditAdlerStandAlone::enableUiElements(bool enable) { DEBUG_LOG(m_logger) << "************* enableUiElements enable=" << enable << ", isOnlyNameModifiable = " << isOnlyNameModifiable(); - // // onGeometrySelected(static_cast(m_explosionClusterData.explosionGeometry().underlying())); + // // onGeometrySelected(static_cast(m_explosionClusterData.explosionGeometry())); m_ui->cbChargeType->setEnabled(enable); m_ui->cbIgniterType->setEnabled(enable && m_ui->cbIgniterType->count() > 1); @@ -1838,7 +1838,7 @@ void ExplosionsEditAdlerStandAlone::enableUiElements(bool enable) m_ui->cbTargetSubType->setEnabled(enable); m_ui->cbFiringType->setEnabled(enable); - const bool isRocket = (m_ui->cbGearClass->currentData().toInt() == ProjectDataManagement::GearClass::Rocket); + const bool isRocket = (m_ui->cbGearClass->currentData().toInt() == static_cast(ProjectDataManagement::GearClass::GearClass_Rocket)); m_ui->lblLoadType->setEnabled(!isRocket && enable); m_ui->lblLoadNumber->setEnabled(!isRocket && enable); m_ui->cbLoadType->setEnabled(!isRocket && enable); @@ -1857,8 +1857,8 @@ void ExplosionsEditAdlerStandAlone::enableUiElements(bool enable) // [GUEZE-2960] Explizite Kunden-Forderung: // ZpNumber nicht_ mehr modifizierbar, wenn Wirkfeld aktiv - m_ui->leZpNumber->setEnabled((enable || isOnlyNameModifiable()) && m_aesItem.effectStateId() != AesEffectState::EsActivated); - m_ui->leElement->setEnabled((enable || isOnlyNameModifiable()) && m_aesItem.effectStateId() != AesEffectState::EsActivated); + m_ui->leZpNumber->setEnabled((enable || isOnlyNameModifiable()) && m_aesItem.effectStateId != AesEffectState::EsActivated); + m_ui->leElement->setEnabled((enable || isOnlyNameModifiable()) && m_aesItem.effectStateId != AesEffectState::EsActivated); m_ui->pbClear->setEnabled(enable); @@ -1868,12 +1868,12 @@ void ExplosionsEditAdlerStandAlone::enableUiElements(bool enable) int numberTrajectoriesRef = 0; { - const int simToRestrict = m_aesItem.id(); // EffectCluster + const int simToRestrict = m_aesItem.id; // EffectCluster // avoid data copying: auto cb = [simToRestrict, &numberTrajectoriesRef](const AreaEffectSimulation::TrajectoryTimeAware &traj) { // [E01562-259] use originatorId, originatorTypeId (instead of aesItemId, aesTypeId) - if ((traj.originatorTypeId() == ProjectDataManagement::StateChangeOriginator::ChargeEffect) && (simToRestrict == traj.originatorId())) + if ((traj.originatorTypeId == ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_ChargeEffect) && (simToRestrict == traj.originatorId)) ++numberTrajectoriesRef; }; m_dtc->trajectoryTimeAwares(cb); @@ -1881,7 +1881,7 @@ void ExplosionsEditAdlerStandAlone::enableUiElements(bool enable) DEBUG_LOG(m_logger) << "************* enableUiElements numberTrajectoriesRef=" << numberTrajectoriesRef; - if ((numberTrajectoriesRef > 0) && !isPointSimilar(m_effectClusterData.explosionGeometry())) + if ((numberTrajectoriesRef > 0) && !isPointSimilar(m_effectClusterData.explosionGeometry)) { // since first TrajectoryTimeAware: enableUiFireButton(); @@ -1889,7 +1889,7 @@ void ExplosionsEditAdlerStandAlone::enableUiElements(bool enable) else { // until first TrajectoryTimeAware: - m_ui->startBtn->setEnabled(enable && m_aesItem.id() > 0); // tbc + m_ui->startBtn->setEnabled(enable && m_aesItem.id > 0); // tbc } setFireBtnState(); @@ -1909,7 +1909,7 @@ void ExplosionsEditAdlerStandAlone::enableUiElements(bool enable) // const bool useFlightDuration = m_ui->sBox_flightDuration->styleSheet().isEmpty(); // m_ui->cbFlightCurve->setEnabled(enable && - // (gearClassType != ProjectDataManagement::GearClass::Mortar) && + // (gearClassType != ProjectDataManagement::GearClass::GearClass_Mortar) && // useFlightDuration // ); // } @@ -1936,7 +1936,7 @@ void ExplosionsEditAdlerStandAlone::enableUiFireButton() // (not initial creation) // - bool enableBasics = (m_aesItem.id() > 0) // while creation, not modification + bool enableBasics = (m_aesItem.id > 0) // while creation, not modification && isDataSufficiant(); INFO_LOG(m_logger) << " enableBasics = " << enableBasics; @@ -1944,20 +1944,20 @@ void ExplosionsEditAdlerStandAlone::enableUiFireButton() if (!enableBasics) return; // stay disabled - if (m_effectClusterData.effectStateId() == AreaEffectSimulation::AesEffectState::EsExpired || m_effectClusterData.remainExplosionNumber() == 0) + if (m_effectClusterData.effectStateId == AreaEffectSimulation::AesEffectState::EsExpired || m_effectClusterData.remainExplosionNumber == 0) return; // stay disabled int numberTrajectoriesRef = 0; { - const int simToRestrict = m_aesItem.id(); + const int simToRestrict = m_aesItem.id; // avoid data copying: auto cb = [simToRestrict, &numberTrajectoriesRef](const AreaEffectSimulation::TrajectoryTimeAware &traj) { // iterateAll // be aware of: [E01562-259] use originatorId, originatorTypeId (instead of aesItemId, aesTypeId) - if (traj.originatorTypeId() != ProjectDataManagement::StateChangeOriginator::ChargeEffect) + if (traj.originatorTypeId != ProjectDataManagement::StateChangeOriginator::StateChangeOriginator_ChargeEffect) return; - const int aesItemId = traj.originatorId(); + const int aesItemId = traj.originatorId; if (simToRestrict == aesItemId) ++numberTrajectoriesRef; }; @@ -1970,11 +1970,11 @@ void ExplosionsEditAdlerStandAlone::enableUiFireButton() // a) during typical usage by operator // b) for re-openening dialog / restart svcAes int impactCount = 0; - for (const auto &effector : m_effectClusterData.effectors()) + for (const auto &effector : m_effectClusterData.effectors) { - impactCount += effector.chargeAmount(); + impactCount += effector.chargeAmount; } - if ((numberTrajectoriesRef <= 0) && (m_effectClusterData.effectDuration() == m_effectClusterData.originalEffectDuration())) + if ((numberTrajectoriesRef <= 0) && (m_effectClusterData.effectDuration == m_effectClusterData.originalEffectDuration)) { INFO_LOG(m_logger) << " Firing has NOT started yet"; return; // stay disabled @@ -2001,7 +2001,7 @@ void ExplosionsEditAdlerStandAlone::enableUiFireButton() else { // re-openening dialog: - if (m_effectClusterData.effectStateId() == AesEffectState::EsPaused) + if (m_effectClusterData.effectStateId == AesEffectState::EsPaused) bPause = false; } } @@ -2018,7 +2018,7 @@ void ExplosionsEditAdlerStandAlone::enableUiFireButton() { // Resume // but it does not makes sense, if there is no ammo left: - if ((impactCount > 1) && (impactCount >= m_effectClusterData.remainExplosionNumber())) + if ((impactCount > 1) && (impactCount >= m_effectClusterData.remainExplosionNumber)) { m_ui->startBtn->setEnabled(true); m_ui->startBtn->setText(tr("Start")); @@ -2039,7 +2039,7 @@ void ExplosionsEditAdlerStandAlone::showPreviewObject() if (!has2DMap(false)) // showMsgBoxIfNot2D return; - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AreaEffectSimulation::AesExplosionGeometry::EgArea: if (m_previewPolygon.isEmpty()) @@ -2084,7 +2084,7 @@ bool ExplosionsEditAdlerStandAlone::isDataSufficiant() // target: bool bHasTargetArea = !m_coord.isNull(); - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AreaEffectSimulation::AesExplosionGeometry::EgArea: bHasTargetArea &= m_ui->sbDimensionX_BreiteRadius->value() > 0; @@ -2117,34 +2117,34 @@ bool ExplosionsEditAdlerStandAlone::apply() EffectClusterModifyRequest request; - request.id(m_aesItem.id()); - request.element(m_ui->leElement->text().toStdString()); - request.name(m_ui->leZpNumber->text().toStdString()); - request.firePurposeId(m_ui->cbFirePurpose->currentData().toInt()); + request.id = m_aesItem.id; + request.element = m_ui->leElement->text().toStdString(); + request.name = m_ui->leZpNumber->text().toStdString(); + request.firePurposeId = m_ui->cbFirePurpose->currentData().toInt(); if (m_ui->dteEffectStart->isChecked() && m_ui->dteEffectStart->isVisible()) { // we use the effect start as usual - request.effectStart().set(m_ui->dteEffectStart->msecsSinceEpoch()); + request.effectStart.set(m_ui->dteEffectStart->msecsSinceEpoch()); } if (m_ui->sbDurationSec->isVisible()) - request.effectDuration(m_ui->sbDurationSec->value() * 1000); + request.effectDuration = m_ui->sbDurationSec->value() * 1000; const bool bIsPoint = isPointSimilar(m_currentGeometry); - request.explosionGeometry(m_currentGeometry); + request.explosionGeometry = m_currentGeometry; Core::GeoPosition2D bottomLeftGeo; - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AesExplosionGeometry::EgRadial: { QPointF bottomLeft(Polygons::centerPoint2BottomLeft(m_coord, m_ui->sbDimensionX_BreiteRadius->value() * 2, m_ui->sbDimensionY_Tiefe->value() * 2, 0.0)); bottomLeftGeo = Core::GeoPosition2D(bottomLeft.x(), bottomLeft.y()); - request.area().cornerBottomLeft(bottomLeftGeo); - request.area().height(m_ui->sbDimensionY_Tiefe->value() * 2); - request.area().width(m_ui->sbDimensionX_BreiteRadius->value() * 2); + request.area.cornerBottomLeft = bottomLeftGeo; + request.area.height = m_ui->sbDimensionY_Tiefe->value() * 2; + request.area.width = m_ui->sbDimensionX_BreiteRadius->value() * 2; break; } @@ -2158,9 +2158,9 @@ bool ExplosionsEditAdlerStandAlone::apply() (m_ui->sbAimingAxis->value() - 1600) * 360.0 / 6400)); bottomLeftGeo = Core::GeoPosition2D(bottomLeft.x(), bottomLeft.y()); - request.area().cornerBottomLeft(bottomLeftGeo); - request.area().height(m_ui->sbDimensionY_Tiefe->value()); - request.area().width(m_ui->sbDimensionX_BreiteRadius->value()); + request.area.cornerBottomLeft = bottomLeftGeo; + request.area.height = m_ui->sbDimensionY_Tiefe->value(); + request.area.width = m_ui->sbDimensionX_BreiteRadius->value(); break; } @@ -2175,17 +2175,17 @@ bool ExplosionsEditAdlerStandAlone::apply() (m_ui->sbAimingAxis->value() - 1600) * 360.0 / 6400)); bottomLeftGeo = Core::GeoPosition2D(bottomLeft.x(), bottomLeft.y()); - request.area().cornerBottomLeft(bottomLeftGeo); - request.area().height(m_ui->sbDimensionY_Tiefe->value()); - request.area().width(m_ui->sbDimensionX_BreiteRadius->value()); + request.area.cornerBottomLeft = bottomLeftGeo; + request.area.height = m_ui->sbDimensionY_Tiefe->value(); + request.area.width = m_ui->sbDimensionX_BreiteRadius->value(); } } - if (bIsPoint || m_currentGeometry.underlying() == AreaEffectSimulation::AesExplosionGeometry::EgRadial) - request.area().rotation(0); + if (bIsPoint || m_currentGeometry == AreaEffectSimulation::AesExplosionGeometry::EgRadial) + request.area.rotation = 0; else - request.area().rotation((m_ui->sbAimingAxis->value() - 1600) * 360.0 / 6400); - request.tla(m_ui->sbZog->value()); // tla: aka zog / ZielOrtungsGenauigkeit + request.area.rotation = (m_ui->sbAimingAxis->value() - 1600) * 360.0 / 6400; + request.tla = m_ui->sbZog->value(); // tla: aka zog / ZielOrtungsGenauigkeit // DMF (Actors) int esmParticipantId1 = m_ui->cbActors->currentData().toInt(); // participant ID @@ -2196,11 +2196,11 @@ bool ExplosionsEditAdlerStandAlone::apply() if (esmParticipantId1 > 0 || esmParticipantId2 > 0) { - request.esmParticipantIds().reserve(2); + request.esmParticipantIds.reserve(2); if (esmParticipantId1 > 0) - request.esmParticipantIds().push_back(esmParticipantId1); + request.esmParticipantIds.push_back(esmParticipantId1); if (esmParticipantId2 > 0 && esmParticipantId1 != esmParticipantId2 && m_ui->cbActors_2->isEnabled()) - request.esmParticipantIds().push_back(esmParticipantId2); + request.esmParticipantIds.push_back(esmParticipantId2); } // mhpCount: @@ -2213,19 +2213,19 @@ bool ExplosionsEditAdlerStandAlone::apply() { EffectorData effectorData; - if (m_data.effectors().size() == 1 && m_data.participantId().is_set() && unitParticipant.id() == m_data.participantId().get()) + if (m_data.effectors.size() == 1 && m_data.participantId.has_value() && unitParticipant.id == m_data.participantId.get()) { // Update - effectorData = m_data.effectors().front(); + effectorData = m_data.effectors.front(); } - effectorData.chargeAmount(1); + effectorData.chargeAmount = 1; // add GearClass ??? - effectorData.chargeStruct().chargeTypeId(m_ui->cbChargeType->currentData().toInt()); - effectorData.chargeStruct().igniterTypeId(m_ui->cbIgniterType->currentData().toInt()); - effectorData.chargeStruct().igniterFunctionId(m_ui->cbIgniterFunction->currentData().toInt()); - effectorData.participantId() = unitParticipant.inferiorIds().front(); // set the first inferior als start - request.effectors().push_back(effectorData); + effectorData.chargeStruct.chargeTypeId = m_ui->cbChargeType->currentData().toInt(); + effectorData.chargeStruct.igniterTypeId = m_ui->cbIgniterType->currentData().toInt(); + effectorData.chargeStruct.igniterFunctionId = m_ui->cbIgniterFunction->currentData().toInt(); + effectorData.participantId = unitParticipant.inferiorIds.front(); // set the first inferior als start + request.effectors.push_back(effectorData); } else { @@ -2244,48 +2244,48 @@ bool ExplosionsEditAdlerStandAlone::apply() // if INFO_LOG(m_logger) << " OLD DATA " << m_data; - for (int inferiorParticipantId : unitParticipant.inferiorIds()) + for (int inferiorParticipantId : unitParticipant.inferiorIds) { INFO_LOG(m_logger) << "Inferoir for " << unitParticipantId << " is: " << inferiorParticipantId; EffectorData effectoData; - if (m_data.effectors().size() == unitParticipant.inferiorIds().size() && m_data.participantId().is_set() && m_data.participantId().get() == unitParticipantId) + if (m_data.effectors.size() == unitParticipant.inferiorIds.size() && m_data.participantId.has_value() && m_data.participantId.get() == unitParticipantId) { - for (const auto &oldEffector : m_data.effectors()) + for (const auto &oldEffector : m_data.effectors) { - if (oldEffector.participantId() == inferiorParticipantId) + if (oldEffector.participantId == inferiorParticipantId) { effectoData = oldEffector; // Reset chargeAmount as we override it later - effectoData.chargeAmount() = 0; + effectoData.chargeAmount = 0; INFO_LOG(m_logger) << " FOND OLD for " << inferiorParticipantId; break; } } } - INFO_LOG(m_logger) << effectoData.mhpPosition() << " pos from old?"; - effectoData.participantId() = inferiorParticipantId; - effectoData.mhpPosition().z(m_ui->sbHeight1SBox->value()); + INFO_LOG(m_logger) << effectoData.mhpPosition << " pos from old?"; + effectoData.participantId = inferiorParticipantId; + effectoData.mhpPosition.z = m_ui->sbHeight1SBox->value(); // add GearClass ??? - effectoData.chargeStruct().chargeTypeId(m_ui->cbChargeType->currentData().toInt()); - effectoData.chargeStruct().igniterTypeId(m_ui->cbIgniterType->currentData().toInt()); - effectoData.chargeStruct().igniterFunctionId(m_ui->cbIgniterFunction->currentData().toInt()); - request.effectors().push_back(effectoData); + effectoData.chargeStruct.chargeTypeId = m_ui->cbChargeType->currentData().toInt(); + effectoData.chargeStruct.igniterTypeId = m_ui->cbIgniterType->currentData().toInt(); + effectoData.chargeStruct.igniterFunctionId = m_ui->cbIgniterFunction->currentData().toInt(); + request.effectors.push_back(effectoData); // break if we have less round than iferior - if (request.effectors().size() == (u_int)m_ui->sbCannons->value()) + if (request.effectors.size() == (u_int)m_ui->sbCannons->value()) break; } - if (request.effectors().size() == 0) + if (request.effectors.size() == 0) return false; // now divide rounds into effectors u_int effectorPos = 0; for (int i = 0; i < m_ui->sbCannons->value(); i++) { - request.effectors().at(effectorPos).chargeAmount() = request.effectors().at(effectorPos).chargeAmount() + 1; + request.effectors.at(effectorPos).chargeAmount = request.effectors.at(effectorPos).chargeAmount + 1; effectorPos++; - if (effectorPos >= request.effectors().size()) + if (effectorPos >= request.effectors.size()) { effectorPos = 0; } @@ -2294,23 +2294,23 @@ bool ExplosionsEditAdlerStandAlone::apply() } // partyId - request.partyId().set(m_ui->cbParty->currentData().toInt()); + request.partyId.set(m_ui->cbParty->currentData().toInt()); // participant id - request.participantId().set(unitParticipantId); - request.partyId().set(m_ui->cbParty->currentData().toInt()); - request.effectMarkingInTa(m_ui->gbEffectMarkingInTa->isChecked()); - request.effectSourceId(ProjectDataManagement::EffectSource::ES_ADLER_STANDALONE); + request.participantId.set(unitParticipantId); + request.partyId.set(m_ui->cbParty->currentData().toInt()); + request.effectMarkingInTa = m_ui->gbEffectMarkingInTa->isChecked(); + request.effectSourceId = ProjectDataManagement::EffectSource::ES_ADLER_STANDALONE; QJsonObject propertiesObj; mmiToJsonproperties(propertiesObj); const QString properties = QString::fromUtf8(QJsonDocument(propertiesObj).toJson()); DEBUG_LOG(m_logger) << "properties: " << properties; - request.properties(properties.toStdString()); + request.properties = properties.toStdString(); // Rocket-Spezifika: const QVariant currentData = m_ui->cbGearClass->currentData(); const ProjectDataManagement::GearClass currentGearClass = static_cast(currentData.toInt()); - if (currentGearClass == ProjectDataManagement::GearClass::Rocket) + if (currentGearClass == ProjectDataManagement::GearClass::GearClass_Rocket) { RocketUtility::addRocketPropertiesToRequest(request, m_ppmDtc); } @@ -2334,7 +2334,7 @@ void ExplosionsEditAdlerStandAlone::onGeometrySelected(int explosionGeometryInt) m_currentGeometry = newGeometry; - RocketUtility::enaDisaWirkmittel(m_ui->cbGearClass, m_currentGeometry.underlying()); + RocketUtility::enaDisaWirkmittel(m_ui->cbGearClass, m_currentGeometry); // cancel active Rubberbands: if (m_sitMapGuiIfc) @@ -2352,7 +2352,7 @@ void ExplosionsEditAdlerStandAlone::onGeometrySelected(int explosionGeometryInt) if (m_sitMapGuiIfc) m_sitMapGuiIfc->removePreviewObject(); - switch (m_currentGeometry.underlying()) + switch (m_currentGeometry) { case AreaEffectSimulation::AesExplosionGeometry::EgAimPoint: // What is AimPoint? case AreaEffectSimulation::AesExplosionGeometry::EgPoint: @@ -2474,12 +2474,12 @@ void ExplosionsEditAdlerStandAlone::onGeometrySelected(int explosionGeometryInt) void ExplosionsEditAdlerStandAlone::onStartBtnClicked() { DEBUG_LOG(m_logger) << " onFireClicked"; - if (((m_aesItem.effectStateId() == AesEffectState::EsUnknown) || // initially the effectStateId is Unknown... - (m_aesItem.effectStateId() == AesEffectState::EsError) || (m_aesItem.effectStateId() == AesEffectState::EsExpired) - || (m_aesItem.effectStateId() == AesEffectState::EsRemoved) || (m_aesItem.effectStateId() == AesEffectState::EsReceived) + if (((m_aesItem.effectStateId == AesEffectState::EsUnknown) || // initially the effectStateId is Unknown... + (m_aesItem.effectStateId == AesEffectState::EsError) || (m_aesItem.effectStateId == AesEffectState::EsExpired) + || (m_aesItem.effectStateId == AesEffectState::EsRemoved) || (m_aesItem.effectStateId == AesEffectState::EsReceived) // || (m_aesItem.effectStateId() == AesEffectState::EsPaused) // Maybe EsPaused will be supported in future ) - || m_aesItem.id() <= 0) + || m_aesItem.id <= 0) return; if (!isDataSufficiant()) @@ -2495,19 +2495,19 @@ void ExplosionsEditAdlerStandAlone::onStartBtnClicked() m_ui->startBtn->setEnabled(false); - const bool bIsObjectModifiable = m_effectClusterData.isObjectModifiable(); + const bool bIsObjectModifiable = m_effectClusterData.isObjectModifiable; // - if ((m_aesItem.effectStateId() == AesEffectState::EsCreated || m_aesItem.effectStateId() == AesEffectState::EsPrepared) && bIsObjectModifiable) + if ((m_aesItem.effectStateId == AesEffectState::EsCreated || m_aesItem.effectStateId == AesEffectState::EsPrepared) && bIsObjectModifiable) { ERROR_LOG(m_logger) << LOGFUNCTION << " onFireClicked 2 " << m_data; - if (!m_data.effectors().size()) + if (!m_data.effectors.size()) return; ERROR_LOG(m_logger) << LOGFUNCTION << " onFireClicked 3"; - double estimatedFlightDurationMsec = m_data.effectors().front().flightTime(); + double estimatedFlightDurationMsec = m_data.effectors.front().flightTime; m_ui->dteEffectStart->setMsecsSinceEpoch(m_session->partitionTime() + estimatedFlightDurationMsec + 15000); @@ -2546,9 +2546,9 @@ void ExplosionsEditAdlerStandAlone::onStartBtnClicked() m_requestHelper->addRequest( [=]() { - return m_ftc->effectClusterPauseResumeRequest(EffectClusterPauseResumeRequest(m_aesItem.id(), + return m_ftc->effectClusterPauseResumeRequest(EffectClusterPauseResumeRequest(m_aesItem.id, resumeExecution, // resumeExecution - dds::core::optional(), + dds::core::optional(), dds::core::optional(), dds::core::optional()), this); @@ -2573,7 +2573,7 @@ void ExplosionsEditAdlerStandAlone::onGearClassChanged() fillParties(); onPartyChanged(); - ProjectDataManagement::GearClass lastGearClassType = ProjectDataManagement::GearClass::Mortar; + ProjectDataManagement::GearClass lastGearClassType = ProjectDataManagement::GearClass::GearClass_Mortar; QVariant lastVal = m_ui->cbGearClass->property(LAST_VALUE); if (!lastVal.isNull()) lastGearClassType = static_cast(lastVal.toInt()); @@ -2587,7 +2587,7 @@ void ExplosionsEditAdlerStandAlone::onGearClassChanged() // Default is Upper m_ui->rbAngleGroupUpper->setChecked(true); // GUEZE-3520: Aufraeumen -> getm rid of AesFlightCurve - if (newGearClassType == ProjectDataManagement::GearClass::Mortar) + if (newGearClassType == ProjectDataManagement::GearClass::GearClass_Mortar) { DEBUG_LOG(m_logger) << " onGearClassChanged switch to Mortar"; m_ui->rbAngleGroupLower->setCheckable(false); @@ -2618,7 +2618,7 @@ void ExplosionsEditAdlerStandAlone::onGearClassChanged() } // update last value: - m_ui->cbGearClass->setProperty(LAST_VALUE, newGearClassType); + m_ui->cbGearClass->setProperty(LAST_VALUE, static_cast(newGearClassType)); doCalculationsAdlerStandAlone(); } @@ -2637,24 +2637,24 @@ void ExplosionsEditAdlerStandAlone::gatherParticipantUnits(const int &partyId, Q auto cb = [this, &partyId, &units, gearClassId](const ParticipantManagement::Participant &part) { - if (part.isDeleted() || part.partyId() != partyId) + if (part.isDeleted || part.partyId != partyId) return; const ParticipantManagement::ParticipantData &ppData = m_ppmDtc->convertParticipantToParticipantData(part); - const ParticipantManagement::Type &ppType = m_ppmDtc->type(ppData.typeId()); + const ParticipantManagement::Type &ppType = m_ppmDtc->type(ppData.typeId); // do not use ADLER Verbund types - if (m_ppmDtc->isAdlerVerbund(ppType.id())) + if (m_ppmDtc->isAdlerVerbund(ppType.id)) return; - const QJsonObject typeProperties(QJsonDocument::fromJson(QByteArray::fromStdString(ppType.properties())).object()); + const QJsonObject typeProperties(QJsonDocument::fromJson(QByteArray::fromStdString(ppType.properties)).object()); // superior ids in participant ids will be saved // participant ids with type units are ignored // participant ids with type GroundVehicule are considered // participant ids without properties "isArtillery=true" are ignored - if (typeProperties.isEmpty() || ppType.typeClass() == ParticipantManagement::TypeClass::Unit || // + if (typeProperties.isEmpty() || ppType.typeClass == ParticipantManagement::TypeClass::Unit || // !typeProperties[QStringLiteral("isArtillery")].toBool(false) || typeProperties[QStringLiteral("gearClassId")].toInt(-1) != gearClassId) return; - units[part.superiorId()] += part.id(); + units[part.superiorId] += part.id; }; m_ppmDtc->participants(cb); @@ -2662,9 +2662,9 @@ void ExplosionsEditAdlerStandAlone::gatherParticipantUnits(const int &partyId, Q for (auto it = units.begin(); it != units.end();) { const ParticipantManagement::Participant &pp = m_ppmDtc->participant(it.key()); - const ParticipantManagement::Type &typ = m_ppmDtc->type(pp.typeId()); - const QJsonObject typeProperties(QJsonDocument::fromJson(QByteArray::fromStdString(typ.properties())).object()); - if ((typ.typeClass() != ParticipantManagement::TypeClass::Unit && typ.typeClass() != ParticipantManagement::TypeClass::GroundVehicle) + const ParticipantManagement::Type &typ = m_ppmDtc->type(pp.typeId); + const QJsonObject typeProperties(QJsonDocument::fromJson(QByteArray::fromStdString(typ.properties)).object()); + if ((typ.typeClass != ParticipantManagement::TypeClass::Unit && typ.typeClass != ParticipantManagement::TypeClass::GroundVehicle) || !typeProperties[QStringLiteral("isArtillery")].toBool(false)) it = units.erase(it++); else @@ -2699,11 +2699,11 @@ bool ExplosionsEditAdlerStandAlone::isValidParty(qint32 partyId) return m_ppmDtc->participants(static_cast>( [this, partyId, gearClassId](const ParticipantManagement::Participant &participant) { - if (participant.partyId() != partyId || participant.isDeleted()) + if (participant.partyId != partyId || participant.isDeleted) return false; - const ParticipantManagement::Type type = m_ppmDtc->type(participant.typeId()); - const QJsonObject typeProperties = QJsonDocument::fromJson(QByteArray::fromStdString(type.properties())).object(); + const ParticipantManagement::Type type = m_ppmDtc->type(participant.typeId); + const QJsonObject typeProperties = QJsonDocument::fromJson(QByteArray::fromStdString(type.properties)).object(); const qint32 typeGearClass = typeProperties.value(QStringLiteral("gearClassId")).toInt(-1); return typeGearClass == gearClassId; @@ -2717,12 +2717,12 @@ void ExplosionsEditAdlerStandAlone::setFireBtnState() m_ui->dteEffectStart->setEnabled(showEffectStart); m_ui->dteEffectStart->setVisible(showEffectStart); m_ui->lblEffectStart->setVisible(showEffectStart); - if (firingType == FiringType::FireWithIndicationTTF && m_aesItem.id() > 0) + if (firingType == FiringType::FireWithIndicationTTF && m_aesItem.id > 0) m_ui->lblEffectStart->setText(tr("Fire Time:")); else m_ui->lblEffectStart->setText(tr("Impact Time:")); - if (m_effectClusterData.effectorState() == AesEffectorState::EsReadyToFire) + if (m_effectClusterData.effectorState == AesEffectorState::EsReadyToFire) m_ui->fireBtn->setText(tr("Fire")); else m_ui->fireBtn->setText(tr("Ready to fire")); @@ -2731,39 +2731,39 @@ void ExplosionsEditAdlerStandAlone::setFireBtnState() const bool effectorsReady = allEffectorReadyToFire(); m_ui->fireBtn->setEnabled(enableFireBtn); - DEBUG_LOG(m_logger) << "FiringType: " << firingType << ", effectStateId: " << m_aesItem.effectStateId(); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired || m_aesItem.effectStateId() == AesEffectState::EsError - || m_aesItem.effectStateId() == AesEffectState::EsPrepared || m_aesItem.effectStateId() == AesEffectState::EsRemoved - || ((m_aesItem.effectStateId() == AesEffectState::EsFired || m_aesItem.effectStateId() == AesEffectState::EsActivated) && firingType != FiringType::FireOnCommand) - || m_aesItem.effectStateId() == AesEffectState::EsReceived || m_aesItem.id() <= 0) + DEBUG_LOG(m_logger) << "FiringType: " << firingType << ", effectStateId: " << m_aesItem.effectStateId; + if (m_aesItem.effectStateId == AesEffectState::EsExpired || m_aesItem.effectStateId == AesEffectState::EsError + || m_aesItem.effectStateId == AesEffectState::EsPrepared || m_aesItem.effectStateId == AesEffectState::EsRemoved + || ((m_aesItem.effectStateId == AesEffectState::EsFired || m_aesItem.effectStateId == AesEffectState::EsActivated) && firingType != FiringType::FireOnCommand) + || m_aesItem.effectStateId == AesEffectState::EsReceived || m_aesItem.id <= 0) return; - if ((firingType == FiringType::FireOnCommand && m_effectClusterData.remainExplosionNumber() <= 0) - || (firingType == FiringType::FireOnCommand && m_effectClusterData.remainExplosionNumber() > 0 && !effectorsReady)) + if ((firingType == FiringType::FireOnCommand && m_effectClusterData.remainExplosionNumber <= 0) + || (firingType == FiringType::FireOnCommand && m_effectClusterData.remainExplosionNumber > 0 && !effectorsReady)) return; // keep the comment for now as we might reactivate this shorty! when the cadence will be used in FireOnCOmmand! // if ((effectorsReady && m_effectClusterData.effectorState() == AesEffectorState::EsNotReadyToFire) || (firingType == FiringType::FireOnCommand && !effectorsReady) // || (effectorsReady && m_effectClusterData.effectorState() == AesEffectorState::EsReadyToFire && firingType == FiringType::FireOnCommand)) enableFireBtn = true; - DEBUG_LOG(m_logger) << " enableFireBtn:" << enableFireBtn << " Effectors ready " << effectorsReady << " current Effector State: " << m_effectClusterData.effectorState() + DEBUG_LOG(m_logger) << " enableFireBtn:" << enableFireBtn << " Effectors ready " << effectorsReady << " current Effector State: " << m_effectClusterData.effectorState << " firetype: " << firingType; m_ui->fireBtn->setEnabled(enableFireBtn); } void ExplosionsEditAdlerStandAlone::onFireBtnClicked() { - if (m_aesItem.effectStateId() == AesEffectState::EsExpired || m_aesItem.effectStateId() == AesEffectState::EsError - || m_aesItem.effectStateId() == AesEffectState::EsRemoved || m_aesItem.effectStateId() == AesEffectState::EsReceived || m_aesItem.id() <= 0) + if (m_aesItem.effectStateId == AesEffectState::EsExpired || m_aesItem.effectStateId == AesEffectState::EsError + || m_aesItem.effectStateId == AesEffectState::EsRemoved || m_aesItem.effectStateId == AesEffectState::EsReceived || m_aesItem.id <= 0) return; // Fire - if (allEffectorReadyToFire() && m_effectClusterData.effectorState() == AesEffectorState::EsReadyToFire) + if (allEffectorReadyToFire() && m_effectClusterData.effectorState == AesEffectorState::EsReadyToFire) { AreaEffectSimulation::SetAesItemEffectorStateRequest request; - request.aesId(m_aesItem.id()); - request.newEffectorState(AesEffectorState::EsReceivedOrder); - DEBUG_LOG(m_logger) << "Send setAesItemEffectorStateRequest with aesId: " << request.aesId() << ", AesEffectorState: " << request.newEffectorState(); + request.aesId = m_aesItem.id; + request.newEffectorState = AesEffectorState::EsReceivedOrder; + DEBUG_LOG(m_logger) << "Send setAesItemEffectorStateRequest with aesId: " << request.aesId << ", AesEffectorState: " << request.newEffectorState; m_requestHelper->addRequest([this, request]() { return m_ftc->setAesItemEffectorStateRequest(request, this); }); @@ -2772,9 +2772,9 @@ void ExplosionsEditAdlerStandAlone::onFireBtnClicked() else // ready to fire { AreaEffectSimulation::SetAesItemEffectorStateRequest request; - request.aesId(m_aesItem.id()); - request.newEffectorState(AesEffectorState::EsReadyToFire); - DEBUG_LOG(m_logger) << "Send setAesItemEffectorStateRequest with aesId: " << request.aesId() << ", AesEffectorState: " << request.newEffectorState(); + request.aesId = m_aesItem.id; + request.newEffectorState = AesEffectorState::EsReadyToFire; + DEBUG_LOG(m_logger) << "Send setAesItemEffectorStateRequest with aesId: " << request.aesId << ", AesEffectorState: " << request.newEffectorState; m_requestHelper->addRequest([this, request]() { return m_ftc->setAesItemEffectorStateRequest(request, this); }); m_ui->fireBtn->setEnabled(false); @@ -2816,7 +2816,7 @@ void ExplosionsEditAdlerStandAlone::onWidthChanged(int width) m_ui->positionEdit_2->setCoordinate(utm2New.geographic()); const Core::GeoPosition coordGeo(utm2New.geographic().x(), utm2New.geographic().y(), 0); - const double height = getElevation(coordGeo.lon(), coordGeo.lat()); + const double height = getElevation(coordGeo.lon, coordGeo.lat); m_ui->sbHeight1SBox->setValue(height); } @@ -2871,11 +2871,11 @@ void ExplosionsEditAdlerStandAlone::onLineP2Changed(const QPointF &point) bool ExplosionsEditAdlerStandAlone::allEffectorReadyToFire() const { - const auto &effectors = m_effectClusterData.effectors(); + const auto &effectors = m_effectClusterData.effectors; size_t fireReadyCount = 0; for (const auto &e : effectors) { - if (m_dtc->effector(e.participantId()).effectorState() != AreaEffectSimulation::AesEffectorState::EsReadyToFire) + if (m_dtc->effector(e.participantId).effectorState != AreaEffectSimulation::AesEffectorState::EsReadyToFire) continue; fireReadyCount++; } @@ -2911,15 +2911,15 @@ void ExplosionsEditAdlerStandAlone::fillCharges() for (const ProjectDataManagement::ChargeType &chargeType : std::as_const(chargesForGearClass)) { // Vulcano ist available for point geometry only: - const bool bIsVulcano = chargeTypeIdIsVulcano(chargeType.id()); - QString adlerChargeTypeName = m_pdmDtc->adlerChargeTypeName(chargeType.id()); + const bool bIsVulcano = chargeTypeIdIsVulcano(chargeType.id); + QString adlerChargeTypeName = m_pdmDtc->adlerChargeTypeName(chargeType.id); DEBUG_LOG(m_logger) << " fillCharges" - << ", id=" << chargeType.id() << ", name= " << chargeType.name() << ", bIsPoint " << bIsPoint << ", bIsVulcano " << bIsVulcano; + << ", id=" << chargeType.id << ", name= " << chargeType.name << ", bIsPoint " << bIsPoint << ", bIsVulcano " << bIsVulcano; - if (adlerChargeTypeName.isEmpty() || (bIsVulcano && !bIsPoint && curGearClassType != ProjectDataManagement::GearClass::Artillery)) // [Jira E01562-21] + if (adlerChargeTypeName.isEmpty() || (bIsVulcano && !bIsPoint && curGearClassType != ProjectDataManagement::GearClass::GearClass_Artillery)) // [Jira E01562-21] continue; - m_ui->cbChargeType->addItem(QString::fromStdString(chargeType.name()), chargeType.id()); + m_ui->cbChargeType->addItem(QString::fromStdString(chargeType.name), chargeType.id); } // restore last: @@ -2944,7 +2944,7 @@ void ExplosionsEditAdlerStandAlone::fillFiringTypCbox() m_ui->cbFiringType->addItem(emptyEntryComboBox, -1); for (const auto &ft : firetypes) { - m_ui->cbFiringType->addItem(AreaEffectSimulation::toString(ft), ft); + m_ui->cbFiringType->addItem(AreaEffectSimulation::toString(ft), static_cast(ft)); } } @@ -2956,13 +2956,13 @@ void ExplosionsEditAdlerStandAlone::fillGearClasses() for (auto type : std::as_const(gearClasses)) { - if (m_gearClassFilter.contains(type.gearClassId())) + if (m_gearClassFilter.contains(type.gearClassId)) { - if (m_pdmDtc->getAdlerWeaponSystemId(type.id()) > 3) + if (m_pdmDtc->getAdlerWeaponSystemId(type.id) > 3) continue; - m_ui->cbGearClass->insertItem(index, m_pdmDtc->trGearTypeName(type.id()), type.gearClassId().underlying()); - m_ui->cbGearClass->setItemData(index, m_pdmDtc->getAdlerWeaponSystemId(type.id()), ROLE_GEARTYPE_ID); + m_ui->cbGearClass->insertItem(index, m_pdmDtc->trGearTypeName(type.id), static_cast(type.gearClassId)); + m_ui->cbGearClass->setItemData(index, m_pdmDtc->getAdlerWeaponSystemId(type.id), ROLE_GEARTYPE_ID); } } m_ui->cbGearClass->model()->sort(0, Qt::AscendingOrder); @@ -2970,7 +2970,7 @@ void ExplosionsEditAdlerStandAlone::fillGearClasses() void ExplosionsEditAdlerStandAlone::onEffectorChanged(const AreaEffectSimulation::Effector &data, DataModification modType) { - if (data.aesItemId() != m_aesItem.id()) + if (data.aesItemId != m_aesItem.id) return; if (!unchangeable()) @@ -2983,10 +2983,10 @@ void ExplosionsEditAdlerStandAlone::onEffectorChanged(const AreaEffectSimulation { if (AesEffector *effectorWidget = qobject_cast(widget)) { - if (effectorWidget->effectorId() != data.id()) + if (effectorWidget->effectorId() != data.id) continue; - effectorWidget->setState(data.effectorState()); + effectorWidget->setState(data.effectorState); return; } } @@ -2994,8 +2994,8 @@ void ExplosionsEditAdlerStandAlone::onEffectorChanged(const AreaEffectSimulation if (modType == DataModification::eAdded) { - const ParticipantManagement::Participant &part = m_ppmDtc->participant(data.participantId()); - setEffector(part, data.effectorState()); + const ParticipantManagement::Participant &part = m_ppmDtc->participant(data.participantId); + setEffector(part, data.effectorState); } } @@ -3003,7 +3003,7 @@ bool ExplosionsEditAdlerStandAlone::isOnlyNameModifiable() const { // BaseClass::isOnlyNameModifiable() -> EsPaused || EsActivated // m_effectClusterData.isObjectModifiable -> since PreStart and s_calculationOffsetMSec - const bool ret = BaseClass::isOnlyNameModifiable() || !m_effectClusterData.isObjectModifiable(); + const bool ret = BaseClass::isOnlyNameModifiable() || !m_effectClusterData.isObjectModifiable; return ret; } @@ -3055,9 +3055,9 @@ void ExplosionsEditAdlerStandAlone::mmiToJsonproperties(QJsonObject &data) data.remove(AdlerJson::JsonKeys::ABFEUERUNGSZEIT()); if (m_ui->rbAngleGroupLower->isChecked()) - data[AdlerJson::JsonKeys::WINKELGRUPPE()] = ProjectDataManagement::L43_AngleGroup::Lower; + data[AdlerJson::JsonKeys::WINKELGRUPPE()] = static_cast(ProjectDataManagement::L43_AngleGroup::Lower); else - data[AdlerJson::JsonKeys::WINKELGRUPPE()] = ProjectDataManagement::L43_AngleGroup::Upper; + data[AdlerJson::JsonKeys::WINKELGRUPPE()] = static_cast(ProjectDataManagement::L43_AngleGroup::Upper); if (m_ui->sbDurationSec->isVisible()) data[AdlerJson::JsonKeys::DAUER()] = m_ui->sbDurationSec->value(); @@ -3085,7 +3085,7 @@ void ExplosionsEditAdlerStandAlone::setEffectClusterDataFromJson(const std::stri m_ui->cbTargetSubType->setCurrentIndex(m_ui->cbTargetSubType->findData(targetSubType)); const int angleGroup = propsObj[AdlerJson::JsonKeys::WINKELGRUPPE()].toInt(); - if (angleGroup == ProjectDataManagement::L43_AngleGroup::Lower) + if (angleGroup == static_cast(ProjectDataManagement::L43_AngleGroup::Lower)) m_ui->rbAngleGroupLower->setChecked(true); else m_ui->rbAngleGroupUpper->setChecked(true); @@ -3098,7 +3098,7 @@ void ExplosionsEditAdlerStandAlone::setEffectClusterDataFromJson(const std::stri } m_ui->cbFiringType->setCurrentIndex(m_ui->cbFiringType->findData(propsObj[AdlerJson::JsonKeys::ABFEUERUNGSART()].toInt())); - if (m_aesItem.id() == 0) + if (m_aesItem.id == 0) { const int duration = propsObj[AdlerJson::JsonKeys::DAUER()].toInt(); m_ui->sbDurationSec->setValue(duration); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler_standalone.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler_standalone.h index 022c9907d..899a6c58b 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler_standalone.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_edit_adler_standalone.h @@ -6,7 +6,7 @@ #include "LtsElevation/lts_elevation_manager.h" #include #include -#include +#include #include #include #include diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_single_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_single_model.h index 9f51712e2..c9bd4a0dd 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_single_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_explosions_single_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_rocket_utility.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_rocket_utility.cpp index 2f187e3bf..534c1424a 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_rocket_utility.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/Explosion/aes_rocket_utility.cpp @@ -47,7 +47,7 @@ void enaDisaWirkmittel(QComboBox *wirkmittelCombobox, AesExplosionGeometry geome const QVariant currentData = wirkmittelCombobox->itemData(indexCounter); const ProjectDataManagement::GearClass currentGearClass = static_cast(currentData.toInt()); - if (currentGearClass == ProjectDataManagement::GearClass::Rocket) + if (currentGearClass == ProjectDataManagement::GearClass::GearClass_Rocket) { QStandardItem *item = cboModel->item(indexCounter); @@ -70,7 +70,7 @@ void enaDisaWirkmittel(QComboBox *wirkmittelCombobox, AesExplosionGeometry geome const QVariant currentData = wirkmittelCombobox->itemData(indexCounter); const ProjectDataManagement::GearClass currentGearClass = static_cast(currentData.toInt()); - if (currentGearClass == ProjectDataManagement::GearClass::Rocket) + if (currentGearClass == ProjectDataManagement::GearClass::GearClass_Rocket) { QStandardItem *item = cboModel->item(indexCounter); @@ -98,7 +98,7 @@ void enaDisaWirkmittel(QComboBox *wirkmittelCombobox, AesExplosionGeometry geome void addRocketPropertiesToRequest(EffectClusterModifyRequest &request, const std::shared_ptr &ppmDtc) { - switch (request.explosionGeometry().underlying()) + switch (request.explosionGeometry) { case AesExplosionGeometry::EgAimPoint: case AesExplosionGeometry::EgPoint: @@ -123,23 +123,23 @@ void addRocketPropertiesForLinearGeometry(EffectClusterModifyRequest &request, c wirkmittel.wirkzeit = 6; - const UtmCoordinate areaBottomLeftUtm = UtmCoordinate::fromGeographic(request.area().cornerBottomLeft().lon(), request.area().cornerBottomLeft().lat()); + const UtmCoordinate areaBottomLeftUtm = UtmCoordinate::fromGeographic(request.area.cornerBottomLeft.lon, request.area.cornerBottomLeft.lat); QTransform transform; transform.translate(areaBottomLeftUtm.x, areaBottomLeftUtm.y); - transform.rotate(-request.area().rotation()); + transform.rotate(-request.area.rotation); - const double yLocal = request.area().height() / 2; + const double yLocal = request.area.height / 2; int mhpSliceCounter = 1; - for (EffectorData ¤tEffector : request.effectors()) + for (EffectorData ¤tEffector : request.effectors) { - wirkmittel.geschoss.anzahl = currentEffector.chargeAmount(); + wirkmittel.geschoss.anzahl = currentEffector.chargeAmount; treffpunkt.anzahl = wirkmittel.geschoss.anzahl; // calculate local x - double xLocal = request.area().width() * (static_cast(mhpSliceCounter++) / (request.effectors().size() + 1)); + double xLocal = request.area.width * (static_cast(mhpSliceCounter++) / (request.effectors.size() + 1)); // transform local point to UTM const QPointF localPoint(xLocal, yLocal); @@ -150,10 +150,10 @@ void addRocketPropertiesForLinearGeometry(EffectClusterModifyRequest &request, c const QPointF mhpGeo = currentUtm.geographic(); // treffpunkt - currentEffector.mhpPosition().lon(mhpGeo.x()); - currentEffector.mhpPosition().lat(mhpGeo.y()); - treffpunkt.koordinate.koordinate.longitude = currentEffector.mhpPosition().lon() * LtsCoordTrans::rad2deg(); - treffpunkt.koordinate.koordinate.latitude = currentEffector.mhpPosition().lat() * LtsCoordTrans::rad2deg(); + currentEffector.mhpPosition.lon = mhpGeo.x(); + currentEffector.mhpPosition.lat = mhpGeo.y(); + treffpunkt.koordinate.koordinate.longitude = currentEffector.mhpPosition.lon * LtsCoordTrans::rad2deg(); + treffpunkt.koordinate.koordinate.latitude = currentEffector.mhpPosition.lat * LtsCoordTrans::rad2deg(); wirkmittel.treffpunkte.clear(); wirkmittel.treffpunkte.append(treffpunkt); @@ -161,32 +161,32 @@ void addRocketPropertiesForLinearGeometry(EffectClusterModifyRequest &request, c QJsonObject wirkmittelObj; AdlerJson::wirkmittelFeuerkommandoRaketeToJson(wirkmittelObj, wirkmittel); - currentEffector.properties(QJsonDocument(wirkmittelObj).toJson().toStdString()); + currentEffector.properties = QJsonDocument(wirkmittelObj).toJson().toStdString(); // trajectory - const ParticipantManagement::ParticipantPosition &participantPosition = ppmDtc->participantPosition(currentEffector.participantId()); - const LtsUtils::QPoint3D trajectoryStart(participantPosition.pos().lon(), - participantPosition.pos().lat(), - participantPosition.pos().z()); - const LtsUtils::QPoint3D trajectoryEnd(currentEffector.mhpPosition().lon(), - currentEffector.mhpPosition().lat(), - currentEffector.mhpPosition().z()); // TODO + const ParticipantManagement::ParticipantPosition &participantPosition = ppmDtc->participantPosition(currentEffector.participantId); + const LtsUtils::QPoint3D trajectoryStart(participantPosition.pos.lon, + participantPosition.pos.lat, + participantPosition.pos.z); + const LtsUtils::QPoint3D trajectoryEnd(currentEffector.mhpPosition.lon, + currentEffector.mhpPosition.lat, + currentEffector.mhpPosition.z); // TODO TrajectoryGeoPosition trajectoryWithoutTime; TrajectoryGenerator::getInstance()->generateTrajectoryBiedziak(trajectoryStart, trajectoryEnd, 45.0, trajectoryWithoutTime); - currentEffector.flightTime(60000.0); - const double flightTimeStep = currentEffector.flightTime() / static_cast(trajectoryWithoutTime.size()); + currentEffector.flightTime = 60000.0; + const double flightTimeStep = currentEffector.flightTime / static_cast(trajectoryWithoutTime.size()); double currentFlightTime = 0.0; - currentEffector.trajectoryRelative().clear(); // LS_711_akkumulierende_flugkurven_bei_rakete - const LtsCoordTrans::UtmCoordinate utmStartPos = LtsCoordTrans::UtmCoordinate::fromGeographic(participantPosition.pos().lon(), participantPosition.pos().lat()); + currentEffector.trajectoryRelative.clear(); // LS_711_akkumulierende_flugkurven_bei_rakete + const LtsCoordTrans::UtmCoordinate utmStartPos = LtsCoordTrans::UtmCoordinate::fromGeographic(participantPosition.pos.lon, participantPosition.pos.lat); for (const Core::GeoPosition &pos : trajectoryWithoutTime) { - const LtsCoordTrans::UtmCoordinate utmCurrentPos = LtsCoordTrans::UtmCoordinate::fromGeographic(pos.lon(), pos.lat()); + const LtsCoordTrans::UtmCoordinate utmCurrentPos = LtsCoordTrans::UtmCoordinate::fromGeographic(pos.lon, pos.lat); - currentEffector.trajectoryRelative().emplace_back(utmCurrentPos.x - utmStartPos.x, - utmCurrentPos.y - utmStartPos.y, pos.z(), currentFlightTime); + currentEffector.trajectoryRelative.emplace_back(utmCurrentPos.x - utmStartPos.x, + utmCurrentPos.y - utmStartPos.y, pos.z, currentFlightTime); currentFlightTime += flightTimeStep; } @@ -203,19 +203,19 @@ void addRocketPropertiesForPointGeometry(EffectClusterModifyRequest &request, co wirkmittel.wirkzeit = 6; treffpunkt.anzahl = 1; - const UtmCoordinate areaBottomLeftUtm = UtmCoordinate::fromGeographic(request.area().cornerBottomLeft().lon(), request.area().cornerBottomLeft().lat()); - const QPointF areaCenterGeo = areaBottomLeftUtm.geographic(request.area().width() / 2, request.area().height() / 2); + const UtmCoordinate areaBottomLeftUtm = UtmCoordinate::fromGeographic(request.area.cornerBottomLeft.lon, request.area.cornerBottomLeft.lat); + const QPointF areaCenterGeo = areaBottomLeftUtm.geographic(request.area.width / 2, request.area.height / 2); - for (EffectorData ¤tEffector : request.effectors()) + for (EffectorData ¤tEffector : request.effectors) { - wirkmittel.geschoss.anzahl = currentEffector.chargeAmount(); + wirkmittel.geschoss.anzahl = currentEffector.chargeAmount; treffpunkt.anzahl = wirkmittel.geschoss.anzahl; // treffpunkt - currentEffector.mhpPosition().lon(areaCenterGeo.x()); - currentEffector.mhpPosition().lat(areaCenterGeo.y()); - treffpunkt.koordinate.koordinate.longitude = currentEffector.mhpPosition().lon() * LtsCoordTrans::rad2deg(); - treffpunkt.koordinate.koordinate.latitude = currentEffector.mhpPosition().lat() * LtsCoordTrans::rad2deg(); + currentEffector.mhpPosition.lon = areaCenterGeo.x(); + currentEffector.mhpPosition.lat = areaCenterGeo.y(); + treffpunkt.koordinate.koordinate.longitude = currentEffector.mhpPosition.lon * LtsCoordTrans::rad2deg(); + treffpunkt.koordinate.koordinate.latitude = currentEffector.mhpPosition.lat * LtsCoordTrans::rad2deg(); wirkmittel.treffpunkte.clear(); wirkmittel.treffpunkte.append(treffpunkt); @@ -223,32 +223,32 @@ void addRocketPropertiesForPointGeometry(EffectClusterModifyRequest &request, co QJsonObject wirkmittelObj; AdlerJson::wirkmittelFeuerkommandoRaketeToJson(wirkmittelObj, wirkmittel); - currentEffector.properties(QJsonDocument(wirkmittelObj).toJson().toStdString()); + currentEffector.properties = QJsonDocument(wirkmittelObj).toJson().toStdString(); // trajectory - const ParticipantManagement::ParticipantPosition &participantPosition = ppmDtc->participantPosition(currentEffector.participantId()); - const LtsUtils::QPoint3D trajectoryStart(participantPosition.pos().lon(), - participantPosition.pos().lat(), - participantPosition.pos().z()); - const LtsUtils::QPoint3D trajectoryEnd(currentEffector.mhpPosition().lon(), - currentEffector.mhpPosition().lat(), - currentEffector.mhpPosition().z()); + const ParticipantManagement::ParticipantPosition &participantPosition = ppmDtc->participantPosition(currentEffector.participantId); + const LtsUtils::QPoint3D trajectoryStart(participantPosition.pos.lon, + participantPosition.pos.lat, + participantPosition.pos.z); + const LtsUtils::QPoint3D trajectoryEnd(currentEffector.mhpPosition.lon, + currentEffector.mhpPosition.lat, + currentEffector.mhpPosition.z); TrajectoryGeoPosition trajectoryWithoutTime; TrajectoryGenerator::getInstance()->generateTrajectoryBiedziak(trajectoryStart, trajectoryEnd, 45.0, trajectoryWithoutTime); - currentEffector.flightTime(60000.0); - const double flightTimeStep = currentEffector.flightTime() / static_cast(trajectoryWithoutTime.size()); + currentEffector.flightTime = 60000.0; + const double flightTimeStep = currentEffector.flightTime / static_cast(trajectoryWithoutTime.size()); double currentFlightTime = 0.0; - currentEffector.trajectoryRelative().clear(); // LS_711_akkumulierende_flugkurven_bei_rakete - const LtsCoordTrans::UtmCoordinate utmStartPos = LtsCoordTrans::UtmCoordinate::fromGeographic(participantPosition.pos().lon(), participantPosition.pos().lat()); + currentEffector.trajectoryRelative.clear(); // LS_711_akkumulierende_flugkurven_bei_rakete + const LtsCoordTrans::UtmCoordinate utmStartPos = LtsCoordTrans::UtmCoordinate::fromGeographic(participantPosition.pos.lon, participantPosition.pos.lat); for (const Core::GeoPosition &pos : trajectoryWithoutTime) { - const LtsCoordTrans::UtmCoordinate utmCurrentPos = LtsCoordTrans::UtmCoordinate::fromGeographic(pos.lon(), pos.lat()); + const LtsCoordTrans::UtmCoordinate utmCurrentPos = LtsCoordTrans::UtmCoordinate::fromGeographic(pos.lon, pos.lat); - currentEffector.trajectoryRelative().emplace_back(utmCurrentPos.x - utmStartPos.x, - utmCurrentPos.y - utmStartPos.y, pos.z(), currentFlightTime); + currentEffector.trajectoryRelative.emplace_back(utmCurrentPos.x - utmStartPos.x, + utmCurrentPos.y - utmStartPos.y, pos.z, currentFlightTime); currentFlightTime += flightTimeStep; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/CustomView/aes_functional_area.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/CustomView/aes_functional_area.cpp index bb39b98c6..f5fb0e475 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/CustomView/aes_functional_area.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/CustomView/aes_functional_area.cpp @@ -66,13 +66,13 @@ bool CustomViewFunctionalArea::init(const QModelIndex &idx) bool CustomViewFunctionalArea::calculateIcon(const FunctionalArea &funcArea, const QColor &color) { Database::AesFunctionalArea funcOut; - funcOut.width = funcArea.area().width(); - funcOut.length = funcArea.area().height(); - funcOut.position = QPointF(funcArea.area().cornerBottomLeft().lon(), - funcArea.area().cornerBottomLeft().lat()); + funcOut.width = funcArea.area.width; + funcOut.length = funcArea.area.height; + funcOut.position = QPointF(funcArea.area.cornerBottomLeft.lon, + funcArea.area.cornerBottomLeft.lat); QPolygonF poly = AreaEffectSimulation::Polygons::functionalArea(funcOut); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(funcArea.effectStateId()); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(funcArea.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_edit.cpp index 7fa6f4910..a7d303b34 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_edit.cpp @@ -163,7 +163,7 @@ void FunctionalAreaEdit::enableUiElements(bool enable) const FunctionalAreaType type = m_functionalAreaTypes.value(m_ui->cbFunctionalAreaType->currentData().toInt()); - if (type.supplyMode() == AesOperatingMode::OmWaitingTime) + if (type.supplyMode == AesOperatingMode::OmWaitingTime) { DEBUG_LOG(m_logger) << "SUPPLY-MODE"; m_ui->sbDecontaminationMinutes->setEnabled(false); @@ -209,24 +209,24 @@ void FunctionalAreaEdit::enableUiElements(bool enable) m_ui->sbWidth->setEnabled(enable); - const bool deconAvailable = type.deconMode() != AesOperatingMode::OmNotAvailable; - const bool maintAvailable = type.maintMode() != AesOperatingMode::OmNotAvailable; - const bool medicAvailable = type.medicMode() != AesOperatingMode::OmNotAvailable; + const bool deconAvailable = type.deconMode != AesOperatingMode::OmNotAvailable; + const bool maintAvailable = type.maintMode != AesOperatingMode::OmNotAvailable; + const bool medicAvailable = type.medicMode != AesOperatingMode::OmNotAvailable; m_ui->cbDecontamination->setEnabled(enable && deconAvailable); m_ui->cbMaintenance->setEnabled(enable && maintAvailable); m_ui->cbMedical->setEnabled(enable && medicAvailable); - m_ui->sbDecontaminationMinutes->setEnabled((m_ui->cbDecontamination->currentIndex() == AesOperatingMode::OmWaitingTime) && enable && deconAvailable); - m_ui->sbMaintanenceMinutes->setEnabled((m_ui->cbMaintenance->currentIndex() == AesOperatingMode::OmWaitingTime) && enable && maintAvailable); - m_ui->sbMedicalMinutes->setEnabled((m_ui->cbMedical->currentIndex() == AesOperatingMode::OmWaitingTime) && enable && medicAvailable); + m_ui->sbDecontaminationMinutes->setEnabled((m_ui->cbDecontamination->currentIndex() == static_cast(AesOperatingMode::OmWaitingTime)) && enable && deconAvailable); + m_ui->sbMaintanenceMinutes->setEnabled((m_ui->cbMaintenance->currentIndex() == static_cast(AesOperatingMode::OmWaitingTime)) && enable && maintAvailable); + m_ui->sbMedicalMinutes->setEnabled((m_ui->cbMedical->currentIndex() == static_cast(AesOperatingMode::OmWaitingTime)) && enable && medicAvailable); m_ui->sbSupplyMinutes->setEnabled(false); m_ui->sbSupplyMinutes->setValue(0); m_ui->cbSupply->setCurrentIndex(0); setVisableFaButtons(); } - const bool isGenericFunctionalArea = type.id() == 0; - const bool symbolAvailable = type.pointSymbol().empty(); + const bool isGenericFunctionalArea = type.id == 0; + const bool symbolAvailable = type.pointSymbol.empty(); m_ui->pbClear->setEnabled(enable); m_ui->leIdentifier->setEnabled(enable || isOnlyNameModifiable()); @@ -244,18 +244,18 @@ void FunctionalAreaEdit::enableUiElements(bool enable) m_ui->pbClearPointSymbol->setEnabled(isGenericFunctionalArea); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); DEBUG_LOG(m_logger) << "setUnchangeable()"; setUnchangeable(); disableButtons(true); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->functionalArea(m_aesItem.id()); + auto baseData = m_dtc->functionalArea(m_aesItem.id); DEBUG_LOG(m_logger) << "init: setData"; setData(baseData, false); __unchange__(); @@ -279,7 +279,7 @@ bool FunctionalAreaEdit::init(int areaId, bool copy, m_ui->cbFunctionalAreaType->clear(); m_functionalAreaTypes = m_dtc->functionalAreaTypes(); for (const auto &type : std::as_const(m_functionalAreaTypes)) - m_ui->cbFunctionalAreaType->addItem(AreaEffectSimulation::trFunctionalAreaTypeName(type.name()), type.id()); + m_ui->cbFunctionalAreaType->addItem(AreaEffectSimulation::trFunctionalAreaTypeName(type.name), type.id); bool editable = LtsSessionData::LtsSessionData::getInstance()->hasOperatorRight(OperatorRights::FunctionalAreasEdit) || m_session->app() == LtsAppDescriptor::App::OC; @@ -326,36 +326,36 @@ void FunctionalAreaEdit::setData(const FunctionalArea &area, bool copy) m_aesItem = area; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromStdString(area.name())); - m_ui->dteEffectStart->setMsecsSinceEpoch(area.effectStart().is_set() ? area.effectStart().get() : 0); - m_ui->sbDurationMinutes->setValue(area.effectDuration() / 1000 / 60); - m_ui->sbWidth->setValue(area.area().width()); - m_ui->sbHeight->setValue(area.area().height()); - m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(area.partyId().is_set() ? area.partyId().get() : 0)); + m_ui->leIdentifier->setText(QString::fromStdString(area.name)); + m_ui->dteEffectStart->setMsecsSinceEpoch(area.effectStart.has_value() ? area.effectStart.get() : 0); + m_ui->sbDurationMinutes->setValue(area.effectDuration / 1000 / 60); + m_ui->sbWidth->setValue(area.area.width); + m_ui->sbHeight->setValue(area.area.height); + m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(area.partyId.has_value() ? area.partyId.get() : 0)); - const QPointF bottomLeft(area.area().cornerBottomLeft().lon(), area.area().cornerBottomLeft().lat()); - const QPointF centerpoint = Polygons::bottomLeft2CenterPoint(bottomLeft, area.area().width(), area.area().height(), 0.0); + const QPointF bottomLeft(area.area.cornerBottomLeft.lon, area.area.cornerBottomLeft.lat); + const QPointF centerpoint = Polygons::bottomLeft2CenterPoint(bottomLeft, area.area.width, area.area.height, 0.0); if (!bottomLeft.isNull()) m_ui->positionEdit->setCoordinate(centerpoint); - m_ui->cbDecontamination->setCurrentIndex(m_ui->cbDecontamination->findData(area.deconMode().underlying())); - m_ui->cbMaintenance->setCurrentIndex(m_ui->cbMaintenance->findData(area.maintMode().underlying())); - m_ui->cbMedical->setCurrentIndex(m_ui->cbMedical->findData(area.medicMode().underlying())); + m_ui->cbDecontamination->setCurrentIndex(m_ui->cbDecontamination->findData(static_cast(area.deconMode))); + m_ui->cbMaintenance->setCurrentIndex(m_ui->cbMaintenance->findData(static_cast(area.maintMode))); + m_ui->cbMedical->setCurrentIndex(m_ui->cbMedical->findData(static_cast(area.medicMode))); - m_ui->sbDecontaminationMinutes->setValue(area.deconTime() / (1000 * 60)); - m_ui->sbMaintanenceMinutes->setValue(area.maintTime() / (1000 * 60)); - m_ui->sbMedicalMinutes->setValue(area.medicTime() / (1000 * 60)); - m_ui->sbSupplyMinutes->setValue(area.supplyTime() / (1000 * 60)); + m_ui->sbDecontaminationMinutes->setValue(area.deconTime / (1000 * 60)); + m_ui->sbMaintanenceMinutes->setValue(area.maintTime / (1000 * 60)); + m_ui->sbMedicalMinutes->setValue(area.medicTime / (1000 * 60)); + m_ui->sbSupplyMinutes->setValue(area.supplyTime / (1000 * 60)); - m_ui->cbFunctionalAreaType->setCurrentIndex(m_ui->cbFunctionalAreaType->findData(area.functionalAreaTypeId())); + m_ui->cbFunctionalAreaType->setCurrentIndex(m_ui->cbFunctionalAreaType->findData(area.functionalAreaTypeId)); - if (m_aesItem.participantId().is_set()) + if (m_aesItem.participantId.has_value()) { - int participantId = m_aesItem.participantId().get(); + int participantId = m_aesItem.participantId.get(); DEBUG_LOG(m_logger) << "ParticipantId = " << participantId; QVector participants; participants.append(participantId); @@ -363,13 +363,13 @@ void FunctionalAreaEdit::setData(const FunctionalArea &area, bool copy) } - if (area.pointSymbol().is_set()) + if (area.pointSymbol.has_value()) { - m_sidc = QString::fromStdString(area.pointSymbol().get()); + m_sidc = QString::fromStdString(area.pointSymbol.get()); onChangeSymbol(m_sidc); } - if ((m_aesItem.effectStateId() == AesEffectState::EsActivated) - || (m_aesItem.effectStateId() == AesEffectState::EsExpired)) + if ((m_aesItem.effectStateId == AesEffectState::EsActivated) + || (m_aesItem.effectStateId == AesEffectState::EsExpired)) { DEBUG_LOG(m_logger) << "setUnchangeable"; disableButtons(true); @@ -394,19 +394,19 @@ void FunctionalAreaEdit::fillCbx() QString byOperator = tr("by operator"); QString bytimeout = tr("by wait time"); - m_ui->cbDecontamination->addItem(unused, AesOperatingMode::OmNotUsed); - m_ui->cbDecontamination->addItem(byOperator, AesOperatingMode::OmObserver); - m_ui->cbDecontamination->addItem(bytimeout, AesOperatingMode::OmWaitingTime); + m_ui->cbDecontamination->addItem(unused, static_cast(AesOperatingMode::OmNotUsed)); + m_ui->cbDecontamination->addItem(byOperator, static_cast(AesOperatingMode::OmObserver)); + m_ui->cbDecontamination->addItem(bytimeout, static_cast(AesOperatingMode::OmWaitingTime)); - m_ui->cbMaintenance->addItem(unused, AesOperatingMode::OmNotUsed); - m_ui->cbMaintenance->addItem(byOperator, AesOperatingMode::OmObserver); - m_ui->cbMaintenance->addItem(bytimeout, AesOperatingMode::OmWaitingTime); + m_ui->cbMaintenance->addItem(unused, static_cast(AesOperatingMode::OmNotUsed)); + m_ui->cbMaintenance->addItem(byOperator, static_cast(AesOperatingMode::OmObserver)); + m_ui->cbMaintenance->addItem(bytimeout, static_cast(AesOperatingMode::OmWaitingTime)); - m_ui->cbMedical->addItem(unused, AesOperatingMode::OmNotUsed); - m_ui->cbMedical->addItem(byOperator, AesOperatingMode::OmObserver); - m_ui->cbMedical->addItem(bytimeout, AesOperatingMode::OmWaitingTime); + m_ui->cbMedical->addItem(unused, static_cast(AesOperatingMode::OmNotUsed)); + m_ui->cbMedical->addItem(byOperator, static_cast(AesOperatingMode::OmObserver)); + m_ui->cbMedical->addItem(bytimeout, static_cast(AesOperatingMode::OmWaitingTime)); - m_ui->cbSupply->addItem(bytimeout, AesOperatingMode::OmWaitingTime); + m_ui->cbSupply->addItem(bytimeout, static_cast(AesOperatingMode::OmWaitingTime)); if (curIdxDeconCbx >= 0) @@ -450,47 +450,47 @@ void FunctionalAreaEdit::onRectData(const QPointF ¢erPoint, double width, do void FunctionalAreaEdit::onCbxIdxDeconChanged() { - m_ui->sbDecontaminationMinutes->setEnabled(AesOperatingMode::OmWaitingTime == m_ui->cbDecontamination->currentData().toInt()); + m_ui->sbDecontaminationMinutes->setEnabled(static_cast(AesOperatingMode::OmWaitingTime) == m_ui->cbDecontamination->currentData().toInt()); } void FunctionalAreaEdit::onCbxIdxMaintChanged() { - m_ui->sbMaintanenceMinutes->setEnabled(AesOperatingMode::OmWaitingTime == m_ui->cbMaintenance->currentData().toInt()); + m_ui->sbMaintanenceMinutes->setEnabled(static_cast(AesOperatingMode::OmWaitingTime) == m_ui->cbMaintenance->currentData().toInt()); } void FunctionalAreaEdit::onCbxIdxMedicChanged() { - m_ui->sbMedicalMinutes->setEnabled(AesOperatingMode::OmWaitingTime == m_ui->cbMedical->currentData().toInt()); + m_ui->sbMedicalMinutes->setEnabled(static_cast(AesOperatingMode::OmWaitingTime) == m_ui->cbMedical->currentData().toInt()); } void FunctionalAreaEdit::onCbxIdxSupplyChanged() { - m_ui->sbSupplyMinutes->setEnabled(AesOperatingMode::OmWaitingTime == m_ui->cbSupply->currentData().toInt()); + m_ui->sbSupplyMinutes->setEnabled(static_cast(AesOperatingMode::OmWaitingTime) == m_ui->cbSupply->currentData().toInt()); } void FunctionalAreaEdit::onCbxIdxFunctionalAreaTypeChanged() { const FunctionalAreaType type = m_functionalAreaTypes.value(m_ui->cbFunctionalAreaType->currentData().toInt()); DEBUG_LOG(m_logger) << "onCbxIdxFunctionalAreaTypeChanged" - << " type.id=" << type.id() - << " name=" << type.name(); - if (type.id() != 0) + << " type.id=" << type.id + << " name=" << type.name; + if (type.id != 0) { - if (type.id() == 7) + if (type.id == 7) { - m_ui->sbSupplyMinutes->setValue(type.supplyTime()); + m_ui->sbSupplyMinutes->setValue(type.supplyTime); m_ui->cbSupply->setCurrentIndex(0); } else { - m_sidc = QString::fromStdString(type.pointSymbol()); + m_sidc = QString::fromStdString(type.pointSymbol); onChangeSymbol(m_sidc); - m_ui->sbDecontaminationMinutes->setValue(type.deconTime()); - m_ui->sbMaintanenceMinutes->setValue(type.maintTime()); - m_ui->sbMedicalMinutes->setValue(type.medicTime()); - m_ui->cbDecontamination->setCurrentIndex(m_ui->cbDecontamination->findData(type.deconMode() == AesOperatingMode::OmNotAvailable ? AesOperatingMode::OmNotUsed : type.deconMode().underlying())); - m_ui->cbMaintenance->setCurrentIndex(m_ui->cbMaintenance->findData(type.maintMode() == AesOperatingMode::OmNotAvailable ? AesOperatingMode::OmNotUsed : type.maintMode().underlying())); - m_ui->cbMedical->setCurrentIndex(m_ui->cbMedical->findData(type.medicMode() == AesOperatingMode::OmNotAvailable ? AesOperatingMode::OmNotUsed : type.medicMode().underlying())); + m_ui->sbDecontaminationMinutes->setValue(type.deconTime); + m_ui->sbMaintanenceMinutes->setValue(type.maintTime); + m_ui->sbMedicalMinutes->setValue(type.medicTime); + m_ui->cbDecontamination->setCurrentIndex(m_ui->cbDecontamination->findData(static_cast(type.deconMode == AesOperatingMode::OmNotAvailable ? AesOperatingMode::OmNotUsed : type.deconMode))); + m_ui->cbMaintenance->setCurrentIndex(m_ui->cbMaintenance->findData(static_cast(type.maintMode == AesOperatingMode::OmNotAvailable ? AesOperatingMode::OmNotUsed : type.maintMode))); + m_ui->cbMedical->setCurrentIndex(m_ui->cbMedical->findData(static_cast(type.medicMode == AesOperatingMode::OmNotAvailable ? AesOperatingMode::OmNotUsed : type.medicMode))); } } enableUiElements(true); @@ -569,7 +569,7 @@ void FunctionalAreaEdit::onChangeSymbol(const QString &sidc) std::shared_ptr ppmDtc; m_session->getDtc(ppmDtc); if (ppmDtc) - symDataToRender.fillColor = ppmDtc->party(partyId).color(); + symDataToRender.fillColor = ppmDtc->party(partyId).color; else WARNING_LOG(m_logger) << "no ppmDtc"; } @@ -614,17 +614,17 @@ bool FunctionalAreaEdit::apply() int playerId = 0; const auto pointSymbol = m_sidc.toStdString(); AesOperatingMode deconMode = static_cast(m_ui->cbDecontamination->currentData().toInt()); - int deconTime = (AesOperatingMode::OmWaitingTime == m_ui->cbDecontamination->currentData().toInt()) ? 1000 * 60 * m_ui->sbDecontaminationMinutes->value() : 0; + int deconTime = (static_cast(AesOperatingMode::OmWaitingTime) == m_ui->cbDecontamination->currentData().toInt()) ? 1000 * 60 * m_ui->sbDecontaminationMinutes->value() : 0; AesOperatingMode maintMode = static_cast(m_ui->cbMaintenance->currentData().toInt()); - int maintTime = (AesOperatingMode::OmWaitingTime == m_ui->cbMaintenance->currentData().toInt()) ? 1000 * 60 * m_ui->sbMaintanenceMinutes->value() : 0; + int maintTime = (static_cast(AesOperatingMode::OmWaitingTime) == m_ui->cbMaintenance->currentData().toInt()) ? 1000 * 60 * m_ui->sbMaintanenceMinutes->value() : 0; AesOperatingMode medicMode = static_cast(m_ui->cbMedical->currentData().toInt()); - int medicTime = (AesOperatingMode::OmWaitingTime == m_ui->cbMedical->currentData().toInt()) ? 1000 * 60 * m_ui->sbMedicalMinutes->value() : 0; + int medicTime = (static_cast(AesOperatingMode::OmWaitingTime) == m_ui->cbMedical->currentData().toInt()) ? 1000 * 60 * m_ui->sbMedicalMinutes->value() : 0; AesOperatingMode supplyMode = static_cast(m_ui->cbSupply->currentData().toInt()); if ( functionalAreaType != 7 ) supplyMode = AesOperatingMode::OmNotUsed; - int supplyTime = (AesOperatingMode::OmWaitingTime == m_ui->cbSupply->currentData().toInt()) ? 1000 * 60 * m_ui->sbSupplyMinutes->value() : 0; + int supplyTime = (static_cast(AesOperatingMode::OmWaitingTime) == m_ui->cbSupply->currentData().toInt()) ? 1000 * 60 * m_ui->sbSupplyMinutes->value() : 0; AesOperatingMode notfightMode = static_cast(m_ui->cbMedical->currentData().toInt()); - int notfightTime = (AesOperatingMode::OmWaitingTime == m_ui->cbMedical->currentData().toInt()) ? 1000 * 60 * m_ui->sbMedicalMinutes->value() : 0; + int notfightTime = (static_cast(AesOperatingMode::OmWaitingTime) == m_ui->cbMedical->currentData().toInt()) ? 1000 * 60 * m_ui->sbMedicalMinutes->value() : 0; if ( functionalAreaType == 7 ) { deconMode = AesOperatingMode::OmNotUsed; @@ -652,12 +652,12 @@ bool FunctionalAreaEdit::apply() if (supplyMode == AesOperatingMode::OmWaitingTime) { partyId = 0; - playerId = m_participant.id(); + playerId = m_participant.id; } - FunctionalAreaModifyRequest req(m_aesItem.id(), + FunctionalAreaModifyRequest req(m_aesItem.id, name, - LtsUtils::toOptional(effectStart), + LtsUtils::toOptional(static_cast(effectStart)), duration, chargeType, area, @@ -679,7 +679,7 @@ bool FunctionalAreaEdit::apply() m_requestHelper->addRequest([this, req, functionalAreaType]() { - DEBUG_LOG(m_logger) << "addRequest m_aesItem.id()=" << m_aesItem.id() + DEBUG_LOG(m_logger) << "addRequest m_aesItem.id()=" << m_aesItem.id << " functionalAreaType=" << functionalAreaType << " area=" << req; return m_ftc->functionalAreaModifyRequest(req, this); @@ -774,7 +774,7 @@ void FunctionalAreaEdit::onParticipantClicked() { ParticipantManagement::ParticipantSelection *ps = new ParticipantManagement::ParticipantSelection(m_session, this); ps->init(); - ps->setParticipantSelected(m_participant.partyId(), m_participant.id()); + ps->setParticipantSelected(m_participant.partyId, m_participant.id); connect(ps, &ParticipantManagement::ParticipantSelection::selectedParticipants, this, &FunctionalAreaEdit::onParticipant); ps->exec(); @@ -792,12 +792,12 @@ void FunctionalAreaEdit::onParticipant(const QVector &participants) m_participant = m_ppmDtc->participant(participants[0]); - QString lblHierarchy = m_ppmDtc->hierarchyFromParticipant(m_participant.id()); - QString lblParticipantType = ParticipantManagement::trTypeName(m_ppmDtc->type(m_participant.typeId()).name()); + QString lblHierarchy = m_ppmDtc->hierarchyFromParticipant(m_participant.id); + QString lblParticipantType = ParticipantManagement::trTypeName(m_ppmDtc->type(m_participant.typeId).name); int functionalAreaType = m_ui->cbFunctionalAreaType->currentData().toInt(); - DEBUG_LOG(m_logger) << "m_participant.id=" << m_participant.id() - << " designator=" << m_participant.designator() - << " tacticalIdentifier=" << m_participant.tacticalIdentifier() + DEBUG_LOG(m_logger) << "m_participant.id=" << m_participant.id + << " designator=" << m_participant.designator + << " tacticalIdentifier=" << m_participant.tacticalIdentifier << " lblHierarchy=" << lblHierarchy << " lblHierarchy.isVisable=" << m_ui->lblHierarchy->isVisible() << " lblParticipantType=" << lblParticipantType @@ -816,14 +816,14 @@ void FunctionalAreaEdit::onParticipant(const QVector &participants) << " property=" << propertyStrType.join(QStringLiteral("|")); m_ui->lblHierarchy->show(); - m_ui->lblHierarchy->setText(m_ppmDtc->hierarchyFromParticipant(m_participant.id())); + m_ui->lblHierarchy->setText(m_ppmDtc->hierarchyFromParticipant(m_participant.id)); m_ui->lblParticipantType->show(); - m_ui->lblParticipantType->setText(ParticipantManagement::trTypeName(m_ppmDtc->type(m_participant.typeId()).name())); + m_ui->lblParticipantType->setText(ParticipantManagement::trTypeName(m_ppmDtc->type(m_participant.typeId).name)); m_ui->lblEquipmentNumber->show(); - dds::core::optional eqId = m_participant.equipmentNumber(); + dds::core::optional eqId = m_participant.equipmentNumber; - if (eqId.is_set()) + if (eqId.has_value()) { QString id = QString::number(eqId.get()); m_ui->lblEquipmentNumber->setText(id); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_edit.h index cb14fb6c6..5295937cd 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include #include #include @@ -38,7 +38,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddFunctionalArea") : QStringLiteral("EditFunctionalArea%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddFunctionalArea") : QStringLiteral("EditFunctionalArea%1").arg(m_aesItem.id); } bool init(int areaId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_gui_plugin.h index 1a9e167f5..533f7ea67 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_functional_area_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_list.h index 1c922d2b2..51412dccc 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_area_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_areas_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_areas_model.cpp index e3412ebd9..27afb6873 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_areas_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_areas_model.cpp @@ -37,8 +37,8 @@ QVariant FunctionalAreasModel::data(const QModelIndex &index, int role) const { case ColType: { - auto fat = m_aesDtc->functionalAreaType(functionalArea.functionalAreaTypeId()); - return trFunctionalAreaTypeName(fat.name()); + auto fat = m_aesDtc->functionalAreaType(functionalArea.functionalAreaTypeId); + return trFunctionalAreaTypeName(fat.name); } default: break; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_areas_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_areas_model.h index fe5fc76d2..51e81d98c 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_areas_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/FunctionalArea/aes_functional_areas_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace LtsSession { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/CustomView/aes_gas_pipe.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/CustomView/aes_gas_pipe.cpp index 03760310d..e053594e3 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/CustomView/aes_gas_pipe.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/CustomView/aes_gas_pipe.cpp @@ -44,21 +44,21 @@ bool CustomViewGasPipe::init(const QModelIndex &idx) bool CustomViewGasPipe::calculateIcon(const AreaEffectSimulation::GasPipe &line, const QColor &color) { - if (line.segments().size() == 0) + if (line.segments.size() == 0) return false; QVector segments; - segments.reserve(line.segments().size()); + segments.reserve(line.segments.size()); int counter = 0; - for (const Core::GeoPosition2D &s : line.segments()) + for (const Core::GeoPosition2D &s : line.segments) { Database::AesGasPipeSegment segment; - segment.position = QPointF(s.lon(), s.lat()); + segment.position = QPointF(s.lon, s.lat); segments.append(segment); counter++; } - QPolygonF poly = AreaEffectSimulation::Polygons::gasPipe(segments, line.width()); + QPolygonF poly = AreaEffectSimulation::Polygons::gasPipe(segments, line.width); Qt::BrushStyle bStyle = Qt::BrushStyle::NoBrush; const auto pix = Polygons::pixmapFromPolygon(poly, color, ICON_RESOLUTION, bStyle, true); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_edit.cpp index c885599a4..bc68d43ea 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_edit.cpp @@ -76,15 +76,15 @@ void GasPipeEdit::enableUiElements(bool enable) m_ui->leIdentifier->setEnabled(enable || isOnlyNameModifiable()); m_ui->cbParty->setEnabled(enable); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->gasPipe(m_aesItem.id()); + auto baseData = m_dtc->gasPipe(m_aesItem.id); setData(baseData, false); __unchange__(); if (name != m_ui->leIdentifier->text()) @@ -135,16 +135,16 @@ void GasPipeEdit::setData(const GasPipe &aesItem, bool copy) m_aesItem = aesItem; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromStdString(aesItem.name())); - m_ui->sbWidth->setValue(aesItem.width()); - m_ui->dteEffectStart->setMsecsSinceEpoch(aesItem.effectStart().is_set() ? aesItem.effectStart().get() : 0); - if ( aesItem.partyId().is_set()) - m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(aesItem.partyId().get())); + m_ui->leIdentifier->setText(QString::fromStdString(aesItem.name)); + m_ui->sbWidth->setValue(aesItem.width); + m_ui->dteEffectStart->setMsecsSinceEpoch(aesItem.effectStart.has_value() ? aesItem.effectStart.get() : 0); + if ( aesItem.partyId.has_value()) + m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(aesItem.partyId.get())); - setCoordinates(aesItem.segments()); + setCoordinates(aesItem.segments); } void GasPipeEdit::getPolygon() @@ -190,8 +190,8 @@ bool GasPipeEdit::apply() if (!checkSegementLengths(this)) return false; - const GasPipeModifyRequest req(m_aesItem.id(), - LtsUtils::toOptional(effectStart), + const GasPipeModifyRequest req(m_aesItem.id, + LtsUtils::toOptional(static_cast(effectStart)), LtsUtils::toOptional(partyId), name, getCoordinates(), diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_edit.h index ff6813d60..58ffe322b 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include class QDoubleSpinBox; @@ -28,7 +28,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddGasPipe") : QStringLiteral("EditGasPipe%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddGasPipe") : QStringLiteral("EditGasPipe%1").arg(m_aesItem.id); } bool init(int aesItemId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_gui_plugin.h index c4836e663..8febc2c5f 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_gas_pipe_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_list.h index 22dc7b1e8..b6b2fccad 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipe_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include #include #include "aes_gas_pipes_model.h" diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipes_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipes_model.h index a0c9d0f0f..e5305bcd5 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipes_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/GasPipe/aes_gas_pipes_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/CustomView/aes_mine_area.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/CustomView/aes_mine_area.cpp index 7c61a1f63..7882ca0c3 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/CustomView/aes_mine_area.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/CustomView/aes_mine_area.cpp @@ -50,23 +50,23 @@ bool CustomViewMineArea::init(const QModelIndex &idx) bool CustomViewMineArea::calculateIcon(const MineArea &area, const QColor &color) { - if (area.segments().size() == 0) + if (area.segments.size() == 0) return false; QVector segments; - segments.reserve(area.segments().size()); - for (AreaEffectSimulation::MineSegment segmentIn : area.segments()) + segments.reserve(area.segments.size()); + for (AreaEffectSimulation::MineSegment segmentIn : area.segments) { Database::AesMineAreaSegment segmentOut; - segmentOut.startPosition = QPointF(segmentIn.positionStart().lon(), - segmentIn.positionStart().lat()); - segmentOut.endPosition = QPointF(segmentIn.positionEnd().lon(), - segmentIn.positionEnd().lat()); + segmentOut.startPosition = QPointF(segmentIn.positionStart.lon, + segmentIn.positionStart.lat); + segmentOut.endPosition = QPointF(segmentIn.positionEnd.lon, + segmentIn.positionEnd.lat); segments.append(segmentOut); } - QPolygonF poly = AreaEffectSimulation::Polygons::mineArea(segments, area.width(), area.density(), area.isCenterLine()); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(area.effectStateId()); + QPolygonF poly = AreaEffectSimulation::Polygons::mineArea(segments, area.width, area.density, area.isCenterLine); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(area.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_edit.cpp index 27ae520fc..528373d6e 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_edit.cpp @@ -81,7 +81,7 @@ std::vector MineAreaEdit::coordWidgets() const void MineAreaEdit::retranslate() { translate(m_ui, m_aesItem, tr("Mine Area")); - bool isReactivatable = m_dtc->mineArea(m_aesItem.id()).isReactivatable(); + bool isReactivatable = m_dtc->mineArea(m_aesItem.id).isReactivatable; m_ui->pbResetDusMines->setText(isReactivatable ? tr("Reset DUS Mines") : tr("Hide DUS Mines")); m_ui->pbResetDusMines->setToolTip(isReactivatable ? tr("Reset all DUS Mines matched to this Minearea") : tr("Hide all DUS Mines matched to this Minearea")); } @@ -105,24 +105,24 @@ void MineAreaEdit::enableUiElements(bool enable) m_ui->sbWidth->setEnabled(enable); m_ui->leIdentifier->setEnabled(enable || isOnlyNameModifiable()); - const MineArea &ma = m_dtc->mineArea(m_aesItem.id()); - if (m_aesItem.id() > 0 && - (ma.isDus() || ma.isConcrete()) && + const MineArea &ma = m_dtc->mineArea(m_aesItem.id); + if (m_aesItem.id > 0 && + (ma.isDus || ma.isConcrete) && LtsSessionData::hasOperatorRight(OperatorRights::MineAreasResetDusMines)) m_ui->pbResetDusMines->setEnabled(isOnlyNameModifiable()); else m_ui->pbResetDusMines->hide(); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->mineArea(m_aesItem.id()); + auto baseData = m_dtc->mineArea(m_aesItem.id); setData(baseData, false); __unchange__(); if (name != m_ui->leIdentifier->text()) @@ -193,10 +193,10 @@ bool MineAreaEdit::init(int aesItemId, bool copy, m_ui->cbDurationHours->setCurrentIndex(m_ui->cbDurationHours->findData(96)); if (strcmp(PROJECTBUILD, "guez") == 0) - m_ui->cbLayingProcedure->addItem(tr("Artillery"), AesMaLayingProcedureType::LptArtillery); + m_ui->cbLayingProcedure->addItem(tr("Artillery"), static_cast(AesMaLayingProcedureType::LptArtillery)); - m_ui->cbLayingProcedure->addItem(tr("Pioneer"), AesMaLayingProcedureType::LptPioneer); - m_ui->cbLayingProcedure->setCurrentIndex(m_ui->cbLayingProcedure->findData(AesMaLayingProcedureType::LptPioneer)); + m_ui->cbLayingProcedure->addItem(tr("Pioneer"), static_cast(AesMaLayingProcedureType::LptPioneer)); + m_ui->cbLayingProcedure->setCurrentIndex(m_ui->cbLayingProcedure->findData(static_cast(AesMaLayingProcedureType::LptPioneer))); m_ui->cbLayingMethod->addItem(tr("Open"), 0); m_ui->cbLayingMethod->addItem(tr("Covered"), 1); @@ -245,30 +245,30 @@ void MineAreaEdit::setData(const MineArea &data, bool copy) m_aesItem = data; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromUtf8(data.name().c_str())); - m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(data.chargeStruct().chargeTypeId())); - m_ui->sbDensity->setValue(data.density()); + m_ui->leIdentifier->setText(QString::fromUtf8(data.name.c_str())); + m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(data.chargeStruct.chargeTypeId)); + m_ui->sbDensity->setValue(data.density); - double distance = qRound(1.0 / data.density()); + double distance = qRound(1.0 / data.density); if (distance == 8.0) distance = 7.5; const int densityIndex = m_ui->cbxDensity->findData(distance); if (densityIndex != -1) m_ui->cbxDensity->setCurrentIndex(densityIndex); else - WARNING_LOG(m_logger) << "Got invalid density = " << data.density() << " / distance = " << distance; + WARNING_LOG(m_logger) << "Got invalid density = " << data.density << " / distance = " << distance; - const QJsonObject &propObj = QJsonDocument::fromJson(data.properties().c_str()).object(); + const QJsonObject &propObj = QJsonDocument::fromJson(data.properties.c_str()).object(); const int refAesItemId = propObj.value(QStringLiteral("referencedAesItemId")).toInt(-1); int effectClusterChargeTypeId = 0; if (refAesItemId > 0) { const auto &effectCluster = m_aesDtc->effectCluster(refAesItemId); - effectClusterChargeTypeId = (effectCluster.id() > 0) ? effectCluster.chargeStruct().chargeTypeId() : 0 ; + effectClusterChargeTypeId = (effectCluster.id > 0) ? effectCluster.chargeStruct.chargeTypeId : 0 ; } const bool showDensity = (effectClusterChargeTypeId != s_DM72ChargeTypeId); @@ -279,22 +279,22 @@ void MineAreaEdit::setData(const MineArea &data, bool copy) m_ui->sbWidth->setDecimals(0); - m_ui->sbWidth->setValue(qRound(data.width())); - m_ui->cbEffectMarkingInTa->setChecked(data.effectMarkingInTa()); + m_ui->sbWidth->setValue(qRound(data.width)); + m_ui->cbEffectMarkingInTa->setChecked(data.effectMarkingInTa); if (m_session->app() != LtsAppDescriptor::App::OC) - m_ui->cbMineAreaInputMode->setCurrentIndex(m_ui->cbMineAreaInputMode->findData(data.isCenterLine())); + m_ui->cbMineAreaInputMode->setCurrentIndex(m_ui->cbMineAreaInputMode->findData(data.isCenterLine)); QVector coords; MineSegment seg; - coords.reserve(data.segments().size()); - for (const MineSegment &ms : data.segments()) + coords.reserve(data.segments.size()); + for (const MineSegment &ms : data.segments) { - coords << QPointF(ms.positionStart().lon(), ms.positionStart().lat()); + coords << QPointF(ms.positionStart.lon, ms.positionStart.lat); seg = ms; } if (coords.size() > 0) - coords << QPointF(seg.positionEnd().lon(), seg.positionEnd().lat()); + coords << QPointF(seg.positionEnd.lon, seg.positionEnd.lat); for (int i = 0; i < coords.size(); ++i) { @@ -304,13 +304,13 @@ void MineAreaEdit::setData(const MineArea &data, bool copy) w->setCoordinate(coords[i]); } - m_ui->dteEffectStart->setMsecsSinceEpoch(data.effectStart().is_set() ? data.effectStart().get() : 0); + m_ui->dteEffectStart->setMsecsSinceEpoch(data.effectStart.has_value() ? data.effectStart.get() : 0); - double duration = data.effectDuration() / (1000 * 60 * 60); + double duration = data.effectDuration / (1000 * 60 * 60); m_ui->cbDurationHours->setCurrentText(QString::number(duration)); - m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(data.partyId().is_set() ? data.partyId().get() : 0)); - m_ui->cbLayingProcedure->setCurrentIndex(m_ui->cbLayingProcedure->findData(static_cast(data.layingProcedureType().underlying()))); - m_ui->cbLayingMethod->setCurrentIndex(m_ui->cbLayingMethod->findData(data.isLaidHidden() ? 1 : 0)); + m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(data.partyId.has_value() ? data.partyId.get() : 0)); + m_ui->cbLayingProcedure->setCurrentIndex(m_ui->cbLayingProcedure->findData(static_cast(data.layingProcedureType))); + m_ui->cbLayingMethod->setCurrentIndex(m_ui->cbLayingMethod->findData(data.isLaidHidden ? 1 : 0)); } @@ -323,7 +323,7 @@ void MineAreaEdit::getPosition() double width = m_ui->sbWidth->value(); int maxSegments = m_segments; - if (m_ui->cbLayingProcedure->currentData().toInt() == AesMaLayingProcedureType::LptArtillery) + if (m_ui->cbLayingProcedure->currentData().toInt() == static_cast(AesMaLayingProcedureType::LptArtillery)) maxSegments = 1; @@ -370,7 +370,7 @@ bool MineAreaEdit::onResetDusMines() { return m_requestHelper->startSingleRequest([this]() { - return m_ftc->mineResetRequest(MineResetRequest(m_aesItem.id(), dds::core::optional()), this); + return m_ftc->mineResetRequest(MineResetRequest(m_aesItem.id, dds::core::optional()), this); }); } @@ -402,10 +402,10 @@ bool MineAreaEdit::apply() return false; const double distance = 500.0; - const MineAreaModifyRequest req(m_aesItem.id(), name, - LtsUtils::toOptional(effectStart), + const MineAreaModifyRequest req(m_aesItem.id, name, + LtsUtils::toOptional(static_cast(effectStart)), effectDuration, - m_aesItem.effectSourceId(), + m_aesItem.effectSourceId, density, width, {chargeTypeId,0,0}, @@ -417,7 +417,7 @@ bool MineAreaEdit::apply() m_ui->cbEffectMarkingInTa->isChecked(), m_ui->cbMineAreaInputMode->currentData().toBool(), distance, - LtsUtils::toOptional(0LL), + LtsUtils::toOptional(static_cast(0LL)), true ); @@ -429,7 +429,7 @@ bool MineAreaEdit::apply() void MineAreaEdit::onLayingProcedureChanged() { - const bool islptArtillery = m_ui->cbLayingProcedure->currentData().toInt() == AesMaLayingProcedureType::LptArtillery; + const bool islptArtillery = m_ui->cbLayingProcedure->currentData().toInt() == static_cast(AesMaLayingProcedureType::LptArtillery); if (islptArtillery) m_pdmGuiIfc->setChargeTypePropertyFilter(m_ui->cbChargeType, QStringLiteral("canBeThrown"), true); else diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_edit.h index 341175226..1ea6712ac 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include #include @@ -28,7 +28,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddMineArea") : QStringLiteral("EditMineArea%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddMineArea") : QStringLiteral("EditMineArea%1").arg(m_aesItem.id); } bool init(int aesItemId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_gui_plugin.h index 7537348e0..e2f45b595 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_mine_area_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_list.h index ccbfde715..a39811c1a 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_area_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_areas_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_areas_model.cpp index 9f34d00f5..c953bb531 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_areas_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_areas_model.cpp @@ -40,7 +40,7 @@ QVariant MineAreasModel::data(const QModelIndex &index, int role) const switch (index.column()) { case ColWidth: - return QLocale().toString(mine.width(), 'f', 2); + return QLocale().toString(mine.width, 'f', 2); default: break; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_areas_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_areas_model.h index 9d02d2474..0d83c053d 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_areas_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineArea/aes_mine_areas_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace LtsSession { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/CustomView/aes_mine_corridor.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/CustomView/aes_mine_corridor.cpp index b0926dc62..373b22d13 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/CustomView/aes_mine_corridor.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/CustomView/aes_mine_corridor.cpp @@ -47,20 +47,20 @@ bool CustomViewMineCorridor::init(const QModelIndex &idx) bool CustomViewMineCorridor::calculateIcon(const MineCorridor &corridor, const QColor &color) { QVector segments; - segments.reserve(corridor.segments().size()); + segments.reserve(corridor.segments.size()); int counter = 0; - for (const Core::GeoPosition2D &segmentIn : corridor.segments()) + for (const Core::GeoPosition2D &segmentIn : corridor.segments) { Database::AesMineCorridorSegment segmentOut; - segmentOut.position = QPointF(segmentIn.lon(), segmentIn.lat()); - segmentOut.mineCorridorId = corridor.id(); + segmentOut.position = QPointF(segmentIn.lon, segmentIn.lat); + segmentOut.mineCorridorId = corridor.id; segmentOut.elementNumber = counter; segments.append(segmentOut); ++counter; } - QPolygonF poly = AreaEffectSimulation::Polygons::mineCorridor(segments, corridor.width()); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(corridor.effectStateId()); + QPolygonF poly = AreaEffectSimulation::Polygons::mineCorridor(segments, corridor.width); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(corridor.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_edit.cpp index bed0d569b..9598800e8 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_edit.cpp @@ -76,15 +76,15 @@ void MineCorridorEdit::enableUiElements(bool enable) m_ui->pbClear->setEnabled(enable); m_ui->leIdentifier->setEnabled(enable || isOnlyNameModifiable()); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->mineCorridor(m_aesItem.id()); + auto baseData = m_dtc->mineCorridor(m_aesItem.id); setData(baseData, false); __unchange__(); if (name != m_ui->leIdentifier->text()) @@ -133,14 +133,14 @@ void MineCorridorEdit::setData(const MineCorridor &aesItem, bool copy) m_aesItem = aesItem; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromStdString(aesItem.name())); - m_ui->sbWidth->setValue(aesItem.width()); - m_ui->dteEffectStart->setMsecsSinceEpoch(aesItem.effectStart().is_set() ? aesItem.effectStart().get() : 0); + m_ui->leIdentifier->setText(QString::fromStdString(aesItem.name)); + m_ui->sbWidth->setValue(aesItem.width); + m_ui->dteEffectStart->setMsecsSinceEpoch(aesItem.effectStart.has_value() ? aesItem.effectStart.get() : 0); - setCoordinates(aesItem.segments()); + setCoordinates(aesItem.segments); } void MineCorridorEdit::getPolygon() @@ -184,16 +184,16 @@ bool MineCorridorEdit::apply() if (!checkSegementLengths(this)) return false; - const MineCorridorModifyRequest req(m_aesItem.id(), + const MineCorridorModifyRequest req(m_aesItem.id, name, 1 * 60 * 1000, - m_aesItem.effectSourceId(), + m_aesItem.effectSourceId, width, getCoordinates(), - LtsUtils::toOptional(effectStart), + LtsUtils::toOptional(static_cast(effectStart)), dds::core::optional(), dds::core::optional(), - dds::core::optional()); + dds::core::optional()); return m_requestHelper->startSingleRequest([this, req]() { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_edit.h index df3fc9701..3651c1168 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include class QDoubleSpinBox; @@ -28,7 +28,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddMineCorridor") : QStringLiteral("EditMineCorridor%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddMineCorridor") : QStringLiteral("EditMineCorridor%1").arg(m_aesItem.id); } bool init(int aesItemId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_gui_plugin.h index e93746875..a13bee725 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_mine_corridor_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_list.h index 74fa0f02b..73f4b92b7 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridor_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridors_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridors_model.h index aabd0a144..840907c20 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridors_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineCorridor/aes_mine_corridors_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace LtsSession { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/CustomView/aes_booby_trap.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/CustomView/aes_booby_trap.cpp index 91fda43d3..4b5c7dd5b 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/CustomView/aes_booby_trap.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/CustomView/aes_booby_trap.cpp @@ -65,10 +65,10 @@ bool CustomViewBoobyTrap::init(const QModelIndex &idx) bool CustomViewBoobyTrap::calculateIcon(const BoobyTrap &bt, const QColor &color) { - QPointF impactPosition = QPointF(bt.impactPosition().lon(), bt.impactPosition().lat()); - const QPolygonF poly = Polygons::circle(impactPosition, bt.triggerRadius()); + QPointF impactPosition = QPointF(bt.impactPosition.lon, bt.impactPosition.lat); + const QPolygonF poly = Polygons::circle(impactPosition, bt.triggerRadius); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(bt.effectStateId()); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(bt.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/CustomView/aes_off_route_mine.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/CustomView/aes_off_route_mine.cpp index b16e213ac..67e4084b1 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/CustomView/aes_off_route_mine.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/CustomView/aes_off_route_mine.cpp @@ -66,16 +66,16 @@ bool CustomViewOffRouteMine::init(const QModelIndex &idx) bool CustomViewOffRouteMine::calculateIcon(const OffRouteMine &orm, const QColor &color) { Database::AesOffRouteMine ormOut; - ormOut.id = orm.id(); - ormOut.chargeTypeId = orm.chargeStruct().chargeTypeId(); - ormOut.effectStart = QDateTime::fromMSecsSinceEpoch(orm.effectStart().is_set() ? orm.effectStart().get() : 0); - ormOut.impactPosition = QPointF(orm.area().cornerBottomLeft().lon(), orm.area().cornerBottomLeft().lat()); - if (orm.impactRadius().is_set()) - ormOut.impactRadius = orm.impactRadius().get(); + ormOut.id = orm.id; + ormOut.chargeTypeId = orm.chargeStruct.chargeTypeId; + ormOut.effectStart = QDateTime::fromMSecsSinceEpoch(orm.effectStart.has_value() ? orm.effectStart.get() : 0); + ormOut.impactPosition = QPointF(orm.area.cornerBottomLeft.lon, orm.area.cornerBottomLeft.lat); + if (orm.impactRadius.has_value()) + ormOut.impactRadius = orm.impactRadius.get(); const QPolygonF poly = AreaEffectSimulation::Polygons::offRouteMineArea(ormOut); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(orm.effectStateId()); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(orm.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/InfoView/aes_booby_trap_info.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/InfoView/aes_booby_trap_info.cpp index 393215aa8..03fd4b8fd 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/InfoView/aes_booby_trap_info.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/InfoView/aes_booby_trap_info.cpp @@ -4,7 +4,7 @@ #include "aes_booby_trap_info.h" #include "ui_aes_booby_trap_info.h" -#include +#include #include #include #include @@ -33,9 +33,9 @@ bool BoobyTrapInfo::setData(const BoobyTrap *item) { m_ui->wBaseData->setData(item); - m_ui->lblImpactRadius->setText(QString::number(item->impactRadius())); - m_ui->lblTriggerRadius->setText(QString::number(item->triggerRadius())); - m_ui->lblImpactPosition->setText(LtsCoordTrans::mgrsFromGeographic(item->impactPosition().lon(), item->impactPosition().lat())); + m_ui->lblImpactRadius->setText(QString::number(item->impactRadius)); + m_ui->lblTriggerRadius->setText(QString::number(item->triggerRadius)); + m_ui->lblImpactPosition->setText(LtsCoordTrans::mgrsFromGeographic(item->impactPosition.lon, item->impactPosition.lat)); return true; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/InfoView/aes_off_route_mine_info.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/InfoView/aes_off_route_mine_info.cpp index 55e844615..db2535564 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/InfoView/aes_off_route_mine_info.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/InfoView/aes_off_route_mine_info.cpp @@ -4,7 +4,7 @@ #include "aes_off_route_mine_info.h" #include "ui_aes_off_route_mine_info.h" -#include +#include #include #include #include @@ -34,7 +34,7 @@ bool OffRouteMineInfo::setData(const OffRouteMine *item) m_ui->wBaseData->setData(item); - m_ui->lblImpactPosition->setText(LtsCoordTrans::mgrsFromGeographic(item->area().cornerBottomLeft().lon(), item->area().cornerBottomLeft().lat())); + m_ui->lblImpactPosition->setText(LtsCoordTrans::mgrsFromGeographic(item->area.cornerBottomLeft.lon, item->area.cornerBottomLeft.lat)); return true; } void OffRouteMineInfo::init(LtsSession::LtsSession *session) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_edit.cpp index ec53e64be..b7ed61563 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_edit.cpp @@ -126,15 +126,15 @@ void BoobyTrapEdit::enableUiElements(bool enable) m_ui->leIdentifier->setEnabled(enable || isOnlyNameModifiable()); m_ui->pbClear->setEnabled(enable); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->boobyTrap(m_aesItem.id()); + auto baseData = m_dtc->boobyTrap(m_aesItem.id); setData(baseData, false); __unchange__(); if (name != m_ui->leIdentifier->text()) @@ -224,29 +224,29 @@ void BoobyTrapEdit::setData(const BoobyTrap &bt, bool copy) m_aesItem = bt; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromStdString(bt.name())); - m_ui->dteEffectStart->setMsecsSinceEpoch(bt.effectStart().is_set() ? bt.effectStart().get() : 0); - m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(bt.chargeStruct().chargeTypeId())); - s_lastChargeTypeBoobyTrap = bt.chargeStruct().chargeTypeId(); - m_ui->sbDurationHours->setValue(bt.effectDuration() / 1000 / 60/ 60); - m_ui->sbTriggerRadius->setValue(bt.triggerRadius()); - m_ui->sbImpactRadius->setValue(bt.impactRadius()); + m_ui->leIdentifier->setText(QString::fromStdString(bt.name)); + m_ui->dteEffectStart->setMsecsSinceEpoch(bt.effectStart.has_value() ? bt.effectStart.get() : 0); + m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(bt.chargeStruct.chargeTypeId)); + s_lastChargeTypeBoobyTrap = bt.chargeStruct.chargeTypeId; + m_ui->sbDurationHours->setValue(bt.effectDuration / 1000 / 60/ 60); + m_ui->sbTriggerRadius->setValue(bt.triggerRadius); + m_ui->sbImpactRadius->setValue(bt.impactRadius); - if (bt.rotationAngle().is_set()) + if (bt.rotationAngle.has_value()) { - m_ui->rotationAngleEdit->setValue(bt.rotationAngle().get(), LtsAngleEditBase::AngleUnitType::Deg); + m_ui->rotationAngleEdit->setValue(bt.rotationAngle.get(), LtsAngleEditBase::AngleUnitType::Deg); } - if (bt.centralAngle().is_set()) - m_ui->sbCentralAngle->setValue(bt.centralAngle().get()); + if (bt.centralAngle.has_value()) + m_ui->sbCentralAngle->setValue(bt.centralAngle.get()); - m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(bt.partyId().is_set() ? bt.partyId().get() : 0)); + m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(bt.partyId.has_value() ? bt.partyId.get() : 0)); - QPointF impactPosition(bt.impactPosition().lon(), bt.impactPosition().lat()); + QPointF impactPosition(bt.impactPosition.lon, bt.impactPosition.lat); if (!impactPosition.isNull()) m_ui->positionEdit->setCoordinate(impactPosition); } @@ -424,7 +424,7 @@ bool BoobyTrapEdit::apply() QPointF p(m_ui->positionEdit->coordinate()); const Core::GeoPosition2D pos(p.x(), p.y()); - BoobyTrapModifyRequest req(m_aesItem.id(), + BoobyTrapModifyRequest req(m_aesItem.id, name, duration, chargeType, @@ -433,7 +433,7 @@ bool BoobyTrapEdit::apply() triggerRadius, dds::core::optional(), dds::core::optional(), - LtsUtils::toOptional(effectStart), + LtsUtils::toOptional(static_cast(effectStart)), LtsUtils::toOptional(partyId) ); @@ -443,9 +443,9 @@ bool BoobyTrapEdit::apply() double rotValue = m_ui->rotationAngleEdit->getAngleConverted(m_ui->rotationAngleEdit->getAngle(), LtsAngleEditBase::AngleUnitType::Deg, m_ui->rotationAngleEdit->getAngleCurrentUnit()); - req.rotationAngle().set(rotValue); + req.rotationAngle.set(rotValue); - req.centralAngle().set(m_ui->sbCentralAngle->value()); + req.centralAngle.set(m_ui->sbCentralAngle->value()); } m_requestHelper->addRequest([this,req]() diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_edit.h index bec6fbf80..4db1e6253 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include #include @@ -30,7 +30,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddBoobyTrap") : QStringLiteral("EditBoobyTrap%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddBoobyTrap") : QStringLiteral("EditBoobyTrap%1").arg(m_aesItem.id); } bool init(int aesItemId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_list.h index 5d7fb1934..55049e101 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_model.cpp index 34bf2bb00..c1f6c7a27 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_model.cpp @@ -37,20 +37,20 @@ QVariant BoobyTrapModel::data(const QModelIndex &index, int role) const switch (index.column()) { case ColTriggerRadius: - return QLocale().toString(bt.triggerRadius(), 'f', 2); + return QLocale().toString(bt.triggerRadius, 'f', 2); case ColImpactRadius: - return QLocale().toString(bt.impactRadius(), 'f', 2); + return QLocale().toString(bt.impactRadius, 'f', 2); case ColRotationAngle: { - if (bt.rotationAngle().is_set()) - return QLocale().toString(bt.rotationAngle().get(), 'f', 2); + if (bt.rotationAngle.has_value()) + return QLocale().toString(bt.rotationAngle.get(), 'f', 2); else return {}; } case ColCentralAngle: { - if (bt.centralAngle().is_set()) - return QLocale().toString(bt.centralAngle().get(), 'f', 2); + if (bt.centralAngle.has_value()) + return QLocale().toString(bt.centralAngle.get(), 'f', 2); else return {}; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_model.h index 4f7e0bab1..5ac005716 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_booby_trap_model.h @@ -4,7 +4,7 @@ #pragma once #include -#include +#include #include namespace LtsSession diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_mine_single_virtual_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_mine_single_virtual_gui_plugin.h index fa25b721c..36cfbbe84 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_mine_single_virtual_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_mine_single_virtual_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_mine_single_virtual_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_edit.cpp index dc15b6978..35288b4b3 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_edit.cpp @@ -176,15 +176,15 @@ void OffRouteMineEdit::enableUiElements(bool enable) m_ui->leIdentifier->setEnabled(enable || isOnlyNameModifiable()); m_ui->pbClear->setEnabled(enable); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->offRouteMine(m_aesItem.id()); + auto baseData = m_dtc->offRouteMine(m_aesItem.id); setData(baseData, false); __unchange__(); if (name != m_ui->leIdentifier->text()) @@ -248,34 +248,34 @@ void OffRouteMineEdit::setData(const OffRouteMine &orm, bool copy) m_aesItem = orm; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - const Area &area = orm.area(); - if (!qFuzzyCompare(area.cornerBottomLeft().lon(), 0) || - !qFuzzyCompare(area.cornerBottomLeft().lat(), 0)) + const Area &area = orm.area; + if (!qFuzzyCompare(area.cornerBottomLeft.lon, 0) || + !qFuzzyCompare(area.cornerBottomLeft.lat, 0)) { - QPointF bottomCenter = bottomLeftToBottomCenterToGeo(QPointF(orm.area().cornerBottomLeft().lon(), orm.area().cornerBottomLeft().lat()), - area.width(), area.rotation()); + QPointF bottomCenter = bottomLeftToBottomCenterToGeo(QPointF(orm.area.cornerBottomLeft.lon, orm.area.cornerBottomLeft.lat), + area.width, area.rotation); m_ui->positionEdit->setCoordinate(bottomCenter); } - m_ui->leIdentifier->setText(QString::fromStdString(orm.name())); - m_ui->dteEffectStart->setMsecsSinceEpoch(orm.effectStart().is_set() ? orm.effectStart().get() : 0); - m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(orm.chargeStruct().chargeTypeId())); - s_lastChargeTypeOffRouteMine = orm.chargeStruct().chargeTypeId(); - m_ui->sbDurationHours->setValue(orm.effectDuration() / 1000 / 60/ 60); - if (orm.impactRadius().is_set()) - m_ui->sbImpactRadius->setValue(orm.impactRadius().get()); + m_ui->leIdentifier->setText(QString::fromStdString(orm.name)); + m_ui->dteEffectStart->setMsecsSinceEpoch(orm.effectStart.has_value() ? orm.effectStart.get() : 0); + m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(orm.chargeStruct.chargeTypeId)); + s_lastChargeTypeOffRouteMine = orm.chargeStruct.chargeTypeId; + m_ui->sbDurationHours->setValue(orm.effectDuration / 1000 / 60/ 60); + if (orm.impactRadius.has_value()) + m_ui->sbImpactRadius->setValue(orm.impactRadius.get()); - m_ui->rotationAngleEdit->setValue(area.rotation(), LtsAngleEditBase::AngleUnitType::Deg); + m_ui->rotationAngleEdit->setValue(area.rotation, LtsAngleEditBase::AngleUnitType::Deg); - m_ui->sbDimensionX->setValue(area.width()); - m_ui->sbDimensionY->setValue(area.height()); + m_ui->sbDimensionX->setValue(area.width); + m_ui->sbDimensionY->setValue(area.height); - m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(orm.partyId().is_set() ? orm.partyId().get() : 0)); + m_ui->cbParty->setCurrentIndex(m_ui->cbParty->findData(orm.partyId.has_value() ? orm.partyId.get() : 0)); } @@ -406,9 +406,9 @@ bool OffRouteMineEdit::apply() int partyId = m_ui->cbParty->currentData().toInt(); Area area; - area.width() = m_ui->sbDimensionX->value(); - area.height() = m_ui->sbDimensionY->value(); - area.rotation() = rotation; + area.width = m_ui->sbDimensionX->value(); + area.height = m_ui->sbDimensionY->value(); + area.rotation = rotation; @@ -419,20 +419,20 @@ bool OffRouteMineEdit::apply() m_ui->rotationAngleEdit->getAngleCurrentUnit()); QPointF bottomLeftGeo = bottomCenterToBottomLeftGeo(m_ui->positionEdit->coordinate(), width, rotationDeg); - area.cornerBottomLeft() = Core::GeoPosition2D(bottomLeftGeo.x(), bottomLeftGeo.y()); + area.cornerBottomLeft = Core::GeoPosition2D(bottomLeftGeo.x(), bottomLeftGeo.y()); - OffRouteMineModifyRequest req(m_aesItem.id(), + OffRouteMineModifyRequest req(m_aesItem.id, name, duration, chargeType, area, dds::core::optional(), - LtsUtils::toOptional(effectStart), + LtsUtils::toOptional(static_cast(effectStart)), LtsUtils::toOptional(partyId) ); if (chargeType == s_offRouteMine2) - req.impactRadius().set(m_ui->sbImpactRadius->value()); + req.impactRadius.set(m_ui->sbImpactRadius->value()); DEBUG_LOG(m_logger) << " req=" << req; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_edit.h index 11f8a425d..ec25f6a25 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include #include @@ -30,7 +30,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddOffRouteMine") : QStringLiteral("EditOffRouteMine%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddOffRouteMine") : QStringLiteral("EditOffRouteMine%1").arg(m_aesItem.id); } bool init(int aesItemId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_list.h index 063e11eed..c5d7f96d3 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_model.cpp index eb423a2ae..7590ab194 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_model.cpp @@ -38,8 +38,8 @@ QVariant OffRouteMineModel::data(const QModelIndex &index, int role) const { case ColImpactRadius: { - if (orm.impactRadius().is_set()) - return QLocale().toString(orm.impactRadius().get(), 'f', 2); + if (orm.impactRadius.has_value()) + return QLocale().toString(orm.impactRadius.get(), 'f', 2); else return {}; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_model.h index 1030c8cda..e81c5a5df 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/MineSingleVirtual/aes_off_route_mine_model.h @@ -4,7 +4,7 @@ #pragma once #include -#include +#include #include namespace LtsSession diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/CustomView/aes_ncontamination.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/CustomView/aes_ncontamination.cpp index 84e33fde7..3c8732f6a 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/CustomView/aes_ncontamination.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/CustomView/aes_ncontamination.cpp @@ -60,15 +60,15 @@ bool CustomViewNContamination::init(const QModelIndex &idx) bool CustomViewNContamination::calculateIcon(const NContamination &nContamination, const QColor &color) { Database::AesNContamination nContaOut; - nContaOut.borderLengthInner = nContamination.borderLengthInner(); - nContaOut.borderLengthOuter = nContamination.borderLengthOuter(); - nContaOut.impactPosition = QPointF(nContamination.impactPosition().lon(), nContamination.impactPosition().lat()); - nContaOut.impactRadius = nContamination.impactRadius(); - nContaOut.rotationAngle = nContamination.rotationAngle(); - nContaOut.spanAngle = nContamination.spanAngle(); + nContaOut.borderLengthInner = nContamination.borderLengthInner; + nContaOut.borderLengthOuter = nContamination.borderLengthOuter; + nContaOut.impactPosition = QPointF(nContamination.impactPosition.lon, nContamination.impactPosition.lat); + nContaOut.impactRadius = nContamination.impactRadius; + nContaOut.rotationAngle = nContamination.rotationAngle; + nContaOut.spanAngle = nContamination.spanAngle; QPolygonF poly = AreaEffectSimulation::Polygons::nContamination(nContaOut); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(nContamination.effectStateId()); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(nContamination.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_edit.cpp index 328748634..349ebce8c 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_edit.cpp @@ -63,7 +63,7 @@ NContaminationEdit::NContaminationEdit(const QString &menuGroup, QWidget *parent s_stepDurationMinutes = 10.0; m_ui->rotationAngleEdit->initAngleEditWidget(2); - m_ui->cbWeather->setCurrentIndex(AesWeatherSource::AwsNone); + m_ui->cbWeather->setCurrentIndex(static_cast(AesWeatherSource::AwsNone)); m_ui->sbRadiusKm->setMinimum(s_minRadiusKm); m_ui->sbRadiusKm->setMaximum(s_maxRadiusKm); @@ -105,9 +105,9 @@ NContaminationEdit::NContaminationEdit(const QString &menuGroup, QWidget *parent connect(m_ui->sbRange2Km, &QDoubleSpinBox::editingFinished, this, &NContaminationEdit::correctSpinBoxValue); connect(m_ui->sbYield, &QDoubleSpinBox::editingFinished, this, &NContaminationEdit::correctSpinBoxValue); - m_ui->cbWeather->addItem(toString(AesWeatherSource::AwsNone), AesWeatherSource::AwsNone); - m_ui->cbWeather->addItem(toString(AesWeatherSource::AwsStatic), AesWeatherSource::AwsStatic); - m_ui->cbWeather->addItem(toString(AesWeatherSource::AwsDynamic), AesWeatherSource::AwsDynamic); + m_ui->cbWeather->addItem(toString(AesWeatherSource::AwsNone), static_cast(AesWeatherSource::AwsNone)); + m_ui->cbWeather->addItem(toString(AesWeatherSource::AwsStatic), static_cast(AesWeatherSource::AwsStatic)); + m_ui->cbWeather->addItem(toString(AesWeatherSource::AwsDynamic), static_cast(AesWeatherSource::AwsDynamic)); m_ui->lblChargeType->hide(); m_ui->cbChargeType->hide(); @@ -133,13 +133,13 @@ void NContaminationEdit::onPresetChanged(int id) return; ProjectDataManagement::NuclearPreset ps = m_presets.value(id); - if (ps.id() != id) + if (ps.id != id) return; - m_ui->sbYield->setValue(ps.detonationValue()); - m_ui->sbRadiusKm->setValue(ps.impactRadius() / 1000.0); - m_ui->sbRange1Km->setValue(ps.borderLengthInner() / 1000.0); - m_ui->sbRange2Km->setValue(ps.borderLengthOuter() / 1000.0); + m_ui->sbYield->setValue(ps.detonationValue); + m_ui->sbRadiusKm->setValue(ps.impactRadius / 1000.0); + m_ui->sbRange1Km->setValue(ps.borderLengthInner / 1000.0); + m_ui->sbRange2Km->setValue(ps.borderLengthOuter / 1000.0); } void NContaminationEdit::showPreviewObject() @@ -202,7 +202,7 @@ double NContaminationEdit::spanAngle() const double radial2 = m_ui->rotationAngleEdit->getAngleConverted(m_ui->rotationAngleEdit->getAngle(1), LtsAngleEditBase::AngleUnitType::Deg, m_ui->rotationAngleEdit->getAngleCurrentUnit()); - if (m_ui->cbWeather->currentData().toInt() != AreaEffectSimulation::AesWeatherSource::AwsNone) + if (m_ui->cbWeather->currentData().toInt() != static_cast(AreaEffectSimulation::AesWeatherSource::AwsNone)) return radial1; double spanAngle = radial2 - radial1; @@ -213,7 +213,7 @@ double NContaminationEdit::spanAngle() const double NContaminationEdit::rotatianAngle() const { - if (m_ui->cbWeather->currentData().toInt() != AreaEffectSimulation::AesWeatherSource::AwsNone) + if (m_ui->cbWeather->currentData().toInt() != static_cast(AreaEffectSimulation::AesWeatherSource::AwsNone)) return 0.0; double radial1 = m_ui->rotationAngleEdit->getAngleConverted(m_ui->rotationAngleEdit->getAngle(0), LtsAngleEditBase::AngleUnitType::Deg, @@ -244,15 +244,15 @@ void NContaminationEdit::enableUiElements(bool enable) m_ui->leIdentifier->setEnabled(enable || isOnlyNameModifiable()); m_ui->cbWeather->setEnabled(enable); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->nContamination(m_aesItem.id()); + auto baseData = m_dtc->nContamination(m_aesItem.id); setData(baseData, false); __unchange__(); if (name != m_ui->leIdentifier->text()) @@ -283,7 +283,7 @@ bool NContaminationEdit::init(int aesItemId, bool copy, { m_presets = pdmDtc->nuclearPresets(); for (const ProjectDataManagement::NuclearPreset &preset : std::as_const(m_presets)) - m_ui->cbStandardValues->addItem(pdmDtc->trNuclearPresetName(preset.id()), preset.id()); + m_ui->cbStandardValues->addItem(pdmDtc->trNuclearPresetName(preset.id), preset.id); connect(m_ui->cbStandardValues, static_cast(&QComboBox::currentIndexChanged), this, &NContaminationEdit::onPresetChanged); } else @@ -321,24 +321,24 @@ void NContaminationEdit::setData(const NContamination &contamination, bool copy) if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromStdString(contamination.name())); - m_ui->dteEffectStart->setMsecsSinceEpoch(contamination.effectStart().is_set() ? contamination.effectStart().get() : 0); - m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(contamination.chargeStruct().chargeTypeId())); - m_ui->cbWeather->setCurrentIndex(m_ui->cbWeather->findData(contamination.weatherSource().underlying())); + m_ui->leIdentifier->setText(QString::fromStdString(contamination.name)); + m_ui->dteEffectStart->setMsecsSinceEpoch(contamination.effectStart.has_value() ? contamination.effectStart.get() : 0); + m_ui->cbChargeType->setCurrentIndex(m_ui->cbChargeType->findData(contamination.chargeStruct.chargeTypeId)); + m_ui->cbWeather->setCurrentIndex(m_ui->cbWeather->findData(static_cast(contamination.weatherSource))); - const QPointF pos(contamination.impactPosition().lon(), contamination.impactPosition().lat()); + const QPointF pos(contamination.impactPosition.lon, contamination.impactPosition.lat); if (!pos.isNull()) m_ui->positionEdit->setCoordinate(pos); - m_ui->sbYield->setValue(contamination.detonationValue()); - m_ui->sbRange1Km->setValue(contamination.borderLengthInner() / 1000.0); - m_ui->sbRange2Km->setValue(contamination.borderLengthOuter() / 1000.0); - m_ui->sbRadiusKm->setValue(contamination.impactRadius() / 1000.0); - setRadials(contamination.rotationAngle(), contamination.spanAngle()); + m_ui->sbYield->setValue(contamination.detonationValue); + m_ui->sbRange1Km->setValue(contamination.borderLengthInner / 1000.0); + m_ui->sbRange2Km->setValue(contamination.borderLengthOuter / 1000.0); + m_ui->sbRadiusKm->setValue(contamination.impactRadius / 1000.0); + setRadials(contamination.rotationAngle, contamination.spanAngle); } void NContaminationEdit::getPosition() @@ -388,9 +388,9 @@ bool NContaminationEdit::apply() AesWeatherSource weatherSourceId = static_cast(m_ui->cbWeather->currentData().toInt()); const QPointF p(m_ui->positionEdit->coordinate()); const Core::GeoPosition2D pos(p.x(), p.y()); - const NContaminationModifyRequest req(m_aesItem.id(), + const NContaminationModifyRequest req(m_aesItem.id, name, - LtsUtils::toOptional(effectStart), + LtsUtils::toOptional(static_cast(effectStart)), duration, chargeType, pos, @@ -403,7 +403,7 @@ bool NContaminationEdit::apply() weatherSourceId, LtsUtils::toOptional(partyId), LtsUtils::toOptional(playerId), - dds::core::optional()); + dds::core::optional()); return m_requestHelper->startSingleRequest([this, req]() { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_edit.h index 555718b7a..f13d8a668 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include #include #include @@ -32,7 +32,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddNContamination") : QStringLiteral("EditContamination%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddNContamination") : QStringLiteral("EditContamination%1").arg(m_aesItem.id); } bool init(int aesItemId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_gui_plugin.h index ad9b6f57f..0fa974b45 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_ncontamination_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_list.h index 663dcf5f5..2039cee93 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontamination_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontaminations_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontaminations_model.h index e8338aa7d..2c5226615 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontaminations_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/NContamination/aes_ncontaminations_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include namespace LtsSession { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/CustomView/aes_technical_area.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/CustomView/aes_technical_area.cpp index 77ca84a28..f14fada9b 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/CustomView/aes_technical_area.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/CustomView/aes_technical_area.cpp @@ -60,13 +60,13 @@ bool CustomViewTechnicalArea::init(const QModelIndex &idx) bool CustomViewTechnicalArea::calculateIcon(const AreaEffectSimulation::TechnicalArea &tecArea, const QColor &color) { Database::AesTechnicalArea tecOut; - tecOut.position = QPointF(tecArea.area().cornerBottomLeft().lon(), - tecArea.area().cornerBottomLeft().lat()); - tecOut.width = tecArea.area().width(); - tecOut.length = tecArea.area().height(); + tecOut.position = QPointF(tecArea.area.cornerBottomLeft.lon, + tecArea.area.cornerBottomLeft.lat); + tecOut.width = tecArea.area.width; + tecOut.length = tecArea.area.height; QPolygonF poly = AreaEffectSimulation::Polygons::technicalArea(tecOut); - Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(tecArea.effectStateId()); + Qt::BrushStyle bStyle = PixmapLabel::checkForBrushStyle(tecArea.effectStateId); const auto pix = Polygons::pixmapFromPolygon(PixmapLabel::geographic2Utm(poly), color, ICON_RESOLUTION, bStyle); m_ui->lblIcon->setPixmap(pix); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_edit.cpp index 6b1e72da6..7556245e9 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_edit.cpp @@ -81,15 +81,15 @@ void TechnicalAreaEdit::enableUiElements(bool enable) m_ui->sbWidth->setEnabled(enable); m_ui->pbClear->setEnabled(enable); m_ui->leIdentifier->setEnabled(enable || isOnlyNameModifiable()); - if (m_aesItem.effectStateId() == AesEffectState::EsExpired) + if (m_aesItem.effectStateId == AesEffectState::EsExpired) { - m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name())); + m_ui->leIdentifier->setText(QString::fromStdString(m_aesItem.name)); __unchange__(); } - if (m_aesItem.effectStateId() == AesEffectState::EsActivated) + if (m_aesItem.effectStateId == AesEffectState::EsActivated) { QString name = m_ui->leIdentifier->text(); - auto baseData = m_dtc->technicalArea(m_aesItem.id()); + auto baseData = m_dtc->technicalArea(m_aesItem.id); setData(baseData, false); __unchange__(); if (name != m_ui->leIdentifier->text()) @@ -136,19 +136,19 @@ void TechnicalAreaEdit::setData(const TechnicalArea &area, bool copy) m_aesItem = area; if (copy) { - m_aesItem.id(0); - m_aesItem.effectStateId(AreaEffectSimulation::AesEffectState::get_default()); + m_aesItem.id = 0; + m_aesItem.effectStateId = AreaEffectSimulation::AesEffectState::EsUnknown; } - m_ui->leIdentifier->setText(QString::fromStdString(area.name())); - m_ui->sbWidth->setValue(area.area().width()); - m_ui->sbHeight->setValue(area.area().height()); + m_ui->leIdentifier->setText(QString::fromStdString(area.name)); + m_ui->sbWidth->setValue(area.area.width); + m_ui->sbHeight->setValue(area.area.height); - QPointF bottomLeft(area.area().cornerBottomLeft().lon(), area.area().cornerBottomLeft().lat()); - QPointF centerpoint = Polygons::bottomLeft2CenterPoint(bottomLeft, area.area().width(), area.area().height(), 0.0); + QPointF bottomLeft(area.area.cornerBottomLeft.lon, area.area.cornerBottomLeft.lat); + QPointF centerpoint = Polygons::bottomLeft2CenterPoint(bottomLeft, area.area.width, area.area.height, 0.0); if (!centerpoint.isNull()) m_ui->positionEdit->setCoordinate(centerpoint); - m_ui->cbType->setCurrentIndex(m_ui->cbType->findData(area.type().underlying())); + m_ui->cbType->setCurrentIndex(m_ui->cbType->findData(static_cast(area.type))); } inline void TechnicalAreaEdit::fillCbx() @@ -161,9 +161,9 @@ inline void TechnicalAreaEdit::fillCbx() m_ui->cbType->clear(); - m_ui->cbType->addItem(AreaEffectSimulation::toString(AesTechnicalAreaType::TatMout), AesTechnicalAreaType::TatMout); + m_ui->cbType->addItem(AreaEffectSimulation::toString(AesTechnicalAreaType::TatMout), static_cast(AesTechnicalAreaType::TatMout)); if ( enableSoundZones ) - m_ui->cbType->addItem(AreaEffectSimulation::toString(AesTechnicalAreaType::TatSoundZone), AesTechnicalAreaType::TatSoundZone); + m_ui->cbType->addItem(AreaEffectSimulation::toString(AesTechnicalAreaType::TatSoundZone), static_cast(AesTechnicalAreaType::TatSoundZone)); @@ -211,7 +211,7 @@ bool TechnicalAreaEdit::apply() 0.0)); const Core::GeoPosition2D bottomLeftGeo(bottomLeft.x(), bottomLeft.y()); const Area area(bottomLeftGeo, m_ui->sbWidth->value(), m_ui->sbHeight->value(), 0.0); - const TechnicalAreaModifyRequest req(m_aesItem.id(), + const TechnicalAreaModifyRequest req(m_aesItem.id, name, area, type); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_edit.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_edit.h index 3ffb0f5eb..a084e6a82 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_edit.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_edit.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include #include @@ -27,7 +27,7 @@ public: QString dialogIdentifier() const override { - return m_aesItem.id() <= 0 ? QStringLiteral("AddTechnicalArea") : QStringLiteral("EditTechnicalArea%1").arg(m_aesItem.id()); + return m_aesItem.id <= 0 ? QStringLiteral("AddTechnicalArea") : QStringLiteral("EditTechnicalArea%1").arg(m_aesItem.id); } bool init(int areaId, bool copy, LtsSession::LtsSession *session); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_gui_plugin.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_gui_plugin.h index bbd0f0e2a..3a4e199fc 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_gui_plugin.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_gui_plugin.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include "aes_technical_area_gui_plugin_interface.h" namespace AreaEffectSimulation diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_list.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_list.h index 4f4df7c98..1c4c8aac2 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_list.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_area_list.h @@ -3,8 +3,8 @@ #pragma once -#include -#include +#include +#include namespace AreaEffectSimulation { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_areas_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_areas_model.cpp index eb1ca4585..3dd0060ca 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_areas_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_areas_model.cpp @@ -45,12 +45,12 @@ QVariant TechnicalAreasModel::data(const QModelIndex &idx, int role) const if (role == Qt::DisplayRole && idx.column() == BcChargeType) { const TechnicalArea &ta = m_vecData.at(idx.row()); - return AreaEffectSimulation::toString(ta.type()); + return AreaEffectSimulation::toString(ta.type); } if (role == Qt::DisplayRole && idx.column() == BcEffectState) { const TechnicalArea &ta = m_vecData.at(idx.row()); - return AreaEffectSimulation::toString(ta.effectStateId()); + return AreaEffectSimulation::toString(ta.effectStateId); } return AesGuiBaseModel::data(idx, role); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_areas_model.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_areas_model.h index 7b74edf33..50bda06f1 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_areas_model.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AreaEffectSimulation/Gui/TechnicalArea/aes_technical_areas_model.h @@ -3,7 +3,7 @@ #pragma once -#include +#include #include namespace LtsSession diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_edit_training_area_dialog.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_edit_training_area_dialog.cpp index 6602e639b..3507b6bcf 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_edit_training_area_dialog.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_edit_training_area_dialog.cpp @@ -6,7 +6,7 @@ #include #include -#include +#include #include #include #include @@ -29,11 +29,12 @@ Core::GeoPosition2D convert(const QPointF& coord) QPointF convert(const Core::GeoPosition2D& geoPos) { - return QPointF(geoPos.lon(), geoPos.lat()); + return QPointF(geoPos.lon, geoPos.lat); } AsmEditTrainingAreaDialog::AsmEditTrainingAreaDialog(QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::OkApplyCancel), + m_logger(getLogger("AssetManangementEditDialog")), m_ui(new Ui::AsmEditTrainingAreaDialog), m_requestHelper(new LtsUtils::RequestHelper(this)), m_menuGroup() { m_ui->setupUi(this); @@ -79,22 +80,22 @@ bool AsmEditTrainingAreaDialog::init(LtsSession::LtsSessionDataDds* session, con if (trainingAreaId == 0) { DEBUG_LOG(m_logger) << Q_FUNC_INFO << " New training area "; - ta.id() = 0; - ta.name() = QStringLiteral("newArea").toStdString(); - ta.width() = 12800; - ta.height() = 12800; + ta.id = 0; + ta.name = QStringLiteral("newArea").toStdString(); + ta.width = 12800; + ta.height = 12800; m_dialogTitle = tr("New Training Area"); } else { ta = m_asmDtc->trainingArea(trainingAreaId); - if (ta.id() <= 0) + if (ta.id <= 0) { ERROR_LOG(m_logger) << Q_FUNC_INFO << " training area not valid id: " << trainingAreaId; return false; } - m_dialogTitle = tr("Edit Training Area: %1").arg(QString::fromStdString(ta.name())); + m_dialogTitle = tr("Edit Training Area: %1").arg(QString::fromStdString(ta.name)); DEBUG_LOG(m_logger) << Q_FUNC_INFO << " edit training area " << trainingAreaId; } @@ -108,7 +109,7 @@ bool AsmEditTrainingAreaDialog::init(LtsSession::LtsSessionDataDds* session, con { m_ui->pbPosition->setEnabled(false); } - m_ui->name_lineEdit->setText(QString::fromStdString(m_trainingArea.name())); + m_ui->name_lineEdit->setText(QString::fromStdString(m_trainingArea.name)); connect(m_ui->pbClear, &QPushButton::clicked, m_ui->positionEdit, &LtsCoordWidget::LtsCoordWidget::clear); @@ -170,9 +171,9 @@ void AsmEditTrainingAreaDialog::onRectData(const QPointF& centerPoint, double wi m_ui->positionEdit->setCoordinate(centerPoint.x(), centerPoint.y()); m_ui->sbWidth->setValue(width); m_ui->sbHeight->setValue(height); - m_trainingArea.height() = height; - m_trainingArea.width() = width; - m_trainingArea.bottomLeft() = convert(btmLeft); + m_trainingArea.height = height; + m_trainingArea.width = width; + m_trainingArea.bottomLeft = convert(btmLeft); DEBUG_LOG(m_logger) << "Pos X: " << centerPoint.x() << " Y: " << centerPoint.y() << " W: " << width << " H: " << height; @@ -205,9 +206,9 @@ void AsmEditTrainingAreaDialog::onCoordinate(const QPointF& centerPoint) m_ui->sbWidth->setValue(width); m_ui->sbHeight->setValue(height); - m_trainingArea.height() = height; - m_trainingArea.width() = width; - m_trainingArea.bottomLeft() = convert(btmLeft); + m_trainingArea.height = height; + m_trainingArea.width = width; + m_trainingArea.bottomLeft = convert(btmLeft); DEBUG_LOG(m_logger) << "Pos X: " << centerPoint.x() << " Y: " << centerPoint.y() << " W: " << width << " H: " << height; @@ -218,9 +219,9 @@ void AsmEditTrainingAreaDialog::onCoordinate(const QPointF& centerPoint) void AsmEditTrainingAreaDialog::onEditClicked() { TRACE_LOG(m_logger) << Q_FUNC_INFO << " START Editing.."; - if (!m_sitMapGuiIfc || m_trainingArea.id() < 0) + if (!m_sitMapGuiIfc || m_trainingArea.id < 0) { - ERROR_LOG(m_logger) << "onEditClicked: sitMapGuiIfc or trainingArea_id: " << m_trainingArea.id() + ERROR_LOG(m_logger) << "onEditClicked: sitMapGuiIfc or trainingArea_id: " << m_trainingArea.id << " invalid! "; return; } @@ -255,9 +256,9 @@ QPointF AsmEditTrainingAreaDialog::getCentPos(TrainingArea ta) { LtsCoordTrans::UtmCoordinate utmCoordinate = - LtsCoordTrans::UtmCoordinate::fromGeographic(ta.bottomLeft().lon(), ta.bottomLeft().lat()); + LtsCoordTrans::UtmCoordinate::fromGeographic(ta.bottomLeft.lon, ta.bottomLeft.lat); - QPointF centerPoint = utmCoordinate.geographic((ta.width() / 2.0), ta.height() / 2.0); + QPointF centerPoint = utmCoordinate.geographic((ta.width / 2.0), ta.height / 2.0); TRACE_LOG(m_logger) << Q_FUNC_INFO << " coord: x: " << centerPoint.x() << " y: " << centerPoint.y(); return centerPoint; @@ -279,10 +280,10 @@ bool AsmEditTrainingAreaDialog::apply() TrainingArea req = m_trainingArea; - req.name() = m_ui->name_lineEdit->text().toStdString(); - req.width() = m_ui->sbWidth->value(); - req.height() = m_ui->sbHeight->value(); - req.bottomLeft(convert(btmLeft)); + req.name = m_ui->name_lineEdit->text().toStdString(); + req.width = m_ui->sbWidth->value(); + req.height = m_ui->sbHeight->value(); + req.bottomLeft = convert(btmLeft); bool success = m_requestHelper->startSingleRequest([this, req]() { return m_asmFtc->trainingAreaModifyRequest(req, this); }); @@ -293,13 +294,13 @@ bool AsmEditTrainingAreaDialog::apply() void AsmEditTrainingAreaDialog::setData() { - if (m_trainingArea.id() > 0) + if (m_trainingArea.id > 0) { - m_ui->name_lineEdit->setText(QString::fromStdString(m_trainingArea.name())); + m_ui->name_lineEdit->setText(QString::fromStdString(m_trainingArea.name)); QPointF coord = getCentPos(m_trainingArea); m_ui->positionEdit->setCoordinate(coord.x(), coord.y()); - m_ui->sbWidth->setValue(m_trainingArea.width()); - m_ui->sbHeight->setValue(m_trainingArea.height()); + m_ui->sbWidth->setValue(m_trainingArea.width); + m_ui->sbHeight->setValue(m_trainingArea.height); } } @@ -314,14 +315,14 @@ QPolygonF AsmEditTrainingAreaDialog::getTrainingArea(const TrainingArea& ta) AssetManagement::TrainingArea ddsTrainingArea = ta; LtsCoordTrans::UtmCoordinate utmCoordinate = LtsCoordTrans::UtmCoordinate::fromGeographic( - ddsTrainingArea.bottomLeft().lon(), ddsTrainingArea.bottomLeft().lat()); - polygonF.push_back(QPointF((ddsTrainingArea.bottomLeft().lon()), (ddsTrainingArea.bottomLeft().lat()))); + ddsTrainingArea.bottomLeft.lon, ddsTrainingArea.bottomLeft.lat); + polygonF.push_back(QPointF((ddsTrainingArea.bottomLeft.lon), (ddsTrainingArea.bottomLeft.lat))); - polygonF.push_back(utmCoordinate.geographic(ddsTrainingArea.width())); + polygonF.push_back(utmCoordinate.geographic(ddsTrainingArea.width)); - polygonF.push_back(utmCoordinate.geographic(ddsTrainingArea.width(), ddsTrainingArea.height())); + polygonF.push_back(utmCoordinate.geographic(ddsTrainingArea.width, ddsTrainingArea.height)); - polygonF.push_back(utmCoordinate.geographic(0, ddsTrainingArea.height())); + polygonF.push_back(utmCoordinate.geographic(0, ddsTrainingArea.height)); return polygonF; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_training_area_dialog.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_training_area_dialog.cpp index 2975f96ef..1c71174fc 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_training_area_dialog.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_training_area_dialog.cpp @@ -19,8 +19,9 @@ namespace AssetManagement { AsmTrainingAreaDialog::AsmTrainingAreaDialog(const QString& menuGroup, QWidget* parent) - : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::CloseOnly), m_ui(new Ui::AsmTrainingAreaDialog), - m_session(nullptr), m_menuGroup(menuGroup), m_requestHelper(new LtsUtils::RequestHelper(this)) + : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::CloseOnly), m_logger(getLogger("AsmTrainingAreaDialog")), + m_ui(new Ui::AsmTrainingAreaDialog), m_session(nullptr), m_menuGroup(menuGroup), + m_requestHelper(new LtsUtils::RequestHelper(this)) { m_ui->setupUi(this); setOnlineHelpFilename(QStringLiteral("Asset_Management-Training_Area")); @@ -139,15 +140,15 @@ void AsmTrainingAreaDialog::onRemoveTrainingArea() return; TrainingArea req = m_model->getRowData(indexList.front().row()); - if (req.id() < 0) + if (req.id < 0) { - ERROR_LOG(m_logger) << Q_FUNC_INFO << " invalid id:bt" << req.id(); + ERROR_LOG(m_logger) << Q_FUNC_INFO << " invalid id:bt" << req.id; return; } - if (!m_viewedTaIds.contains(req.id())) + if (!m_viewedTaIds.contains(req.id)) { bool success = m_requestHelper->startSingleRequest( - [this, req]() { return m_asmFtc->trainingAreaRemoveRequest(TrainingAreaRemoveRequest(req.id()), this); }); + [this, req]() { return m_asmFtc->trainingAreaRemoveRequest(TrainingAreaRemoveRequest(req.id), this); }); TRACE_LOG(m_logger) << Q_FUNC_INFO << " success = " << success; } @@ -166,13 +167,13 @@ void AsmTrainingAreaDialog::onEditTrainingArea() if (indexList.size() == 0) return; TrainingArea taItem = m_model->getRowData(indexList.front().row()); - if (taItem.id() < 0) + if (taItem.id < 0) { - ERROR_LOG(m_logger) << "onEditTrainingArea invalid id = " << taItem.id(); + ERROR_LOG(m_logger) << "onEditTrainingArea invalid id = " << taItem.id; return; } - const QString identifier = QStringLiteral("AsmEditTrainingArea_%1").arg(taItem.id()); + const QString identifier = QStringLiteral("AsmEditTrainingArea_%1").arg(taItem.id); if (focusDialog(m_menuGroup, identifier, LtsWidgets::LayoutArea::eDialogTab)) { return; @@ -180,7 +181,7 @@ void AsmTrainingAreaDialog::onEditTrainingArea() AsmEditTrainingAreaDialog* dialog = new AsmEditTrainingAreaDialog(this); - if (!dialog->init(m_session, taItem.id(), m_sitMapGuiIfc, m_menuGroup)) + if (!dialog->init(m_session, taItem.id, m_sitMapGuiIfc, m_menuGroup)) { delete dialog; return; @@ -201,14 +202,14 @@ void AsmTrainingAreaDialog::onSelectionChanged() return; AssetManagement::TrainingArea taItem = m_model->getRowData(curIdx.row()); - DEBUG_LOG(m_logger) << "onSelectionChanged() selected training area id: " << taItem.id(); - if (taItem.id() < 0) + DEBUG_LOG(m_logger) << "onSelectionChanged() selected training area id: " << taItem.id; + if (taItem.id < 0) { - ERROR_LOG(m_logger) << "onEditTrainingArea invalid id" << taItem.id(); + ERROR_LOG(m_logger) << "onEditTrainingArea invalid id" << taItem.id; return; } - m_previewPolygon = getTrainingArea(taItem.id()); + m_previewPolygon = getTrainingArea(taItem.id); showPreviewObject(); } @@ -229,7 +230,7 @@ QPolygonF AsmTrainingAreaDialog::getTrainingArea(int trainingAreaId) return {}; } const AssetManagement::TrainingArea& ddsTrainingArea = m_asmDtc->trainingArea(trainingAreaId); - if (ddsTrainingArea.id() != trainingAreaId) + if (ddsTrainingArea.id != trainingAreaId) { ERROR_LOG(m_logger) << Q_FUNC_INFO << " TrainingArea not found, trainingAreaId = " << trainingAreaId; return {}; @@ -243,14 +244,14 @@ QPolygonF AsmTrainingAreaDialog::getTrainingArea(const TrainingArea& ddsTraining QPolygonF polygonF; LtsCoordTrans::UtmCoordinate utmCoordinate = LtsCoordTrans::UtmCoordinate::fromGeographic( - ddsTrainingArea.bottomLeft().lon(), ddsTrainingArea.bottomLeft().lat()); - polygonF.push_back(QPointF((ddsTrainingArea.bottomLeft().lon()), (ddsTrainingArea.bottomLeft().lat()))); + ddsTrainingArea.bottomLeft.lon, ddsTrainingArea.bottomLeft.lat); + polygonF.push_back(QPointF((ddsTrainingArea.bottomLeft.lon), (ddsTrainingArea.bottomLeft.lat))); - polygonF.push_back(utmCoordinate.geographic(ddsTrainingArea.width())); + polygonF.push_back(utmCoordinate.geographic(ddsTrainingArea.width)); - polygonF.push_back(utmCoordinate.geographic(ddsTrainingArea.width(), ddsTrainingArea.height())); + polygonF.push_back(utmCoordinate.geographic(ddsTrainingArea.width, ddsTrainingArea.height)); - polygonF.push_back(utmCoordinate.geographic(0, ddsTrainingArea.height())); + polygonF.push_back(utmCoordinate.geographic(0, ddsTrainingArea.height)); return polygonF; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_training_area_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_training_area_model.cpp index 1e95592ff..5ad5d8832 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_training_area_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AssetManagement/Gui/AsmTrainingAreaEdit/asm_training_area_model.cpp @@ -8,7 +8,7 @@ AsmTrainingAreaDialogModel::AsmTrainingAreaDialogModel(QObject* parent) {tr("Id"), tr("Name"), tr("Botton Left x"), tr("Bottom Left y"), tr("Height"), tr("Width")}, parent), - m_asmDtc(nullptr) + m_logger(getLogger("AsmTrainingAreaDialogModel")), m_asmDtc(nullptr) { } @@ -45,17 +45,17 @@ QVariant AsmTrainingAreaDialogModel::data(const QModelIndex& index, int role) co switch (index.column()) { case Id: - return asmTrainingArea.id(); + return asmTrainingArea.id; case Name: - return QString::fromStdString(asmTrainingArea.name()); + return QString::fromStdString(asmTrainingArea.name); case BottomLeft_x: - return asmTrainingArea.bottomLeft().lon(); + return asmTrainingArea.bottomLeft.lon; case BottomLeft_y: - return asmTrainingArea.bottomLeft().lat(); + return asmTrainingArea.bottomLeft.lat; case Height: - return asmTrainingArea.height(); + return asmTrainingArea.height; case Width: - return asmTrainingArea.width(); + return asmTrainingArea.width; } } return QVariant(); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/avs_session_context.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/avs_session_context.cpp index 5fa7c103d..3cc04fd0a 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/avs_session_context.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/avs_session_context.cpp @@ -41,7 +41,7 @@ struct AvsSessionContext::Composite , audioPrioObserver(exerciseId_, operatorId, exerciseContextHandle.opmDtc(), exerciseContextHandle.exmDtc()) , avaComm(NGL::Connections::hostName(NGL::Connections::eConnection::AVS_WORKSTATION), NGL::Connections::port(NGL::Connections::eConnection::AVS_WORKSTATION)) , avaControl(&avaComm, exerciseContextHandle.streamNameMapping(), PluginSettings::instance()->avaTimeout()) - , avaSession(&avaControl, exerciseId, QString::fromStdString(operator_.name()), langCode, operator_.audioChannelPriority(), audioPrioObserver.timezone(), guiStyle, PluginSettings::instance()->avaKeepAliveEnabled()) + , avaSession(&avaControl, exerciseId, QString::fromStdString(operator_.name), langCode, operator_.audioChannelPriority, audioPrioObserver.timezone(), guiStyle, PluginSettings::instance()->avaKeepAliveEnabled()) , avaState(&avaSession) , streamNameMappingToAva(&avaSession, exerciseContextHandle.streamNameMapping()) , avsMenus(&avaSession, exerciseContextHandle.dtc().get(), exerciseContextHandle.ismDtc(), avaState.rtState()) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/operator_settings_observer.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/operator_settings_observer.cpp index b5c6e63a6..25dd2c8c8 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/operator_settings_observer.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/operator_settings_observer.cpp @@ -80,12 +80,12 @@ OperatorSettingsObserver::OperatorSettingsObserver(int exerciseId, int operatorI Q_ASSERT(exmDtc); OperatorManagement::User operator_ = m_opmDtc->user(operatorId); - if (operator_.id() == operatorId) - m_currentPrio = operator_.audioChannelPriority(); + if (operator_.id == operatorId) + m_currentPrio = operator_.audioChannelPriority; ExerciseManagement::Exercise exercise = m_exmDtc->exercise(exerciseId); - if (exercise.id() == exerciseId) - m_timezoneCalculator->setDefaultTimezone(QChar::fromLatin1(exercise.defaultTimeZone())); + if (exercise.id == exerciseId) + m_timezoneCalculator->setDefaultTimezone(QChar::fromLatin1(exercise.defaultTimeZone)); connect(opmDtc, &OperatorManagement::Interface::Dtc::userChanged, this, &OperatorSettingsObserver::onOperatorChanged); connect(exmDtc, &ExerciseManagement::Interface::Dtc::exerciseChanged, this, &OperatorSettingsObserver::onExerciseChanged); @@ -109,10 +109,10 @@ void OperatorSettingsObserver::onOperatorChanged(const OperatorManagement::User case DataModification::eModified: { - if (operator_.id() != m_operatorId) + if (operator_.id != m_operatorId) return; - AvaAudioPrio prio = operator_.audioChannelPriority(); + AvaAudioPrio prio = operator_.audioChannelPriority; if (prio == m_currentPrio) return; @@ -131,13 +131,13 @@ void OperatorSettingsObserver::onOperatorChanged(const OperatorManagement::User void OperatorSettingsObserver::onExerciseChanged(const ExerciseManagement::Exercise &exercise, DataModification modType) { - if (exercise.id() != m_exerciseId) + if (exercise.id != m_exerciseId) return; switch (modType) { case DataModification::eModified: - m_timezoneCalculator->setDefaultTimezone(QChar::fromLatin1(exercise.defaultTimeZone())); + m_timezoneCalculator->setDefaultTimezone(QChar::fromLatin1(exercise.defaultTimeZone)); break; default: diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/rt_profile_observer.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/rt_profile_observer.cpp index c4553b4c8..c2a126e39 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/rt_profile_observer.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Data/rt_profile_observer.cpp @@ -51,7 +51,7 @@ void RtProfileObserver::onCnrConfigChanged(const CnrConfig &cnrConfig, DataModif return; if (!isInProfile(cnrConfig)) return; - m_avaControl->changeRtProfileCircuitName(m_rtState, {RadioSystem::Cnr, cnrConfig.id(), cnrConfig.radioCircuit()}); + m_avaControl->changeRtProfileCircuitName(m_rtState, {RadioSystem::Cnr, cnrConfig.id, cnrConfig.radioCircuit}); } void RtProfileObserver::onTvcConfigChanged(const TvcConfig &tvcConfig, DataModification modType) @@ -60,14 +60,14 @@ void RtProfileObserver::onTvcConfigChanged(const TvcConfig &tvcConfig, DataModif return; if (!isInProfile(tvcConfig)) return; - m_avaControl->changeRtProfileCircuitName(m_rtState, {RadioSystem::Tvc, tvcConfig.id(), tvcConfig.radioCircuit()}); + m_avaControl->changeRtProfileCircuitName(m_rtState, {RadioSystem::Tvc, tvcConfig.id, tvcConfig.radioCircuit}); } void RtProfileObserver::onCnrTvcProfileChanged(const CnrTvcProfile &profile, DataModification modType) { Q_UNUSED(modType); - if (profile.exerciseId() != m_exerciseId || profile.operatorId() != m_operatorId) + if (profile.exerciseId != m_exerciseId || profile.operatorId != m_operatorId) return; switch (modType) @@ -95,16 +95,16 @@ QVector RtProfileObserver::defaultRtChannels() const const QMap tvccs = m_dtc->tvcConfigs(); QVector rtChannels; - rtChannels.reserve(m_profile->data().size()); - for (const auto &cnrTvcProfileData : m_profile->data()) + rtChannels.reserve(m_profile->data.size()); + for (const auto &cnrTvcProfileData : m_profile->data) { std::string circuitName; - if (cnrTvcProfileData.radioSystemId() == RadioSystem::Cnr) - circuitName = cnrcs.value(cnrTvcProfileData.radioCircuitId()).radioCircuit(); + if (cnrTvcProfileData.radioSystemId == RadioSystem::Cnr) + circuitName = cnrcs.value(cnrTvcProfileData.radioCircuitId).radioCircuit; else - circuitName = tvccs.value(cnrTvcProfileData.radioCircuitId()).radioCircuit(); + circuitName = tvccs.value(cnrTvcProfileData.radioCircuitId).radioCircuit; - rtChannels.push_back({cnrTvcProfileData.radioSystemId(), cnrTvcProfileData.radioCircuitId(), circuitName}); + rtChannels.push_back({cnrTvcProfileData.radioSystemId, cnrTvcProfileData.radioCircuitId, circuitName}); } return rtChannels; @@ -115,7 +115,7 @@ boost::optional RtProfileObserver::getProfile() const boost::optional foundProfile; std::function forUserInExercise = [this, &foundProfile] (const CnrTvcProfile &profile) { - if (profile.exerciseId() != m_exerciseId || profile.operatorId() != m_operatorId) + if (profile.exerciseId != m_exerciseId || profile.operatorId != m_operatorId) return false; foundProfile = profile; return true; @@ -127,12 +127,12 @@ boost::optional RtProfileObserver::getProfile() const bool RtProfileObserver::isInProfile(const CnrConfig &cnrConfig) const { - return isInProfile(RadioSystem::Cnr, cnrConfig.id()); + return isInProfile(RadioSystem::Cnr, cnrConfig.id); } bool RtProfileObserver::isInProfile(const TvcConfig &tvcConfig) const { - return isInProfile(RadioSystem::Tvc, tvcConfig.id()); + return isInProfile(RadioSystem::Tvc, tvcConfig.id); } bool RtProfileObserver::isInProfile(RadioSystem radioSystem, int32_t id) const @@ -140,8 +140,8 @@ bool RtProfileObserver::isInProfile(RadioSystem radioSystem, int32_t id) const if (!m_profile) return false; - for (const auto &cnrTvcProfileData : m_profile->data()) - if (cnrTvcProfileData.radioSystemId() == radioSystem && cnrTvcProfileData.radioCircuitId() == id) + for (const auto &cnrTvcProfileData : m_profile->data) + if (cnrTvcProfileData.radioSystemId == radioSystem && cnrTvcProfileData.radioCircuitId == id) return true; return false; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_avail_streams_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_avail_streams_model.cpp index c3050ed76..2d80bf209 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_avail_streams_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_avail_streams_model.cpp @@ -21,12 +21,11 @@ QDataStream& operator>>(QDataStream& ds, StreamData& sd) AvailStreamsModel::AvailStreamsModel(Interface::Dtc* avmDtc, int32_t exerciseId, QObject* parent) : NGLTreeModel(parent, new NGLTreeItem(QVariant()), {tr("Available")}), m_exerciseId(exerciseId), m_avmDtc(avmDtc), - m_cnrRoot(new NGLTreeItem(QVariant())), m_tvcRoot(new NGLTreeItem(QVariant())), m_changes(false) + m_cnrRoot(new NGLTreeItem(QVariant())), m_tvcRoot(new NGLTreeItem(QVariant())), m_changes(false), + m_logger(getLogger("AudioSettingsAvailStreamsModel")) { Q_ASSERT(avmDtc); - qRegisterMetaTypeStreamOperators(); - setMimeType(StreamData::mimeType()); StreamData data; @@ -168,7 +167,7 @@ void AvailStreamsModel::insertUpdateData(const T& config, DataModification modTy if (modType == DataModification::eModified) { - if (config.exerciseId().is_set() && config.exerciseId().get() != m_exerciseId) + if (config.exerciseId.has_value() && config.exerciseId.get() != m_exerciseId) action = DataModification::eRemoved; } @@ -177,7 +176,7 @@ void AvailStreamsModel::insertUpdateData(const T& config, DataModification modTy switch (action) { case DataModification::eAdded: - if (config.exerciseId().is_set() && config.exerciseId().get() != m_exerciseId) + if (config.exerciseId.has_value() && config.exerciseId.get() != m_exerciseId) break; Q_FALLTHROUGH(); case DataModification::eModified: { diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_dialog.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_dialog.cpp index 52a301ac1..b468a4fd8 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_dialog.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_dialog.cpp @@ -17,7 +17,7 @@ namespace AudioVideoManagement { AudioSettingsDialog::AudioSettingsDialog(QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::OkApplyCancel), m_ui(new Ui::AudioSettingsDialog), - m_requestHelper(new LtsUtils::RequestHelper(this)) + m_requestHelper(new LtsUtils::RequestHelper(this)), m_logger(getLogger("AudioSettingsDialog")) { m_ui->setupUi(this); setAttribute(Qt::WA_DeleteOnClose); @@ -111,9 +111,9 @@ void AudioSettingsDialog::onOperatorChanged(const OperatorManagement::User& data switch (modType) { case DataModification::eRemoved: { - Q_ASSERT(m_operatorMap.contains(data.id())); + Q_ASSERT(m_operatorMap.contains(data.id)); - if (m_ui->operatorComboBox->currentData().toInt() == data.id()) + if (m_ui->operatorComboBox->currentData().toInt() == data.id) { __unchange__(); m_modelAllocated->resetChangeState(); @@ -121,25 +121,25 @@ void AudioSettingsDialog::onOperatorChanged(const OperatorManagement::User& data m_filterAvailable->invalidate(); } - m_operatorMap.remove(data.id()); - m_ui->operatorComboBox->removeItem(m_ui->operatorComboBox->findData(data.id())); + m_operatorMap.remove(data.id); + m_ui->operatorComboBox->removeItem(m_ui->operatorComboBox->findData(data.id)); break; } case DataModification::eAdded: { - Q_ASSERT(!m_operatorMap.contains(data.id())); - const QString operatorName = QString::fromStdString(data.name()); - m_operatorMap.insert(data.id(), operatorName); - m_ui->operatorComboBox->addItem(operatorName, data.id()); + Q_ASSERT(!m_operatorMap.contains(data.id)); + const QString operatorName = QString::fromStdString(data.name); + m_operatorMap.insert(data.id, operatorName); + m_ui->operatorComboBox->addItem(operatorName, data.id); m_ui->operatorComboBox->model()->sort(0); break; } case DataModification::eModified: { - Q_ASSERT(m_operatorMap.contains(data.id())); - const QString operatorName = QString::fromStdString(data.name()); - m_operatorMap.insert(data.id(), operatorName); - int i = m_ui->operatorComboBox->findData(data.id()); + Q_ASSERT(m_operatorMap.contains(data.id)); + const QString operatorName = QString::fromStdString(data.name); + m_operatorMap.insert(data.id, operatorName); + int i = m_ui->operatorComboBox->findData(data.id); Q_ASSERT(i != -1); m_ui->operatorComboBox->setItemText(i, operatorName); m_ui->operatorComboBox->model()->sort(0); @@ -150,15 +150,15 @@ void AudioSettingsDialog::onOperatorChanged(const OperatorManagement::User& data void AudioSettingsDialog::onCnrTvcProfileChanged(const CnrTvcProfile& data, DataModification modType) { - if (m_session->exerciseId() == data.exerciseId()) + if (m_session->exerciseId() == data.exerciseId) { if (modType == DataModification::eRemoved) { - m_cnrTvcProfileMap.remove(data.id()); + m_cnrTvcProfileMap.remove(data.id); } else { - m_cnrTvcProfileMap.insert(data.id(), data); + m_cnrTvcProfileMap.insert(data.id, data); fillOperatorList(); } } @@ -170,12 +170,12 @@ void AudioSettingsDialog::fillOperatorList() for (const auto& rc : std::as_const(m_cnrTvcProfileMap)) { - if ((rc.exerciseId() != m_session->exerciseId()) || - (rc.operatorId() != m_ui->operatorComboBox->currentData().toInt())) + if ((rc.exerciseId != m_session->exerciseId()) || + (rc.operatorId != m_ui->operatorComboBox->currentData().toInt())) continue; - newStreamData.reserve(rc.data().size()); - for (const CnrTvcProfileData& profileEntry : rc.data()) + newStreamData.reserve(rc.data.size()); + for (const CnrTvcProfileData& profileEntry : rc.data) newStreamData += toStreamData(profileEntry); break; @@ -264,12 +264,12 @@ bool AudioSettingsDialog::applyRemove() for (const auto& profile : std::as_const(m_cnrTvcProfileMap)) { - if (profile.operatorId() != m_operatorId) + if (profile.operatorId != m_operatorId) continue; - removeRequest.id(profile.id()); + removeRequest.id = profile.id; break; } - if (removeRequest.id() <= 0) + if (removeRequest.id <= 0) return true; m_requestHelper->startSingleRequest( @@ -285,23 +285,23 @@ bool AudioSettingsDialog::applyModify() for (const auto& profile : std::as_const(m_cnrTvcProfileMap)) { - if (profile.operatorId() != m_operatorId) + if (profile.operatorId != m_operatorId) continue; - modifyRequest.id(profile.id()); + modifyRequest.id = profile.id; break; } - modifyRequest.exerciseId(m_session->exerciseId()); - modifyRequest.operatorId(m_operatorId); + modifyRequest.exerciseId = m_session->exerciseId(); + modifyRequest.operatorId = m_operatorId; const QVector allocatedList = m_modelAllocated->getStreamDataVector(); - modifyRequest.data().reserve(allocatedList.size()); + modifyRequest.data.reserve(allocatedList.size()); for (const StreamData& stream : allocatedList) { CnrTvcProfileData circuitData; - circuitData.radioSystemId(stream.bIsCnr ? RadioSystem::Cnr : RadioSystem::Tvc); - circuitData.radioCircuitId(stream.topicId); - modifyRequest.data().push_back(std::move(circuitData)); + circuitData.radioSystemId = stream.bIsCnr ? RadioSystem::Cnr : RadioSystem::Tvc; + circuitData.radioCircuitId = stream.topicId; + modifyRequest.data.push_back(std::move(circuitData)); } m_requestHelper->startSingleRequest( @@ -383,18 +383,18 @@ void AudioSettingsDialog::onEntryRemoved(const StreamData& stream) StreamData AudioSettingsDialog::toStreamData(const CnrTvcProfileData& profileEntry) const { - int configId = profileEntry.radioCircuitId(); + int configId = profileEntry.radioCircuitId; StreamData streamData; streamData.topicId = configId; - if (profileEntry.radioSystemId() == RadioSystem::Cnr) + if (profileEntry.radioSystemId == RadioSystem::Cnr) { - streamData.name = QString::fromStdString(m_avmDtc->cnrConfig(configId).radioCircuit()); + streamData.name = QString::fromStdString(m_avmDtc->cnrConfig(configId).radioCircuit); streamData.bIsCnr = true; } else { - streamData.name = QString::fromStdString(m_avmDtc->tvcConfig(configId).radioCircuit()); + streamData.name = QString::fromStdString(m_avmDtc->tvcConfig(configId).radioCircuit); streamData.bIsCnr = false; } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_used_streams_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_used_streams_model.cpp index e54189453..8ec6b4b2f 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_used_streams_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_settings_used_streams_model.cpp @@ -10,7 +10,8 @@ namespace AudioVideoManagement { AllocatedStreamsModel::AllocatedStreamsModel(QObject* parent) - : NGLTreeModel(parent, new NGLTreeItem(QVariant(QLatin1String("root"))), {tr("Allocated")}) + : NGLTreeModel(parent, new NGLTreeItem(QVariant(QLatin1String("root"))), {tr("Allocated")}), + m_logger(getLogger("AudioSettingsUsedStreamsModel")) { setMimeType(StreamData::mimeType()); } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_stream_type.h b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_stream_type.h index e2b92f707..18407f7c4 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_stream_type.h +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/AudioSettings/audio_stream_type.h @@ -19,14 +19,14 @@ struct StreamData : boost::totally_ordered StreamData() = default; explicit StreamData(const TvcConfig &tvcConfig) - : name(QString::fromStdString(tvcConfig.radioCircuit())) - , topicId(tvcConfig.id()) + : name(QString::fromStdString(tvcConfig.radioCircuit)) + , topicId(tvcConfig.id) , bIsCnr(false) {} explicit StreamData(const CnrConfig &cnrConfig) - : name(QString::fromStdString(cnrConfig.radioCircuit())) - , topicId(cnrConfig.id()) + : name(QString::fromStdString(cnrConfig.radioCircuit)) + , topicId(cnrConfig.id) , bIsCnr(true) {} diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/TopicEditor/avm_sequence_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/TopicEditor/avm_sequence_model.cpp index d333a3d43..aca2a8d52 100755 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/TopicEditor/avm_sequence_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/TopicEditor/avm_sequence_model.cpp @@ -21,7 +21,8 @@ AvmSequenceModel::AvmSequenceModel(QObject *parent) tr("Speed"), tr("Volume"), tr("Description")}, - parent) + parent), + m_logger(getLogger("AvmSequenceModel")) {} void AvmSequenceModel::setTimezoneHoursOffset(int timezoneHoursOffset) diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/TopicEditor/topic_editor.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/TopicEditor/topic_editor.cpp index 155be9654..a5e793852 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/TopicEditor/topic_editor.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/TopicEditor/topic_editor.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -52,7 +53,8 @@ AvaTimePoint msecsToAvaTimePoint(qint64 msecs) TopicEditor::TopicEditor(LtsSession::LtsSession* session, const TopicEditorBase::TopicData& data, QWidget* parent) : TopicEditorBase::TopicEditor(parent), m_session(session), m_avmDataIfc(nullptr), - m_model(new AvmSequenceModel(this)), m_playbackMenu(nullptr), m_ui(new Ui::AVTopicEditor) + m_model(new AvmSequenceModel(this)), m_playbackMenu(nullptr), m_ui(new Ui::AVTopicEditor), + m_logger(getLogger("TopicEditor")) { Q_ASSERT(session); @@ -79,7 +81,7 @@ TopicEditor::TopicEditor(LtsSession::LtsSession* session, const TopicEditorBase: m_proxyModel->setSourceModel(m_model); m_ui->tvSequences->setModel(m_proxyModel); connect(m_ui->tvSequences, &QTreeView::doubleClicked, m_ui->tvSequences->selectionModel(), - &QItemSelectionModel::select); + [this](const QModelIndex &idx) { m_ui->tvSequences->selectionModel()->select(idx, QItemSelectionModel::Toggle); }); connect(m_ui->tvSequences->selectionModel(), &QItemSelectionModel::selectionChanged, this, &TopicEditor::onEnaDisa); connect(m_ui->pbDelete, &QToolButton::clicked, this, &TopicEditor::onDeleteSequences); diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_available_streams_model.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_available_streams_model.cpp index fe27bdb2d..fc55dc8f4 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_available_streams_model.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_available_streams_model.cpp @@ -14,14 +14,14 @@ namespace bool isMountingPointOfInterest(const InfrastructureManagement::StructureElement& se, bool isAudio) { - if (se.structureElementTypeId() != InfrastructureManagement::StructureElementType::MountingPoint) + if (se.structureElementTypeId != InfrastructureManagement::StructureElementType::MountingPoint) return false; - if (se.mountingPointTypeId() == InfrastructureManagement::MountingPointType::IndoorCamera || - se.mountingPointTypeId() == InfrastructureManagement::MountingPointType::OutdoorCamera) + if (se.mountingPointTypeId == InfrastructureManagement::MountingPointType::IndoorCamera || + se.mountingPointTypeId == InfrastructureManagement::MountingPointType::OutdoorCamera) return true; - if (isAudio && se.mountingPointTypeId() == InfrastructureManagement::MountingPointType::AnnouncementUnit) + if (isAudio && se.mountingPointTypeId == InfrastructureManagement::MountingPointType::AnnouncementUnit) return true; return false; @@ -47,13 +47,12 @@ AvailableStreamsModel::AvailableStreamsModel(const std::shared_ptr& ismDtc, LtsSession::LtsSession* session, StreamNameMapping* streamNameMapping, QObject* parent, bool isAudio) - : NGLTreeModel(parent, new NGLTreeItem(QVariant(), QIcon()), , - m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()){tr("Available Streams")}), - m_isAudio(isAudio), m_avmDtc(avmDtc), m_ismDtc(ismDtc), m_session(session), m_streamNameMapping(streamNameMapping) + : NGLTreeModel(parent, new NGLTreeItem(QVariant(), QIcon()), {tr("Available Streams")}), m_isAudio(isAudio), + m_avmDtc(avmDtc), m_ismDtc(ismDtc), m_session(session), m_streamNameMapping(streamNameMapping), + m_logger(getLogger("AvailableStreamsModel")) { Q_ASSERT(ismDtc); Q_ASSERT(streamNameMapping); - qRegisterMetaTypeStreamOperators("StreamModelData"); qRegisterMetaType("StreamModelData"); setMimeType(s_MimeType); @@ -175,7 +174,7 @@ void AvailableStreamsModel::initModel() const auto& buildings = m_ismDtc->mainStructureElements(); for (const auto& building : buildings) { - for (const auto& mountingPoint : building.elements()) + for (const auto& mountingPoint : building.elements) { if (!isMountingPointOfInterest(mountingPoint, m_isAudio)) continue; @@ -183,7 +182,7 @@ void AvailableStreamsModel::initModel() bool isMounted = false; for (const auto& mountedAsset : mountedAssets) { - if (mountedAsset.structureElementId() == mountingPoint.id()) + if (mountedAsset.structureElementId == mountingPoint.id) { isMounted = true; break; @@ -193,11 +192,11 @@ void AvailableStreamsModel::initModel() if (!isMounted) continue; StreamModelData item; - item.name = m_streamNameMapping->displayName(mountingPoint.id()); - item.mountingPointId = mountingPoint.id(); + item.name = m_streamNameMapping->displayName(mountingPoint.id); + item.mountingPointId = mountingPoint.id; item.isGroup = false; - if (mountingPoint.mountingPointTypeId() == InfrastructureManagement::MountingPointType::IndoorCamera) + if (mountingPoint.mountingPointTypeId == InfrastructureManagement::MountingPointType::IndoorCamera) toAddIndoor.push_back(item); else toAddOutdoor.push_back(item); @@ -209,12 +208,12 @@ void AvailableStreamsModel::initModel() const auto& mvsStreams = m_avmDtc->videoTeams(); for (const auto& videoTeam : mvsStreams) { - if (videoTeam.exerciseId() != m_session->exerciseId()) + if (videoTeam.exerciseId != m_session->exerciseId()) continue; DEBUG_LOG(m_logger) << "add new videoteam" << videoTeam; StreamModelData item; - item.name = QString::fromStdString(videoTeam.streamName().c_str()); - item.mountingPointId = -1 * videoTeam.id(); + item.name = QString::fromStdString(videoTeam.streamName.c_str()); + item.mountingPointId = -1 * videoTeam.id; item.isGroup = false; toAddMvs.push_back(item); @@ -248,22 +247,22 @@ StreamModelData StreamModelData::createFromServiceItem(const AvMenuEntry& entry, const QMap& videoTeamList) { StreamModelData data; - data.id = entry.id(); - data.parentId = entry.parentId(); - data.isGroup = entry.isGroup(); - if (entry.isGroup()) - data.name = QString::fromStdString(entry.name().get()); + data.id = entry.id; + data.parentId = entry.parentId; + data.isGroup = entry.isGroup; + if (entry.isGroup) + data.name = QString::fromStdString(entry.name.get()); else { - if (entry.mountingPointId().is_set() && (entry.mountingPointId().get() > 0)) + if (entry.mountingPointId.has_value() && (entry.mountingPointId.get() > 0)) { - data.mountingPointId = entry.mountingPointId().get(); - data.name = streamNameMapping->displayName(entry.mountingPointId().get()); + data.mountingPointId = entry.mountingPointId.get(); + data.name = streamNameMapping->displayName(entry.mountingPointId.get()); } else { - data.mountingPointId = entry.mountingPointId().get(); - data.name = QString::fromStdString(videoTeamList.value(entry.mountingPointId().get() * -1).streamName()); + data.mountingPointId = entry.mountingPointId.get(); + data.name = QString::fromStdString(videoTeamList.value(entry.mountingPointId.get() * -1).streamName); } } diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_choose_menu.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_choose_menu.cpp index 7706a9ba4..91a562243 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_choose_menu.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_choose_menu.cpp @@ -15,7 +15,7 @@ namespace AudioVideoManagement ChooseMenu::ChooseMenu(Interface::Dtc* dtc, AvsMenus* avsMenus, QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::OkApplyCancel), m_dtc(dtc), m_avsMenus(avsMenus), - m_ui(new Ui::ChooseMenuStruct) + m_ui(new Ui::ChooseMenuStruct), m_logger(getLogger("ChooseMenu")) { Q_ASSERT(dtc); Q_ASSERT(avsMenus); @@ -47,22 +47,22 @@ void ChooseMenu::onMenuStructChanged(const MenuStruct& data, DataModification mo switch (modType) { case DataModification::eAdded: { - if (data.isAudio()) - m_ui->cbAudio->addItem(QString::fromStdString(data.name()), data.id()); + if (data.isAudio) + m_ui->cbAudio->addItem(QString::fromStdString(data.name), data.id); else - m_ui->cbVideo->addItem(QString::fromStdString(data.name()), data.id()); + m_ui->cbVideo->addItem(QString::fromStdString(data.name), data.id); break; } case DataModification::eRemoved: { - if (data.isAudio()) + if (data.isAudio) { - int index = m_ui->cbAudio->findData(data.id()); + int index = m_ui->cbAudio->findData(data.id); m_ui->cbAudio->removeItem(index); } else { - int index = m_ui->cbVideo->findData(data.id()); + int index = m_ui->cbVideo->findData(data.id); m_ui->cbVideo->removeItem(index); } break; diff --git a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_menu_edit.cpp b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_menu_edit.cpp index 15b573410..df5be2230 100644 --- a/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_menu_edit.cpp +++ b/qt6-after/qt6-migrated-legatus/Lts/Plugins/AudioVideoManagement/Gui/AVMenuEdit/avm_menu_edit.cpp @@ -1,6 +1,7 @@ #include "avm_menu_edit.h" +#include #include "ui_avm_menu_edit.h" @@ -13,6 +14,7 @@ MenuEdit::MenuEdit(QWidget* parent) : LtsWidgets::LtsDialog(parent, LtsWidgets::ButtonCombination::OkApplyCancel), m_ftc(nullptr), m_ui(new Ui::MenuEdit), m_availStreamsModel(nullptr), m_usedStreamsModel(nullptr), m_isAudio(false), m_requestHelper(new LtsUtils::RequestHelper(this)) +, m_logger(NGL::NGLLoggerBootstrap::getNGLRootLogger()) { m_ui->setupUi(this); } @@ -44,8 +46,8 @@ bool MenuEdit::init(LtsSession::LtsSession* session, const std::shared_ptr