Adds immediate migration results

This commit is contained in:
torsten committed 2026-08-18 22:12:24 +02:00
1 parent ba4121728b
commit 6a2a0667ab
2395 files changed
+357322 -2524

No files matched your search

+1
View File
@@ -3,3 +3,4 @@
*~ *~
build build
**/build_*/ **/build_*/
qt6-after/qt6-migrated-legatus/build[0-9]*/
+1
View File
@@ -0,0 +1 @@
/home/torsten/swy/sandbox/external
+33 -16
View File
@@ -64,6 +64,16 @@ IF(CMAKE_VERSION VERSION_GREATER 3.15.9)
ENDIF() ENDIF()
ENDIF() ENDIF()
# Qt6 Migration: Options to disable modules with missing dependencies (WebEngine, XmlPatterns, ArcGIS)
# These can be enabled once the required system dependencies are available in the build environment
OPTION(BUILD_PLUGINS_PLANEDITOR "Build PlanEditor plugin (requires Qt6 WebEngine + ArcGIS SDK)" OFF)
OPTION(BUILD_PLUGINS_ONLINEHELP "Build OnlineHelp plugin (requires Qt6 WebEngine)" OFF)
OPTION(BUILD_PLUGINS_SERVICEMONITOR "Build ServiceMonitor plugin (requires Qt6 WebEngine)" OFF)
OPTION(BUILD_PLUGINS_PARTICIPANT_ORG_CHART "Build ParticipantOrgChart (requires Qt6 WebEngine)" OFF)
OPTION(BUILD_PLUGINS_MSDL "Build MSDL module (requires Qt6 XmlPatterns)" OFF)
OPTION(BUILD_PLUGINS_SAAB "Build Saab module (requires Qt6 XmlPatterns)" OFF)
OPTION(BUILD_RTI "Build RTI Connext DDS dependent modules" OFF)
IF(WIN32) IF(WIN32)
SET(EXTERNAL_LIBRARY_DIR "C:/Development/Projekte/SituationMap/ExtFw" CACHE STRING "Library dir with all external dependencies") SET(EXTERNAL_LIBRARY_DIR "C:/Development/Projekte/SituationMap/ExtFw" CACHE STRING "Library dir with all external dependencies")
LIST(APPEND CMAKE_PREFIX_PATH "${EXTERNAL_LIBRARY_DIR}") LIST(APPEND CMAKE_PREFIX_PATH "${EXTERNAL_LIBRARY_DIR}")
@@ -72,6 +82,8 @@ ENDIF()
ENABLE_TESTING() ENABLE_TESTING()
INCLUDE(CTest) INCLUDE(CTest)
# Add migration tests
ADD_SUBDIRECTORY(tests)
CONFIGURE_FILE(CTestCustom.ctest ${CMAKE_BINARY_DIR}/CTestCustom.ctest COPYONLY) CONFIGURE_FILE(CTestCustom.ctest ${CMAKE_BINARY_DIR}/CTestCustom.ctest COPYONLY)
CONFIGURE_FILE(lts-cc.conf ${CMAKE_BINARY_DIR}/lts-cc.conf.distrib COPYONLY) CONFIGURE_FILE(lts-cc.conf ${CMAKE_BINARY_DIR}/lts-cc.conf.distrib COPYONLY)
@@ -96,9 +108,9 @@ macro_ensure_out_of_source_build("In-Source build nicht erlaubt!")
SET(CMAKE_AUTOMOC TRUE) SET(CMAKE_AUTOMOC TRUE)
SET(CMAKE_AUTOUIC TRUE) SET(CMAKE_AUTOUIC TRUE)
SET(QT_USE_IMPORTED_TARGETS TRUE) SET(QT_USE_IMPORTED_TARGETS TRUE)
# Prefer Qt6, fallback to Qt5. Create Qt5::*-aliases when Qt6 is found so existing CMakeLists continue to work. # Prefer Qt6, fallback to Qt5. Create Qt6::*-aliases when Qt6 is found so existing CMakeLists continue to work.
# Try to detect Qt6 with a minimal check and then create aliases/placeholders for components used across the project. # Try to detect Qt6 with a minimal check and then create aliases/placeholders for components used across the project.
# Prefer Qt6, fallback to Qt5. Create Qt5::* aliases only when the corresponding # Prefer Qt6, fallback to Qt5. Create Qt6::* aliases only when the corresponding
# Qt6:: component target exists. Avoid creating IMPORTED placeholder targets which # Qt6:: component target exists. Avoid creating IMPORTED placeholder targets which
# have no LOCATION and later inject 'NOTFOUND' into autogen timestamp deps. # have no LOCATION and later inject 'NOTFOUND' into autogen timestamp deps.
# Find minimal Qt6 Core first, then probe for other components (non-fatal). # Find minimal Qt6 Core first, then probe for other components (non-fatal).
@@ -109,11 +121,8 @@ if(Qt6_FOUND)
Sensors Multimedia Sql Svg SerialPort Test UiTools WebSockets WebEngineCore WebEngineWidgets Sensors Multimedia Sql Svg SerialPort Test UiTools WebSockets WebEngineCore WebEngineWidgets
Widgets Xml XmlPatterns) Widgets Xml XmlPatterns)
foreach(_comp ${_qlist}) foreach(_comp ${_qlist})
# Probe for each component (non-fatal). If found, create a Qt5:: alias. # Probe for each component (non-fatal).
find_package(Qt6 COMPONENTS ${_comp} QUIET) find_package(Qt6 COMPONENTS ${_comp} QUIET)
if(TARGET "Qt6::${_comp}")
add_library("Qt5::${_comp}" ALIAS "Qt6::${_comp}")
endif()
endforeach() endforeach()
# Map version variable for compatibility if available # Map version variable for compatibility if available
if(Qt6Core_VERSION) if(Qt6Core_VERSION)
@@ -127,22 +136,22 @@ if(Qt6_FOUND)
find_program(_lrelease_exec lrelease-qt6 lrelease) find_program(_lrelease_exec lrelease-qt6 lrelease)
if(_lrelease_exec) if(_lrelease_exec)
set(Qt5_LRELEASE_EXECUTABLE ${_lrelease_exec} CACHE INTERNAL "Compatibility lrelease executable") set(Qt5_LRELEASE_EXECUTABLE ${_lrelease_exec} CACHE INTERNAL "Compatibility lrelease executable")
if(TARGET Qt6::LinguistTools AND NOT TARGET Qt5::lrelease) if(TARGET Qt6::LinguistTools AND NOT TARGET Qt6::lrelease)
add_executable(Qt5::lrelease IMPORTED) add_executable(Qt6::lrelease IMPORTED)
set_target_properties(Qt5::lrelease PROPERTIES IMPORTED_LOCATION ${Qt5_LRELEASE_EXECUTABLE}) set_target_properties(Qt6::lrelease PROPERTIES IMPORTED_LOCATION ${Qt5_LRELEASE_EXECUTABLE})
endif() endif()
endif() endif()
else() else()
FIND_PACKAGE(Qt5 5.9.0 COMPONENTS Concurrent Core Gui Location LinguistTools find_package(Qt6 5.9.0 COMPONENTS Concurrent Core Gui Location LinguistTools
Network OpenGL PrintSupport Sensors Multimedia Network OpenGL PrintSupport Sensors Multimedia
Sql Svg SerialPort Test UiTools WebSockets Sql Svg SerialPort Test UiTools WebSockets
WebEngineCore WebEngineWidgets Widgets WebEngineCore WebEngineWidgets Widgets
Xml XmlPatterns Xml XmlPatterns
REQUIRED) REQUIRED)
MESSAGE(STATUS "Qt version is ${Qt5Core_VERSION}") MESSAGE(STATUS "Qt version is ${Qt6Core_VERSION}")
endif() endif()
MESSAGE(STATUS "Qt version is ${Qt5Core_VERSION}") MESSAGE(STATUS "Qt version is ${Qt6Core_VERSION}")
ADD_DEFINITIONS(-DQT_USE_QSTRINGBUILDER) ADD_DEFINITIONS(-DQT_USE_QSTRINGBUILDER)
ADD_DEFINITIONS(-DQT_NO_CAST_TO_ASCII) ADD_DEFINITIONS(-DQT_NO_CAST_TO_ASCII)
ADD_DEFINITIONS(-DQT_NO_CAST_FROM_ASCII) ADD_DEFINITIONS(-DQT_NO_CAST_FROM_ASCII)
@@ -290,6 +299,15 @@ ENDIF(USE_UBSAN)
OPTION(BUILD_RPM "Build a RPM - install script in scripts subdir" OFF) OPTION(BUILD_RPM "Build a RPM - install script in scripts subdir" OFF)
# Build component options for NGL_ADD_LIBRARY
OPTION(BUILD_ALL "Build all components" ON)
OPTION(BUILD_SV "Build SV component" ON)
OPTION(BUILD_WS "Build WS component" ON)
OPTION(BUILD_AAR "Build AAR component" ON)
OPTION(BUILD_TOOLSWS "Build TOOLSWS component" ON)
OPTION(BUILD_TOOLSSV "Build TOOLSSV component" ON)
OPTION(BUILD_HLA "Build HLA component" ON)
IF(BUILD_RPM) IF(BUILD_RPM)
ADD_SUBDIRECTORY(scripts) ADD_SUBDIRECTORY(scripts)
ELSE() ELSE()
@@ -359,13 +377,12 @@ endfunction()
NGL_ADD_SUBDIR_GUARDED(TetraIF) NGL_ADD_SUBDIR_GUARDED(TetraIF)
NGL_ADD_SUBDIR_GUARDED(Z/src) NGL_ADD_SUBDIR_GUARDED(Z/src)
NGL_ADD_SUBDIR_GUARDED(Lts) NGL_ADD_SUBDIR_GUARDED(Lts)
# Special-case: when migrating TetraIF, also include TrainingAreaBase and Z so generated headers # TrainingAreaBase is included via Lts/Proxies when Lts is processed
# Special-case: when migrating TetraIF, also include ProjectDataManagement so generated headers
# and internal logger target are available in the same build tree for TetraIF dependents. # and internal logger target are available in the same build tree for TetraIF dependents.
if(DEFINED MIGRATE_MODULE AND MIGRATE_MODULE STREQUAL "TetraIF") if(DEFINED MIGRATE_MODULE AND MIGRATE_MODULE STREQUAL "TetraIF")
message(STATUS "Including helper modules for TetraIF migration: Lts/Proxies/TrainingAreaBase and Z/src") message(STATUS "Including helper modules for TetraIF migration: Lts/Plugins/ProjectDataManagement")
add_subdirectory(Lts/Proxies/TrainingAreaBase)
add_subdirectory(Lts/Plugins/ProjectDataManagement) add_subdirectory(Lts/Plugins/ProjectDataManagement)
add_subdirectory(Z/src)
endif() endif()
# at last, to make sure we get all targets in NGL_TS_TARGETS property # at last, to make sure we get all targets in NGL_TS_TARGETS property
NGL_ADD_SUBDIR_GUARDED(translations) NGL_ADD_SUBDIR_GUARDED(translations)
@@ -5,7 +5,7 @@
# #
FIND_PACKAGE(RTI) FIND_PACKAGE(RTI)
FIND_PACKAGE(Grantlee5) FIND_PACKAGE(Grantlee5 REQUIRED COMPONENTS Templates)
NGL_ADD_LIBRARY(ALL codegen_base SHARED NGL_ADD_LIBRARY(ALL codegen_base SHARED
codegen_export.h codegen_export.h
@@ -18,11 +18,11 @@ NGL_ADD_LIBRARY(ALL codegen_base SHARED
) )
NGL_TARGET_LINK_LIBRARIES(codegen_base NGL_TARGET_LINK_LIBRARIES(codegen_base
PRIVATE PRIVATE
Qt5::Xml Qt6::Xml
NGLLogger NGLLogger
ngltools ngltools
PUBLIC PUBLIC
Qt5::Core Qt6::Core
) )
NGL_TARGET_INCLUDE_DIRECTORIES(codegen_base NGL_TARGET_INCLUDE_DIRECTORIES(codegen_base
PUBLIC PUBLIC
@@ -37,9 +37,11 @@ if (TARGET RTI::nddscpp2)
NGL_TARGET_COMPILE_DEFINITIONS(codegen_base NGL_TARGET_COMPILE_DEFINITIONS(codegen_base
PUBLIC PUBLIC
$<TARGET_PROPERTY:RTI::nddscpp2,INTERFACE_COMPILE_DEFINITIONS> $<TARGET_PROPERTY:RTI::nddscpp2,INTERFACE_COMPILE_DEFINITIONS>
RTI_DDS_AVAILABLE
) )
message(STATUS "RTI found; building codegen_base with RTI support")
else() else()
message(STATUS "RTI not found; building codegen_base without RTI include/compile definitions") message(STATUS "RTI not found; building codegen_base without RTI support")
endif() endif()
NGL_INSTALL_TARGET(codegen_base) NGL_INSTALL_TARGET(codegen_base)
@@ -110,7 +112,7 @@ if (TARGET Grantlee5::Templates)
${CMAKE_CURRENT_SOURCE_DIR}/../ ${CMAKE_CURRENT_SOURCE_DIR}/../
) )
else() else()
message(STATUS "Grantlee5 not found; skipping codegen_grantlee target") message(STATUS "Grantlee not found; skipping codegen_grantlee target")
endif() endif()
# Smoke-test: parse all .grantlee templates in this directory to detect parse/render regressions # Smoke-test: parse all .grantlee templates in this directory to detect parse/render regressions
@@ -119,8 +121,8 @@ if (TARGET Grantlee5::Templates)
if (Qt6_FOUND) if (Qt6_FOUND)
set(QTCORE_TARGET Qt6::Core) set(QTCORE_TARGET Qt6::Core)
else() else()
find_package(Qt5 COMPONENTS Core REQUIRED) find_package(Qt6 COMPONENTS Core REQUIRED)
set(QTCORE_TARGET Qt5::Core) set(QTCORE_TARGET Qt6::Core)
endif() endif()
add_executable(grantlee_parser_smoke tests/GrantleeParserSmoke.cpp) add_executable(grantlee_parser_smoke tests/GrantleeParserSmoke.cpp)
@@ -128,14 +130,14 @@ if (TARGET Grantlee5::Templates)
add_test(NAME GrantleeParserSmoke COMMAND grantlee_parser_smoke ${CMAKE_CURRENT_SOURCE_DIR}) add_test(NAME GrantleeParserSmoke COMMAND grantlee_parser_smoke ${CMAKE_CURRENT_SOURCE_DIR})
endif() endif()
NGL_ADD_EXECUTABLE(ALL codegen NGL_ADD_EXECUTABLE(ALL ngl_codegen
main_grantlee.cpp main_grantlee.cpp
) )
NGL_TARGET_LINK_LIBRARIES(codegen NGL_TARGET_LINK_LIBRARIES(ngl_codegen
codegen_grantlee codegen_grantlee
LtsCommandLineParser LtsCommandLineParser
nglcoreapplication nglcoreapplication
Qt5::Core Qt6::Core
) )
NGL_WRAP_UI(codegen_gui_uics NGL_WRAP_UI(codegen_gui_uics
@@ -150,6 +152,6 @@ NGL_TARGET_LINK_LIBRARIES(codegen_gui
codegen_grantlee codegen_grantlee
LtsCommandLineParser LtsCommandLineParser
nglapplication nglapplication
Qt5::Widgets Qt6::Widgets
Grantlee5::Templates Grantlee5::Templates
) )
@@ -7,6 +7,10 @@
#include <NGLLogger/INGLLogger.h> #include <NGLLogger/INGLLogger.h>
#include <grantlee/context.h> #include <grantlee/context.h>
#ifdef RTI_HEADER_AVAILABLE
#include <dds/core/xtypes/EnumType.hpp>
#endif
using namespace CodeGen; using namespace CodeGen;
CppTopicGeneratorGrantlee::CppTopicGeneratorGrantlee() CppTopicGeneratorGrantlee::CppTopicGeneratorGrantlee()
@@ -240,12 +244,17 @@ bool CppTopicGeneratorGrantlee::handleIdlStruct(const CompleteTopicTypeInformati
const CompleteTopicTypeInformation ctti = m_structBuilder->topicTypeInformationByStructType(csi.baseValueType, false); const CompleteTopicTypeInformation ctti = m_structBuilder->topicTypeInformationByStructType(csi.baseValueType, false);
if (ctti.isValid()) if (ctti.isValid())
{ {
#ifdef RTI_HEADER_AVAILABLE
if (ctti.extensibility == dds::core::xtypes::ExtensibilityKind_def::FINAL) if (ctti.extensibility == dds::core::xtypes::ExtensibilityKind_def::FINAL)
{ {
ERROR_LOG(m_logger) << "Base struct (" << ctti.name ERROR_LOG(m_logger) << "Base struct (" << ctti.name
<< ") has final extensibility - this is not allowed"; << ") has final extensibility - this is not allowed";
return false; return false;
} }
#else
// RTI not available - skip extensibility check (assume EXTENSIBLE)
Q_UNUSED(ctti.extensibility);
#endif
if (!idlStructNames.contains(csi.baseValueType)) if (!idlStructNames.contains(csi.baseValueType))
{ {
if (!handleIdlStruct(ctti, idlStructNames, idlStructs)) if (!handleIdlStruct(ctti, idlStructNames, idlStructs))
@@ -336,8 +345,7 @@ CompleteTopicTypeInformation CppTopicGeneratorGrantlee::topicTypeInformationByDe
if (tti.name.contains(QLatin1String("::")) && if (tti.name.contains(QLatin1String("::")) &&
!tti.baseValueType.contains(QLatin1String("::"))) !tti.baseValueType.contains(QLatin1String("::")))
{ {
const QStringList sl = tti.name.split(QStringLiteral("::"));
const QVector<QStringRef> sl = tti.name.splitRef(QStringLiteral("::"));
baseValueType = sl.at(0) + QLatin1String("::") + tti.baseValueType; baseValueType = sl.at(0) + QLatin1String("::") + tti.baseValueType;
} }
DEBUG_LOG(m_logger) << "topicTypeInformationByStructName(" << baseValueType << ")"; DEBUG_LOG(m_logger) << "topicTypeInformationByStructName(" << baseValueType << ")";
@@ -6,6 +6,7 @@
#include "GrantleeWrappers.h" #include "GrantleeWrappers.h"
#include <NGLLogger/NGLLoggerBootstrap.h> #include <NGLLogger/NGLLoggerBootstrap.h>
#include <QFile> #include <QFile>
#include <QRegularExpression>
#include <grantlee/context.h> #include <grantlee/context.h>
#include <grantlee/engine.h> #include <grantlee/engine.h>
@@ -57,7 +58,7 @@ bool GeneratorGrantleeBase::setTemplate(const QString &templateName, const QStri
QString GeneratorGrantleeBase::render() const QString GeneratorGrantleeBase::render() const
{ {
QString out = m_template->render(m_ctx); QString out = m_template->render(m_ctx);
QRegExp rx(QLatin1String(";\\n([ ]+\\n)*")); const QRegularExpression rx(QLatin1String(";\\n([ ]+\\n)*"));
out = out.replace(rx, QStringLiteral(";\n")); out = out.replace(rx, QStringLiteral(";\n"));
return out; return out;
} }
@@ -131,7 +132,7 @@ bool GeneratorGrantleeBase::getFilenameFromData(const QString &dataToParse, QStr
ERROR_LOG(m_logger) << "Could not find end marker '\\n' in data!"; ERROR_LOG(m_logger) << "Could not find end marker '\\n' in data!";
return false; return false;
} }
filename = dataToParse.midRef(idx, endIdx - idx).trimmed().toString(); filename = dataToParse.mid(idx, endIdx - idx).trimmed();
return true; return true;
} }
@@ -3,9 +3,11 @@
#include "GrantleeWrappers.h" #include "GrantleeWrappers.h"
#include <NGLLogger/NGLLoggerBootstrap.h> #include <NGLLogger/NGLLoggerBootstrap.h>
#include <utility>
using namespace CodeGen; using namespace CodeGen;
#ifdef RTI_HEADER_AVAILABLE
QString IdlStructWrapper::extensibility2String(dds::core::xtypes::ExtensibilityKind extensiblity) QString IdlStructWrapper::extensibility2String(dds::core::xtypes::ExtensibilityKind extensiblity)
{ {
switch (extensiblity.underlying()) switch (extensiblity.underlying())
@@ -20,6 +22,13 @@ QString IdlStructWrapper::extensibility2String(dds::core::xtypes::ExtensibilityK
Q_ASSERT_X(false, "IdlStructWrapper::extensibility2String", "Unknown extensiblity kind"); Q_ASSERT_X(false, "IdlStructWrapper::extensibility2String", "Unknown extensiblity kind");
return QString(); return QString();
} }
#else
QString IdlStructWrapper::extensibility2String(int /*extensiblity*/)
{
// RTI not available - return placeholder
return QStringLiteral("EXTENSIBLE_EXTENSIBILITY");
}
#endif
QString DataTopicWrapper::typeFq() const QString DataTopicWrapper::typeFq() const
{ {
@@ -51,29 +60,44 @@ QString MemberInformationWrapper::ddsToJsonElement() const
{ {
if (cppMemberName().isEmpty()) if (cppMemberName().isEmpty())
return QStringLiteral("obj[QStringLiteral(\"") + cppType() + QStringLiteral("\")] = element;"); return QStringLiteral("obj[QStringLiteral(\"") + cppType() + QStringLiteral("\")] = element;");
const QString memberAccess = isCppStruct() ? cppMemberName() : cppMemberName() + QStringLiteral("()");
if (!isOptional()) if (!isOptional())
return QStringLiteral("obj[QStringLiteral(\"") + cppMemberName() + QStringLiteral("\")] = ") + return QStringLiteral("obj[QStringLiteral(\"") + cppMemberName() + QStringLiteral("\")] = ") +
cppToJsonPre() + QStringLiteral("element.") + cppMemberName() + QStringLiteral("()") + cppToJsonPost(); cppToJsonPre() + QStringLiteral("element.") + memberAccess + cppToJsonPost();
return QStringLiteral("if (element.") + cppMemberName() + QStringLiteral("().is_set()) ") + const QString optionalAccess = isCppStruct() ? cppMemberName() + QStringLiteral(".is_set()") : cppMemberName() + QStringLiteral("().is_set()");
const QString getValue = isCppStruct() ? cppMemberName() : cppMemberName() + QStringLiteral("()");
return QStringLiteral("if (element.") + optionalAccess + QStringLiteral(") ") +
QStringLiteral("obj[QStringLiteral(\"") + cppMemberName() + QStringLiteral("\")] = ") + QStringLiteral("obj[QStringLiteral(\"") + cppMemberName() + QStringLiteral("\")] = ") +
cppToJsonPre() + QStringLiteral("element.") + cppMemberName() + QStringLiteral("().get()") + cppToJsonPost(); cppToJsonPre() + QStringLiteral("element.") + getValue + cppToJsonPost();
} }
QString MemberInformationWrapper::jsonElementToDds() const QString MemberInformationWrapper::jsonElementToDds() const
{ {
@@ -81,10 +105,6 @@ QString MemberInformationWrapper::jsonElementToDds() const
if (cppMemberName().isEmpty()) if (cppMemberName().isEmpty())
return QStringLiteral("element = ") + return QStringLiteral("element = ") +
cppFromQvPre2() + QStringLiteral("objElement.value(QStringLiteral(\"") + cppType() + QStringLiteral("\"))") + cppFromJsonPost(); cppFromQvPre2() + QStringLiteral("objElement.value(QStringLiteral(\"") + cppType() + QStringLiteral("\"))") + cppFromJsonPost();
@@ -93,8 +113,12 @@ QString MemberInformationWrapper::jsonElementToDds() const
if (isOptional()) if (isOptional())
ret += QStringLiteral("if (!val.isNull()) "); ret += QStringLiteral("if (!val.isNull()) ");
ret += QStringLiteral("element.") + cppMemberName() + QStringLiteral("(") + if (isCppStruct())
cppFromJsonPre2() + QStringLiteral("val") + cppFromJsonPost() + QStringLiteral(")"); ret += QStringLiteral("element.") + cppMemberName() + QStringLiteral(" = ") +
cppFromJsonPre2() + QStringLiteral("val") + cppFromJsonPost();
else
ret += QStringLiteral("element.") + cppMemberName() + QStringLiteral("(") +
cppFromJsonPre2() + QStringLiteral("val") + cppFromJsonPost() + QStringLiteral(")");
return ret; return ret;
} }
@@ -165,7 +189,7 @@ QVariantList DbStructWrapper::insertStructures()
QMap<QString, MemberInformationWrapper *> fkComplexTableKeys; QMap<QString, MemberInformationWrapper *> fkComplexTableKeys;
tableNames.reserve(5); tableNames.reserve(5);
for (const QVariant &v : qAsConst(m_member)) for (const QVariant &v : std::as_const(m_member))
{ {
MemberInformationWrapper *mi = v.value<MemberInformationWrapper *>(); MemberInformationWrapper *mi = v.value<MemberInformationWrapper *>();
const QString &tableName = mi->info().db.table; const QString &tableName = mi->info().db.table;
@@ -6,8 +6,13 @@
#include <QObject> #include <QObject>
#include <QString> #include <QString>
#include <QVariant> #include <QVariant>
#include <utility>
#include "StructBuilder.h" #include "StructBuilder.h"
#ifdef RTI_HEADER_AVAILABLE
#include <dds/core/xtypes/EnumType.hpp>
#endif
namespace CodeGen namespace CodeGen
{ {
class NameWrapper : public QObject class NameWrapper : public QObject
@@ -38,7 +43,7 @@ public:
using NameWrapper::NameWrapper; using NameWrapper::NameWrapper;
~VariantListWrapper() ~VariantListWrapper()
{ {
for (const QVariant &v : qAsConst(m_member)) for (const QVariant &v : std::as_const(m_member))
{ {
auto ptr = v.value<QObject *>(); auto ptr = v.value<QObject *>();
delete ptr; delete ptr;
@@ -75,6 +80,7 @@ class MemberInformationWrapper final : public QObject
Q_PROPERTY(QString jsonElementToDb READ jsonElementToDb) Q_PROPERTY(QString jsonElementToDb READ jsonElementToDb)
Q_PROPERTY(bool dbHasSequence READ dbHasSequence) Q_PROPERTY(bool dbHasSequence READ dbHasSequence)
Q_PROPERTY(bool isOptional READ isOptional) Q_PROPERTY(bool isOptional READ isOptional)
Q_PROPERTY(bool isCppStruct READ isCppStruct)
public: public:
MemberInformationWrapper(const MemberInformation &mi, QObject *parent) MemberInformationWrapper(const MemberInformation &mi, QObject *parent)
: QObject(parent) : QObject(parent)
@@ -103,6 +109,7 @@ public:
QString jsonElementToDb() const; QString jsonElementToDb() const;
bool dbHasSequence() const { return m_mi.db.hasSequence; } bool dbHasSequence() const { return m_mi.db.hasSequence; }
bool isOptional() const { return m_mi.cpp.isOptional; } bool isOptional() const { return m_mi.cpp.isOptional; }
bool isCppStruct() const { return m_mi.cpp.usedForCppStruct; }
QString cppToJsonPre() const { return m_mi.cpp.toJsonPre.isNull() ? m_mi.cpp.toVariantPre : m_mi.cpp.toJsonPre; } QString cppToJsonPre() const { return m_mi.cpp.toJsonPre.isNull() ? m_mi.cpp.toVariantPre : m_mi.cpp.toJsonPre; }
@@ -245,7 +252,7 @@ public:
, m_csi(csi) , m_csi(csi)
{ {
m_dbNotifications.reserve(m_csi.dbNotifications.size()); m_dbNotifications.reserve(m_csi.dbNotifications.size());
for (const auto &notification : qAsConst(m_csi.dbNotifications)) for (const auto &notification : std::as_const(m_csi.dbNotifications))
m_dbNotifications += QVariant(notification.methodName); m_dbNotifications += QVariant(notification.methodName);
} }
@@ -356,7 +363,7 @@ public:
, m_ctti(ctti) , m_ctti(ctti)
{ {
m_member.reserve(m_ctti.members.size()); m_member.reserve(m_ctti.members.size());
for (const auto &val : qAsConst(m_ctti.members)) for (const auto &val : std::as_const(m_ctti.members))
m_member += QVariant::fromValue(new IdlDataWrapper(val, this)); m_member += QVariant::fromValue(new IdlDataWrapper(val, this));
} }
@@ -366,7 +373,11 @@ public:
private: private:
const CompleteTopicTypeInformation m_ctti; const CompleteTopicTypeInformation m_ctti;
#ifdef RTI_HEADER_AVAILABLE
static QString extensibility2String(dds::core::xtypes::ExtensibilityKind extensiblity); static QString extensibility2String(dds::core::xtypes::ExtensibilityKind extensiblity);
#else
static QString extensibility2String(int extensiblity);
#endif
}; };
class IdlServiceWrapper final : public QObject class IdlServiceWrapper final : public QObject
@@ -306,7 +306,7 @@ QString SqlGenerator::getTableColumnCreateStatements(const QString &tableName,
int maxLength = 1; int maxLength = 1;
for (const MemberInformation &mi : columns) for (const MemberInformation &mi : columns)
maxLength = std::max(maxLength, mi.db.columnName.length()); maxLength = std::max(maxLength, static_cast<int>(mi.db.columnName.length()));
maxLength += 1; maxLength += 1;
QStringList retCols; QStringList retCols;
@@ -4,6 +4,7 @@
#include "StructBuilder.h" #include "StructBuilder.h"
#include <QDateTime> #include <QDateTime>
#include <utility>
#include <NGLLogger/NGLLoggerBootstrap.h> #include <NGLLogger/NGLLoggerBootstrap.h>
@@ -294,7 +295,7 @@ bool StructBuilder::handleEnum(const EnumInformation &ei)
} }
CompleteTableInformation cti = m_sqlTableInformations[ei.tableName]; CompleteTableInformation cti = m_sqlTableInformations[ei.tableName];
for (const ColumnInformation &ci : qAsConst(ti->plainColumns)) for (const ColumnInformation &ci : std::as_const(ti->plainColumns))
{ {
MemberInformation mi; MemberInformation mi;
mi.db = FullQualifiedColumnInformation(ci, ei.tableName); mi.db = FullQualifiedColumnInformation(ci, ei.tableName);
@@ -335,7 +336,7 @@ EnumInformation StructBuilder::enumInformationByType(const QString &type, bool c
return m_xmlReader->getExternalEnumeration(extInfo.service, extInfo.type, verbose); return m_xmlReader->getExternalEnumeration(extInfo.service, extInfo.type, verbose);
} }
for (const EnumInformation &ei : qAsConst(m_enumInfos)) for (const EnumInformation &ei : std::as_const(m_enumInfos))
{ {
if (ei.enumName == type) if (ei.enumName == type)
return ei; return ei;
@@ -359,7 +360,7 @@ CompleteTopicTypeInformation StructBuilder::topicTypeInformationByStructType(con
return externalTopicTypeByStructType(extInfo); return externalTopicTypeByStructType(extInfo);
} }
for (const CompleteTopicTypeInformation &csi : qAsConst(m_topicTypeInfos)) for (const CompleteTopicTypeInformation &csi : std::as_const(m_topicTypeInfos))
{ {
if (csi.name == type) if (csi.name == type)
return csi; return csi;
@@ -385,7 +386,7 @@ CompleteTopicTypeInformation StructBuilder::externalTopicTypeByStructType(const
{ {
const QString typeToSearch = sts.fqType(); const QString typeToSearch = sts.fqType();
DEBUG_LOG(m_logger) << "externalTopicTypeByStructType " << typeToSearch; DEBUG_LOG(m_logger) << "externalTopicTypeByStructType " << typeToSearch;
for (const CompleteTopicTypeInformation &ctti : qAsConst(m_externalTopicTypes)) for (const CompleteTopicTypeInformation &ctti : std::as_const(m_externalTopicTypes))
{ {
if (ctti.name == typeToSearch) if (ctti.name == typeToSearch)
return ctti; return ctti;
@@ -427,7 +428,7 @@ bool StructBuilder::getColumnsFromTable(const QString &tableName,
const QSharedPointer<TableInformation> ti = m_xmlReader->getTable(tableName); const QSharedPointer<TableInformation> ti = m_xmlReader->getTable(tableName);
QVector<ConstraintInformation> constraints; QVector<ConstraintInformation> constraints;
constraints.reserve(ti->constraints.size()); constraints.reserve(ti->constraints.size());
for (const ConstraintInformation &ci : qAsConst(ti->constraints)) for (const ConstraintInformation &ci : std::as_const(ti->constraints))
{ {
if (ci.affectedColumns.size() != 1) if (ci.affectedColumns.size() != 1)
continue; continue;
@@ -437,7 +438,7 @@ bool StructBuilder::getColumnsFromTable(const QString &tableName,
} }
columns.reserve(columns.size() + ti->plainColumns.size()); columns.reserve(columns.size() + ti->plainColumns.size());
for (const auto &plainColum : qAsConst(ti->plainColumns)) for (const auto &plainColum : std::as_const(ti->plainColumns))
{ {
ColumnInformationEx cie(ColumnInformationEx(plainColum, ti)); ColumnInformationEx cie(ColumnInformationEx(plainColum, ti));
for (int j = 0; j < constraints.size(); ++j) for (int j = 0; j < constraints.size(); ++j)
@@ -466,7 +467,7 @@ bool StructBuilder::handleTable(const ServiceStructInformation &ssi)
csi.hasStaticContent = ssi.hasStaticContent; csi.hasStaticContent = ssi.hasStaticContent;
csi.dbNotifications = ssi.dbNotifications; csi.dbNotifications = ssi.dbNotifications;
DEBUG_LOG(m_loggerCSV) << "primaryTable: " << csi.primaryTable; DEBUG_LOG(m_loggerCSV) << "primaryTable: " << csi.primaryTable.data();
DEBUG_LOG(m_loggerCSV) << "hasStaticContent: " << csi.hasStaticContent; DEBUG_LOG(m_loggerCSV) << "hasStaticContent: " << csi.hasStaticContent;
@@ -486,7 +487,7 @@ bool StructBuilder::handleTable(const ServiceStructInformation &ssi)
csi.member.reserve(columns.size() + 1); csi.member.reserve(columns.size() + 1);
MemberInformation miPkFirstTable, miPkLastTable; MemberInformation miPkFirstTable, miPkLastTable;
for (const ColumnInformationEx &ci : qAsConst(columns)) for (const ColumnInformationEx &ci : std::as_const(columns))
{ {
DEBUG_LOG(m_logger) << "handling column " << ci.columnName; DEBUG_LOG(m_logger) << "handling column " << ci.columnName;
@@ -494,7 +495,7 @@ bool StructBuilder::handleTable(const ServiceStructInformation &ssi)
if (ti.isNull()) if (ti.isNull())
{ {
WARNING_LOG(m_logger) << "Could not find table for column " << ci.columnName WARNING_LOG(m_logger) << "Could not find table for column " << ci.columnName
<< " primary table is " << ssi.primaryTable; << " primary table is " << ssi.primaryTable.data();
return false; return false;
} }
csi.tables += ti; csi.tables += ti;
@@ -528,7 +529,7 @@ bool StructBuilder::handleTable(const ServiceStructInformation &ssi)
if (!fki.isNull()) if (!fki.isNull())
{ {
for(const auto &tbl : qAsConst(csi.tables)) for(const auto &tbl : std::as_const(csi.tables))
{ {
if (tbl->name == fki->destination.tableName) if (tbl->name == fki->destination.tableName)
{ {
@@ -545,7 +546,7 @@ bool StructBuilder::handleTable(const ServiceStructInformation &ssi)
if (fki->destination.service.isEmpty()) if (fki->destination.service.isEmpty())
{ {
for (const EnumInformation &ei : qAsConst(m_enumInfos)) for (const EnumInformation &ei : std::as_const(m_enumInfos))
{ {
if (ei.tableName == fki->destination.tableName) if (ei.tableName == fki->destination.tableName)
{ {
@@ -658,7 +659,7 @@ bool StructBuilder::handleIdlStructInfo(const TopicTypeInformation &tti,
const QString &svcName) const QString &svcName)
{ {
for (const CompleteTopicTypeInformation &c : qAsConst(destination)) for (const CompleteTopicTypeInformation &c : std::as_const(destination))
{ {
if (c.name == tti.name) if (c.name == tti.name)
return true; return true;
@@ -1285,7 +1286,7 @@ CompleteTableInformation StructBuilder::getRecordingTopicTable(const QString &st
{ {
const auto vec = structName.contains(QLatin1String("::")) ? m_externalTopicTypes : m_topicTypeInfos; const auto vec = structName.contains(QLatin1String("::")) ? m_externalTopicTypes : m_topicTypeInfos;
for (const CompleteTopicTypeInformation &ctti : qAsConst(vec)) for (const CompleteTopicTypeInformation &ctti : std::as_const(vec))
{ {
if (structName != ctti.name) if (structName != ctti.name)
continue; continue;
@@ -1311,7 +1312,7 @@ QMap<QString, CompleteTableInformation> StructBuilder::getRecordingTopicTables()
MemberInformation miPrimaryKey(getRecordPrimaryKey()); MemberInformation miPrimaryKey(getRecordPrimaryKey());
for (const CompleteTopicTypeInformation &ctti : qAsConst(m_topicTypeInfos)) for (const CompleteTopicTypeInformation &ctti : std::as_const(m_topicTypeInfos))
{ {
if (!ctti.recordTopic) if (!ctti.recordTopic)
continue; continue;
@@ -1331,7 +1332,7 @@ QMap<QString, CompleteTableInformation> StructBuilder::getRecordingTopicTables()
void StructBuilder::addToSerializeFromToJsonTopics(const QSharedPointer<DataTypeInfo> &toAdd) void StructBuilder::addToSerializeFromToJsonTopics(const QSharedPointer<DataTypeInfo> &toAdd)
{ {
typedef QSharedPointer<DataTypeInfo> sDTI; typedef QSharedPointer<DataTypeInfo> sDTI;
for (const sDTI &dti : qAsConst(m_serializeFromToJsonTopics)) for (const sDTI &dti : std::as_const(m_serializeFromToJsonTopics))
{ {
if (dti->cppType() == toAdd->cppType()) if (dti->cppType() == toAdd->cppType())
return; return;
@@ -1392,9 +1393,9 @@ QString StructBuilder::camelCaseToUnderline(const QString &in)
StructBuilder::ServiceTypeStruct StructBuilder::extractServiceAndTypeFromTypename(const QString &type) StructBuilder::ServiceTypeStruct StructBuilder::extractServiceAndTypeFromTypename(const QString &type)
{ {
const QVector<QStringRef> sl = type.splitRef(QStringLiteral("::")); const QStringList sl = QString(type).split(QStringLiteral("::"));
QStringRef extServiceRef;; QStringView extServiceRef;
QStringRef extTypeRef; QStringView extTypeRef;
if (sl.size() == 1) if (sl.size() == 1)
extTypeRef = sl.at(0); extTypeRef = sl.at(0);
else if (sl.size() == 2) else if (sl.size() == 2)
@@ -1407,19 +1408,17 @@ StructBuilder::ServiceTypeStruct StructBuilder::extractServiceAndTypeFromTypenam
StructBuilder::ServiceTypeStruct ret; StructBuilder::ServiceTypeStruct ret;
if (!extServiceRef.isEmpty()) if (!extServiceRef.isEmpty())
{ {
if (extServiceRef.contains(QLatin1Char('<'))) if (extServiceRef.contains(QLatin1Char('<')))
ret.service = extServiceRef.split(QLatin1Char('<')).at(1).toString(); ret.service = QString(extServiceRef).split(QLatin1Char('<')).at(1);
else else
ret.service = extServiceRef.toString(); ret.service = QString(extServiceRef);
} }
if (!extTypeRef.isEmpty()) if (!extTypeRef.isEmpty())
{ {
if (extTypeRef.contains(QLatin1Char('>'))) if (extTypeRef.contains(QLatin1Char('>')))
ret.type = extTypeRef.split(QLatin1Char('>')).at(0).toString(); ret.type = QString(extTypeRef).split(QLatin1Char('>')).at(0);
else else
ret.type = extTypeRef.toString(); ret.type = QString(extTypeRef);
} }
return ret; return ret;
} }
@@ -1,6 +1,7 @@
#include "XmlReader.h" #include "XmlReader.h"
#include <utility>
#include <NGLLogger/NGLLoggerBootstrap.h> #include <NGLLogger/NGLLoggerBootstrap.h>
@@ -134,7 +135,7 @@ bool XmlReader::readServiceFile(const QString &svcFile,
const QString groupNamesString = getAttribute(domRoot, QStringLiteral("groups"), true); const QString groupNamesString = getAttribute(domRoot, QStringLiteral("groups"), true);
if (!groupNamesString.isEmpty()) if (!groupNamesString.isEmpty())
{ {
m_groupNames = groupNamesString.split(QLatin1Char(','), QString::SkipEmptyParts); m_groupNames = groupNamesString.split(QLatin1Char(','), Qt::SkipEmptyParts);
INFO_LOG(m_logger) << "groups: " << groupNamesString; INFO_LOG(m_logger) << "groups: " << groupNamesString;
} }
else else
@@ -471,15 +472,20 @@ void XmlReader::parseTopicTypes(const QDomElement &rootElement)
isi.baseValueType = getAttribute(domIdlStruct, QStringLiteral("baseValueType"), true); isi.baseValueType = getAttribute(domIdlStruct, QStringLiteral("baseValueType"), true);
const QVector<QStringRef> sl = isi.baseValueType.splitRef(QStringLiteral("::")); const QStringList sl = isi.baseValueType.split(QStringLiteral("::"));
if (sl.size() == 2) if (sl.size() == 2)
loadExternalTopicType(sl.at(0).toString(), sl.at(1).toString()); loadExternalTopicType(sl.at(0), sl.at(1));
const QString tmp = getAttribute(domIdlStruct, QStringLiteral("extensibility"), true); const QString tmp = getAttribute(domIdlStruct, QStringLiteral("extensibility"), true);
#ifdef RTI_HEADER_AVAILABLE
if (tmp.compare(QLatin1String("FINAL"), Qt::CaseInsensitive) == 0) isi.extensibility = dds::core::xtypes::ExtensibilityKind::FINAL; if (tmp.compare(QLatin1String("FINAL"), Qt::CaseInsensitive) == 0) isi.extensibility = dds::core::xtypes::ExtensibilityKind::FINAL;
if (tmp.compare(QLatin1String("MUTABLE"), Qt::CaseInsensitive) == 0) isi.extensibility = dds::core::xtypes::ExtensibilityKind::MUTABLE; if (tmp.compare(QLatin1String("MUTABLE"), Qt::CaseInsensitive) == 0) isi.extensibility = dds::core::xtypes::ExtensibilityKind::MUTABLE;
if (tmp.compare(QLatin1String("EXTENSIBLE"), Qt::CaseInsensitive) == 0) isi.extensibility = dds::core::xtypes::ExtensibilityKind::EXTENSIBLE; if (tmp.compare(QLatin1String("EXTENSIBLE"), Qt::CaseInsensitive) == 0) isi.extensibility = dds::core::xtypes::ExtensibilityKind::EXTENSIBLE;
#else
// RTI not available - skip extensibility parsing
Q_UNUSED(tmp)
#endif
isi.comment = getAttribute(domIdlStruct, QStringLiteral("comment"), true); isi.comment = getAttribute(domIdlStruct, QStringLiteral("comment"), true);
isi.isDataObject = getAttributeBool(domIdlStruct, QStringLiteral("isDataObject"), true, false); isi.isDataObject = getAttributeBool(domIdlStruct, QStringLiteral("isDataObject"), true, false);
@@ -530,14 +536,14 @@ void XmlReader::parseFunctionTopics(const QDomElement &rootElement)
domFunctionTopic = domFunctionTopic.nextSiblingElement(domFunctionTopic.tagName()); domFunctionTopic = domFunctionTopic.nextSiblingElement(domFunctionTopic.tagName());
} }
for (const FunctionTopic &ft : qAsConst(m_functionTopics)) for (const FunctionTopic &ft : std::as_const(m_functionTopics))
{ {
const QVector<QStringRef> sl1 = ft.requestTopicType.splitRef(QStringLiteral("::")); const QStringList sl1 = ft.requestTopicType.split(QStringLiteral("::"));
if (sl1.size() == 2) if (sl1.size() == 2)
loadExternalTopicType(sl1.at(0).toString(), sl1.at(1).toString()); loadExternalTopicType(sl1.at(0), sl1.at(1));
const QVector<QStringRef> sl2 = ft.replyTopicType.splitRef(QStringLiteral("::")); const QStringList sl2 = ft.replyTopicType.split(QStringLiteral("::"));
if (sl2.size() == 2) if (sl2.size() == 2)
loadExternalTopicType(sl2.at(0).toString(), sl2.at(1).toString()); loadExternalTopicType(sl2.at(0), sl2.at(1));
} }
} }
@@ -847,18 +853,18 @@ void XmlReader::loadIdlInfofile(const QString &idlServiceInfoFile)
if (filePath.startsWith("--") || filePath.trimmed().isEmpty()) if (filePath.startsWith("--") || filePath.trimmed().isEmpty())
continue; continue;
const QString fileName = QString::fromLocal8Bit(filePath.trimmed()); const QString fileName = QString::fromLocal8Bit(filePath.trimmed());
const QVector<QStringRef> parts = fileName.splitRef(QLatin1Char('/')); const QStringList parts = fileName.split(QStringLiteral("/"));
getServiceNameInfoFromFilePath(parts); getServiceNameInfoFromFilePath(parts);
const auto fn = parts.last().trimmed(); const auto fn = parts.last().trimmed();
if (fn.endsWith(QLatin1String(".xml"))) if (fn.endsWith(QLatin1String(".xml")))
{ {
const auto svcAbbreveation = fn.split(QLatin1Char('.')).at(0).split(QLatin1Char('_')).at(0); const auto svcAbbreveation = fn.split(QLatin1Char('.')).at(0).split(QLatin1Char('_')).at(0);
m_xmlFiles[svcAbbreveation.toString()] = fileName; m_xmlFiles[svcAbbreveation] = fileName;
DEBUG_LOG(m_logger) << "xml: " << svcAbbreveation.toString() << " = " << fileName; DEBUG_LOG(m_logger) << "xml: " << svcAbbreveation << " = " << fileName;
} }
else else
{ {
const auto svcAbbreveation = fn.split(QLatin1Char('.')).at(0).toString().toLower(); const auto svcAbbreveation = fn.split(QLatin1Char('.')).at(0).toLower();
if (svcAbbreveation.endsWith(QLatin1String("_enums"))) if (svcAbbreveation.endsWith(QLatin1String("_enums")))
continue; continue;
m_idlFiles[svcAbbreveation] = fileName; m_idlFiles[svcAbbreveation] = fileName;
@@ -880,14 +886,14 @@ QString XmlReader::serviceNameAbbreviation(const QString &serviceName) const
return m_fullServiceName2Abbreviation.value(serviceName); return m_fullServiceName2Abbreviation.value(serviceName);
} }
void XmlReader::getServiceNameInfoFromFilePath(const QVector<QStringRef> &parts) void XmlReader::getServiceNameInfoFromFilePath(const QStringList &parts)
{ {
if (parts.size() < 2) if (parts.size() < 2)
return; return;
const QString abbreviation = parts.last().split(QLatin1Char('.')).first().split(QLatin1Char('_')).first().toString(); const QString abbreviation = parts.last().split(QLatin1Char('.')).first().split(QLatin1Char('_')).first();
const QString serviceName = parts.at(parts.size() - 2).toString(); const QString serviceName = parts.at(parts.size() - 2);
DEBUG_LOG(m_logger) << "serviceName: " << serviceName << " = " << abbreviation; DEBUG_LOG(m_logger) << "serviceName: " << serviceName << " = " << abbreviation;
m_fullServiceName2Abbreviation[serviceName] = abbreviation; m_fullServiceName2Abbreviation[serviceName] = abbreviation;
} }
@@ -7,9 +7,18 @@
#include <QtCore/QSharedPointer> #include <QtCore/QSharedPointer>
#include <QtCore/QString> #include <QtCore/QString>
#include <QtCore/QStringList> #include <QtCore/QStringList>
#include <QtCore/QStringView>
#include <QtCore/QVector> #include <QtCore/QVector>
#ifdef RTI_DDS_AVAILABLE
// Only include RTI headers if they are actually available
#if __has_include(<dds/core/xtypes/EnumType.hpp>)
#include <dds/core/xtypes/EnumType.hpp> #include <dds/core/xtypes/EnumType.hpp>
#define RTI_HEADER_AVAILABLE 1
#else
#undef RTI_DDS_AVAILABLE
#endif
#endif
#include "codegen_export.h" #include "codegen_export.h"
@@ -212,7 +221,11 @@ struct TopicTypeInformationBase
bool routeInReplay = true; bool routeInReplay = true;
bool autosubscribe = true; bool autosubscribe = true;
#ifdef RTI_DDS_AVAILABLE
dds::core::xtypes::ExtensibilityKind extensibility = dds::core::xtypes::ExtensibilityKind::EXTENSIBLE; dds::core::xtypes::ExtensibilityKind extensibility = dds::core::xtypes::ExtensibilityKind::EXTENSIBLE;
#else
int extensibility = 0; // Placeholder when RTI DDS is not available
#endif
virtual bool isValid() const { return !name.isEmpty(); } virtual bool isValid() const { return !name.isEmpty(); }
@@ -377,7 +390,7 @@ private:
void loadIdlInfofile(const QString &idlServiceInfoFile); void loadIdlInfofile(const QString &idlServiceInfoFile);
QString getIdlFileForService(const QMap<QString, QString> &data, const QString &serviceName) const; QString getIdlFileForService(const QMap<QString, QString> &data, const QString &serviceName) const;
QString serviceNameAbbreviation(const QString &serviceName) const; QString serviceNameAbbreviation(const QString &serviceName) const;
void getServiceNameInfoFromFilePath(const QVector<QStringRef> &parts); void getServiceNameInfoFromFilePath(const QStringList &parts);
static QString serviceNamespaceFromFile(const QString &fn); static QString serviceNamespaceFromFile(const QString &fn);
@@ -20,13 +20,13 @@ namespace {{ namespace }}
// //
QString toString({{ idl_enum.name }} state) QString toString({{ idl_enum.name }} state)
{ {
switch(state.underlying()) switch(static_cast<int>(state))
{{% for idl_member in idl_enum.member %} {{% for idl_member in idl_enum.member %}
case {{ idl_enum.name }}_def::{{ idl_member.key }}: return QCoreApplication::translate("{{ idl_enum.name }}", "{{ idl_member.key }}"); case static_cast<int>({{ idl_enum.name }}::{{ idl_member.key }}): return QCoreApplication::translate("{{ idl_enum.name }}", "{{ idl_member.key }}");
{% endfor %} {% endfor %}
default: break; default: break;
} }
return QCoreApplication::translate("{{ idl_enum.name }}", "Unknown (%1)").arg(state.underlying()); return QCoreApplication::translate("{{ idl_enum.name }}", "Unknown (%1)").arg(static_cast<int>(state));
} }
{% endfor %} {% endfor %}
@@ -22,7 +22,7 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsAppDescriptor
NGL_TARGET_LINK_LIBRARIES(LtsAppDescriptor NGL_TARGET_LINK_LIBRARIES(LtsAppDescriptor
PUBLIC PUBLIC
Qt5::Core Qt6::Core
) )
NGL_INSTALL_TARGET(LtsAppDescriptor) NGL_INSTALL_TARGET(LtsAppDescriptor)
@@ -40,7 +40,7 @@ NGL_TARGET_LINK_LIBRARIES(LtsAppDescriptorChecker
PRIVATE PRIVATE
LtsAppDescriptor LtsAppDescriptor
PUBLIC PUBLIC
Qt5::Core Qt6::Core
) )
@@ -66,8 +66,8 @@ NGL_TARGET_LINK_LIBRARIES(LtsAppDescriptorChecker
#NGL_TARGET_LINK_LIBRARIES(LtsAppDescriptorEditor #NGL_TARGET_LINK_LIBRARIES(LtsAppDescriptorEditor
# PUBLIC # PUBLIC
# Qt5::Core # Qt6::Core
# Qt5::Widgets # Qt6::Widgets
# LtsAppDescriptor # LtsAppDescriptor
#) #)
@@ -1,4 +1,5 @@
#include <LtsAppDescriptor/lts_app_descriptor.h> #include <LtsAppDescriptor/lts_app_descriptor.h>
#include <utility>
#include <QCoreApplication> #include <QCoreApplication>
#include <QFile> #include <QFile>
@@ -66,14 +67,14 @@ int main(int argc, char *argv[])
QStringList filenames; QStringList filenames;
filenames.reserve(guiPluginFiles.size()); filenames.reserve(guiPluginFiles.size());
for (const QFileInfo &fi : qAsConst(guiPluginFiles)) for (const QFileInfo &fi : std::as_const(guiPluginFiles))
{ {
filenames += fi.absoluteFilePath(); filenames += fi.absoluteFilePath();
} }
QStringList guiPluginIIDs; QStringList guiPluginIIDs;
for (const QFileInfo &fi : qAsConst(guiPluginFiles)) for (const QFileInfo &fi : std::as_const(guiPluginFiles))
{ {
QFile f2(fi.absoluteFilePath()); QFile f2(fi.absoluteFilePath());
@@ -105,9 +106,9 @@ int main(int argc, char *argv[])
bool ok = true; bool ok = true;
for (const LtsAppDescriptor::AppDescription &appdesc : qAsConst(adv)) for (const LtsAppDescriptor::AppDescription &appdesc : std::as_const(adv))
{ {
for (const LtsAppDescriptor::PluginInfo &pi : qAsConst(appdesc.pluginInfos)) for (const LtsAppDescriptor::PluginInfo &pi : std::as_const(appdesc.pluginInfos))
{ {
if (!guiPluginIIDs.contains(pi.iid)) if (!guiPluginIIDs.contains(pi.iid))
{ {
@@ -39,13 +39,13 @@ NGL_TARGET_LINK_LIBRARIES(LtsAppManager
LtsUtilsSettings LtsUtilsSettings
LtsMultiMonitor LtsMultiMonitor
ProjectConfig ProjectConfig
Qt5::Gui Qt6::Gui
Qt5::Widgets Qt6::Widgets
Qt5::Network # debug server Qt6::Network # debug server
OpmSettingsGuiPluginInterface OpmSettingsGuiPluginInterface
LtsPluginLoader LtsPluginLoader
PUBLIC PUBLIC
Qt5::Core Qt6::Core
LtsAppDescriptor LtsAppDescriptor
) )
@@ -1,4 +1,5 @@
#include "lts_app_manager.h" #include "lts_app_manager.h"
#include <utility>
#include "AppChooser/app_chooser.h" #include "AppChooser/app_chooser.h"
#include <LtsPluginManager/lts_plugin_manager.h> #include <LtsPluginManager/lts_plugin_manager.h>
@@ -880,7 +881,7 @@ bool LtsAppManager::hasApp(LtsAppDescriptor::App appId) const
int LtsAppManager::getNumberOfSituationMapInstances() const int LtsAppManager::getNumberOfSituationMapInstances() const
{ {
int numberOfSituationMapInstances = 0; int numberOfSituationMapInstances = 0;
for (const LtsPluginManager::LtsPluginManager *app : qAsConst(m_appList)) for (const LtsPluginManager::LtsPluginManager *app : std::as_const(m_appList))
{ {
if (!app) if (!app)
continue; continue;
@@ -931,7 +932,7 @@ void LtsAppManager::saveState()
QJsonArray root; QJsonArray root;
for (const LtsPluginManager::LtsPluginManager *app : qAsConst(m_appList)) for (const LtsPluginManager::LtsPluginManager *app : std::as_const(m_appList))
{ {
const QVector<LtsSession::LtsSession *> sessions = app->sessions(); const QVector<LtsSession::LtsSession *> sessions = app->sessions();
@@ -1000,7 +1001,7 @@ void LtsAppManager::saveState()
void LtsAppManager::slotLogout() void LtsAppManager::slotLogout()
{ {
for (LtsPluginManager::LtsPluginManager *app : qAsConst(m_appList)) for (LtsPluginManager::LtsPluginManager *app : std::as_const(m_appList))
{ {
const QVector<LtsSession::LtsSession *> sessions = app->sessions(); const QVector<LtsSession::LtsSession *> sessions = app->sessions();
for (LtsSession::LtsSession *session : sessions) for (LtsSession::LtsSession *session : sessions)
@@ -1118,7 +1119,7 @@ bool LtsAppManager::otherSessionsResponsibility(LtsSession::LtsSession *thisSess
for (const LtsPluginManager::LtsPluginManager *app : qAsConst(worthyApps)) for (const LtsPluginManager::LtsPluginManager *app : std::as_const(worthyApps))
{ {
const QVector<LtsSession::LtsSession *> sessions = app->sessions(); const QVector<LtsSession::LtsSession *> sessions = app->sessions();
for (const LtsSession::LtsSession *session : sessions) for (const LtsSession::LtsSession *session : sessions)
@@ -1133,7 +1134,7 @@ bool LtsAppManager::otherSessionsResponsibility(LtsSession::LtsSession *thisSess
LtsMultiMonitor::LtsMultiMonitor *mm = LtsMultiMonitor::LtsMultiMonitor::getInstance(); LtsMultiMonitor::LtsMultiMonitor *mm = LtsMultiMonitor::LtsMultiMonitor::getInstance();
LtsMultiMonitor::LtsScreenBase *mainScreen = mm->mainScreen(); LtsMultiMonitor::LtsScreenBase *mainScreen = mm->mainScreen();
for (const LtsPluginManager::LtsPluginManager *app : qAsConst(worthyApps)) for (const LtsPluginManager::LtsPluginManager *app : std::as_const(worthyApps))
{ {
const QVector<LtsSession::LtsSession *> sessions = app->sessions(); const QVector<LtsSession::LtsSession *> sessions = app->sessions();
for (LtsSession::LtsSession *session : sessions) for (LtsSession::LtsSession *session : sessions)
@@ -15,7 +15,7 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsCommandLineParser
NGL_TARGET_LINK_LIBRARIES(LtsCommandLineParser NGL_TARGET_LINK_LIBRARIES(LtsCommandLineParser
PRIVATE PRIVATE
ngltools ngltools
Qt5::Network Qt6::Network
PUBLIC PUBLIC
Qt5::Core Qt6::Core
) )
@@ -12,11 +12,11 @@ NGL_ADD_LIBRARY2(LtsCoordTrans WS AAR SV HLA SHARED
) )
NGL_TARGET_LINK_LIBRARIES(LtsCoordTrans NGL_TARGET_LINK_LIBRARIES(LtsCoordTrans
PRIVATE PRIVATE
Qt5::Core Qt6::Core
) )
if (GeographicLib_FOUND) if (GeographicLib_FOUND)
NGL_TARGET_LINK_LIBRARIES(LtsCoordTrans NGL_TARGET_LINK_LIBRARIES(LtsCoordTrans
PRIVATE GeographicLib PRIVATE GeographicLib::GeographicLib_SHARED
) )
else() else()
message(STATUS "GeographicLib not found; building LtsCoordTrans without it") message(STATUS "GeographicLib not found; building LtsCoordTrans without it")
@@ -41,8 +41,8 @@ NGL_TARGET_LINK_LIBRARIES(ltsCoordWidget
PRIVATE PRIVATE
LtsCoordTrans LtsCoordTrans
PUBLIC PUBLIC
Qt5::Core Qt6::Core
Qt5::Widgets Qt6::Widgets
) )
NGL_TARGET_INCLUDE_DIRECTORIES(ltsCoordWidget NGL_TARGET_INCLUDE_DIRECTORIES(ltsCoordWidget
PUBLIC PUBLIC
@@ -54,8 +54,8 @@ IF(TARGET LtsCoordTrans)
FOREACH(_tool ${_tools}) FOREACH(_tool ${_tools})
NGL_ADD_EXECUTABLE(ALL ${_tool} ${_tool}.cpp) NGL_ADD_EXECUTABLE(ALL ${_tool} ${_tool}.cpp)
NGL_TARGET_LINK_LIBRARIES(${_tool} NGL_TARGET_LINK_LIBRARIES(${_tool}
Qt5::Core Qt6::Core
GeographicLib GeographicLib::GeographicLib_SHARED
) )
NGL_INSTALL_TARGET(${_tool}) NGL_INSTALL_TARGET(${_tool})
ENDFOREACH() ENDFOREACH()
@@ -76,8 +76,8 @@ IF(BUILD_TESTING AND TARGET LtsCoordTrans)
) )
TARGET_LINK_LIBRARIES(lts_coord_trans_unit_test TARGET_LINK_LIBRARIES(lts_coord_trans_unit_test
LtsCoordTrans LtsCoordTrans
Qt5::Test Qt6::Test
GeographicLib GeographicLib::GeographicLib_SHARED
) )
ADD_TEST(NAME lts_coord_trans_unit_test COMMAND $<TARGET_FILE:lts_coord_trans_unit_test>) ADD_TEST(NAME lts_coord_trans_unit_test COMMAND $<TARGET_FILE:lts_coord_trans_unit_test>)
ENDIF() ENDIF()
@@ -2,6 +2,7 @@
#include "lts_coord_trans.h" #include "lts_coord_trans.h"
#include <utility>
#include <GeographicLib/Geocentric.hpp> #include <GeographicLib/Geocentric.hpp>
#include <GeographicLib/UTMUPS.hpp> #include <GeographicLib/UTMUPS.hpp>
@@ -320,7 +321,7 @@ QStringList getMgrsSurroundingSquares(const QRectF &geoRect, const QSize &offset
QVector<UtmCoordinate> mainUtmsWithOffset = getMgrsSquaresInternal(rectWithOffset); QVector<UtmCoordinate> mainUtmsWithOffset = getMgrsSquaresInternal(rectWithOffset);
QStringList mainSquaresWithOffset; QStringList mainSquaresWithOffset;
mainSquaresWithOffset.reserve(mainUtmsWithOffset.count()); mainSquaresWithOffset.reserve(mainUtmsWithOffset.count());
for (const auto &utm : qAsConst(mainUtmsWithOffset)) for (const auto &utm : std::as_const(mainUtmsWithOffset))
mainSquaresWithOffset.append(utm.mgrs(0)); mainSquaresWithOffset.append(utm.mgrs(0));
@@ -2,6 +2,7 @@
#include "lts_coord_trans_unit_test.h" #include "lts_coord_trans_unit_test.h"
#include <utility>
#include "lts_coord_trans.h" #include "lts_coord_trans.h"
#include <GeographicLib/Math.hpp> #include <GeographicLib/Math.hpp>
#include <QTest> #include <QTest>
@@ -408,23 +409,23 @@ void coordtrans_test::testMgrsSquaresWithSurrounding()
QStringList string1; QStringList string1;
string1.reserve(squares1.size()); string1.reserve(squares1.size());
for (const LtsCoordTrans::UtmCoordinate &item : qAsConst(squares1)) for (const LtsCoordTrans::UtmCoordinate &item : std::as_const(squares1))
string1.append(item.mgrs(0)); string1.append(item.mgrs(0));
QStringList string9; QStringList string9;
string9.reserve(squares9.size()); string9.reserve(squares9.size());
for (const LtsCoordTrans::UtmCoordinate &item : qAsConst(squares9)) for (const LtsCoordTrans::UtmCoordinate &item : std::as_const(squares9))
string9.append(item.mgrs(0)); string9.append(item.mgrs(0));
QStringList string33; QStringList string33;
string33.reserve(square33.size()); string33.reserve(square33.size());
for (const LtsCoordTrans::UtmCoordinate &item : qAsConst(square33)) for (const LtsCoordTrans::UtmCoordinate &item : std::as_const(square33))
string33.append(item.mgrs(0)); string33.append(item.mgrs(0));
{ {
QStringList surroundingStrings; QStringList surroundingStrings;
surroundingStrings.reserve(squares9.size()); surroundingStrings.reserve(squares9.size());
for (const QString &str : qAsConst(string9)) for (const QString &str : std::as_const(string9))
if (!string1.contains(str)) if (!string1.contains(str))
surroundingStrings.append(str); surroundingStrings.append(str);
@@ -434,7 +435,7 @@ void coordtrans_test::testMgrsSquaresWithSurrounding()
{ {
QStringList surroundingStrings; QStringList surroundingStrings;
surroundingStrings.reserve(string33.size()); surroundingStrings.reserve(string33.size());
for (const QString &str : qAsConst(string33)) for (const QString &str : std::as_const(string33))
if (!string1.contains(str)) if (!string1.contains(str))
surroundingStrings.append(str); surroundingStrings.append(str);
@@ -2,6 +2,7 @@
#include "lts_coord_widget_p.h" #include "lts_coord_widget_p.h"
#include <utility>
namespace LtsCoordWidget namespace LtsCoordWidget
@@ -188,7 +189,7 @@ void MgrsEdit::addMgrsSquare(const QString &newMgrsSquare)
{ {
QStringList squares = utmCoordsToList(LtsCoordTrans::defaultMgrsSquareWithOffsets()); QStringList squares = utmCoordsToList(LtsCoordTrans::defaultMgrsSquareWithOffsets());
for (const auto &sq : qAsConst(squares)) for (const auto &sq : std::as_const(squares))
if (!sl.contains(sq)) if (!sl.contains(sq))
sl.append(sq); sl.append(sq);
} }
@@ -20,7 +20,7 @@ NGL_TARGET_LINK_LIBRARIES(LtsCoordinate
PUBLIC PUBLIC
ddscore ddscore
LtsUtilsCoreHeaderOnly LtsUtilsCoreHeaderOnly
Qt5::Core Qt6::Core
) )
ADD_SUBDIRECTORY(UnitTest_Coordinate) ADD_SUBDIRECTORY(UnitTest_Coordinate)
@@ -21,9 +21,9 @@ TARGET_LINK_LIBRARIES(commonUnitTestCoordinate
LtsCoordTrans LtsCoordTrans
situationMapCommon situationMapCommon
situationMapElevationMap situationMapElevationMap
Qt5::Core Qt6::Core
Qt5::Gui Qt6::Gui
Qt5::Test) Qt6::Test)
ADD_TEST(NAME commonUnitTestCoordinate COMMAND $<TARGET_FILE:commonUnitTestCoordinate>) ADD_TEST(NAME commonUnitTestCoordinate COMMAND $<TARGET_FILE:commonUnitTestCoordinate>)
@@ -4,6 +4,7 @@
#pragma once #pragma once
#include <LtsCoordinate/ltscoordinate_export.h> #include <LtsCoordinate/ltscoordinate_export.h>
#include <utility>
#include <Core/core.hpp> #include <Core/core.hpp>
#include <LtsCoordTrans/lts_coord_trans.h> #include <LtsCoordTrans/lts_coord_trans.h>
@@ -56,7 +57,7 @@ protected:
utmVectorRef.clear(); utmVectorRef.clear();
utmVectorRef.reserve(m_geo_coordinates.size()); utmVectorRef.reserve(m_geo_coordinates.size());
for (const auto &geoCoord : qAsConst(m_geo_coordinates)) for (const auto &geoCoord : std::as_const(m_geo_coordinates))
utmVectorRef.push_back(LtsCoordTrans::UtmCoordinate::fromGeographic(geoCoord.lon(), geoCoord.lat(), zone)); utmVectorRef.push_back(LtsCoordTrans::UtmCoordinate::fromGeographic(geoCoord.lon(), geoCoord.lat(), zone));
} }
@@ -4,6 +4,7 @@
#pragma once #pragma once
#include <LtsCoordinate/ltscoordinate_export.h> #include <LtsCoordinate/ltscoordinate_export.h>
#include <utility>
#include <Core/core.hpp> #include <Core/core.hpp>
#include <LtsCoordTrans/lts_coord_trans.h> #include <LtsCoordTrans/lts_coord_trans.h>
@@ -352,7 +353,7 @@ T_OUT convert(const T_IN& contIn)
{ {
T_OUT out; T_OUT out;
out.reserve(contIn.size()); out.reserve(contIn.size());
for (const Core::GeoPosition &posGeo : qAsConst(contIn)) for (const Core::GeoPosition &posGeo : std::as_const(contIn))
out.push_back(LtsCoordinate(posGeo)); out.push_back(LtsCoordinate(posGeo));
return out; return out;
} }
@@ -24,7 +24,7 @@ NGL_TARGET_LINK_LIBRARIES(LtsElevation
situationMapElevationMap situationMapElevationMap
PUBLIC PUBLIC
LtsUtilsCoreHeaderOnly LtsUtilsCoreHeaderOnly
Qt5::Core Qt6::Core
) )
ADD_SUBDIRECTORY(UnitTest_Elevation) ADD_SUBDIRECTORY(UnitTest_Elevation)
@@ -20,9 +20,9 @@ TARGET_LINK_LIBRARIES(commenUnitTestElevation
LtsCoordTrans LtsCoordTrans
situationMapCommon situationMapCommon
situationMapElevationMap situationMapElevationMap
Qt5::Core Qt6::Core
Qt5::Gui Qt6::Gui
Qt5::Test) Qt6::Test)
ADD_TEST(NAME commenUnitTestElevation COMMAND $<TARGET_FILE:commenUnitTestElevation>) ADD_TEST(NAME commenUnitTestElevation COMMAND $<TARGET_FILE:commenUnitTestElevation>)
@@ -2,6 +2,7 @@
#include "lts_elevation_manager.h" #include "lts_elevation_manager.h"
#include <utility>
#include <Plugins/ExerciseManagement/exm_data_plugin_interface.h> #include <Plugins/ExerciseManagement/exm_data_plugin_interface.h>
#include <Plugins/AssetManagement/asm_data_plugin_interface.h> #include <Plugins/AssetManagement/asm_data_plugin_interface.h>
@@ -348,7 +349,7 @@ QStringList LtsElevationManager::getFilenamesForTrainingArea(int trainingAreaId)
const std::vector<AssetManagement::MapDescription> &mdVec = ta.elevation(); const std::vector<AssetManagement::MapDescription> &mdVec = ta.elevation();
filePaths_rough_to_fine.reserve(mdVec.size()); filePaths_rough_to_fine.reserve(mdVec.size());
for (const AssetManagement::MapDescription &md : qAsConst(mdVec)) for (const AssetManagement::MapDescription &md : std::as_const(mdVec))
{ {
QUrl url(QString::fromStdString(md.url())); QUrl url(QString::fromStdString(md.url()));
@@ -23,10 +23,10 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsLicence
NGL_TARGET_LINK_LIBRARIES(LtsLicence NGL_TARGET_LINK_LIBRARIES(LtsLicence
PRIVATE PRIVATE
${OPENSSL_LIBRARIES} ${OPENSSL_LIBRARIES}
Qt5::Xml Qt6::Xml
NGLLogger NGLLogger
PUBLIC PUBLIC
Qt5::Core Qt6::Core
) )
IF (BUILD_TESTING AND TARGET LtsLicence) IF (BUILD_TESTING AND TARGET LtsLicence)
@@ -34,8 +34,8 @@ IF (BUILD_TESTING AND TARGET LtsLicence)
TARGET_LINK_LIBRARIES(aes_crypt_test TARGET_LINK_LIBRARIES(aes_crypt_test
LtsLicence LtsLicence
NGLLogger NGLLogger
Qt5::Core Qt6::Core
Qt5::Test Qt6::Test
) )
ADD_TEST(NAME aes_crypt_test COMMAND $<TARGET_FILE:aes_crypt_test>) ADD_TEST(NAME aes_crypt_test COMMAND $<TARGET_FILE:aes_crypt_test>)
ENDIF() ENDIF()
@@ -38,5 +38,5 @@ NGL_TARGET_LINK_LIBRARIES(LtsLogin
OpmDataPluginInterface OpmDataPluginInterface
SrmDataPluginInterface SrmDataPluginInterface
AsmDataPluginInterface AsmDataPluginInterface
Qt5::Core Qt6::Core
) )
@@ -36,10 +36,10 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsMultiMonitor
NGL_TARGET_LINK_LIBRARIES(LtsMultiMonitor NGL_TARGET_LINK_LIBRARIES(LtsMultiMonitor
PUBLIC PUBLIC
Qt5::Core Qt6::Core
Qt5::Widgets Qt6::Widgets
PRIVATE PRIVATE
Qt5::Gui Qt6::Gui
LtsWidgets LtsWidgets
LtsSessionData LtsSessionData
LtsUtilsCore LtsUtilsCore
@@ -2,6 +2,7 @@
#include "lts_multi_monitor.h" #include "lts_multi_monitor.h"
#include <utility>
#include "lts_multi_monitor_selector_normal.h" #include "lts_multi_monitor_selector_normal.h"
#include "lts_multi_monitor_selector_wide.h" #include "lts_multi_monitor_selector_wide.h"
#include "lts_screen_normal.h" #include "lts_screen_normal.h"
@@ -111,7 +112,7 @@ void LtsMultiMonitor::init()
bool found = false; bool found = false;
for (LtsScreenBase *ltsScreen : qAsConst(m_screens)) for (LtsScreenBase *ltsScreen : std::as_const(m_screens))
{ {
if (ltsScreen->serialNumber() == screen.name()) if (ltsScreen->serialNumber() == screen.name())
{ {
@@ -247,7 +248,7 @@ bool LtsMultiMonitor::putScreen(QWidget *widget, int screenId, int screenPart)
bool isSecondary = isWidgetSecondary(widget); bool isSecondary = isWidgetSecondary(widget);
qWarning() << "putScreen: isSecondary" << isSecondary; qWarning() << "putScreen: isSecondary" << isSecondary;
for (LtsScreenBase *screen : qAsConst(m_screens)) for (LtsScreenBase *screen : std::as_const(m_screens))
{ {
if (screen->screenId() != screenId) if (screen->screenId() != screenId)
continue; continue;
@@ -289,7 +290,7 @@ bool LtsMultiMonitor::putScreenAutomatically(QWidget *widget)
if (overlapBaseLayouts(widget)) if (overlapBaseLayouts(widget))
return true; return true;
for (LtsScreenBase *screen : qAsConst(m_screens)) for (LtsScreenBase *screen : std::as_const(m_screens))
{ {
if (screen->screenId() == m_skipScreenId || !screen->isEmpty()) if (screen->screenId() == m_skipScreenId || !screen->isEmpty())
continue; continue;
@@ -333,7 +334,7 @@ bool LtsMultiMonitor::isOverlapBaseLayouts() const
void LtsMultiMonitor::freezeMagicCorner(int screenId) void LtsMultiMonitor::freezeMagicCorner(int screenId)
{ {
for (auto *screen : qAsConst(m_screens)) for (auto *screen : std::as_const(m_screens))
{ {
if (screen->screenId() == screenId) if (screen->screenId() == screenId)
@@ -352,7 +353,7 @@ void LtsMultiMonitor::freezeMagicCorner(int screenId)
void LtsMultiMonitor::unfreezeMagicCorner(int screenId) void LtsMultiMonitor::unfreezeMagicCorner(int screenId)
{ {
for (auto *screen : qAsConst(m_screens)) for (auto *screen : std::as_const(m_screens))
{ {
if (screen->screenId() == screenId) if (screen->screenId() == screenId)
@@ -420,7 +421,7 @@ bool LtsMultiMonitor::selectAndSwap(QWidget *widget)
LtsScreenContainer *oldContainer = nullptr; LtsScreenContainer *oldContainer = nullptr;
for (LtsScreenBase *_screen : qAsConst(m_screens)) for (LtsScreenBase *_screen : std::as_const(m_screens))
{ {
try try
{ {
@@ -445,7 +446,7 @@ bool LtsMultiMonitor::selectAndSwap(QWidget *widget)
LtsScreenBase *LtsMultiMonitor::widgetsScreen(QWidget *widget) LtsScreenBase *LtsMultiMonitor::widgetsScreen(QWidget *widget)
{ {
for (LtsScreenBase *screen : qAsConst(m_screens)) for (LtsScreenBase *screen : std::as_const(m_screens))
if (screen->hasWidget(widget)) if (screen->hasWidget(widget))
return screen; return screen;
return nullptr; return nullptr;
@@ -519,7 +520,7 @@ bool LtsMultiMonitor::selectScreen(QWidget *widget, LtsScreenContainer *swap, bo
if (!isSecondary) if (!isSecondary)
{ {
bool allEmpty = putOnMainIfFree; bool allEmpty = putOnMainIfFree;
for (LtsScreenBase *screen : qAsConst(m_screens)) for (LtsScreenBase *screen : std::as_const(m_screens))
{ {
screen->switchToTemp(LtsScreenBase::WidgetType::MainWidget); screen->switchToTemp(LtsScreenBase::WidgetType::MainWidget);
bool isEmpty = screen->isEmpty(); bool isEmpty = screen->isEmpty();
@@ -590,7 +591,7 @@ bool LtsMultiMonitor::selectScreen(QWidget *widget, LtsScreenContainer *swap, bo
} }
bool skip = false; bool skip = false;
for (QWidget *widget : qAsConst(irreplacableWidgets)) for (QWidget *widget : std::as_const(irreplacableWidgets))
{ {
if (screen->hasWidget(widget)) if (screen->hasWidget(widget))
@@ -649,7 +650,7 @@ bool LtsMultiMonitor::selectScreen(QWidget *widget, LtsScreenContainer *swap, bo
{ {
for (LtsScreenBase *screen : qAsConst(m_screens)) for (LtsScreenBase *screen : std::as_const(m_screens))
screen->check(); screen->check();
@@ -23,7 +23,7 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsNotification
) )
NGL_TARGET_LINK_LIBRARIES(LtsNotification NGL_TARGET_LINK_LIBRARIES(LtsNotification
Qt5::Widgets Qt6::Widgets
) )
NGL_INSTALL_TARGET(LtsNotification) NGL_INSTALL_TARGET(LtsNotification)
@@ -1,6 +1,7 @@
#include "lts_notification_ctl.h" #include "lts_notification_ctl.h"
#include <utility>
#include <QToolButton> #include <QToolButton>
#include <QImage> #include <QImage>
@@ -46,7 +47,7 @@ void LtsNotificationController::setCount(const int count)
void LtsNotificationController::setBackground(const int r, const int g, const int b) void LtsNotificationController::setBackground(const int r, const int g, const int b)
{ {
for (QToolButton *tb : qAsConst(m_notiList)) for (QToolButton *tb : std::as_const(m_notiList))
{ {
QString stylesheet; QString stylesheet;
@@ -81,7 +82,7 @@ void LtsNotificationController::setToolTip(const QString &toolTip)
{ {
m_toolTip = toolTip; m_toolTip = toolTip;
for (QToolButton *tb : qAsConst(m_notiList)) for (QToolButton *tb : std::as_const(m_notiList))
{ {
tb->setToolTip(toolTip); tb->setToolTip(toolTip);
tb->setIconSize(QSize(30,30)); tb->setIconSize(QSize(30,30));
@@ -97,7 +98,7 @@ void LtsNotificationController::setAllIcons()
QIcon icon = modifyIcon(m_icon); QIcon icon = modifyIcon(m_icon);
for (QToolButton *tb : qAsConst(m_notiList)) for (QToolButton *tb : std::as_const(m_notiList))
{ {
tb->setIcon(icon); tb->setIcon(icon);
tb->setIconSize(QSize(30,30)); tb->setIconSize(QSize(30,30));
@@ -120,7 +121,7 @@ QIcon LtsNotificationController::modifyIcon(const QIcon &icon)
QPainter painter(&iconImage); QPainter painter(&iconImage);
painter.save(); painter.save();
painter.setRenderHints(QPainter::TextAntialiasing | QPainter::Antialiasing | QPainter::HighQualityAntialiasing | QPainter::SmoothPixmapTransform); painter.setRenderHints(QPainter::TextAntialiasing | QPainter::Antialiasing | QPainter::SmoothPixmapTransform);
QFont f; QFont f;
f.setFamily(QStringLiteral("Monospace")); f.setFamily(QStringLiteral("Monospace"));
@@ -17,7 +17,7 @@ NGL_TARGET_LINK_LIBRARIES(LtsPluginLoader
PRIVATE PRIVATE
NGLLogger NGLLogger
PUBLIC PUBLIC
Qt5::Core Qt6::Core
) )
# LtsPluginManager # LtsPluginManager
@@ -53,11 +53,11 @@ NGL_TARGET_LINK_LIBRARIES(LtsPluginManager
LtsWidgets LtsWidgets
LtsSession LtsSession
LtsSessionData LtsSessionData
Qt5::Widgets Qt6::Widgets
PUBLIC PUBLIC
ProjectConfig ProjectConfig
LtsAppDescriptor LtsAppDescriptor
Qt5::Core Qt6::Core
) )
NGL_INSTALL_TARGET(LtsPluginManager) NGL_INSTALL_TARGET(LtsPluginManager)
@@ -2,6 +2,7 @@
#include "lts_plugin_loader.h" #include "lts_plugin_loader.h"
#include <utility>
#include <NGLLogger/NGLLoggerBootstrap.h> #include <NGLLogger/NGLLoggerBootstrap.h>
#include <LtsAppDescriptor/lts_app_descriptor.h> #include <LtsAppDescriptor/lts_app_descriptor.h>
@@ -49,7 +50,7 @@ LtsPluginLoader::~LtsPluginLoader()
void LtsPluginLoader::unloadAllPlugins() void LtsPluginLoader::unloadAllPlugins()
{ {
for (auto &pi : qAsConst(m_loadedPlugins)) for (auto &pi : std::as_const(m_loadedPlugins))
{ {
QPluginLoader *pluginLoader = pi.pluginLoader; QPluginLoader *pluginLoader = pi.pluginLoader;
@@ -281,7 +282,7 @@ bool LtsPluginLoader::loadPlugins(PluginType requestedPluginType,
} }
const QString jsonIid = iid.value().toString().toLower(); const QString jsonIid = iid.value().toString().toLower();
const QVector<QStringRef> iidParameters = jsonIid.splitRef(QLatin1Char(':')); const QStringList iidParameters = QString(jsonIid).split(QLatin1Char(':'));
DEBUG_LOG(logger) << "Plugin " << absoluteFilePath << " provides iid '" << jsonIid; DEBUG_LOG(logger) << "Plugin " << absoluteFilePath << " provides iid '" << jsonIid;
@@ -302,8 +303,8 @@ bool LtsPluginLoader::loadPlugins(PluginType requestedPluginType,
PluginType pluginType = PluginType::UNKNOWN; PluginType pluginType = PluginType::UNKNOWN;
const QString pluginName = iidParameters.at(2).toString(); const QString pluginName = iidParameters.at(2);
const QString pluginTypeString = iidParameters.at(0).toString(); const QString pluginTypeString = iidParameters.at(0);
switch (pluginTypes.indexOf(pluginTypeString)) switch (pluginTypes.indexOf(pluginTypeString))
{ {
case 0: case 0:
@@ -2,6 +2,7 @@
#include "lts_plugin_manager.h" #include "lts_plugin_manager.h"
#include <utility>
#include "Ui/lts_plugin_manager_dialog.h" #include "Ui/lts_plugin_manager_dialog.h"
#include <LtsSession/lts_session_data_dds.h> #include <LtsSession/lts_session_data_dds.h>
@@ -78,7 +79,7 @@ bool LtsPluginManager::hasSituationMapInstance(const LtsAppDescriptor::AppDescri
if (alsoTestForScriptApp && appDescription.id == LtsAppDescriptor::App::Scripts) if (alsoTestForScriptApp && appDescription.id == LtsAppDescriptor::App::Scripts)
return true; return true;
for (const LtsAppDescriptor::PluginInfo &pluginInfo : qAsConst(appDescription.pluginInfos)) for (const LtsAppDescriptor::PluginInfo &pluginInfo : std::as_const(appDescription.pluginInfos))
{ {
if (pluginInfo.flags.testFlag(LtsAppDescriptor::PluginInfo::Flag::ACTIONS) && if (pluginInfo.flags.testFlag(LtsAppDescriptor::PluginInfo::Flag::ACTIONS) &&
(pluginInfo.iid == QStringLiteral("sitmap"))) (pluginInfo.iid == QStringLiteral("sitmap")))
@@ -29,8 +29,8 @@ if (KDReports_FOUND)
nglsettings nglsettings
ngltools ngltools
PUBLIC PUBLIC
Qt5::PrintSupport Qt6::PrintSupport
Qt5::Core Qt6::Core
) )
NGL_INSTALL_TARGET(LtsPrinting) NGL_INSTALL_TARGET(LtsPrinting)
else() else()
@@ -7,6 +7,7 @@
#include "printing_base.h" #include "printing_base.h"
#include <utility>
#include <ngltools/ngltools_filesystem.h> #include <ngltools/ngltools_filesystem.h>
#include <QDateTime> #include <QDateTime>
@@ -251,7 +252,7 @@ bool Base::printListData(QString &str,
QLatin1String("<tr>"); QLatin1String("<tr>");
int columIdx = 0; int columIdx = 0;
for (const QModelIndex &mi :qAsConst(mil)) for (const QModelIndex &mi :std::as_const(mil))
{ {
if (columIdx >= nColums) if (columIdx >= nColums)
@@ -281,7 +282,7 @@ bool Base::printListData(QString &str,
else else
{ {
for (const QModelIndex &mi :qAsConst(mil)) for (const QModelIndex &mi :std::as_const(mil))
{ {
if (printItemData(str, vm, mi, iconExtent)) if (printItemData(str, vm, mi, iconExtent))
str += QLatin1String("<br />"); str += QLatin1String("<br />");
@@ -363,7 +364,7 @@ bool Base::printTableData(QString &str,
str += QLatin1String("<table border=\"1\" cellspacing=\"0\" cellpadding=\"3\" style=\"border-collapse:collapse\">") + str += QLatin1String("<table border=\"1\" cellspacing=\"0\" cellpadding=\"3\" style=\"border-collapse:collapse\">") +
QLatin1String("<thead>") + QLatin1String("<thead>") +
QLatin1String("<tr>"); QLatin1String("<tr>");
for (const QString &s : qAsConst(tableHeader)) for (const QString &s : std::as_const(tableHeader))
str += QLatin1String("<th scope=\"col\">") + s + QLatin1String("</th>"); str += QLatin1String("<th scope=\"col\">") + s + QLatin1String("</th>");
str += QLatin1String("</tr></thead><tbody>"); str += QLatin1String("</tr></thead><tbody>");
@@ -371,7 +372,7 @@ bool Base::printTableData(QString &str,
QVector<QPair<int, int> > spannedL; QVector<QPair<int, int> > spannedL;
for (const QModelIndex &mi :qAsConst(mil)) for (const QModelIndex &mi :std::as_const(mil))
{ {
str += QLatin1String("<tr>"); str += QLatin1String("<tr>");
for (int ii = 0; ii < colCount; ii++) for (int ii = 0; ii < colCount; ii++)
@@ -508,10 +509,10 @@ bool Base::printTreeData(QString &str,
} }
} }
for (const QString &s : qAsConst(tableHeader)) for (const QString &s : std::as_const(tableHeader))
str += QLatin1String("<th align=\"left\"><h4>") + s + QLatin1String("</h4></th>"); str += QLatin1String("<th align=\"left\"><h4>") + s + QLatin1String("</h4></th>");
str += QLatin1String("</tr>"); str += QLatin1String("</tr>");
for (const QModelIndex &miColumn0 : qAsConst(milColumn0)) for (const QModelIndex &miColumn0 : std::as_const(milColumn0))
printListPoint(str, view, vm, miColumn0, suppressCols, iconExtent); printListPoint(str, view, vm, miColumn0, suppressCols, iconExtent);
str += QLatin1String("</tbody></table><br /><br />"); str += QLatin1String("</tbody></table><br /><br />");
@@ -34,9 +34,9 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsProjectionWorkstation
NGL_TARGET_LINK_LIBRARIES(LtsProjectionWorkstation NGL_TARGET_LINK_LIBRARIES(LtsProjectionWorkstation
PUBLIC PUBLIC
Qt5::Core Qt6::Core
PRIVATE PRIVATE
Qt5::Gui Qt6::Gui
NGLLogger NGLLogger
nglsettings nglsettings
LtsWebSocketServer LtsWebSocketServer
@@ -2,6 +2,7 @@
#include "lts_projection_workstation.h" #include "lts_projection_workstation.h"
#include <utility>
#include "WebSocket/message_factory.h" #include "WebSocket/message_factory.h"
#include "WebSocket/json_keys.h" #include "WebSocket/json_keys.h"
@@ -212,7 +213,7 @@ void LtsProjectionWorkstation::slotLogoffDone()
{ {
if (hasPendingLoginRequest()) if (hasPendingLoginRequest())
return; return;
for (LtsWebSocket::ClientConnection *con : qAsConst(m_connections)) for (LtsWebSocket::ClientConnection *con : std::as_const(m_connections))
con->webSocket()->close(); con->webSocket()->close();
} }
@@ -2,6 +2,7 @@
#include "vnc_server_manager.h" #include "vnc_server_manager.h"
#include <utility>
#include <QRegularExpression> #include <QRegularExpression>
#include <QScreen> #include <QScreen>
@@ -83,7 +84,7 @@ bool VncServerManager::init(const QList<QScreen *> &screens)
void VncServerManager::startScreens() void VncServerManager::startScreens()
{ {
DEBUG_LOG(m_logger) << "Starting " << m_vncScreens.size() << " VNCScreen(s) ... "; DEBUG_LOG(m_logger) << "Starting " << m_vncScreens.size() << " VNCScreen(s) ... ";
for (const VncScreen &s : qAsConst(m_vncScreens)) for (const VncScreen &s : std::as_const(m_vncScreens))
{ {
connect(s.proc, &QProcess::readyReadStandardOutput, connect(s.proc, &QProcess::readyReadStandardOutput,
this, &VncServerManager::slotReadStandardOutput, Qt::UniqueConnection); this, &VncServerManager::slotReadStandardOutput, Qt::UniqueConnection);
@@ -91,7 +92,7 @@ void VncServerManager::startScreens()
this, &VncServerManager::slotErrorOccured, Qt::UniqueConnection); this, &VncServerManager::slotErrorOccured, Qt::UniqueConnection);
s.proc->start(); s.proc->start();
} }
for (const VncScreen &s : qAsConst(m_vncScreens)) for (const VncScreen &s : std::as_const(m_vncScreens))
{ {
if (!s.proc->waitForStarted(2000)) if (!s.proc->waitForStarted(2000))
ERROR_LOG(m_logger) << "Can not start process '" << s.proc->program() << "': " ERROR_LOG(m_logger) << "Can not start process '" << s.proc->program() << "': "
@@ -105,12 +106,12 @@ void VncServerManager::stopScreens()
{ {
DEBUG_LOG(m_logger) << "Stopping " << m_vncScreens.size() << " VNCScreen(s) ..."; DEBUG_LOG(m_logger) << "Stopping " << m_vncScreens.size() << " VNCScreen(s) ...";
for (const VncScreen &s : qAsConst(m_vncScreens)) for (const VncScreen &s : std::as_const(m_vncScreens))
{ {
s.proc->disconnect(this); s.proc->disconnect(this);
s.proc->terminate(); s.proc->terminate();
} }
for (const VncScreen &s : qAsConst(m_vncScreens)) for (const VncScreen &s : std::as_const(m_vncScreens))
{ {
if (!s.proc->waitForFinished(2000)) if (!s.proc->waitForFinished(2000))
s.proc->kill(); s.proc->kill();
@@ -63,8 +63,8 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsScriptTimeline
) )
NGL_TARGET_LINK_LIBRARIES(LtsScriptTimeline NGL_TARGET_LINK_LIBRARIES(LtsScriptTimeline
Qt5::Core Qt6::Core
Qt5::Widgets Qt6::Widgets
LtsWidgets LtsWidgets
LtsSessionData LtsSessionData
) )
@@ -1,4 +1,5 @@
#include "script_timeline.h" #include "script_timeline.h"
#include <utility>
#include "ui_script_timeline.h" #include "ui_script_timeline.h"
#include "track_widget.h" #include "track_widget.h"
#include "tools.h" #include "tools.h"
@@ -437,7 +438,7 @@ TrackEntry *ScriptTimeline::getTrackEntryWithFiltersAsEntries(int topicId)
for (const TrackWidget *tw : trackWidgetList) for (const TrackWidget *tw : trackWidgetList)
{ {
const QVector<TrackEntry *> trackEntries = tw->getTrackEntriesFiltersAsEntries(); const QVector<TrackEntry *> trackEntries = tw->getTrackEntriesFiltersAsEntries();
for (TrackEntry *te : qAsConst(trackEntries)) for (TrackEntry *te : std::as_const(trackEntries))
{ {
if (te->m_topicId == topicId) if (te->m_topicId == topicId)
return te; return te;
@@ -507,7 +508,7 @@ bool ScriptTimeline::importTrackEntries(const QVector<LtsScriptTimeline::TrackEn
{ {
int importLength = 0; int importLength = 0;
for (TrackEntry *te : qAsConst(importTes)) for (TrackEntry *te : std::as_const(importTes))
{ {
int teLen = te->m_startTime + te->m_length; int teLen = te->m_startTime + te->m_length;
if (teLen > importLength) if (teLen > importLength)
@@ -519,7 +520,7 @@ bool ScriptTimeline::importTrackEntries(const QVector<LtsScriptTimeline::TrackEn
const QVector<TrackEntry *> tes = getTrackEntries(); const QVector<TrackEntry *> tes = getTrackEntries();
int pasteTime = m_time; int pasteTime = m_time;
for (TrackEntry *te : qAsConst(tes)) for (TrackEntry *te : std::as_const(tes))
{ {
int start = te->m_startTime; int start = te->m_startTime;
int sum = start + te->m_length; int sum = start + te->m_length;
@@ -536,7 +537,7 @@ bool ScriptTimeline::importTrackEntries(const QVector<LtsScriptTimeline::TrackEn
for (TrackEntry *te : qAsConst(tes)) for (TrackEntry *te : std::as_const(tes))
{ {
if (te->m_startTime >= m_time) if (te->m_startTime >= m_time)
te->m_startTime += importLength + diff; te->m_startTime += importLength + diff;
@@ -608,7 +609,7 @@ QVector<TrackEntry *> ScriptTimeline::getSelectedEntriesWithFilterEntries() cons
const QList<TrackWidget *> tws = getTrackWidgets(); const QList<TrackWidget *> tws = getTrackWidgets();
for (const TrackWidget *tw : qAsConst(tws)) for (const TrackWidget *tw : std::as_const(tws))
tes += tw->getTrackEntriesFiltersAsEntries(true); tes += tw->getTrackEntriesFiltersAsEntries(true);
return tes; return tes;
@@ -655,7 +656,7 @@ QVector<TrackEntry *> ScriptTimeline::getSelectedFilterEntries() const
QVector<TrackEntry *> result; QVector<TrackEntry *> result;
const QList<TrackWidget *> tws = getTrackWidgets(); const QList<TrackWidget *> tws = getTrackWidgets();
for (const TrackWidget *tw : qAsConst(tws)) for (const TrackWidget *tw : std::as_const(tws))
{ {
result += tw->getSelectedFilterEntries(); result += tw->getSelectedFilterEntries();
} }
@@ -669,7 +670,7 @@ void ScriptTimeline::slotDeleteSelectedTopics()
int topicCount = 0; int topicCount = 0;
const QList<TrackWidget *> tws = getTrackWidgets(); const QList<TrackWidget *> tws = getTrackWidgets();
for (const TrackWidget *tw : qAsConst(tws)) for (const TrackWidget *tw : std::as_const(tws))
{ {
topicCount += tw->getSelectedFilterEntries().count(); topicCount += tw->getSelectedFilterEntries().count();
@@ -689,12 +690,12 @@ void ScriptTimeline::slotDeleteSelectedTopics()
this, [this]() this, [this]()
{ {
const QList<TrackWidget *> tws = getTrackWidgets(); const QList<TrackWidget *> tws = getTrackWidgets();
for (const TrackWidget *tw : qAsConst(tws)) for (const TrackWidget *tw : std::as_const(tws))
{ {
const QVector<FilterTrackWidget *> &ftws = tw->filterLines(); const QVector<FilterTrackWidget *> &ftws = tw->filterLines();
for (const FilterTrackWidget *ftw : qAsConst(ftws)) for (const FilterTrackWidget *ftw : std::as_const(ftws))
{ {
const FilterBackgroundWidget *fbw = ftw->fbw(); const FilterBackgroundWidget *fbw = ftw->fbw();
const QMap<int , TrackContentWidget *> &fcws = fbw->filterContentWidgets(); const QMap<int , TrackContentWidget *> &fcws = fbw->filterContentWidgets();
@@ -715,7 +716,7 @@ void ScriptTimeline::slotCutTopics()
slotCopyTopics(); slotCopyTopics();
const QList<TrackWidget *> tws = getTrackWidgets(); const QList<TrackWidget *> tws = getTrackWidgets();
for (const TrackWidget *tw : qAsConst(tws)) for (const TrackWidget *tw : std::as_const(tws))
{ {
TrackContentWidget *tcw = tw->getTrackContentWidget(); TrackContentWidget *tcw = tw->getTrackContentWidget();
tcw->deleteSelectedTopics(); tcw->deleteSelectedTopics();
@@ -730,7 +731,7 @@ void ScriptTimeline::slotCopyTopics()
for (const TrackWidget *tw : qAsConst(tws)) for (const TrackWidget *tw : std::as_const(tws))
{ {
TrackContentWidget *tcw = tw->getTrackContentWidget(); TrackContentWidget *tcw = tw->getTrackContentWidget();
@@ -739,7 +740,7 @@ void ScriptTimeline::slotCopyTopics()
if (tcw->getSelectedEntries().isEmpty()) if (tcw->getSelectedEntries().isEmpty())
continue; continue;
for (const TrackEntry *te : qAsConst(selected)) for (const TrackEntry *te : std::as_const(selected))
{ {
if (firstTeTime > te->m_startTime || firstTeTime == -1) if (firstTeTime > te->m_startTime || firstTeTime == -1)
firstTeTime = te->m_startTime; firstTeTime = te->m_startTime;
@@ -824,7 +825,7 @@ void ScriptTimeline::slotMoveAll(int direction)
QList<TrackWidget *> tws = getTrackWidgets(); QList<TrackWidget *> tws = getTrackWidgets();
for (TrackWidget *tw : qAsConst(tws)) for (TrackWidget *tw : std::as_const(tws))
{ {
TrackContentWidget *tcw = tw->getTrackContentWidget(); TrackContentWidget *tcw = tw->getTrackContentWidget();
if (!tcw->canMoveAll(direction * factor)) if (!tcw->canMoveAll(direction * factor))
@@ -836,7 +837,7 @@ void ScriptTimeline::slotMoveAll(int direction)
} }
for (TrackWidget *tw : qAsConst(tws)) for (TrackWidget *tw : std::as_const(tws))
{ {
TrackContentWidget *tcw = tw->getTrackContentWidget(); TrackContentWidget *tcw = tw->getTrackContentWidget();
tcw->forceMoveAll(direction * factor); tcw->forceMoveAll(direction * factor);
@@ -1153,7 +1154,7 @@ void ScriptTimeline::slotTrackEntrySelectionChanged(TrackEntry *)
} }
for (TrackWidget *tw : qAsConst(tws)) for (TrackWidget *tw : std::as_const(tws))
tw->getTrackContentWidget()->setMultiLineMultiSelectionMode(activateMultiLineMultiSelectionMode); tw->getTrackContentWidget()->setMultiLineMultiSelectionMode(activateMultiLineMultiSelectionMode);
emit signalTrackEntrySelectionChanged(nullptr); emit signalTrackEntrySelectionChanged(nullptr);
@@ -1,4 +1,5 @@
#include "track_content_widget.h" #include "track_content_widget.h"
#include <utility>
#include "track_entry.h" #include "track_entry.h"
#include "tools.h" #include "tools.h"
#include "track_entry_painters.h" #include "track_entry_painters.h"
@@ -170,7 +171,7 @@ bool TrackContentWidget::checkForCollisions(const TrackContentWidget *tcw, const
{ {
const QVector<TrackEntry *> &selectedEntries = tcw->getSelectedEntries(); const QVector<TrackEntry *> &selectedEntries = tcw->getSelectedEntries();
for (TrackEntry *te : qAsConst(trackEntries)) for (TrackEntry *te : std::as_const(trackEntries))
{ {
if (!selectedEntries.contains(te)) if (!selectedEntries.contains(te))
vecEntriesToCheck.append(te); vecEntriesToCheck.append(te);
@@ -192,7 +193,7 @@ bool TrackContentWidget::checkForCollisions(const TrackContentWidget *tcw, const
int startOffset_s = dropTime_s - startTimeMostLeft_s; int startOffset_s = dropTime_s - startTimeMostLeft_s;
for (TrackEntry *previewEntry : qAsConst(_preview)) for (TrackEntry *previewEntry : std::as_const(_preview))
{ {
int startPreview_s = previewEntry->m_startTime + startOffset_s; int startPreview_s = previewEntry->m_startTime + startOffset_s;
@@ -204,7 +205,7 @@ bool TrackContentWidget::checkForCollisions(const TrackContentWidget *tcw, const
int endPreview_s = startPreview_s + previewEntry->m_length; int endPreview_s = startPreview_s + previewEntry->m_length;
for (const TrackEntry *checkTe : qAsConst(vecEntriesToCheck)) for (const TrackEntry *checkTe : std::as_const(vecEntriesToCheck))
{ {
if (checkTe->m_topicId == previewEntry->m_topicId && !ignoreSelfCheck) if (checkTe->m_topicId == previewEntry->m_topicId && !ignoreSelfCheck)
{ {
@@ -300,7 +301,7 @@ bool TrackContentWidget::checkForParallelTopics(const TrackContentWidget *tcw, c
for (TrackEntry *previewEntry : qAsConst(previewCopy)) for (TrackEntry *previewEntry : std::as_const(previewCopy))
{ {
@@ -311,7 +312,7 @@ bool TrackContentWidget::checkForParallelTopics(const TrackContentWidget *tcw, c
for (TrackEntry *pTrackEntry : qAsConst(vecTrackEntries)) for (TrackEntry *pTrackEntry : std::as_const(vecTrackEntries))
{ {
@@ -443,7 +444,7 @@ bool TrackContentWidget::checkForParallelTopics(const TrackContentWidget *tcw, c
QVector<TrackEntryType> correspondingDifferentTopicTypes; QVector<TrackEntryType> correspondingDifferentTopicTypes;
for (TrackEntry *previewEntry : qAsConst(previewCopy)) for (TrackEntry *previewEntry : std::as_const(previewCopy))
{ {
correspondingDifferentTopicTypes.clear(); correspondingDifferentTopicTypes.clear();
@@ -454,7 +455,7 @@ bool TrackContentWidget::checkForParallelTopics(const TrackContentWidget *tcw, c
startOffset_s -= startTimeMostLeft_s; startOffset_s -= startTimeMostLeft_s;
for (const QPair<TrackEntryType, TrackEntryType> &pair : qAsConst(differentParallelForbidden)) for (const QPair<TrackEntryType, TrackEntryType> &pair : std::as_const(differentParallelForbidden))
{ {
if (pair.first == previewEntry->m_type) if (pair.first == previewEntry->m_type)
correspondingDifferentTopicTypes += pair.second; correspondingDifferentTopicTypes += pair.second;
@@ -468,11 +469,11 @@ bool TrackContentWidget::checkForParallelTopics(const TrackContentWidget *tcw, c
if (correspondingDifferentTopicTypes.isEmpty()) if (correspondingDifferentTopicTypes.isEmpty())
continue; continue;
for (const TrackEntryType correspondingDifferentTopicType : qAsConst(correspondingDifferentTopicTypes)) for (const TrackEntryType correspondingDifferentTopicType : std::as_const(correspondingDifferentTopicTypes))
{ {
for (TrackEntry *pTrackEntry : qAsConst(vecTrackEntries)) for (TrackEntry *pTrackEntry : std::as_const(vecTrackEntries))
{ {
@@ -769,7 +770,7 @@ void TrackContentWidget::paintEvent(QPaintEvent *event)
{ {
int firstTeTime = -1; int firstTeTime = -1;
for (const TrackEntry *te : qAsConst(m_preview)) for (const TrackEntry *te : std::as_const(m_preview))
{ {
if (firstTeTime > te->m_startTime || firstTeTime == -1) if (firstTeTime > te->m_startTime || firstTeTime == -1)
firstTeTime = te->m_startTime; firstTeTime = te->m_startTime;
@@ -863,7 +864,7 @@ void TrackContentWidget::selectAll()
{ {
m_selected.clear(); m_selected.clear();
for (TrackEntry *te : qAsConst(m_entryList)) for (TrackEntry *te : std::as_const(m_entryList))
{ {
m_selected.append(te); m_selected.append(te);
m_mainSelected = te; m_mainSelected = te;
@@ -1035,7 +1036,7 @@ bool TrackContentWidget::canMoveAll(int offset) const
checkForCollisions(this, m_selected, newTime, cols, true); checkForCollisions(this, m_selected, newTime, cols, true);
QVector<TrackEntry *> parls; QVector<TrackEntry *> parls;
for (const auto &tcw : qAsConst(m_tcwCorresponding)) for (const auto &tcw : std::as_const(m_tcwCorresponding))
checkForParallelTopics(tcw, m_selected, newTime, parls); checkForParallelTopics(tcw, m_selected, newTime, parls);
if (!cols.isEmpty() || !parls.isEmpty()) if (!cols.isEmpty() || !parls.isEmpty())
@@ -1168,7 +1169,7 @@ void TrackContentWidget::selectEntriesAtPositions(int fromPos, int toPos)
{ {
m_unselectAllImmune = true; m_unselectAllImmune = true;
for (TrackEntry *te : qAsConst(m_entryList)) for (TrackEntry *te : std::as_const(m_entryList))
{ {
int start = m_tools->getPos(te->m_startTime); int start = m_tools->getPos(te->m_startTime);
int end = m_tools->getPos(te->m_startTime + te->m_length); int end = m_tools->getPos(te->m_startTime + te->m_length);
@@ -1215,7 +1216,7 @@ bool TrackContentWidget::canPasteTopics(const QVector<TrackEntry *> &topics, int
TemporaryPointerVector<TrackEntry *> newTes; TemporaryPointerVector<TrackEntry *> newTes;
newTes.reserve(topics.size()); newTes.reserve(topics.size());
for (TrackEntry *te : qAsConst(topics)) for (TrackEntry *te : std::as_const(topics))
{ {
TrackEntry *newTe = new TrackEntry(te); TrackEntry *newTe = new TrackEntry(te);
newTe->m_startTime = (newTe->m_startTime - offsetTime + pasteTime); newTe->m_startTime = (newTe->m_startTime - offsetTime + pasteTime);
@@ -1228,7 +1229,7 @@ bool TrackContentWidget::canPasteTopics(const QVector<TrackEntry *> &topics, int
bool parl = false; bool parl = false;
for (const auto &tcw : qAsConst(m_tcwCorresponding)) for (const auto &tcw : std::as_const(m_tcwCorresponding))
{ {
parl = checkForParallelTopics(tcw, newTes, pasteTime, true ); parl = checkForParallelTopics(tcw, newTes, pasteTime, true );
if (parl) if (parl)
@@ -1252,7 +1253,7 @@ void TrackContentWidget::forcePasteTopics(const QVector<TrackEntry *> &topics, i
m_selected.clear(); m_selected.clear();
for (TrackEntry *te : qAsConst(topics)) for (TrackEntry *te : std::as_const(topics))
{ {
TrackEntry *newTe = new TrackEntry(te); TrackEntry *newTe = new TrackEntry(te);
newTe->m_topicId = m_scriptTimeline->nextUniqueId(); newTe->m_topicId = m_scriptTimeline->nextUniqueId();
@@ -1345,7 +1346,7 @@ bool TrackContentWidget::dragEnter(const QByteArray &itemData)
if (tes.isEmpty()) if (tes.isEmpty())
return false; return false;
for (TrackEntry *te : qAsConst(tes)) for (TrackEntry *te : std::as_const(tes))
{ {
if (!allowedByType(te)) if (!allowedByType(te))
{ {
@@ -1370,11 +1371,11 @@ bool TrackContentWidget::dragEnter(const QByteArray &itemData)
if (m_isMultiLineMultiSelectionMode) if (m_isMultiLineMultiSelectionMode)
{ {
for (TrackEntry *te : qAsConst(tes)) for (TrackEntry *te : std::as_const(tes))
{ {
bool found = false; bool found = false;
for (TrackEntry *thisTe : qAsConst(thisTes)) for (TrackEntry *thisTe : std::as_const(thisTes))
{ {
if (thisTe->m_topicId == te->m_topicId) if (thisTe->m_topicId == te->m_topicId)
{ {
@@ -1397,7 +1398,7 @@ bool TrackContentWidget::dragEnter(const QByteArray &itemData)
TrackEntry *pPreview = tes.front(); TrackEntry *pPreview = tes.front();
bool hasJustBeenAddedByUser = true; bool hasJustBeenAddedByUser = true;
for (auto pTE : qAsConst(m_entryList)) for (auto pTE : std::as_const(m_entryList))
{ {
if (pPreview->m_topicId == pTE->m_topicId) if (pPreview->m_topicId == pTE->m_topicId)
{ {
@@ -1407,9 +1408,9 @@ bool TrackContentWidget::dragEnter(const QByteArray &itemData)
} }
for (const auto &tcw : qAsConst(m_tcwCorresponding)) for (const auto &tcw : std::as_const(m_tcwCorresponding))
{ {
for (auto pTE : qAsConst(tcw->m_entryList)) for (auto pTE : std::as_const(tcw->m_entryList))
{ {
if (pPreview->m_topicId == pTE->m_topicId) if (pPreview->m_topicId == pTE->m_topicId)
{ {
@@ -1424,7 +1425,7 @@ bool TrackContentWidget::dragEnter(const QByteArray &itemData)
m_selected.clear(); m_selected.clear();
for (const auto &tcw : qAsConst(m_tcwCorresponding)) for (const auto &tcw : std::as_const(m_tcwCorresponding))
tcw->m_selected.clear(); tcw->m_selected.clear();
} }
} }
@@ -1472,7 +1473,7 @@ bool TrackContentWidget::dragDrop(int pos)
int firstTeTime = -1; int firstTeTime = -1;
for (const TrackEntry *te : qAsConst(m_preview)) for (const TrackEntry *te : std::as_const(m_preview))
{ {
if (firstTeTime > te->m_startTime || firstTeTime == -1) if (firstTeTime > te->m_startTime || firstTeTime == -1)
firstTeTime = te->m_startTime; firstTeTime = te->m_startTime;
@@ -1509,7 +1510,7 @@ bool TrackContentWidget::dragDrop(int pos)
update(); update();
for (const auto &tcw : qAsConst(m_tcwCorresponding)) for (const auto &tcw : std::as_const(m_tcwCorresponding))
tcw->removeTrackEntryByTopicId(prevTe); tcw->removeTrackEntryByTopicId(prevTe);
m_unselectAllImmune = false; m_unselectAllImmune = false;
@@ -1520,7 +1521,7 @@ bool TrackContentWidget::dragDrop(int pos)
if (m_isMultiLineMultiSelectionMode) if (m_isMultiLineMultiSelectionMode)
{ {
for (TrackEntry *oldSel : qAsConst(selectedOld)) for (TrackEntry *oldSel : std::as_const(selectedOld))
emit signalTrackEntryDeleted(oldSel->m_topicId); emit signalTrackEntryDeleted(oldSel->m_topicId);
qDeleteAll(selectedOld); qDeleteAll(selectedOld);
@@ -1540,7 +1541,7 @@ bool TrackContentWidget::dragMove(int pos)
checkForCollisions(this, m_preview, dropTime_s, m_dragHandler->m_vecCollisions, true); checkForCollisions(this, m_preview, dropTime_s, m_dragHandler->m_vecCollisions, true);
m_dragHandler->m_vecParallel.clear(); m_dragHandler->m_vecParallel.clear();
for (const auto &tcw : qAsConst(m_tcwCorresponding)) for (const auto &tcw : std::as_const(m_tcwCorresponding))
checkForParallelTopics(tcw, m_preview, dropTime_s, m_dragHandler->m_vecParallel); checkForParallelTopics(tcw, m_preview, dropTime_s, m_dragHandler->m_vecParallel);
m_moveValid = m_dragHandler->m_vecCollisions.isEmpty() && m_dragHandler->m_vecParallel.isEmpty(); m_moveValid = m_dragHandler->m_vecCollisions.isEmpty() && m_dragHandler->m_vecParallel.isEmpty();
@@ -1,4 +1,5 @@
#include "track_drag_handler.h" #include "track_drag_handler.h"
#include <utility>
#include "track_content_widget.h" #include "track_content_widget.h"
#include "track_entry.h" #include "track_entry.h"
@@ -33,7 +34,7 @@ void DragHandler::dragEnterEvent(QDragEnterEvent *event)
} }
else else
{ {
for (const auto &tcw : qAsConst(m_tcwCorresponding)) for (const auto &tcw : std::as_const(m_tcwCorresponding))
tcw->dragEnter(tcw->selectedItemsToData(tcw->m_tools->getTime(m_dragStartPos.x()))); tcw->dragEnter(tcw->selectedItemsToData(tcw->m_tools->getTime(m_dragStartPos.x())));
} }
} }
@@ -53,7 +54,7 @@ void DragHandler::dragLeaveEvent(QDragLeaveEvent *event)
if (m_tcw->isMultiLineMultiSelectionMode()) if (m_tcw->isMultiLineMultiSelectionMode())
{ {
event->ignore(); event->ignore();
for (const auto &tcw : qAsConst(m_tcwCorresponding)) for (const auto &tcw : std::as_const(m_tcwCorresponding))
tcw->dragEnd(); tcw->dragEnd();
} }
@@ -68,7 +69,7 @@ void DragHandler::dropEvent(QDropEvent *event)
for (const auto &tcw : qAsConst(m_tcwCorresponding)) for (const auto &tcw : std::as_const(m_tcwCorresponding))
{ {
bool hasParallelTopicsOfSameType = TrackContentWidget::checkForParallelTopics(tcw, m_tcw->m_preview, dropTime); bool hasParallelTopicsOfSameType = TrackContentWidget::checkForParallelTopics(tcw, m_tcw->m_preview, dropTime);
@@ -1,4 +1,5 @@
#include "track_resize_handler.h" #include "track_resize_handler.h"
#include <utility>
#include "track_entry.h" #include "track_entry.h"
#include "track_widget.h" #include "track_widget.h"
#include "track_content_widget.h" #include "track_content_widget.h"
@@ -40,7 +41,7 @@ void ResizeHandler::mouseReleaseEvent(QMouseEvent *)
QVector<TrackEntry *> vecPreviewTrackEntries = {m_trackContentWidget->m_mainSelected}; QVector<TrackEntry *> vecPreviewTrackEntries = {m_trackContentWidget->m_mainSelected};
bool msg = true; bool msg = true;
for (TrackContentWidget *tcw : qAsConst(m_tcwCorresponding)) for (TrackContentWidget *tcw : std::as_const(m_tcwCorresponding))
{ {
if (TrackContentWidget::checkForParallelTopics(tcw, vecPreviewTrackEntries, m_trackContentWidget->m_mainSelected->m_startTime)) if (TrackContentWidget::checkForParallelTopics(tcw, vecPreviewTrackEntries, m_trackContentWidget->m_mainSelected->m_startTime))
{ {
@@ -74,7 +75,7 @@ bool ResizeHandler::isCollision(int newLength) const
const QVector<FilterTrackWidget *> &filterTrackWidgets = m_trackContentWidget->trackWidget()->filterLines(); const QVector<FilterTrackWidget *> &filterTrackWidgets = m_trackContentWidget->trackWidget()->filterLines();
for (const FilterTrackWidget *filterTrackWidget : qAsConst(filterTrackWidgets)) for (const FilterTrackWidget *filterTrackWidget : std::as_const(filterTrackWidgets))
{ {
for (auto iFilterContentWidget = filterTrackWidget->fbw()->filterContentWidgets().begin(); iFilterContentWidget != filterTrackWidget->fbw()->filterContentWidgets().end(); ++iFilterContentWidget) for (auto iFilterContentWidget = filterTrackWidget->fbw()->filterContentWidgets().begin(); iFilterContentWidget != filterTrackWidget->fbw()->filterContentWidgets().end(); ++iFilterContentWidget)
{ {
@@ -1,4 +1,5 @@
#include "track_widget.h" #include "track_widget.h"
#include <utility>
#include "ui_track_widget.h" #include "ui_track_widget.h"
#include "track_entry.h" #include "track_entry.h"
#include "filter_track_widget.h" #include "filter_track_widget.h"
@@ -115,7 +116,7 @@ QVector<TrackEntry *> TrackWidget::getSelectedFilterEntries() const
QVector<TrackEntry *> result; QVector<TrackEntry *> result;
const QVector<FilterTrackWidget *> &ftws = filterLines(); const QVector<FilterTrackWidget *> &ftws = filterLines();
for (const FilterTrackWidget *ftw : qAsConst(ftws)) for (const FilterTrackWidget *ftw : std::as_const(ftws))
{ {
const FilterBackgroundWidget *fbw = ftw->fbw(); const FilterBackgroundWidget *fbw = ftw->fbw();
const QMap<int , TrackContentWidget *> &fcws = fbw->filterContentWidgets(); const QMap<int , TrackContentWidget *> &fcws = fbw->filterContentWidgets();
@@ -197,7 +198,7 @@ void TrackWidget::slotTrackEntryAdded(TrackEntry *te)
{ {
for (FilterTrackWidget *ftw : qAsConst(m_filterLines)) for (FilterTrackWidget *ftw : std::as_const(m_filterLines))
ftw->fbw()->trackEntryAdded(te); ftw->fbw()->trackEntryAdded(te);
emit signalTrackEntryAdded(te); emit signalTrackEntryAdded(te);
@@ -208,7 +209,7 @@ void TrackWidget::slotTrackEntryDeleted(const int topicId)
{ {
for (FilterTrackWidget *ftw : qAsConst(m_filterLines)) for (FilterTrackWidget *ftw : std::as_const(m_filterLines))
ftw->fbw()->trackEntryDeleted(topicId); ftw->fbw()->trackEntryDeleted(topicId);
emit signalTrackEntryDeleted(topicId); emit signalTrackEntryDeleted(topicId);
@@ -291,7 +292,7 @@ QVector<TrackEntry *> TrackWidget::getTrackEntriesWithFilters(bool selectedEntri
QJsonArray jsonFilterLines; QJsonArray jsonFilterLines;
for (const FilterTrackWidget *ftw : qAsConst(m_filterLines)) for (const FilterTrackWidget *ftw : std::as_const(m_filterLines))
{ {
const FilterBackgroundWidget *fbw = ftw->fbw(); const FilterBackgroundWidget *fbw = ftw->fbw();
const QMap<int , TrackContentWidget *> &filterContentWidgets = fbw->filterContentWidgets(); const QMap<int , TrackContentWidget *> &filterContentWidgets = fbw->filterContentWidgets();
@@ -381,7 +382,7 @@ void TrackWidget::setBaseWidth(int width)
ui->mainLeft->setMinimumWidth(width); ui->mainLeft->setMinimumWidth(width);
ui->mainLeft->setMaximumWidth(width); ui->mainLeft->setMaximumWidth(width);
for (FilterTrackWidget *ftw : qAsConst(m_filterLines)) for (FilterTrackWidget *ftw : std::as_const(m_filterLines))
ftw->setBaseWidth(m_baseWidth); ftw->setBaseWidth(m_baseWidth);
} }
@@ -493,7 +494,7 @@ void TrackWidget::unselectAll()
{ {
ui->mainTrack->unselectAll(); ui->mainTrack->unselectAll();
for (FilterTrackWidget *ftw : qAsConst(m_filterLines)) for (FilterTrackWidget *ftw : std::as_const(m_filterLines))
{ {
const auto fcw = ftw->fbw()->filterContentWidgets(); const auto fcw = ftw->fbw()->filterContentWidgets();
for (TrackContentWidget *tcw : fcw) for (TrackContentWidget *tcw : fcw)
@@ -514,7 +515,7 @@ void TrackWidget::setIndicatorTime(int time)
{ {
ui->mainTrack->setIndicatorTime(time); ui->mainTrack->setIndicatorTime(time);
for (FilterTrackWidget *ftw : qAsConst(m_filterLines)) for (FilterTrackWidget *ftw : std::as_const(m_filterLines))
{ {
const auto filterContentWidgets = ftw->fbw()->filterContentWidgets(); const auto filterContentWidgets = ftw->fbw()->filterContentWidgets();
@@ -27,5 +27,5 @@ NGL_TARGET_LINK_LIBRARIES(LtsSerialPortQuerry
PRIVATE PRIVATE
PUBLIC PUBLIC
NGLLogger NGLLogger
Qt5::SerialPort Qt6::SerialPort
) )
@@ -23,7 +23,7 @@ NGL_TARGET_LINK_LIBRARIES(LtsSessionDataDds
PUBLIC PUBLIC
ddscore ddscore
NGLLogger NGLLogger
Qt5::Core Qt6::Core
) )
@@ -46,7 +46,7 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsSession
NGL_TARGET_LINK_LIBRARIES(LtsSession NGL_TARGET_LINK_LIBRARIES(LtsSession
PRIVATE PRIVATE
Qt5::Network Qt6::Network
LtsMultiMonitor LtsMultiMonitor
LtsSessionData LtsSessionData
ddsconnector ddsconnector
@@ -54,11 +54,11 @@ NGL_TARGET_LINK_LIBRARIES(LtsSession
LtsNotification LtsNotification
svcCoreClient # Core Ftc - for TLH svcCoreClient # Core Ftc - for TLH
OhpOnlineHelpViewerGuiPluginInterface OhpOnlineHelpViewerGuiPluginInterface
Qt5::Svg Qt6::Svg
PUBLIC PUBLIC
LtsWidgets LtsWidgets
LtsSessionDataDds LtsSessionDataDds
Qt5::Core Qt6::Core
GuiPluginInterface GuiPluginInterface
DataPluginInterface DataPluginInterface
NGLLogger NGLLogger
@@ -81,7 +81,7 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsSessionData
NGL_TARGET_LINK_LIBRARIES(LtsSessionData NGL_TARGET_LINK_LIBRARIES(LtsSessionData
PUBLIC PUBLIC
Qt5::Core Qt6::Core
Qt5::Gui # QPixmap as Storage for Profile Picture Qt6::Gui # QPixmap as Storage for Profile Picture
ddscore ddscore
) )
@@ -2,6 +2,7 @@
#include "lts_session.h" #include "lts_session.h"
#include <utility>
#include "lts_session_manager.h" #include "lts_session_manager.h"
#include "lts_session_data_dds.h" #include "lts_session_data_dds.h"
#include "lts_session_lock_handler.h" #include "lts_session_lock_handler.h"
@@ -1138,7 +1139,7 @@ void LtsSession::createBaseLayout()
addDeveloperActions(); addDeveloperActions();
for (LtsNotification::LtsNotificationController *ctl : qAsConst(m_notiCtlList)) for (LtsNotification::LtsNotificationController *ctl : std::as_const(m_notiCtlList))
{ {
if (!m_baseLayout->notificationExists(ctl->identifier())) if (!m_baseLayout->notificationExists(ctl->identifier()))
m_baseLayout->addNotification(ctl->createWidget()); m_baseLayout->addNotification(ctl->createWidget());
@@ -55,9 +55,9 @@ NGL_TARGET_LINK_LIBRARIES(LtsTimeline
NGLLogger NGLLogger
ngltools # DTG ngltools # DTG
LtsWidgets # LtsMessageDialogNew for remove filter track LtsWidgets # LtsMessageDialogNew for remove filter track
Qt5::Core Qt6::Core
Qt5::Gui Qt6::Gui
Qt5::Widgets Qt6::Widgets
) )
NGL_INSTALL_TARGET(LtsTimeline) NGL_INSTALL_TARGET(LtsTimeline)
@@ -68,7 +68,7 @@ NGL_TARGET_LINK_LIBRARIES(LtsTimelineTest
LtsTimeline LtsTimeline
nglapplication nglapplication
NGLLogger NGLLogger
Qt5::Core Qt6::Core
Qt5::Gui Qt6::Gui
Qt5::Widgets Qt6::Widgets
) )
@@ -1,4 +1,5 @@
#include "timeline_header_view.h" #include "timeline_header_view.h"
#include <utility>
#include "timeline_view.h" #include "timeline_view.h"
#include <QGuiApplication> #include <QGuiApplication>
@@ -400,7 +401,7 @@ void TimelineHeaderView::paintSection(QPainter *painter, const QRect &rect, int
int height = (bottom - rect.top()) / 2; int height = (bottom - rect.top()) / 2;
for (const Tick &tick : qAsConst(m_majorTicks)) for (const Tick &tick : std::as_const(m_majorTicks))
{ {
painter->setPen(QPen(QGuiApplication::palette().color(QPalette::Text), 1)); painter->setPen(QPen(QGuiApplication::palette().color(QPalette::Text), 1));
painter->drawText(QRect(tick.pos - 160 / 2, rect.top(), 160, height), Qt::AlignCenter, tick.label); painter->drawText(QRect(tick.pos - 160 / 2, rect.top(), 160, height), Qt::AlignCenter, tick.label);
@@ -413,11 +414,11 @@ void TimelineHeaderView::paintSection(QPainter *painter, const QRect &rect, int
painter->setPen(QPen(QGuiApplication::palette().color(QPalette::Text), 1)); painter->setPen(QPen(QGuiApplication::palette().color(QPalette::Text), 1));
for (const Tick &tick : qAsConst(m_mediumTicks)) for (const Tick &tick : std::as_const(m_mediumTicks))
painter->drawLine(tick.pos, bottom - static_cast<int>(double(height) * 2 / 3), tick.pos, bottom); painter->drawLine(tick.pos, bottom - static_cast<int>(double(height) * 2 / 3), tick.pos, bottom);
for (const Tick &tick : qAsConst(m_minorTicks)) for (const Tick &tick : std::as_const(m_minorTicks))
painter->drawLine(tick.pos, bottom - static_cast<int>(double(height) / 3), tick.pos, bottom); painter->drawLine(tick.pos, bottom - static_cast<int>(double(height) / 3), tick.pos, bottom);
@@ -2,6 +2,7 @@
#include "timeline_model.h" #include "timeline_model.h"
#include <utility>
#include "timeline_view_drag_handler.h" #include "timeline_view_drag_handler.h"
#include "track.h" #include "track.h"
@@ -159,7 +160,7 @@ const QVector<int> TimelineModel::_copyItemIdsBetween(Track &t, qint64 start, qi
itemIds.reserve(t.itemCount()); itemIds.reserve(t.itemCount());
for (const int itemId : qAsConst(t.copyItemIds())) for (const int itemId : std::as_const(t.copyItemIds()))
{ {
const Item &i = item(itemId); const Item &i = item(itemId);
if (Track::isItemBetween(i, start, end, strict, complete, minimumDuration)) if (Track::isItemBetween(i, start, end, strict, complete, minimumDuration))
@@ -167,7 +168,7 @@ const QVector<int> TimelineModel::_copyItemIdsBetween(Track &t, qint64 start, qi
} }
if (recursive) if (recursive)
for (const TrackPtr &trackPtr : qAsConst(t.tracks())) for (const TrackPtr &trackPtr : std::as_const(t.tracks()))
itemIds += _copyItemIdsBetween(*trackPtr.get(), start, end, strict, complete, true, false, minimumDuration); itemIds += _copyItemIdsBetween(*trackPtr.get(), start, end, strict, complete, true, false, minimumDuration);
@@ -197,7 +198,7 @@ const QVector<int> TimelineModel::_itemIdsBetween(Track &t, qint64 start, qint64
QVector<int> itemIds; QVector<int> itemIds;
itemIds.reserve(t.itemCount()); itemIds.reserve(t.itemCount());
for (const ItemPtr &itemPtr : qAsConst(t.items())) for (const ItemPtr &itemPtr : std::as_const(t.items()))
{ {
const Item &i = *itemPtr; const Item &i = *itemPtr;
if (Track::isItemBetween(i, start, end, strict, complete, minimumDuration)) if (Track::isItemBetween(i, start, end, strict, complete, minimumDuration))
@@ -205,7 +206,7 @@ const QVector<int> TimelineModel::_itemIdsBetween(Track &t, qint64 start, qint64
} }
if (recursive) if (recursive)
for (const TrackPtr &trackPtr : qAsConst(t.tracks())) for (const TrackPtr &trackPtr : std::as_const(t.tracks()))
itemIds += _itemIdsBetween(*trackPtr.get(), start, end, strict, complete, true, false, minimumDuration); itemIds += _itemIdsBetween(*trackPtr.get(), start, end, strict, complete, true, false, minimumDuration);
@@ -232,7 +233,7 @@ const QVector<int> TimelineModel::_itemIdsBetween(Track &t, qint64 start, qint64
bool TimelineModel::_isItemsBetween(const Track &t, qint64 start, qint64 end, const QVector<int> &ignoreIds, bool strict, bool complete, bool recursive, qint64 minimumDuration) const bool TimelineModel::_isItemsBetween(const Track &t, qint64 start, qint64 end, const QVector<int> &ignoreIds, bool strict, bool complete, bool recursive, qint64 minimumDuration) const
{ {
for (const ItemPtr &itemPtr : qAsConst(t.items())) for (const ItemPtr &itemPtr : std::as_const(t.items()))
{ {
const Item &i = *itemPtr; const Item &i = *itemPtr;
if (!ignoreIds.contains(i.id())) if (!ignoreIds.contains(i.id()))
@@ -243,7 +244,7 @@ bool TimelineModel::_isItemsBetween(const Track &t, qint64 start, qint64 end, co
if (!recursive) if (!recursive)
return false; return false;
for (const TrackPtr &trackPtr : qAsConst(t.tracks())) for (const TrackPtr &trackPtr : std::as_const(t.tracks()))
if (_isItemsBetween(*trackPtr.get(), start, end, ignoreIds, strict, complete, true, minimumDuration)) if (_isItemsBetween(*trackPtr.get(), start, end, ignoreIds, strict, complete, true, minimumDuration))
return true; return true;
@@ -360,7 +361,7 @@ int TimelineModel::rowOfTrackId(int id) const noexcept(false)
int row = 0; int row = 0;
for (const TrackPtr &trackPtr : qAsConst(parent.tracks())) for (const TrackPtr &trackPtr : std::as_const(parent.tracks()))
{ {
if (trackPtr->id() == id) if (trackPtr->id() == id)
return row; return row;
@@ -527,7 +528,7 @@ void TimelineModel::copyToClipboard(const QVector<int> &ids) noexcept(false)
m_clipboard.clear(); m_clipboard.clear();
m_clipboard.reserve(ids.size()); m_clipboard.reserve(ids.size());
qint64 tStartMin = LLONG_MAX; qint64 tStartMin = LLONG_MAX;
for (int itemId : qAsConst(ids)) for (int itemId : std::as_const(ids))
{ {
const Item &i = item(itemId); const Item &i = item(itemId);
ItemPtr iPtr = std::make_unique<Item>(Item(i.startTime(), i.duration(), i.color())); ItemPtr iPtr = std::make_unique<Item>(Item(i.startTime(), i.duration(), i.color()));
@@ -542,7 +543,7 @@ void TimelineModel::copyToClipboard(const QVector<int> &ids) noexcept(false)
void TimelineModel::cutToClipboard(const QVector<int> &ids) noexcept(false) void TimelineModel::cutToClipboard(const QVector<int> &ids) noexcept(false)
{ {
copyToClipboard(ids); copyToClipboard(ids);
for (int itemId : qAsConst(ids)) for (int itemId : std::as_const(ids))
removeItem(itemId); removeItem(itemId);
} }
@@ -2,6 +2,7 @@
#include "timeline_view.h" #include "timeline_view.h"
#include <utility>
#include "item_delegate.h" #include "item_delegate.h"
#include <NGLLogger/NGLLoggerBootstrap.h> #include <NGLLogger/NGLLoggerBootstrap.h>
@@ -340,7 +341,7 @@ void TimelineView::selectItems(const QVector<int> &itemIds, bool reset)
{ {
if (reset) if (reset)
m_selectedItemIds.clear(); m_selectedItemIds.clear();
for (const int &itemId : qAsConst(itemIds)) for (const int &itemId : std::as_const(itemIds))
if (!m_selectedItemIds.contains(itemId)) if (!m_selectedItemIds.contains(itemId))
m_selectedItemIds.append(itemId); m_selectedItemIds.append(itemId);
emit selectedItemsChanged(m_selectedItemIds); emit selectedItemsChanged(m_selectedItemIds);
@@ -1,5 +1,6 @@
#include "timeline_view_drag_handler.h" #include "timeline_view_drag_handler.h"
#include "item.h" #include "item.h"
#include <utility>
#include "track.h" #include "track.h"
#include <QApplication> #include <QApplication>
@@ -79,7 +80,7 @@ void TimelineViewDragHandler::dropEvent(QDropEvent *e)
qint64 dt = deltaTime(); qint64 dt = deltaTime();
try try
{ {
for (const int &itemId : qAsConst(m_dragItemIds)) for (const int &itemId : std::as_const(m_dragItemIds))
{ {
const Item &item = m_view->timelineModel()->item(itemId); const Item &item = m_view->timelineModel()->item(itemId);
m_view->timelineModel()->moveItemToTrack(itemId, dragItemTrackId(item), item.startTime() + dt); m_view->timelineModel()->moveItemToTrack(itemId, dragItemTrackId(item), item.startTime() + dt);
@@ -1,4 +1,5 @@
#include "timeline_view_selection_handler.h" #include "timeline_view_selection_handler.h"
#include <utility>
#include "item_delegate.h" #include "item_delegate.h"
#include <QApplication> #include <QApplication>
@@ -197,7 +198,7 @@ void TimelineViewSelectHandler::keyPressEvent(QKeyEvent *e)
{ {
if (!m_view->m_selectedItemIds.isEmpty()) if (!m_view->m_selectedItemIds.isEmpty())
{ {
for (const int &itemId : qAsConst(m_view->m_selectedItemIds)) for (const int &itemId : std::as_const(m_view->m_selectedItemIds))
{ {
try try
{ {
@@ -2,6 +2,7 @@
#include "timeline_widget.h" #include "timeline_widget.h"
#include <utility>
#include "ui_timeline_widget.h" #include "ui_timeline_widget.h"
#include "timeline_view.h" #include "timeline_view.h"
#include "timeline_header_view.h" #include "timeline_header_view.h"
@@ -317,7 +318,7 @@ void TimelineWidget::populateZoomFactorComboBox()
this, &TimelineWidget::onZoomSelected); this, &TimelineWidget::onZoomSelected);
m_ui->cbZoom->clear(); m_ui->cbZoom->clear();
QVector<ZoomFactor> availableZooms = Zoom::availableZoomFactors(m_ui->view->minimumZoomFactor(), m_ui->view->upperZoomFactor()); QVector<ZoomFactor> availableZooms = Zoom::availableZoomFactors(m_ui->view->minimumZoomFactor(), m_ui->view->upperZoomFactor());
for (ZoomFactor factor : qAsConst(availableZooms)) for (ZoomFactor factor : std::as_const(availableZooms))
{ {
m_ui->cbZoom->addItem(Zoom::toString(factor), QVariant(factor)); m_ui->cbZoom->addItem(Zoom::toString(factor), QVariant(factor));
if (factor == zoomFactor()) if (factor == zoomFactor())
@@ -392,7 +393,7 @@ void TimelineWidget::onUpdateDebugInfo()
m_ui->lblDebugSlider->setText(DateTime::toString(qint64(m_ui->slider->value()) * 1000, DateTimeFormat::DTG)); m_ui->lblDebugSlider->setText(DateTime::toString(qint64(m_ui->slider->value()) * 1000, DateTimeFormat::DTG));
m_ui->lblDebugZoom->setText(Zoom::toString(m_ui->view->zoomFactor())); m_ui->lblDebugZoom->setText(Zoom::toString(m_ui->view->zoomFactor()));
QString selection; QString selection;
for (int itemId : qAsConst(m_ui->view->selectedItemIds())) for (int itemId : std::as_const(m_ui->view->selectedItemIds()))
selection += QString::number(itemId) + QStringLiteral(", "); selection += QString::number(itemId) + QStringLiteral(", ");
if (selection.size() > 1) if (selection.size() > 1)
selection.chop(2); selection.chop(2);
@@ -2,6 +2,7 @@
#include "track.h" #include "track.h"
#include <utility>
namespace LtsTimeline namespace LtsTimeline
{ {
@@ -19,7 +20,7 @@ const Track &Track::track(int id) const noexcept(false)
return **it; return **it;
for (const TrackPtr &track : qAsConst(m_childrenTracks)) for (const TrackPtr &track : std::as_const(m_childrenTracks))
{ {
try try
{ {
@@ -48,7 +49,7 @@ bool Track::hasTrack(int id, bool recursive) const
if (!recursive) if (!recursive)
return false; return false;
for (const TrackPtr &trackPtr : qAsConst(m_childrenTracks)) for (const TrackPtr &trackPtr : std::as_const(m_childrenTracks))
{ {
if (trackPtr->hasTrack(id, true)) if (trackPtr->hasTrack(id, true))
return true; return true;
@@ -95,7 +96,7 @@ void Track::addCopyItemId(int id)
const Track &Track::parentOf(int id) const noexcept(false) const Track &Track::parentOf(int id) const noexcept(false)
{ {
for (const TrackPtr &trackPtr : qAsConst(m_childrenTracks)) for (const TrackPtr &trackPtr : std::as_const(m_childrenTracks))
{ {
if (trackPtr->hasTrack(id)) if (trackPtr->hasTrack(id))
return *trackPtr; return *trackPtr;
@@ -170,7 +171,7 @@ const QVector<int> Track::copyItemIdsBetween(qint64 start, qint64 end, bool stri
if (recursive) if (recursive)
{ {
for (const TrackPtr &trackPtr : qAsConst(m_childrenTracks)) for (const TrackPtr &trackPtr : std::as_const(m_childrenTracks))
{ {
auto itemPtrRefs2 = trackPtr->_copyItems(); auto itemPtrRefs2 = trackPtr->_copyItems();
itemPtrRefs.insert(itemPtrRefs.end(), itemPtrRefs2.begin(), itemPtrRefs2.end()); itemPtrRefs.insert(itemPtrRefs.end(), itemPtrRefs2.begin(), itemPtrRefs2.end());
@@ -215,7 +216,7 @@ const QVector<int> Track::itemIdsBetween(qint64 start, qint64 end, bool strict,
QVector<int> itemIds; QVector<int> itemIds;
itemIds.reserve(m_items.size()); itemIds.reserve(m_items.size());
for (const ItemPtr &itemPtr : qAsConst(m_items)) for (const ItemPtr &itemPtr : std::as_const(m_items))
{ {
const Item &item = *itemPtr; const Item &item = *itemPtr;
if (isItemBetween(item, start, end, strict, complete, minimumDuration)) if (isItemBetween(item, start, end, strict, complete, minimumDuration))
@@ -228,7 +229,7 @@ const QVector<int> Track::itemIdsBetween(qint64 start, qint64 end, bool strict,
return itemIds; return itemIds;
} }
for (const TrackPtr &trackPtr : qAsConst(m_childrenTracks)) for (const TrackPtr &trackPtr : std::as_const(m_childrenTracks))
itemIds += trackPtr->itemIdsBetween(start, end, strict, complete, true, minimumDuration); itemIds += trackPtr->itemIdsBetween(start, end, strict, complete, true, minimumDuration);
return itemIds; return itemIds;
@@ -237,7 +238,7 @@ const QVector<int> Track::itemIdsBetween(qint64 start, qint64 end, bool strict,
bool Track::isItemsBetween(qint64 start, qint64 end, const QVector<int> &ignoreIds, bool strict, bool complete, bool recursive, qint64 minimumDuration) const bool Track::isItemsBetween(qint64 start, qint64 end, const QVector<int> &ignoreIds, bool strict, bool complete, bool recursive, qint64 minimumDuration) const
{ {
for (const ItemPtr &itemPtr : qAsConst(m_items)) for (const ItemPtr &itemPtr : std::as_const(m_items))
{ {
const Item &i = *itemPtr; const Item &i = *itemPtr;
if (!ignoreIds.contains(i.id())) if (!ignoreIds.contains(i.id()))
@@ -246,7 +247,7 @@ bool Track::isItemsBetween(qint64 start, qint64 end, const QVector<int> &ignoreI
} }
for (const int itemId : qAsConst(m_copyItemIds)) for (const int itemId : std::as_const(m_copyItemIds))
{ {
const Item &i = item(itemId); const Item &i = item(itemId);
if (!ignoreIds.contains(i.id())) if (!ignoreIds.contains(i.id()))
@@ -258,7 +259,7 @@ bool Track::isItemsBetween(qint64 start, qint64 end, const QVector<int> &ignoreI
if (!recursive) if (!recursive)
return false; return false;
for (const TrackPtr &trackPtr : qAsConst(m_childrenTracks)) for (const TrackPtr &trackPtr : std::as_const(m_childrenTracks))
if (trackPtr->isItemsBetween(start, end, ignoreIds, strict, complete, true, minimumDuration)) if (trackPtr->isItemsBetween(start, end, ignoreIds, strict, complete, true, minimumDuration))
return true; return true;
@@ -281,7 +282,7 @@ ItemPtrRefs Track::_items(bool recursive) const
x.reserve(x.size() + m_copyItemIds.count()); x.reserve(x.size() + m_copyItemIds.count());
for (const int itemId : qAsConst(m_copyItemIds)) for (const int itemId : std::as_const(m_copyItemIds))
{ {
try try
{ {
@@ -297,7 +298,7 @@ ItemPtrRefs Track::_items(bool recursive) const
return x; return x;
for (const TrackPtr &t : qAsConst(m_childrenTracks)) for (const TrackPtr &t : std::as_const(m_childrenTracks))
{ {
const ItemPtrRefs x2(t->_items(true)); const ItemPtrRefs x2(t->_items(true));
x.insert(x.end(), x2.begin(), x2.end()); x.insert(x.end(), x2.begin(), x2.end());
@@ -315,7 +316,7 @@ ItemPtrRefs Track::_copyItems() const
ItemPtrRefs x; ItemPtrRefs x;
for (int id : qAsConst(m_copyItemIds)) for (int id : std::as_const(m_copyItemIds))
{ {
try try
{ {
@@ -361,7 +362,7 @@ const QVector<int> Track::_itemIds(bool recursive) const
return itemIds; return itemIds;
for (const TrackPtr &trackPtr : qAsConst(m_childrenTracks)) for (const TrackPtr &trackPtr : std::as_const(m_childrenTracks))
itemIds += trackPtr->_itemIds(true); itemIds += trackPtr->_itemIds(true);
return itemIds; return itemIds;
@@ -381,7 +382,7 @@ ItemPtrRef Track::_item(int id) const noexcept(false)
return *it; return *it;
for (const TrackPtr &track : qAsConst(m_childrenTracks)) for (const TrackPtr &track : std::as_const(m_childrenTracks))
{ {
try try
{ {
@@ -405,7 +406,7 @@ void Track::printTrackIds(bool withItems, int level) const
if (withItems) if (withItems)
{ {
fprintf(stderr, " ( "); fprintf(stderr, " ( ");
for (const ItemPtr &itemPtr : qAsConst(m_items)) for (const ItemPtr &itemPtr : std::as_const(m_items))
{ {
fprintf(stderr, "%d ", itemPtr->id()); fprintf(stderr, "%d ", itemPtr->id());
} }
@@ -415,7 +416,7 @@ void Track::printTrackIds(bool withItems, int level) const
fprintf(stderr, "\n"); fprintf(stderr, "\n");
for (const TrackPtr &trackPtr : qAsConst(m_childrenTracks)) for (const TrackPtr &trackPtr : std::as_const(m_childrenTracks))
trackPtr->printTrackIds(level + 1); trackPtr->printTrackIds(level + 1);
} }
@@ -446,7 +447,7 @@ QVector<int> Track::itemIds(bool recursive, bool sorted) const
return itemIds; return itemIds;
for (const TrackPtr &trackPtr : qAsConst(m_childrenTracks)) for (const TrackPtr &trackPtr : std::as_const(m_childrenTracks))
itemIds += trackPtr->_itemIds(true); itemIds += trackPtr->_itemIds(true);
return itemIds; return itemIds;
@@ -640,7 +641,7 @@ const Item &Track::item(int id) const noexcept(false)
return **it; return **it;
for (const TrackPtr &track : qAsConst(m_childrenTracks)) for (const TrackPtr &track : std::as_const(m_childrenTracks))
{ {
try try
{ {
@@ -762,7 +763,7 @@ Item &Track::next(int id) noexcept(false)
int Track::rowOfTrack(int id) const noexcept(false) int Track::rowOfTrack(int id) const noexcept(false)
{ {
int row = 0; int row = 0;
for (const TrackPtr &trackPtr : qAsConst(m_childrenTracks)) for (const TrackPtr &trackPtr : std::as_const(m_childrenTracks))
{ {
if (trackPtr->id() == id) if (trackPtr->id() == id)
return row; return row;
@@ -2,6 +2,7 @@
#include "AbstractTimelineModel.h" #include "AbstractTimelineModel.h"
#include <utility>
#include <NGLLogger/NGLLoggerBootstrap.h> #include <NGLLogger/NGLLoggerBootstrap.h>
@@ -107,7 +108,7 @@ void AbstractTimelineModel::addEvent(Event *event)
Item *currentItem = m_rootItem; Item *currentItem = m_rootItem;
QModelIndex currentIndex = QModelIndex(); QModelIndex currentIndex = QModelIndex();
for (const QString &curPath : qAsConst(actuatorPath)) for (const QString &curPath : std::as_const(actuatorPath))
{ {
Item *oldItem = currentItem; Item *oldItem = currentItem;
const ItemList *itemList = currentItem->getChildren(); const ItemList *itemList = currentItem->getChildren();
@@ -56,9 +56,9 @@ NGL_TARGET_LINK_LIBRARIES(LtsTimelineClassic
PRIVATE PRIVATE
NGLLogger NGLLogger
ngltools # DTG ngltools # DTG
Qt5::Core Qt6::Core
Qt5::Gui Qt6::Gui
Qt5::Widgets Qt6::Widgets
LtsSessionDataDds LtsSessionDataDds
) )
@@ -68,9 +68,9 @@ IF(NEVER)
NGL_TARGET_LINK_LIBRARIES(LtsTimelineClassicTest NGL_TARGET_LINK_LIBRARIES(LtsTimelineClassicTest
nglapplication nglapplication
NGLLogger NGLLogger
Qt5::Core Qt6::Core
Qt5::Gui Qt6::Gui
Qt5::Widgets Qt6::Widgets
LtsTimelineClassic LtsTimelineClassic
svcEemCommon svcEemCommon
svcEemClient svcEemClient
@@ -3,6 +3,7 @@
#include "EventGraphic.h" #include "EventGraphic.h"
#include <utility>
#include <QPainter> #include <QPainter>
#include <QPen> #include <QPen>
@@ -59,7 +60,7 @@ qint64 EventGraphic::getDuration()
qint64 highestDuration = 0; qint64 highestDuration = 0;
qint64 lowest = lowestTime(); qint64 lowest = lowestTime();
for (Event *event : qAsConst(m_eventList)) for (Event *event : std::as_const(m_eventList))
{ {
@@ -2,6 +2,7 @@
#include <QDebug> #include <QDebug>
#include <utility>
#include "Item.h" #include "Item.h"
#include "EventTools.h" #include "EventTools.h"
@@ -215,7 +216,7 @@ EventList Item::getFullEventList(bool recursive, bool getHiddenEvents) const
if (!m_children || !recursive) if (!m_children || !recursive)
return el; return el;
for (const Item *item : qAsConst(*m_children)) for (const Item *item : std::as_const(*m_children))
el += item->getFullEventList(recursive, getHiddenEvents); el += item->getFullEventList(recursive, getHiddenEvents);
return el; return el;
@@ -2,6 +2,7 @@
#include "TimelineView.h" #include "TimelineView.h"
#include <utility>
#include "TimelineHeaderView.h" #include "TimelineHeaderView.h"
#include "TimelineWidget.h" #include "TimelineWidget.h"
#include "EventDelegate.h" #include "EventDelegate.h"
@@ -335,7 +336,7 @@ void TimelineView::paintEvent(QPaintEvent *event)
painter.setBrush(QBrush("white")); painter.setBrush(QBrush("white"));
int h = height(); int h = height();
for (const auto &range : qAsConst(m_knownRanges)) for (const auto &range : std::as_const(m_knownRanges))
{ {
int start = EventTools::getEventPosition(range.start); int start = EventTools::getEventPosition(range.start);
@@ -43,7 +43,7 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsUtilsCore
) )
NGL_TARGET_LINK_LIBRARIES(LtsUtilsCore NGL_TARGET_LINK_LIBRARIES(LtsUtilsCore
PUBLIC PUBLIC
Qt5::Core Qt6::Core
LtsUtilsCoreHeaderOnly LtsUtilsCoreHeaderOnly
) )
@@ -60,8 +60,8 @@ IF((BUILD_WS OR BUILD_SV) AND BUILD_TESTING)
) )
TARGET_LINK_LIBRARIES(utils_test TARGET_LINK_LIBRARIES(utils_test
LtsUtilsCore LtsUtilsCore
Qt5::Core Qt6::Core
Qt5::Test Qt6::Test
ddscore ddscore
) )
ADD_TEST(NAME utils_test COMMAND $<TARGET_FILE:utils_test>) ADD_TEST(NAME utils_test COMMAND $<TARGET_FILE:utils_test>)
@@ -4,6 +4,7 @@
#include "pgarray.h" #include "pgarray.h"
#include <QVector> #include <QVector>
#include <QDebug> #include <QDebug>
#include <QStringView>
#include <functional> #include <functional>
#include <LtsUtilsCore/ltsutilscore_export.h> #include <LtsUtilsCore/ltsutilscore_export.h>
@@ -37,7 +38,7 @@ LTSUTILSCORE_EXPORT QString BigintArray::toPgString() const
} }
template<typename T> template<typename T>
static inline T convertFromPgString(const QString &str, const std::function<typename T::Type(const QStringRef &val, bool *bOk)> &convertFunc) static inline T convertFromPgString(const QString &str, const std::function<typename T::Type(QStringView val, bool *bOk)> &convertFunc)
{ {
typename T::ContainerType result; typename T::ContainerType result;
@@ -52,10 +53,10 @@ static inline T convertFromPgString(const QString &str, const std::function<type
idxEnd = str.length() + 1; idxEnd = str.length() + 1;
} }
const QStringRef strRef = str.midRef(idxStart + 1, idxEnd - idxStart - 1); const QStringView strRef = QStringView(str).mid(idxStart + 1, idxEnd - idxStart - 1);
const QVector<QStringRef> vec = strRef.split(QLatin1Char(','), QString::SkipEmptyParts); const QVector<QStringView> vec = strRef.split(QLatin1Char(','), Qt::SkipEmptyParts);
result.reserve(vec.size()); result.reserve(vec.size());
for (const QStringRef &s : vec) for (const QStringView &s : vec)
{ {
bool ok = false; bool ok = false;
const typename T::Type i = convertFunc(s, &ok); const typename T::Type i = convertFunc(s, &ok);
@@ -70,14 +71,14 @@ template<>
LTSUTILSCORE_EXPORT IntArray IntArray::fromPgString(const QString &str) LTSUTILSCORE_EXPORT IntArray IntArray::fromPgString(const QString &str)
{ {
return convertFromPgString<IntArray>(str, return convertFromPgString<IntArray>(str,
[](const QStringRef & val, bool * bOk) { return val.toInt(bOk);}); [](QStringView val, bool * bOk) { return val.toString().toInt(bOk);});
} }
template<> template<>
LTSUTILSCORE_EXPORT BigintArray BigintArray::fromPgString(const QString &str) LTSUTILSCORE_EXPORT BigintArray BigintArray::fromPgString(const QString &str)
{ {
return convertFromPgString<BigintArray>(str, return convertFromPgString<BigintArray>(str,
[](const QStringRef & val, bool * bOk) { return val.toLongLong(bOk);}); [](QStringView val, bool * bOk) { return val.toString().toLongLong(bOk);});
} }
@@ -115,7 +116,7 @@ LTSUTILSCORE_EXPORT QString BigintArray2D::toPgString() const
template<typename T> template<typename T>
static inline T convertFromPgString2D(const QString &str, const std::function<typename T::Type(const QStringRef &val)> &convertFunc) static inline T convertFromPgString2D(const QString &str, const std::function<typename T::Type(QStringView val)> &convertFunc)
{ {
typename T::ContainerType ret; typename T::ContainerType ret;
int idxStart = str.indexOf(QLatin1Char('{')); int idxStart = str.indexOf(QLatin1Char('{'));
@@ -129,7 +130,7 @@ static inline T convertFromPgString2D(const QString &str, const std::function<ty
idxEnd = str.length() + 1; idxEnd = str.length() + 1;
} }
const QStringRef strRef = str.midRef(idxStart + 1, idxEnd - idxStart - 1); const QStringView strRef = QStringView(str).mid(idxStart + 1, idxEnd - idxStart - 1);
idxStart = strRef.indexOf(QLatin1Char('{')); idxStart = strRef.indexOf(QLatin1Char('{'));
while (idxStart >= 0) while (idxStart >= 0)
{ {
@@ -137,8 +138,8 @@ static inline T convertFromPgString2D(const QString &str, const std::function<ty
if (idxEnd < 0) if (idxEnd < 0)
break; break;
const QStringRef keyValueStr = strRef.mid(idxStart + 1, idxEnd - idxStart - 1); const QStringView keyValueStr = strRef.mid(idxStart + 1, idxEnd - idxStart - 1);
const QVector<QStringRef> keyValuePair = keyValueStr.split(QLatin1Char(','), QString::SkipEmptyParts); const QVector<QStringView> keyValuePair = keyValueStr.split(QLatin1Char(','), Qt::SkipEmptyParts);
if (keyValuePair.size() != 2) if (keyValuePair.size() != 2)
break; break;
const typename T::Type key = convertFunc(keyValuePair.at(0).trimmed()); const typename T::Type key = convertFunc(keyValuePair.at(0).trimmed());
@@ -156,14 +157,14 @@ template<>
LTSUTILSCORE_EXPORT IntArray2D IntArray2D::fromPgString(const QString &str) LTSUTILSCORE_EXPORT IntArray2D IntArray2D::fromPgString(const QString &str)
{ {
return convertFromPgString2D<IntArray2D>(str, return convertFromPgString2D<IntArray2D>(str,
[](const QStringRef & val) { return val.toInt();}); [](QStringView val) { return val.toString().toInt();});
} }
template<> template<>
LTSUTILSCORE_EXPORT BigintArray2D BigintArray2D::fromPgString(const QString &str) LTSUTILSCORE_EXPORT BigintArray2D BigintArray2D::fromPgString(const QString &str)
{ {
return convertFromPgString2D<BigintArray2D>(str, return convertFromPgString2D<BigintArray2D>(str,
[](const QStringRef & val) { return val.toLongLong();}); [](QStringView val) { return val.toString().toLongLong();});
} }
} }
@@ -23,6 +23,6 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsUtilsGuiConnectDialog
${CMAKE_CURRENT_BINARY_DIR}/../ ${CMAKE_CURRENT_BINARY_DIR}/../
) )
NGL_TARGET_LINK_LIBRARIES(LtsUtilsGuiConnectDialog NGL_TARGET_LINK_LIBRARIES(LtsUtilsGuiConnectDialog
Qt5::Widgets Qt6::Widgets
LtsWidgets LtsWidgets
) )
@@ -22,11 +22,11 @@ NGL_TARGET_LINK_LIBRARIES(LtsUtilsGuiDds
PRIVATE PRIVATE
LtsUtilsCoreHeaderOnly LtsUtilsCoreHeaderOnly
LtsWidgets LtsWidgets
Qt5::Gui Qt6::Gui
Qt5::Widgets Qt6::Widgets
Qt5::Svg Qt6::Svg
PUBLIC PUBLIC
Qt5::Core Qt6::Core
ddscore ddscore
) )
NGL_TARGET_COMPILE_DEFINITIONS(LtsUtilsGuiDds NGL_TARGET_COMPILE_DEFINITIONS(LtsUtilsGuiDds
@@ -44,6 +44,6 @@ NGL_TARGET_LINK_LIBRARIES(LtsUtilsDds
PRIVATE PRIVATE
LtsUtilsCoreHeaderOnly LtsUtilsCoreHeaderOnly
PUBLIC PUBLIC
Qt5::Core Qt6::Core
ddscore ddscore
) )
@@ -17,6 +17,6 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsUtilsGuiStyleManager
${CMAKE_CURRENT_BINARY_DIR}/../ ${CMAKE_CURRENT_BINARY_DIR}/../
) )
NGL_TARGET_LINK_LIBRARIES(LtsUtilsGuiStyleManager NGL_TARGET_LINK_LIBRARIES(LtsUtilsGuiStyleManager
Qt5::Core Qt6::Core
LtsPluginLoader LtsPluginLoader
) )
@@ -17,5 +17,5 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsUtilsSettings
NGL_TARGET_LINK_LIBRARIES(LtsUtilsSettings NGL_TARGET_LINK_LIBRARIES(LtsUtilsSettings
PUBLIC PUBLIC
Qt5::Core Qt6::Core
) )
@@ -248,9 +248,9 @@ QStringList Settings::identifiers(const QString &group) const
QStringList result; QStringList result;
for (auto it = m_data.begin(); it != m_data.end(); ++it) for (auto it = m_data.begin(); it != m_data.end(); ++it)
{ {
QVector<QStringRef> decrafted = it.key().splitRef(QLatin1Char('.')); const QStringList decrafted = QString(it.key()).split(QLatin1Char('.'));
if (decrafted.size() > 1 && group.compare(decrafted.at(0)) == 0) if (decrafted.size() > 1 && QStringView(group).compare(decrafted.at(0)) == 0)
result.append(decrafted.at(1).toString()); result.append(decrafted.at(0).mid(1));
} }
return result; return result;
} }
@@ -31,6 +31,6 @@ NGL_TARGET_LINK_LIBRARIES(LtsVirtualKeyboard
LtsWidgets LtsWidgets
LtsSession LtsSession
LtsAppManager LtsAppManager
Qt5::Widgets Qt6::Widgets
Qt5::Gui Qt6::Gui
) )
@@ -29,8 +29,8 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsWebSocketCommon
) )
NGL_TARGET_LINK_LIBRARIES(LtsWebSocketCommon NGL_TARGET_LINK_LIBRARIES(LtsWebSocketCommon
Qt5::Core Qt6::Core
Qt5::WebSockets Qt6::WebSockets
NGLLogger NGLLogger
) )
@@ -54,7 +54,7 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsWebSocketServer
) )
NGL_TARGET_LINK_LIBRARIES(LtsWebSocketServer NGL_TARGET_LINK_LIBRARIES(LtsWebSocketServer
Qt5::Core Qt6::Core
LtsWebSocketCommon LtsWebSocketCommon
) )
@@ -74,6 +74,6 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsWebSocketClient
) )
NGL_TARGET_LINK_LIBRARIES(LtsWebSocketClient NGL_TARGET_LINK_LIBRARIES(LtsWebSocketClient
Qt5::Core Qt6::Core
LtsWebSocketCommon LtsWebSocketCommon
) )
@@ -1,6 +1,7 @@
#include "connection_handler.h" #include "connection_handler.h"
#include <utility>
#include "client_connection.h" #include "client_connection.h"
@@ -16,7 +17,7 @@ ConnectionHandler::ConnectionHandler(QObject *parent)
ConnectionHandler::~ConnectionHandler() ConnectionHandler::~ConnectionHandler()
{ {
for (auto connection : qAsConst(m_connections)) for (auto connection : std::as_const(m_connections))
connection->disconnect(this); connection->disconnect(this);
} }
@@ -46,7 +47,7 @@ bool ConnectionHandler::init(const QString &serviceName, unsigned short port)
void ConnectionHandler::sendToAllClients(ReplyMessage *message) void ConnectionHandler::sendToAllClients(ReplyMessage *message)
{ {
for (auto connection : qAsConst(m_connections)) for (auto connection : std::as_const(m_connections))
connection->addReply(new ReplyMessage(*message)); connection->addReply(new ReplyMessage(*message));
delete message; delete message;
@@ -155,8 +155,8 @@ NGL_TARGET_INCLUDE_DIRECTORIES(LtsWidgets
NGL_TARGET_LINK_LIBRARIES(LtsWidgets NGL_TARGET_LINK_LIBRARIES(LtsWidgets
PRIVATE PRIVATE
Qt5::Network # for QHostInfo - for portability Qt6::Network # for QHostInfo - for portability
Qt5::Svg Qt6::Svg
ngltools ngltools
ngltranslator ngltranslator
TabBarTabStyle TabBarTabStyle
@@ -164,9 +164,9 @@ NGL_TARGET_LINK_LIBRARIES(LtsWidgets
LtsUtilsSettings LtsUtilsSettings
PUBLIC PUBLIC
LtsUtilsCore LtsUtilsCore
Qt5::Core Qt6::Core
Qt5::Widgets Qt6::Widgets
Qt5::Gui Qt6::Gui
) )
NGL_INSTALL_TARGET(LtsWidgets) NGL_INSTALL_TARGET(LtsWidgets)
@@ -2,6 +2,7 @@
#include "lts_angle_edit.h" #include "lts_angle_edit.h"
#include <utility>
#include "ui_lts_angle_edit.h" #include "ui_lts_angle_edit.h"
#include <cmath> #include <cmath>
@@ -194,7 +195,7 @@ QString LtsAngleEdit::toString(LtsAngleEdit::AngleUnitType t)
void LtsAngleEdit::onCBoxAngleUnitChanged() void LtsAngleEdit::onCBoxAngleUnitChanged()
{ {
AngleUnitType newUnit = static_cast<AngleUnitType>(m_ui->cBoxAngleUnit->currentData().toInt()); AngleUnitType newUnit = static_cast<AngleUnitType>(m_ui->cBoxAngleUnit->currentData().toInt());
for(auto dbox : qAsConst(m_sBoxMap)) for(auto dbox : std::as_const(m_sBoxMap))
{ {
const double value = getAngleConverted(dbox->value(), newUnit, m_currAngleUnit); const double value = getAngleConverted(dbox->value(), newUnit, m_currAngleUnit);
auto mapVal = m_dboxLimitMap.value(newUnit); auto mapVal = m_dboxLimitMap.value(newUnit);
@@ -2,6 +2,7 @@
#include "lts_base_layout_widget.h" #include "lts_base_layout_widget.h"
#include <utility>
#include "ui_lts_base_layout.h" #include "ui_lts_base_layout.h"
#include "lts_dialog.h" #include "lts_dialog.h"
@@ -629,7 +630,7 @@ void LtsBaseLayoutWidget::slotOperatorMenuClicked()
operatorMenu->setTerminalButton(m_showTerminalButton); operatorMenu->setTerminalButton(m_showTerminalButton);
bool hasOperatorSettings = false; bool hasOperatorSettings = false;
for (const PluginData &pd : qAsConst(m_mapButtons)) for (const PluginData &pd : std::as_const(m_mapButtons))
{ {
if (pd.identifier == QStringLiteral("_OpmShowOperatorSettings")) if (pd.identifier == QStringLiteral("_OpmShowOperatorSettings"))
{ {
@@ -1794,7 +1795,7 @@ bool LtsBaseLayoutWidget::messageIdentifierExists(const QString &identifier) con
return true; return true;
} }
for (const Message &m : qAsConst(m_messageQueue)) for (const Message &m : std::as_const(m_messageQueue))
{ {
if (m.identifier == identifier) if (m.identifier == identifier)
{ {
@@ -2,6 +2,7 @@
#include "lts_date_time_edit.h" #include "lts_date_time_edit.h"
#include <utility>
#include "lts_date_time_edit_p.h" #include "lts_date_time_edit_p.h"
#include "ui_lts_date_time_edit_touch.h" #include "ui_lts_date_time_edit_touch.h"
@@ -1413,7 +1414,7 @@ void LtsDateTimeEdit::onCheckBoxChanged()
} }
bEnable = checkBox()->isChecked(); bEnable = checkBox()->isChecked();
for (auto w : qAsConst(widgets)) for (auto w : std::as_const(widgets))
{ {
if (w) if (w)
w->setEnabled(bEnable); w->setEnabled(bEnable);
@@ -2,6 +2,7 @@
#include "lts_grid_layout.h" #include "lts_grid_layout.h"
#include <utility>
#include <QResizeEvent> #include <QResizeEvent>
namespace LtsWidgets namespace LtsWidgets
@@ -57,10 +58,10 @@ void LtsGridLayout::setMaxColumn(int max)
m_colSize = 0; m_colSize = 0;
for (QWidget *wid : qAsConst(m_widgetList)) for (QWidget *wid : std::as_const(m_widgetList))
removeWidget(wid); removeWidget(wid);
for (QWidget *wid : qAsConst(m_widgetList)) for (QWidget *wid : std::as_const(m_widgetList))
addWidgetInternal(wid); addWidgetInternal(wid);
} }
@@ -2,6 +2,7 @@
#include "lts_multi_range_spinbox.h" #include "lts_multi_range_spinbox.h"
#include <utility>
#include <QEvent> #include <QEvent>
#include <QWheelEvent> #include <QWheelEvent>
@@ -63,7 +64,7 @@ void LtsMultiRangeSpinBox::fixup(QString &str) const
QValidator::State LtsMultiRangeSpinBox::validateAll(QString &input, int &pos) QValidator::State LtsMultiRangeSpinBox::validateAll(QString &input, int &pos)
{ {
for(QPair<int,int> range : qAsConst(m_rangesList)) for(QPair<int,int> range : std::as_const(m_rangesList))
{ {
QIntValidator validator(range.first, range.second); QIntValidator validator(range.first, range.second);
QValidator::State valState = validator.validate(input, pos); QValidator::State valState = validator.validate(input, pos);
@@ -112,7 +113,7 @@ void LtsMultiRangeSpinBox::setRanges(const QVector<QPair<int, int>> &ranges)
QStringList rangeStrings; QStringList rangeStrings;
rangeStrings.reserve(m_rangesList.size()); rangeStrings.reserve(m_rangesList.size());
for (const QPair<int,int> &range : qAsConst(m_rangesList)) for (const QPair<int,int> &range : std::as_const(m_rangesList))
rangeStrings << tr("%1-%2%3").arg(range.first).arg(range.second).arg(suffix()); rangeStrings << tr("%1-%2%3").arg(range.first).arg(range.second).arg(suffix());
setToolTip(tr("Ranges:\n%1").arg(rangeStrings.join(QStringLiteral(",\n")))); setToolTip(tr("Ranges:\n%1").arg(rangeStrings.join(QStringLiteral(",\n"))));
} }
@@ -2,6 +2,7 @@
#include "lts_tool_bar_area.h" #include "lts_tool_bar_area.h"
#include <utility>
#include "ui_lts_tool_bar_area.h" #include "ui_lts_tool_bar_area.h"
#include "lts_drag_icon.h" #include "lts_drag_icon.h"
@@ -259,7 +260,7 @@ bool LtsToolBarArea::setFunctionKey(int fkey, const QString &action)
LtsDragIcon *icon = nullptr; LtsDragIcon *icon = nullptr;
for (LtsDragIcon *ic : qAsConst(m_buttonMap)) for (LtsDragIcon *ic : std::as_const(m_buttonMap))
{ {
if (ic->identifier() == action) if (ic->identifier() == action)
{ {
@@ -275,7 +276,7 @@ bool LtsToolBarArea::setFunctionKey(int fkey, const QString &action)
ShortCut &shorty = m_functionKeys[fkey]; ShortCut &shorty = m_functionKeys[fkey];
for (LtsDragIcon *ic : qAsConst(m_buttonMap)) for (LtsDragIcon *ic : std::as_const(m_buttonMap))
if (ic->identifier() == shorty.identifier) if (ic->identifier() == shorty.identifier)
ic->removeModification(); ic->removeModification();
@@ -322,7 +323,7 @@ void LtsToolBarArea::removeMenuAction(LtsDragIcon *icon)
if (itShortcut.identifier == icon->identifier()) if (itShortcut.identifier == icon->identifier())
itShortcut.clear(); itShortcut.clear();
} }
for (LtsDragIcon *ic : qAsConst(m_foreignButtonMap)) for (LtsDragIcon *ic : std::as_const(m_foreignButtonMap))
{ {
if(ic->identifier() == icon->identifier()) if(ic->identifier() == icon->identifier())
{ {
@@ -9,7 +9,7 @@ ADD_INTERFACE_LIBRARY(
DataPluginInterface DataPluginInterface
${CMAKE_CURRENT_SOURCE_DIR}/data_plugin_interface.h ${CMAKE_CURRENT_SOURCE_DIR}/data_plugin_interface.h
${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/..
Qt5::Core Qt6::Core
) )
# GuiPluginInterface # GuiPluginInterface
@@ -17,7 +17,7 @@ ADD_INTERFACE_LIBRARY(
GuiPluginInterface GuiPluginInterface
${CMAKE_CURRENT_SOURCE_DIR}/gui_plugin_interface.h ${CMAKE_CURRENT_SOURCE_DIR}/gui_plugin_interface.h
${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/..
Qt5::Core LtsWidgets ProjectConfig LtsAppDescriptor LtsUtilsCore Qt6::Core LtsWidgets ProjectConfig LtsAppDescriptor LtsUtilsCore
) )
# projectPluginInterface # projectPluginInterface
@@ -25,7 +25,7 @@ ADD_INTERFACE_LIBRARY(
ProjectPluginInterface ProjectPluginInterface
${CMAKE_CURRENT_SOURCE_DIR}/project_plugin_interface.h ${CMAKE_CURRENT_SOURCE_DIR}/project_plugin_interface.h
${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/..
Qt5::Core Qt6::Core
) )
# stylePluginInterface # stylePluginInterface
@@ -33,7 +33,7 @@ ADD_INTERFACE_LIBRARY(
StylePluginInterface StylePluginInterface
${CMAKE_CURRENT_SOURCE_DIR}/style_plugin_interface.h ${CMAKE_CURRENT_SOURCE_DIR}/style_plugin_interface.h
${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/..
Qt5::Core Qt6::Core
) )
# record_replay_plugin # record_replay_plugin
@@ -41,7 +41,7 @@ ADD_INTERFACE_LIBRARY(
RecordReplayPlugin RecordReplayPlugin
${CMAKE_CURRENT_SOURCE_DIR}/record_replay_plugin.h ${CMAKE_CURRENT_SOURCE_DIR}/record_replay_plugin.h
${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/..
Qt5::Core Qt6::Core
) )
# Topic Replay Interface # Topic Replay Interface
@@ -49,5 +49,5 @@ ADD_INTERFACE_LIBRARY(
TopicReplayInterface TopicReplayInterface
${CMAKE_CURRENT_SOURCE_DIR}/topic_replay_interface.h ${CMAKE_CURRENT_SOURCE_DIR}/topic_replay_interface.h
${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/..
Qt5::Core Qt6::Core
) )
@@ -12,7 +12,7 @@ ADD_INTERFACE_LIBRARY(
TopicEditorInterface TopicEditorInterface
${CMAKE_CURRENT_SOURCE_DIR}/topic_editor_interface.h ${CMAKE_CURRENT_SOURCE_DIR}/topic_editor_interface.h
${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/..
Qt5::Core Qt6::Core
) )
# Library # Library
@@ -41,8 +41,8 @@ NGL_TARGET_INCLUDE_DIRECTORIES(TopicEditorBase
NGL_TARGET_LINK_LIBRARIES(TopicEditorBase NGL_TARGET_LINK_LIBRARIES(TopicEditorBase
LtsScriptTimeline LtsScriptTimeline
Qt5::Widgets Qt6::Widgets
Qt5::Core Qt6::Core
LtsWidgets LtsWidgets
LtsUtilsCore LtsUtilsCore
) )
@@ -24,9 +24,9 @@ NGL_TARGET_INCLUDE_DIRECTORIES(httq
) )
NGL_TARGET_LINK_LIBRARIES(httq NGL_TARGET_LINK_LIBRARIES(httq
Qt5::Core Qt6::Core
Qt5::Network Qt6::Network
Qt5::WebSockets Qt6::WebSockets
) )
NGL_INSTALL_TARGET(httq) NGL_INSTALL_TARGET(httq)
@@ -2,9 +2,6 @@
#ifndef http_parser_h #ifndef http_parser_h
#define http_parser_h #define http_parser_h
#ifdef __cplusplus
extern "C" {
#endif
#define HTTP_PARSER_VERSION_MAJOR 2 #define HTTP_PARSER_VERSION_MAJOR 2
#define HTTP_PARSER_VERSION_MINOR 9 #define HTTP_PARSER_VERSION_MINOR 9
@@ -34,11 +31,19 @@ typedef unsigned __int64 uint64_t;
#define HTTP_MAX_HEADER_SIZE (80 * 1024) #define HTTP_MAX_HEADER_SIZE (80 * 1024)
#endif #endif
using http_parser = struct http_parser; #ifdef __cplusplus
using http_parser_settings = struct http_parser_settings; extern "C" {
#endif
using http_data_cb = int (*)(http_parser *, const char *, size_t); /* Forward declarations */
using http_cb = int (*)(http_parser *); struct http_parser;
struct http_parser_settings;
typedef struct http_parser http_parser;
typedef struct http_parser_settings http_parser_settings;
typedef int (*http_data_cb)(http_parser *, const char *, size_t);
typedef int (*http_cb)(http_parser *);
#define HTTP_STATUS_MAP(XX) \ #define HTTP_STATUS_MAP(XX) \
XX(100, CONTINUE, Continue) \ XX(100, CONTINUE, Continue) \
@@ -4,21 +4,29 @@
# $Author$ # $Author$
# #
ADD_SUBDIRECTORY(DDSConnector) IF(BUILD_RTI)
ADD_SUBDIRECTORY(DDSConnector)
ENDIF()
ADD_SUBDIRECTORY(DTC) ADD_SUBDIRECTORY(DTC)
ADD_SUBDIRECTORY(DTS) ADD_SUBDIRECTORY(DTS)
ADD_SUBDIRECTORY(FTC) IF(BUILD_RTI)
ADD_SUBDIRECTORY(FTC)
ENDIF()
ADD_SUBDIRECTORY(FTS) ADD_SUBDIRECTORY(FTS)
ADD_SUBDIRECTORY(Generic) ADD_SUBDIRECTORY(Generic)
ADD_SUBDIRECTORY(Routing) ADD_SUBDIRECTORY(Routing)
ADD_SUBDIRECTORY(Core) ADD_SUBDIRECTORY(Core)
ADD_SUBDIRECTORY(QosProfile) IF(BUILD_RTI)
ADD_SUBDIRECTORY(QosProfile)
ENDIF()
# During stepwise migration, add placeholder CTest entries before the # During stepwise migration, add placeholder CTest entries before the
# real DdsUnitTests subdir so the test-suite shows migration status even # real DdsUnitTests subdir so the test-suite shows migration status even
# when internal codegen targets are not yet available. # when internal codegen targets are not yet available.
ADD_SUBDIRECTORY(DdsUnitTestsPlaceholder) ADD_SUBDIRECTORY(DdsUnitTestsPlaceholder)
ADD_SUBDIRECTORY(DdsUnitTests) IF(BUILD_RTI)
ADD_SUBDIRECTORY(DdsUnitTests)
ENDIF()
@@ -4,6 +4,8 @@
# $Author$ # $Author$
# #
IF(BUILD_RTI)
INCLUDE(MacroRTIDDSGen) INCLUDE(MacroRTIDDSGen)
INCLUDE(MacroCodeGenIdl) INCLUDE(MacroCodeGenIdl)
@@ -42,7 +44,7 @@ NGL_TARGET_LINK_LIBRARIES(ddscore
PUBLIC PUBLIC
LtsUtilsCoreHeaderOnly LtsUtilsCoreHeaderOnly
ddsdts ddsdts
Qt5::Core Qt6::Core
RTI::nddsc # DDS_GroupDataQosPolicy_initialize (wo auch immer das herkommt) RTI::nddsc # DDS_GroupDataQosPolicy_initialize (wo auch immer das herkommt)
RTI::nddscore # RTI_LOG_ANY_FAILURE_s (wo auch immer das herkommt) RTI::nddscore # RTI_LOG_ANY_FAILURE_s (wo auch immer das herkommt)
RTI::nddscpp2 RTI::nddscpp2
@@ -95,3 +97,5 @@ NGL_INSTALL_TARGET(svcCoreClient)
# --- Topic Type Plugin -------------------------------------------------------------- # --- Topic Type Plugin --------------------------------------------------------------
# #
CREATE_TOPIC_TYPE_PLUGIN(${xml_FILE}) CREATE_TOPIC_TYPE_PLUGIN(${xml_FILE})
ENDIF(BUILD_RTI)
@@ -21,6 +21,7 @@ NGL_TARGET_INCLUDE_DIRECTORIES(
INTERFACE INTERFACE
${CMAKE_CURRENT_SOURCE_DIR}/../../ ${CMAKE_CURRENT_SOURCE_DIR}/../../
) )
IF(BUILD_RTI)
NGL_TARGET_LINK_LIBRARIES(ddsconnector NGL_TARGET_LINK_LIBRARIES(ddsconnector
PRIVATE PRIVATE
NGLLogger NGLLogger
@@ -32,5 +33,17 @@ NGL_TARGET_LINK_LIBRARIES(ddsconnector
ddsdtc ddsdtc
ddsdts ddsdts
ProjectConfig ProjectConfig
Qt5::Core Qt6::Core
) )
ELSE()
NGL_TARGET_LINK_LIBRARIES(ddsconnector
PRIVATE
NGLLogger
PUBLIC
ddsQoS
ddsdtc
ddsdts
ProjectConfig
Qt6::Core
)
ENDIF()
@@ -11,7 +11,7 @@ TARGET_INCLUDE_DIRECTORIES(ddsdtc
) )
TARGET_LINK_LIBRARIES(ddsdtc TARGET_LINK_LIBRARIES(ddsdtc
INTERFACE INTERFACE
Qt5::Core Qt6::Core
ddsgen ddsgen
NGLLogger NGLLogger
LtsUtilsCoreHeaderOnly LtsUtilsCoreHeaderOnly
@@ -11,7 +11,7 @@ TARGET_INCLUDE_DIRECTORIES(ddsdts
) )
TARGET_LINK_LIBRARIES(ddsdts TARGET_LINK_LIBRARIES(ddsdts
INTERFACE INTERFACE
Qt5::Core Qt6::Core
ddsgen ddsgen
NGLLogger NGLLogger
) )
@@ -4,7 +4,7 @@
# $Author$ # $Author$
# #
IF(BUILD_TESTING AND TARGET ddsgen AND TARGET ddsdtc AND TARGET ddsfts AND TARGET ddsQoS) IF(BUILD_TESTING AND BUILD_RTI AND TARGET ddsgen AND TARGET ddsdtc AND TARGET ddsfts AND TARGET ddsQoS)
SET(xml_FILE ddsut.xml) SET(xml_FILE ddsut.xml)
@@ -27,7 +27,7 @@ NGL_TARGET_LINK_LIBRARIES(ddsut_common
NGLLogger NGLLogger
PUBLIC PUBLIC
LtsUtilsCoreHeaderOnly LtsUtilsCoreHeaderOnly
Qt5::Core Qt6::Core
RTI::nddsc RTI::nddsc
RTI::nddscore RTI::nddscore
RTI::nddscpp2 RTI::nddscpp2
@@ -77,8 +77,8 @@ TARGET_LINK_LIBRARIES(ddsGenericDataTests
nglcoreapplication nglcoreapplication
NGLLogger NGLLogger
ProjectConfig ProjectConfig
Qt5::Core Qt6::Core
Qt5::Test Qt6::Test
ddsut_common ddsut_common
) )
ADD_TEST(NAME ddsGenericDataTests COMMAND $<TARGET_FILE:ddsGenericDataTests>) ADD_TEST(NAME ddsGenericDataTests COMMAND $<TARGET_FILE:ddsGenericDataTests>)
@@ -94,8 +94,8 @@ TARGET_LINK_LIBRARIES(ddsDataTopicTests
ddsdtc ddsdtc
ddsQoS ddsQoS
ProjectConfig ProjectConfig
Qt5::Core Qt6::Core
Qt5::Test Qt6::Test
ddsut_common ddsut_common
) )
ADD_TEST(NAME ddsDataTopicTests COMMAND $<TARGET_FILE:ddsDataTopicTests>) ADD_TEST(NAME ddsDataTopicTests COMMAND $<TARGET_FILE:ddsDataTopicTests>)
@@ -111,8 +111,8 @@ TARGET_LINK_LIBRARIES(ddsFunctionTopicTests
nglcoreapplication nglcoreapplication
NGLLogger NGLLogger
ngltools ngltools
Qt5::Core Qt6::Core
Qt5::Test Qt6::Test
ddsut_common ddsut_common
) )
ADD_TEST(NAME ddsFunctionTopicTests COMMAND $<TARGET_FILE:ddsFunctionTopicTests>) ADD_TEST(NAME ddsFunctionTopicTests COMMAND $<TARGET_FILE:ddsFunctionTopicTests>)
@@ -23,21 +23,21 @@ if(BUILD_TESTING)
# Generic data tests smoke (QtTest) # Generic data tests smoke (QtTest)
if(BUILD_SMOKE_TESTS OR NOT TARGET ddsGenericDataTests) if(BUILD_SMOKE_TESTS OR NOT TARGET ddsGenericDataTests)
add_executable(ddsGenericDataTests_smoke ddsGenericDataTests_smoke.cpp mocks/MockDDS.cpp) add_executable(ddsGenericDataTests_smoke ddsGenericDataTests_smoke.cpp mocks/MockDDS.cpp)
target_link_libraries(ddsGenericDataTests_smoke PRIVATE Qt5::Core Qt5::Test) target_link_libraries(ddsGenericDataTests_smoke PRIVATE Qt6::Core Qt6::Test)
add_test(NAME ddsGenericDataTests COMMAND $<TARGET_FILE:ddsGenericDataTests_smoke>) add_test(NAME ddsGenericDataTests COMMAND $<TARGET_FILE:ddsGenericDataTests_smoke>)
endif() endif()
# Data topic tests smoke (QtTest) # Data topic tests smoke (QtTest)
if(BUILD_SMOKE_TESTS OR NOT TARGET ddsDataTopicTests) if(BUILD_SMOKE_TESTS OR NOT TARGET ddsDataTopicTests)
add_executable(ddsDataTopicTests_smoke ddsDataTopicTests_smoke.cpp mocks/MockDDS.cpp) add_executable(ddsDataTopicTests_smoke ddsDataTopicTests_smoke.cpp mocks/MockDDS.cpp)
target_link_libraries(ddsDataTopicTests_smoke PRIVATE Qt5::Core Qt5::Test) target_link_libraries(ddsDataTopicTests_smoke PRIVATE Qt6::Core Qt6::Test)
add_test(NAME ddsDataTopicTests COMMAND $<TARGET_FILE:ddsDataTopicTests_smoke>) add_test(NAME ddsDataTopicTests COMMAND $<TARGET_FILE:ddsDataTopicTests_smoke>)
endif() endif()
# Function topic tests smoke (QtTest) # Function topic tests smoke (QtTest)
if(BUILD_SMOKE_TESTS OR NOT TARGET ddsFunctionTopicTests) if(BUILD_SMOKE_TESTS OR NOT TARGET ddsFunctionTopicTests)
add_executable(ddsFunctionTopicTests_smoke ddsFunctionTopicTests_smoke.cpp mocks/MockDDS.cpp) add_executable(ddsFunctionTopicTests_smoke ddsFunctionTopicTests_smoke.cpp mocks/MockDDS.cpp)
target_link_libraries(ddsFunctionTopicTests_smoke PRIVATE Qt5::Core Qt5::Test) target_link_libraries(ddsFunctionTopicTests_smoke PRIVATE Qt6::Core Qt6::Test)
add_test(NAME ddsFunctionTopicTests COMMAND $<TARGET_FILE:ddsFunctionTopicTests_smoke>) add_test(NAME ddsFunctionTopicTests COMMAND $<TARGET_FILE:ddsFunctionTopicTests_smoke>)
endif() endif()
@@ -11,9 +11,10 @@ TARGET_INCLUDE_DIRECTORIES(ddsftc
INTERFACE INTERFACE
${CMAKE_CURRENT_SOURCE_DIR}/../../ ${CMAKE_CURRENT_SOURCE_DIR}/../../
) )
IF(BUILD_RTI)
TARGET_LINK_LIBRARIES(ddsftc TARGET_LINK_LIBRARIES(ddsftc
INTERFACE INTERFACE
Qt5::Core Qt6::Core
ddsfts_connext ddsfts_connext
ddscore # due to the usage of Core::FtReplyState inside generic_ftc_impl.h, only on core.hpp - fixme :/ ddscore # due to the usage of Core::FtReplyState inside generic_ftc_impl.h, only on core.hpp - fixme :/
ddsgen ddsgen
@@ -23,6 +24,17 @@ TARGET_LINK_LIBRARIES(ddsftc
ddsftccore ddsftccore
LtsUtilsCoreHeaderOnly LtsUtilsCoreHeaderOnly
) )
ELSE()
TARGET_LINK_LIBRARIES(ddsftc
INTERFACE
Qt6::Core
ddscore
ddsgen
ddsQoS
ddsftccore
LtsUtilsCoreHeaderOnly
)
ENDIF()
SET(SRCS SET(SRCS
${CMAKE_CURRENT_SOURCE_DIR}/generic_ftc.h ${CMAKE_CURRENT_SOURCE_DIR}/generic_ftc.h
${CMAKE_CURRENT_SOURCE_DIR}/generic_ftc.cpp ${CMAKE_CURRENT_SOURCE_DIR}/generic_ftc.cpp
@@ -42,7 +54,7 @@ NGL_TARGET_INCLUDE_DIRECTORIES(ddsftccore
) )
NGL_TARGET_LINK_LIBRARIES(ddsftccore NGL_TARGET_LINK_LIBRARIES(ddsftccore
PUBLIC PUBLIC
Qt5::Core Qt6::Core
ddscore ddscore
) )
NGL_INSTALL_TARGET(ddsftccore) NGL_INSTALL_TARGET(ddsftccore)
@@ -4,6 +4,7 @@
# $Author$ # $Author$
# #
IF(BUILD_RTI)
ADD_LIBRARY(ddsfts_connext INTERFACE) ADD_LIBRARY(ddsfts_connext INTERFACE)
TARGET_INCLUDE_DIRECTORIES(ddsfts_connext TARGET_INCLUDE_DIRECTORIES(ddsfts_connext
INTERFACE INTERFACE
@@ -17,7 +18,7 @@ SET(SRCS
${CMAKE_CURRENT_SOURCE_DIR}/connext.h ${CMAKE_CURRENT_SOURCE_DIR}/connext.h
) )
TARGET_SOURCES(ddsfts_connext INTERFACE ${SRCS}) TARGET_SOURCES(ddsfts_connext INTERFACE ${SRCS})
ENDIF()
SET(SRCS SET(SRCS
generic_fts.h ;# Interface generic_fts.h ;# Interface
@@ -31,15 +32,26 @@ NGL_TARGET_INCLUDE_DIRECTORIES(
INTERFACE INTERFACE
${CMAKE_CURRENT_SOURCE_DIR}/../../ ${CMAKE_CURRENT_SOURCE_DIR}/../../
) )
IF(BUILD_RTI)
NGL_TARGET_LINK_LIBRARIES(ddsfts NGL_TARGET_LINK_LIBRARIES(ddsfts
PRIVATE PRIVATE
RTI::nddscore RTI::nddscore
ProjectConfig ProjectConfig
ddsQoS ddsQoS
PUBLIC PUBLIC
Qt5::Core Qt6::Core
RTI::nddsc RTI::nddsc
RTI::nddscpp2 RTI::nddscpp2
ddsgen ddsgen
ddsfts_connext ddsfts_connext
) )
ELSE()
NGL_TARGET_LINK_LIBRARIES(ddsfts
PRIVATE
ProjectConfig
ddsQoS
PUBLIC
Qt6::Core
ddsgen
)
ENDIF()
@@ -4,6 +4,8 @@
# $Author$ # $Author$
# #
IF(BUILD_RTI)
FIND_PACKAGE(Threads REQUIRED) FIND_PACKAGE(Threads REQUIRED)
SET(ddsgen_SRCS SET(ddsgen_SRCS
@@ -30,7 +32,7 @@ NGL_TARGET_INCLUDE_DIRECTORIES(ddsgen
NGL_TARGET_LINK_LIBRARIES(ddsgen NGL_TARGET_LINK_LIBRARIES(ddsgen
PUBLIC PUBLIC
${CMAKE_THREAD_LIBS_INIT} ${CMAKE_THREAD_LIBS_INIT}
Qt5::Core Qt6::Core
RTI::nddscpp2 RTI::nddscpp2
NGLLogger NGLLogger
LtsUtilsCoreHeaderOnly LtsUtilsCoreHeaderOnly
@@ -40,4 +42,6 @@ NGL_TARGET_LINK_LIBRARIES(ddsgen
ADD_LIBRARY(topic_type_plugin INTERFACE) ADD_LIBRARY(topic_type_plugin INTERFACE)
TARGET_SOURCES(topic_type_plugin INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/topic_type_plugin.h) TARGET_SOURCES(topic_type_plugin INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/topic_type_plugin.h)
TARGET_INCLUDE_DIRECTORIES(topic_type_plugin INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/../../) TARGET_INCLUDE_DIRECTORIES(topic_type_plugin INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/../../)
TARGET_LINK_LIBRARIES(topic_type_plugin INTERFACE ddsgen Qt5::Core) TARGET_LINK_LIBRARIES(topic_type_plugin INTERFACE ddsgen Qt6::Core)
ENDIF(BUILD_RTI)
@@ -4,6 +4,8 @@
# $Author$ # $Author$
# #
IF(BUILD_RTI)
SET(SRCS SET(SRCS
DDS_DefaultQos.h DDS_DefaultQos.h
DDS_DefaultQos.cpp DDS_DefaultQos.cpp
@@ -31,5 +33,7 @@ NGL_TARGET_LINK_LIBRARIES(ddsQoS
NGLLogger NGLLogger
ngltools ngltools
PUBLIC PUBLIC
Qt5::Core Qt6::Core
) )
ENDIF(BUILD_RTI)
@@ -26,7 +26,7 @@ ADD_INTERFACE_LIBRARY(AsbGuiPluginInterface
${CMAKE_CURRENT_SOURCE_DIR}/asb_gui_plugin_interface.h ${CMAKE_CURRENT_SOURCE_DIR}/asb_gui_plugin_interface.h
${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/..
GuiPluginInterface GuiPluginInterface
Qt5::Core Qt6::Core
) )
# #
@@ -36,5 +36,5 @@ ADD_INTERFACE_LIBRARY(AsbSymbolProxyGuiPluginInterface
${CMAKE_CURRENT_SOURCE_DIR}/asb_symbol_proxy_gui_plugin_interface.h ${CMAKE_CURRENT_SOURCE_DIR}/asb_symbol_proxy_gui_plugin_interface.h
${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/..
GuiPluginInterface GuiPluginInterface
Qt5::Gui Qt6::Gui
) )
@@ -33,7 +33,7 @@ NGL_ADD_LIBRARY(WS AsbDataPlugin MODULE
NGL_TARGET_LINK_LIBRARIES(AsbDataPlugin NGL_TARGET_LINK_LIBRARIES(AsbDataPlugin
AsbData AsbData
Qt5::Core Qt6::Core
AsbDataPluginInterface AsbDataPluginInterface
GimDataPluginInterface GimDataPluginInterface
svcAesCommon svcAesCommon
@@ -51,7 +51,7 @@ NGL_ADD_LIBRARY(WS AsbForeignDataPluginThp STATIC
) )
NGL_TARGET_LINK_LIBRARIES(AsbForeignDataPluginThp NGL_TARGET_LINK_LIBRARIES(AsbForeignDataPluginThp
AsbData AsbData
Qt5::Core Qt6::Core
AsbDataPluginInterface AsbDataPluginInterface
GimDataPluginInterface GimDataPluginInterface
svcAesCommon svcAesCommon
@@ -47,8 +47,8 @@ NGL_TARGET_LINK_LIBRARIES(AsbSymEditGuiPlugin
LtsSession LtsSession
LtsSessionData LtsSessionData
LtsUtilsGuiDds LtsUtilsGuiDds
Qt5::Core Qt6::Core
Qt5::Gui Qt6::Gui
Qt5::Widgets Qt6::Widgets
) )
NGL_INSTALL_TARGET(AsbSymEditGuiPlugin) NGL_INSTALL_TARGET(AsbSymEditGuiPlugin)
Loaded 100 of 2395 files, more files were not shown because too many files have changed in this diff. Show more