Merge feature/lts-viewer-validation-testing-phase into feature/qt6-migration-basis-modules-merge

Resolves 1 conflict (new_docker_build.sh, union of viewer-only + codification options); folds in fixes for pre-existing defects surfaced by the validation runs (KDReports-qt6 wiring, LtsSession RTI linking, LtsFileDialog/WLS/BSM Qt6/RTI API migration, GROUP4 target list, new --cmake_build_flags option); validated with BUILD_RTI=ON BUILD_GRANTLEE=ON in 3 Docker runs (run 3: build green, 6 base-state first-run CTest failures documented).

qt6-after/qt6-migrated-legatus/Lts/Common/LtsSession/lts_session_data_dds.cpp

@@ -20,30 +20,6 @@
 #include <QtCore/QSet>
 #include <QtCore/QVector>
 
-namespace
-{
-// Convert LtsSession::PartitionType to IDL::PartitionType
-IDL::PartitionType toIdlPartitionType(LtsSession::PartitionType type)
-{
-    switch (type)
-    {
-        case LtsSession::PartitionType::Any:
-            return IDL::PartitionType::Any;
-        case LtsSession::PartitionType::Global:
-            return IDL::PartitionType::Global;
-        case LtsSession::PartitionType::Exercise:
-            return IDL::PartitionType::Exercise;
-        case LtsSession::PartitionType::AllExercises:
-            return IDL::PartitionType::AllExercises;
-        case LtsSession::PartitionType::Replay:
-            return IDL::PartitionType::Replay;
-        case LtsSession::PartitionType::Invalid:
-        default:
-            return IDL::PartitionType::Any;
-    }
-}
-} // namespace
-
 namespace LtsSession
 {
 /**
@@ -74,7 +50,7 @@ class DdsConnectionContainer
         for (int i = ddsConnections.size() - 1; i >= 0; --i)
         {
             const DdsConnection& conn = ddsConnections.at(i);
-            if (toIdlPartitionType(conn.partitionType) != IDL::PartitionType::Global)
+            if (conn.partitionType != IDL::PartitionType::Global)
                 continue;
             auto ret = conn.ddsConnector.lock();
             if (ret != nullptr)
@@ -242,7 +218,7 @@ bool LtsSessionDataDds::init(const DdsConnectionParams& connParams)
 #endif
 
         m_ddsConnector = std::make_shared<DDSConnector::DdsConnector>(
-            connParams.domainId, toIdlPartitionType(connParams.partitionType), connParams.partitionId,
+            connParams.domainId, connParams.partitionType, connParams.partitionId,
             connParams.exerciseId, // same as partition Id in live but not in replay
             type);
         s_ddsConnections()->insertConnection(connParams, m_ddsConnector);
@@ -277,7 +253,7 @@ bool LtsSessionDataDds::init(const dds::domain::DomainParticipant& dp, const Dds
         if (m_ddsConnector == nullptr)
         {
             m_ddsConnector =
-                std::make_shared<DDSConnector::DdsConnector>(dp, toIdlPartitionType(connParams.partitionType), type, connParams.partitionId);
+                std::make_shared<DDSConnector::DdsConnector>(dp, connParams.partitionType, type, connParams.partitionId);
 
             s_ddsConnections()->insertConnection(connParams, m_ddsConnector);
         }
@@ -292,38 +268,27 @@ Fetcher* LtsSessionDataDds::fetcher(const QString& yourPluginsName)
     return m_fetcher;
 }
 
-QString LtsSessionDataDds::partitionTypeString(PartitionType partitionType)
+QString LtsSessionDataDds::partitionTypeString(IDL::PartitionType partitionType)
 {
     switch (partitionType)
     {
-        case PartitionType::AllExercises:
+        case IDL::PartitionType::AllExercises:
             return QStringLiteral("AllExercises");
-        case PartitionType::Any:
+        case IDL::PartitionType::Any:
             return QStringLiteral("Any");
-        case PartitionType::Exercise:
+        case IDL::PartitionType::Exercise:
             return QStringLiteral("Exercise");
-        case PartitionType::Global:
+        case IDL::PartitionType::Global:
             return QStringLiteral("Global");
-        case PartitionType::Replay:
+        case IDL::PartitionType::Replay:
             return QStringLiteral("Replay");
+        default:
+            break;
     }
 
     return QStringLiteral("Invalid (%1)").arg(int(partitionType));
 }
 
-LtsSession::PartitionType LtsSessionDataDds::toPartitionType(IDL::PartitionType idlType)
-{
-    switch (idlType)
-    {
-        case IDL::PartitionType::Any: return PartitionType::Any;
-        case IDL::PartitionType::Exercise: return PartitionType::Exercise;
-        case IDL::PartitionType::Replay: return PartitionType::Replay;
-        case IDL::PartitionType::AllExercises: return PartitionType::AllExercises;
-        case IDL::PartitionType::Global: return PartitionType::Global;
-        default: return PartitionType::Invalid;
-    }
-}
-
 QString LtsSessionDataDds::toString() const
 {
     return QStringLiteral("(LtsSessionDataDds: id=%1, partitionId=%2, partitionType=%3(%4), exerciseId=%5)")
@@ -349,9 +314,9 @@ int LtsSessionDataDds::partitionId() const
     return m_ddsConnector ? m_ddsConnector->getPartitionId() : -1;
 }
 
-PartitionType LtsSessionDataDds::partitionType() const
+IDL::PartitionType LtsSessionDataDds::partitionType() const
 {
-    return m_ddsConnector ? toPartitionType(m_ddsConnector->getPartitionType()) : PartitionType::Global;
+    return m_ddsConnector ? m_ddsConnector->getPartitionType() : IDL::PartitionType::Global;
 }
 
 QStringList LtsSessionDataDds::qosFile() const
@@ -394,7 +359,7 @@ bool LtsSessionDataDds::initInternal()
     assert(m_dtcPartitionTime.get());
 
     m_dtcPartitionTime->setSubscriberCallback([this](const Core::PartitionTime& data, DataModification) {
-        m_curMSecSinceEpoch = data.timeStamp();
+        m_curMSecSinceEpoch = data.timeStamp;
         emit partitionTimeChangedInternal();
     });
     connect(this, &LtsSessionDataDds::partitionTimeChangedInternal, this,