Clean up stale comments and blank lines in FTC/FTS and nglapplication unit-test

Drop the Qt6-migration explanatory comments (rtiddsgen setter notes,
Log4Qt/BUILDING_NGLLOGGER notes, the INTERFACE-to-STATIC note, the
return_loan comment block) and the stray blank lines. No code changes:
this is the state the last full green run (build + 22/22 ctest +
coverage + DEB) was built from.
This commit is contained in:
berrux-dev committed 2026-11-21 09:25:55 +01:00
1 parent e8d7aa7bd6
commit b1662eddfa
10 files changed
+3 -104

No files matched your search

@@ -53,18 +53,10 @@ void Threading::preInit() const
m_partitionId = partitionId();
m_partitionType = partitionType();
const QString base(QStringLiteral("F%1%2").arg(m_partitionType.left(1)).arg(m_partitionId));
const int baseLen = base.length();
const int maxLen = 16 - 1 - baseLen;
if (maxLen < 1)
{
Q_ASSERT(false);
@@ -96,8 +88,6 @@ void Threading::preInit() const
}
int wordsLeft = words.count();
if (wordsLeft < 1)
{
Q_ASSERT(false);
@@ -124,25 +114,16 @@ void Threading::preInit() const
}
const int maxWordLen = lenRest / wordsLeft;
if (words.isEmpty())
{
Q_ASSERT(false);
break;
}
name += words.takeFirst().left(maxWordLen);
wordsLeft--;
}
const int finalLeft = maxLen - name.size();
if (finalLeft < 0 || (finalLeft > 0 && functionTopicName().length() > maxLen))
{
@@ -157,48 +138,36 @@ void Threading::preInit() const
m_threadName = QStringLiteral("%1%2[%3]").arg(base, name).arg(QRandomGenerator::global()->bounded(0x100000000LL), 8, 16, QLatin1Char('0'));
}
const QString &Threading::threadName() const
{
if (m_threadName.isEmpty())
{
Q_ASSERT(false);
}
return m_threadName;
}
const char *Threading::posixThreadName() const
{
if (m_posixThreadName.empty())
{
m_posixThreadName = threadName().left(15).toStdString();
}
return m_posixThreadName.c_str();
}
void Threading::createThread()
{
if (!isRun())
{
if (m_thread.joinable())
{
m_condition.notify_all();
m_thread.join();
threadDone();
}
m_alreadyThreaded = 0;
setRun(true);
m_thread = std::thread(&Threading::run, this, threadName());
#ifdef Q_OS_LINUX
@@ -213,7 +182,6 @@ void Threading::createThread()
void Threading::runThread()
{
m_used = true;
Q_ASSERT(m_createThreadCalledBefore);
m_createThreadCalledBefore = false;
@@ -243,7 +211,6 @@ void Threading::runThread()
if (workAvailable || working)
{
m_threadLifetime->start();
return;
}
@@ -253,13 +220,10 @@ void Threading::runThread()
if (!run)
{
Q_ASSERT(false);
return;
}
{
std::lock_guard<std::mutex> l(m_conditionMutex);
setRun(false);
@@ -271,7 +235,6 @@ void Threading::runThread()
m_threadLifetime->start();
}
void Threading::run(const QString &threadName)
{
Q_ASSERT(m_alreadyThreaded == 0);
@@ -286,8 +249,6 @@ void Threading::run(const QString &threadName)
{
{
std::unique_lock<std::mutex> conditionLock(m_conditionMutex);
m_condition.wait(conditionLock, [this]{ return (isWorkAvailable() || !isRun()); });
}