TetraIF migration and Unittest Implementation for it
Entire-Checkpoint: 14d1fef0cf36
This commit is contained in:
1 parent
a86f9b5bac
commit
ba212f9dce
78 files changed
+1611
-640
No files matched your search
@@ -37,3 +37,8 @@ NGL_TARGET_INCLUDE_DIRECTORIES(CoPrtCnv
|
||||
${CMAKE_CURRENT_SOURCE_DIR}/../
|
||||
${CMAKE_CURRENT_BINARY_DIR}
|
||||
)
|
||||
|
||||
# Unit tests (LTS_HAVE_GTEST is set by the top-level CMakeLists.txt)
|
||||
if(BUILD_TESTING AND LTS_HAVE_GTEST)
|
||||
add_subdirectory(unittest)
|
||||
endif()
|
||||
@@ -16,6 +16,7 @@
|
||||
#include "CoPrtCnvRadioTelegram.hpp"
|
||||
|
||||
#include <QtCore/QByteArray>
|
||||
#include <QtCore/QString>
|
||||
#include <NGLLogger/NGLLoggerBootstrap.h>
|
||||
|
||||
static std::string dumpSammeldeaktivierung(const N_CoPrtCnv::CoPrtCnvRadioTelegram* sammelTelegram)
|
||||
@@ -129,7 +130,7 @@ QByteArray telegramId2String(gef_telegramm_id_et telId)
|
||||
Q_ASSERT(str);
|
||||
if (!str)
|
||||
str = "Unknown";
|
||||
return str + QByteArray(" (") + QByteArray::number(int(telId)) + ")";
|
||||
return QByteArray(str) + QByteArray(" (") + QByteArray::number(static_cast<int>(telId)) + ")";
|
||||
}
|
||||
|
||||
QString wirkfeldTyp2Str(TrainingAreaBase::TetraIcd::AreaEffectSimulationType wirkfeldTyp)
|
||||
@@ -137,29 +138,29 @@ QString wirkfeldTyp2Str(TrainingAreaBase::TetraIcd::AreaEffectSimulationType wir
|
||||
switch(wirkfeldTyp)
|
||||
{
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::MineArea:
|
||||
return QLatin1String("MINENSPERRE");
|
||||
return QStringLiteral("MINENSPERRE");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::ExplosionArea:
|
||||
return QLatin1String("FLAECHENFEUER");
|
||||
return QStringLiteral("FLAECHENFEUER");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::ExplosionSingle:
|
||||
return QLatin1String("EINZELFEUER");
|
||||
return QStringLiteral("EINZELFEUER");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::NContamination:
|
||||
return QLatin1String("A_KAMPF");
|
||||
return QStringLiteral("A_KAMPF");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::CContamination:
|
||||
return QLatin1String("C_KAMPF");
|
||||
return QStringLiteral("C_KAMPF");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::FunctionalArea:
|
||||
return QLatin1String("FUNKTIONS_RAUM");
|
||||
return QStringLiteral("FUNKTIONS_RAUM");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::TechnicalArea:
|
||||
return QLatin1String("FUNKTIONS_RAUM_TECHNIK");
|
||||
return QStringLiteral("FUNKTIONS_RAUM_TECHNIK");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::GasPipeDetonation:
|
||||
return QLatin1String("GAS_PIPE_DETONATION");
|
||||
return QStringLiteral("GAS_PIPE_DETONATION");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::SpecialArea:
|
||||
return QLatin1String("SPECIAL_AREA");
|
||||
return QStringLiteral("SPECIAL_AREA");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::Unknown:
|
||||
return QLatin1String("DUS");
|
||||
return QStringLiteral("DUS");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::DusSingleMineSimulator:
|
||||
return QLatin1String("DUS_SINGLE_MINE_SIMULATOR");
|
||||
return QStringLiteral("DUS_SINGLE_MINE_SIMULATOR");
|
||||
case TrainingAreaBase::TetraIcd::AreaEffectSimulationType::BeStillWarning:
|
||||
return QLatin1String("BE_STILL_WARNING");
|
||||
return QStringLiteral("BE_STILL_WARNING");
|
||||
}
|
||||
return QStringLiteral("Unknown Wirkfeldtyp <%1>").arg(static_cast<int>(wirkfeldTyp));
|
||||
}
|
||||
|
||||
@@ -14,6 +14,7 @@
|
||||
#pragma once
|
||||
|
||||
#include <QtCore/QString>
|
||||
#include <QtCore/QByteArray>
|
||||
#include <NGLLogger/INGLLogger.h>
|
||||
#include <TrainingAreaBase/training_area_telegrams.h>
|
||||
#include "coprtcnv_export.h"
|
||||
@@ -24,9 +25,10 @@ namespace N_CoPrtCnv
|
||||
class CoPrtCnvRadioTelegram;
|
||||
}
|
||||
|
||||
COPRTCNV_EXPORT QByteArray telegramId2String(gef_telegramm_id_et telId);
|
||||
// Qt6/C++17: [[nodiscard]] indicates return value should not be ignored
|
||||
[[nodiscard]] COPRTCNV_EXPORT QByteArray telegramId2String(gef_telegramm_id_et telId);
|
||||
COPRTCNV_EXPORT void dumpTelegram(NGL::INGLLogger &m_logger,
|
||||
int id,
|
||||
N_CoPrtCnv::CoPrtCnvRadioTelegram *a_radioTelegram,
|
||||
const char *prefix = nullptr);
|
||||
COPRTCNV_EXPORT QString wirkfeldTyp2Str(TrainingAreaBase::TetraIcd::AreaEffectSimulationType wirkfeldTyp);
|
||||
[[nodiscard]] COPRTCNV_EXPORT QString wirkfeldTyp2Str(TrainingAreaBase::TetraIcd::AreaEffectSimulationType wirkfeldTyp);
|
||||
@@ -296,13 +296,13 @@ uint32_t CoPrtCnvRadioTelegram::getPayloadDataUInt32(size_t a_offset, uint16_t a
|
||||
{
|
||||
case 4:
|
||||
ptrValue[3] = ptr[a_offset++];
|
||||
Q_FALLTHROUGH();
|
||||
[[fallthrough]];
|
||||
case 3:
|
||||
ptrValue[2] = ptr[a_offset++];
|
||||
Q_FALLTHROUGH();
|
||||
[[fallthrough]];
|
||||
case 2:
|
||||
ptrValue[1] = ptr[a_offset++];
|
||||
Q_FALLTHROUGH();
|
||||
[[fallthrough]];
|
||||
case 1:
|
||||
ptrValue[0] = ptr[a_offset++];
|
||||
break;
|
||||
@@ -949,7 +949,7 @@ bool CoPrtCnvRadioTelegram::isContentValid()
|
||||
case GEF_WIRKFELD_EINZELMINENSIMULATOR:
|
||||
wirkfeldkennung = getPayloadDataUInt32(5, 2);
|
||||
wirkfeldtyp = 3;
|
||||
Q_FALLTHROUGH();
|
||||
[[fallthrough]];
|
||||
case GEF_DEAKTIVIERUNG_WIRKFELD:
|
||||
case GEF_WIRKFELD_AENDERUNG_BEZEICHNER:
|
||||
if (GEF_DEAKTIVIERUNG_WIRKFELD == getTelID() || GEF_WIRKFELD_AENDERUNG_BEZEICHNER == getTelID())
|
||||
@@ -1239,7 +1239,7 @@ bool CoPrtCnvRadioTelegram::mustBeSentAsBroadcast(time_t a_currentTime, bool& a_
|
||||
break;
|
||||
}
|
||||
++m_BroadcastCounter;
|
||||
Q_FALLTHROUGH();
|
||||
[[fallthrough]];
|
||||
case 1:
|
||||
if (s_3rdDelay >= 0)
|
||||
{
|
||||
@@ -1249,7 +1249,7 @@ bool CoPrtCnvRadioTelegram::mustBeSentAsBroadcast(time_t a_currentTime, bool& a_
|
||||
break;
|
||||
}
|
||||
++m_BroadcastCounter;
|
||||
Q_FALLTHROUGH();
|
||||
[[fallthrough]];
|
||||
default:
|
||||
INFO_LOG(m_logger) << "3rd Broadcast-Telegram telId=" << getTelID()
|
||||
<< " BC=" << getBroadcastIndex();
|
||||
|
||||
@@ -0,0 +1,20 @@
|
||||
# Unit tests for the CoPrtCnv library.
|
||||
# GoogleTest is resolved once in the top-level CMakeLists.txt.
|
||||
|
||||
add_executable(CoPrtCnvTests
|
||||
${CMAKE_CURRENT_SOURCE_DIR}/../../unittest_main.cpp
|
||||
CoPrtCnvRadioTelegramTest.cpp
|
||||
)
|
||||
|
||||
target_include_directories(CoPrtCnvTests PRIVATE
|
||||
${CMAKE_CURRENT_SOURCE_DIR}/..
|
||||
)
|
||||
|
||||
target_link_libraries(CoPrtCnvTests PRIVATE
|
||||
CoPrtCnv
|
||||
Qt6::Core
|
||||
GTest::gtest
|
||||
)
|
||||
|
||||
include(GoogleTest)
|
||||
gtest_discover_tests(CoPrtCnvTests)
|
||||
+167
@@ -0,0 +1,167 @@
|
||||
/**
|
||||
* @file CoPrtCnvRadioTelegramTest.cpp
|
||||
* @brief Unit tests for N_CoPrtCnv::CoPrtCnvRadioTelegram.
|
||||
*
|
||||
* Covers the constructors that build a telegram from scratch, the header
|
||||
* accessors (ISSIs, telegram id, PDU type, identity) and the payload helpers.
|
||||
* Payload words are stored MSB first, which several of these tests pin down.
|
||||
*/
|
||||
|
||||
#include <gtest/gtest.h>
|
||||
|
||||
#include <QtCore/QByteArray>
|
||||
|
||||
#include "CoPrtCnvRadioTelegram.hpp"
|
||||
#include "tetra_telegram_ids.h"
|
||||
|
||||
using N_CoPrtCnv::CoPrtCnvRadioTelegram;
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, RegisterIndCarriesSourceIssi)
|
||||
{
|
||||
const uint32_t sourceISSI = 0x123456;
|
||||
const CoPrtCnvRadioTelegram telegram(sourceISSI);
|
||||
|
||||
EXPECT_EQ(telegram.getSrcISSI(), sourceISSI);
|
||||
EXPECT_EQ(telegram.getPDU_Type(), CoPrtCnvRadioTelegram::e_RegisterInd);
|
||||
EXPECT_EQ(telegram.getSize(), 9);
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, HeaderStartsWithMagicNumber)
|
||||
{
|
||||
const CoPrtCnvRadioTelegram telegram(1234);
|
||||
|
||||
ASSERT_GT(telegram.getSize(), 0);
|
||||
EXPECT_EQ(static_cast<uint8_t>(telegram.data().at(0)), CoPrtCnvRadioTelegram::MAGIC_NUMBER);
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, SetSrcIssiOverwritesPreviousValue)
|
||||
{
|
||||
CoPrtCnvRadioTelegram telegram(1);
|
||||
|
||||
telegram.setSrcISSI(0xABCDEF);
|
||||
EXPECT_EQ(telegram.getSrcISSI(), 0xABCDEFu);
|
||||
|
||||
telegram.setSrcISSI(0);
|
||||
EXPECT_EQ(telegram.getSrcISSI(), 0u);
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, TelegramIdConstructorSetsIdAndIdentity)
|
||||
{
|
||||
const uint16_t payloadSize = 8;
|
||||
const uint16_t identity = 0x0042;
|
||||
const CoPrtCnvRadioTelegram telegram(GEF_POSITIONS_MELDUNG, payloadSize, identity);
|
||||
|
||||
EXPECT_EQ(telegram.getTelID(), GEF_POSITIONS_MELDUNG);
|
||||
EXPECT_EQ(telegram.getIdentity(), identity);
|
||||
EXPECT_EQ(telegram.getPDU_Type(), CoPrtCnvRadioTelegram::e_DataIndReq);
|
||||
EXPECT_EQ(telegram.getSize(),
|
||||
payloadSize + CoPrtCnvRadioTelegram::DATA_IND_REQ_HEADER_LENGTH);
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, TelegramIdConstructorProducesANormalTelegram)
|
||||
{
|
||||
const CoPrtCnvRadioTelegram telegram(GEF_POSITIONS_MELDUNG, 8, 0);
|
||||
|
||||
EXPECT_TRUE(telegram.isNormalTelegram());
|
||||
EXPECT_FALSE(telegram.isLoginTelegram());
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, SetIdentityIsReadBack)
|
||||
{
|
||||
CoPrtCnvRadioTelegram telegram(GEF_POSITIONS_MELDUNG, 8, 0);
|
||||
|
||||
telegram.setIdentity(0x1234);
|
||||
EXPECT_EQ(telegram.getIdentity(), 0x1234);
|
||||
// The identity lives behind the telegram id, which must survive the write.
|
||||
EXPECT_EQ(telegram.getTelID(), GEF_POSITIONS_MELDUNG);
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, TelegramIdIsTruncatedToASingleByte)
|
||||
{
|
||||
// The telegram id is written into one payload byte, so ids of 256 and above
|
||||
// are stored truncated. GEF_GEFECHTSFELDTELEGRAMM (300) reads back as 44.
|
||||
const CoPrtCnvRadioTelegram telegram(GEF_GEFECHTSFELDTELEGRAMM, 8, 0);
|
||||
|
||||
EXPECT_EQ(static_cast<int>(telegram.getTelID()), GEF_GEFECHTSFELDTELEGRAMM & 0xFF);
|
||||
EXPECT_NE(static_cast<int>(telegram.getTelID()), int(GEF_GEFECHTSFELDTELEGRAMM));
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, PayloadWordsAreStoredMostSignificantByteFirst)
|
||||
{
|
||||
CoPrtCnvRadioTelegram telegram(GEF_POSITIONS_MELDUNG, 8, 0);
|
||||
|
||||
telegram.setPayloadDataWithIndex(4, 0x00112233, 4);
|
||||
|
||||
EXPECT_EQ(telegram.getPayloadDataUInt32(4, 4), 0x00112233u);
|
||||
EXPECT_EQ(telegram.getPayloadDataUInt8(4), 0x00);
|
||||
EXPECT_EQ(telegram.getPayloadDataUInt8(5), 0x11);
|
||||
EXPECT_EQ(telegram.getPayloadDataUInt8(6), 0x22);
|
||||
EXPECT_EQ(telegram.getPayloadDataUInt8(7), 0x33);
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, PayloadDataUInt32HonoursRequestedWidth)
|
||||
{
|
||||
CoPrtCnvRadioTelegram telegram(GEF_POSITIONS_MELDUNG, 8, 0);
|
||||
|
||||
telegram.setPayloadDataWithIndex(4, 0x00112233, 4);
|
||||
|
||||
EXPECT_EQ(telegram.getPayloadDataUInt32(4, 1), 0x00u);
|
||||
EXPECT_EQ(telegram.getPayloadDataUInt32(5, 2), 0x1122u);
|
||||
EXPECT_EQ(telegram.getPayloadDataUInt32(5, 3), 0x112233u);
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, ConstructingFromRawDataPreservesBytes)
|
||||
{
|
||||
const CoPrtCnvRadioTelegram source(0x00ABCD);
|
||||
const QByteArray raw = source.data();
|
||||
|
||||
const CoPrtCnvRadioTelegram restored(raw);
|
||||
|
||||
EXPECT_EQ(restored.data(), raw);
|
||||
EXPECT_EQ(restored.getSrcISSI(), source.getSrcISSI());
|
||||
EXPECT_EQ(restored.getPDU_Type(), source.getPDU_Type());
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, TelegramLengthLimits)
|
||||
{
|
||||
EXPECT_TRUE(CoPrtCnvRadioTelegram::isTelegramLengthOk(1));
|
||||
EXPECT_TRUE(CoPrtCnvRadioTelegram::isTelegramLengthOk(
|
||||
CoPrtCnvRadioTelegram::MAX_RADIO_TELEGRAM_PAYLOAD_LENGTH));
|
||||
EXPECT_FALSE(CoPrtCnvRadioTelegram::isTelegramLengthOk(0xFFFF));
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, LoginTelegramIsRecognised)
|
||||
{
|
||||
const CoPrtCnvRadioTelegram login(CoPrtCnvRadioTelegram::e_LoginRequest, 0x0001, 0x001234);
|
||||
|
||||
EXPECT_TRUE(login.isLoginTelegram());
|
||||
EXPECT_FALSE(login.isNormalTelegram());
|
||||
EXPECT_EQ(login.getIdentity(), 0x0001);
|
||||
EXPECT_EQ(login.getDestISSI(), 0x001234u);
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, BroadcastIndexRoundTrips)
|
||||
{
|
||||
// getBroadcastIndex() only reports an index when the payload extends past
|
||||
// offset 4, so the telegram needs more than five payload bytes.
|
||||
CoPrtCnvRadioTelegram telegram(GEF_POSITIONS_MELDUNG, 8, 0);
|
||||
|
||||
telegram.setBroadcastIndex(0x0107);
|
||||
EXPECT_EQ(telegram.getBroadcastIndex(), 0x0107);
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, CounterRoundTrips)
|
||||
{
|
||||
CoPrtCnvRadioTelegram telegram(GEF_POSITIONS_MELDUNG, 8, 0);
|
||||
|
||||
telegram.setZaehler(0x2A);
|
||||
EXPECT_EQ(telegram.zaehler(), 0x2A);
|
||||
}
|
||||
|
||||
TEST(CoPrtCnvRadioTelegramTest, DestIssiRoundTrips)
|
||||
{
|
||||
CoPrtCnvRadioTelegram telegram(GEF_POSITIONS_MELDUNG, 8, 0);
|
||||
|
||||
telegram.setDestISSI(0x00FEDC);
|
||||
EXPECT_EQ(telegram.getDestISSI(), 0x00FEDCu);
|
||||
}
|
||||
Reference in new issue
Block a user