From 3988248897f713aea379726ae9306c62bff3adc7 Mon Sep 17 00:00:00 2001
From: Torsten Wierschin <torsten.wierschin@life-maps.com>
Date: Fri, 17 Jul 2026 17:12:07 +0200
Subject: [PATCH] tests: upgrade DDS smoke-tests to Qt Test-based checks
 (QString, QVariant, containers)

---
 .../DdsUnitTestsPlaceholder/CMakeLists.txt    |  3 +++
 .../ddsDataTopicTests_smoke.cpp               | 23 ++++++++++++----
 .../ddsFunctionTopicTests_smoke.cpp           | 27 +++++++++++++++----
 .../ddsGenericDataTests_smoke.cpp             | 24 +++++++++++++----
 4 files changed, 62 insertions(+), 15 deletions(-)

diff --git a/Lts/DDS/DdsUnitTestsPlaceholder/CMakeLists.txt b/Lts/DDS/DdsUnitTestsPlaceholder/CMakeLists.txt
index ad9575e88..519df8165 100644
--- a/Lts/DDS/DdsUnitTestsPlaceholder/CMakeLists.txt
+++ b/Lts/DDS/DdsUnitTestsPlaceholder/CMakeLists.txt
@@ -10,18 +10,21 @@ if(BUILD_TESTING)
   # Generic data tests smoke
   if(NOT TARGET ddsGenericDataTests)
     add_executable(ddsGenericDataTests_smoke ddsGenericDataTests_smoke.cpp)
+    target_link_libraries(ddsGenericDataTests_smoke PRIVATE Qt5::Core Qt5::Test)
     add_test(NAME ddsGenericDataTests COMMAND $<TARGET_FILE:ddsGenericDataTests_smoke>)
   endif()
 
   # Data topic tests smoke
   if(NOT TARGET ddsDataTopicTests)
     add_executable(ddsDataTopicTests_smoke ddsDataTopicTests_smoke.cpp)
+    target_link_libraries(ddsDataTopicTests_smoke PRIVATE Qt5::Core Qt5::Test)
     add_test(NAME ddsDataTopicTests COMMAND $<TARGET_FILE:ddsDataTopicTests_smoke>)
   endif()
 
   # Function topic tests smoke
   if(NOT TARGET ddsFunctionTopicTests)
     add_executable(ddsFunctionTopicTests_smoke ddsFunctionTopicTests_smoke.cpp)
+    target_link_libraries(ddsFunctionTopicTests_smoke PRIVATE Qt5::Core Qt5::Test)
     add_test(NAME ddsFunctionTopicTests COMMAND $<TARGET_FILE:ddsFunctionTopicTests_smoke>)
   endif()
 
diff --git a/Lts/DDS/DdsUnitTestsPlaceholder/ddsDataTopicTests_smoke.cpp b/Lts/DDS/DdsUnitTestsPlaceholder/ddsDataTopicTests_smoke.cpp
index ae73157a6..a1e6f3f82 100644
--- a/Lts/DDS/DdsUnitTestsPlaceholder/ddsDataTopicTests_smoke.cpp
+++ b/Lts/DDS/DdsUnitTestsPlaceholder/ddsDataTopicTests_smoke.cpp
@@ -1,5 +1,18 @@
-#include <iostream>
-int main() {
-  std::cout << "[smoke] ddsDataTopicTests_smoke running" << std::endl;
-  return 0;
-}
+#include <QObject>
+#include <QtTest>
+
+class DataTopicSmokeTest : public QObject {
+  Q_OBJECT
+private slots:
+  void initTestCase() {
+    // basic QCoreApplication check via QCoreApplication::applicationName
+    QVERIFY(QCoreApplication::instance() == nullptr || true); // harmless check
+  }
+  void test_qstring_format() {
+    QString fmt = QStringLiteral("%1-%2").arg(42).arg("abc");
+    QCOMPARE(fmt, QString("42-abc"));
+  }
+};
+
+QTEST_MAIN(DataTopicSmokeTest)
+#include "ddsDataTopicTests_smoke.moc"
diff --git a/Lts/DDS/DdsUnitTestsPlaceholder/ddsFunctionTopicTests_smoke.cpp b/Lts/DDS/DdsUnitTestsPlaceholder/ddsFunctionTopicTests_smoke.cpp
index 018eaaa22..54ea564d6 100644
--- a/Lts/DDS/DdsUnitTestsPlaceholder/ddsFunctionTopicTests_smoke.cpp
+++ b/Lts/DDS/DdsUnitTestsPlaceholder/ddsFunctionTopicTests_smoke.cpp
@@ -1,5 +1,22 @@
-#include <iostream>
-int main() {
-  std::cout << "[smoke] ddsFunctionTopicTests_smoke running" << std::endl;
-  return 0;
-}
+#include <QObject>
+#include <QtTest>
+
+class FunctionTopicSmokeTest : public QObject {
+  Q_OBJECT
+private slots:
+  void test_containers() {
+    QStringList list;
+    list << "a" << "b" << "c";
+    QCOMPARE(list.size(), 3);
+    QVERIFY(list.contains("b"));
+  }
+  void test_qmap_basic() {
+    QMap<QString,int> m;
+    m["one"] = 1;
+    m["two"] = 2;
+    QCOMPARE(m.value("two"), 2);
+  }
+};
+
+QTEST_MAIN(FunctionTopicSmokeTest)
+#include "ddsFunctionTopicTests_smoke.moc"
diff --git a/Lts/DDS/DdsUnitTestsPlaceholder/ddsGenericDataTests_smoke.cpp b/Lts/DDS/DdsUnitTestsPlaceholder/ddsGenericDataTests_smoke.cpp
index bb8691f05..34e016031 100644
--- a/Lts/DDS/DdsUnitTestsPlaceholder/ddsGenericDataTests_smoke.cpp
+++ b/Lts/DDS/DdsUnitTestsPlaceholder/ddsGenericDataTests_smoke.cpp
@@ -1,5 +1,19 @@
-#include <iostream>
-int main() {
-  std::cout << "[smoke] ddsGenericDataTests_smoke running" << std::endl;
-  return 0;
-}
+#include <QObject>
+#include <QtTest>
+
+class GenericSmokeTest : public QObject {
+  Q_OBJECT
+private slots:
+  void test_string_ops() {
+    QString s = QString::fromUtf8("mIxEd");
+    QCOMPARE(s.toLower(), QString("mixed"));
+  }
+  void test_basic_qvariant() {
+    QVariant v = QString("value");
+    QVERIFY(v.canConvert<QString>());
+    QCOMPARE(v.toString(), QString("value"));
+  }
+};
+
+QTEST_MAIN(GenericSmokeTest)
+#include "ddsGenericDataTests_smoke.moc"