Update MIGRATION_STATUS.md with Session 013 VideoOverlayManagement logger fixes
Qt6 Migration CI / migrate (push) Waiting to run

- Added Session 013 section documenting logger initialization fixes
- Updated build validation status (BUILD_RTI=OFF success)
- Updated latest commit hash (4969e4ff)
- Added VideoOverlayManagement to completed modules table
- Updated next steps with completed items

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Entire-Checkpoint: 01M0SPXXRB5JWR506XVD3W84PR
This commit is contained in:
torstenandCopilot committed 2026-08-24 13:01:45 +02:00
1 parent 37763ed719
commit c107cde36b
1 file changed
+68 -8
+68 -8
View File
@@ -1,7 +1,7 @@
# Qt5/C++11 → Qt6/C++17 Migration Status
**Last Updated**: 2026-08-24 11:15
**Session**: 012-application-module-migration
**Last Updated**: 2026-08-24 12:30
**Session**: 013-videooverlay-logger-fixes
**Branch**: main → `qt-migration-legatus` submodule → `feature/qt6-migration-basis-modules`
---
@@ -12,20 +12,74 @@
| Configuration | Status | Notes |
|---------------|--------|-------|
| **BUILD_RTI=OFF** | ✅ **SUCCESS** (0 errors) | Tests CMakeLists fixed for MIGRATE_MODULE |
| **BUILD_RTI=OFF** | ✅ **SUCCESS** (0 errors) | VideoOverlayManagement logger fixes complete |
| **BUILD_RTI=ON** | 🟡 **BLOCKED** | External dependency (svcIsmCommon) not in Docker image |
| **C++ Standard** | **C++17** | Enforced due to RTI DDS 7.7.0 incompatibility with C++20+ |
### Latest Commits
- **Submodule**: `f6c2ac04` → `feature/qt6-migration-basis-modules`
- **Submodule**: `4969e4ff` → `feature/qt6-migration-basis-modules`
- **Main Repo**: `d48a78b5` → `main`
- **Changes**: Tests CMakeLists.txt fixes for incremental module migration
- **Changes**: VideoOverlayManagement INGLLogger initialization fixes
---
## ✅ Completed Work
### Session 013: VideoOverlayManagement Logger Fixes
#### Fixed Files (6 files changed, ~40 insertions, ~20 deletions)
1. **Lts/Services/VideoOverlayManagement/logger.cpp**
- Added `#if BUILD_RTI` guards around logger initialization
- Replaced `NGLLoggerBootstrap` with `NGL::getMemoryLogger()` for BUILD_RTI=OFF
- **Impact**: Clean compilation without RTI dependencies
2. **Lts/Services/VideoOverlayManagement/avs_interface.cpp**
- Fixed logger initialization to use `NGL::getMemoryLogger()`
- Fixed Qt6 signal syntax: `error` → `errorOccurred` (line 57)
- **Impact**: Qt6 compatibility for TCP socket error handling
3. **Lts/Services/VideoOverlayManagement/main_handler.cpp**
- Fixed logger initialization pattern
- **Impact**: Consistent logger usage across module
4. **Lts/Services/VideoOverlayManagement/handler_overlays.cpp**
- Fixed logger initialization
- **Impact**: BUILD_RTI=OFF compatibility
5. **Lts/Services/VideoOverlayManagement/handler_infrastructure_data.cpp**
- Fixed logger initialization
- **Impact**: BUILD_RTI=OFF compatibility
6. **Lts/Services/VideoOverlayManagement/handler_participant_data.cpp**
- Fixed logger initialization
- **Impact**: BUILD_RTI=OFF compatibility
#### Build Results
```
✅ BUILD_RTI=OFF: VideoOverlayManagement compiles successfully
- All logger initialization patterns fixed
- Qt6 signal syntax corrected (error → errorOccurred)
✅ BUILD_RTI=ON: Pending validation
```
#### Key Technical Details
**INGLLogger Interface Pattern**:
- `INGLLogger` is an abstract interface with no static `instance()` method
- Created externally via `NGLLoggerBootstrap` or `NGL::getMemoryLogger()`
- For BUILD_RTI=OFF stubs: Use `NGL::getMemoryLogger()` which returns `INGLLogger&`
- Pattern: `auto& logger = NGL::getMemoryLogger();` instead of `NGLLoggerBootstrap::getNGLRootLogger()`
**Qt6 Signal Syntax**:
- `QTcpSocket::error` signal renamed to `errorOccurred` in Qt6
- Connection syntax: `connect(socket, &QTcpSocket::errorOccurred, ...)`
- May require `QOverload` for const member function pointer
---
### Session 011: Module Migration Tests Skip Fix
#### Fixed Files (2 files changed, 30 insertions, 6 deletions)
@@ -243,6 +297,7 @@ When using `MIGRATE_MODULE` to migrate individual modules, tests cannot be built
| Lts/DDS/Discovery | 🟡 Partial | ✅ | ⏳ | Pending full validation |
| **Lts/Application** | **✅ Complete** | **⏳** | **⏳** | **AarApp, OpApp, THP migrated** |
| **Lts/Viewer** | **✅ Complete** | **⏳** | **⏳** | **LtsFileDialog, LtsReportDisplay migrated** |
| **Lts/Services/VideoOverlayManagement** | **✅ Complete** | **✅** | **⏳** | **Logger initialization fixed** |
| TetraIF | 🟡 Partial | ⏳ | ⏳ | Migration in progress |
| Z-Modules | 🟡 Partial | ⏳ | ⏳ | Some submodules complete |
@@ -310,11 +365,16 @@ docker run --rm -v $(pwd):/repo migration-pipeline:ubuntu26.04 \
- LtsFileDialog and LtsReportDisplay migrated
- CMakeLists.txt updated for Qt6
4. ⏳ **BUILD_RTI=OFF validation**
- Test build with newly migrated Application modules
4. ✅ **VideoOverlayManagement logger fixes** - COMPLETED
- All 6 files fixed for BUILD_RTI=OFF compatibility
- Qt6 signal syntax corrected (error → errorOccurred)
- Committed and pushed to submodule (4969e4ff)
5. ⏳ **BUILD_RTI=OFF full validation**
- Test complete build with all migrated modules
- Verify no new errors introduced
5. ⏳ **Continue Lts module migration**
6. ⏳ **Continue Lts module migration**
- Lts/Plugins: Start with core functionality submodules
- Lts/Services: Address InfrastructureManagement dependencies
- Lts/Proxies: Complete remaining modules